flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH] flashrom: fix sparse warning: Unknown escape %
by Peter Huewe 25 Jan '11

25 Jan '11

flashrom: fix sparse warning: Unknown escape % This patch fixes wrong escaping of %. In print.c %%2b is correct instead of \%2b ("%%2b"=%2b=+) In board_enable.c %d is correct instead of \%d. Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> --- board_enable.c | 2 +- print.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/board_enable.c b/board_enable.c index d09923a..5776bf5 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1135,7 +1135,7 @@ static int intel_piix4_gpo_set(unsigned int gpo, int raise) if ( (((1 << gpo) & nonmuxed_gpos) == 0) && (pci_read_word(dev, piix4_gpo[gpo].reg) & piix4_gpo[gpo].mask) != piix4_gpo[gpo].value ) { - msg_perr("\nERROR: PIIX4 GPO\%d not programmed for output.\n", gpo); + msg_perr("\nERROR: PIIX4 GPO%d not programmed for output.\n", gpo); return -1; } diff --git a/print.c b/print.c index 86b4fb1..7ba2801 100644 --- a/print.c +++ b/print.c @@ -355,7 +355,7 @@ const struct board_info boards_known[] = { B("ASRock", "775i65G", 1, "http://www.asrock.com/mb/overview.asp?Model=775i65G", NULL), B("ASRock", "939A785GMH/128M", 1, "http://www.asrock.com/mb/overview.asp?Model=939A785GMH/128M&s=939", NULL), B("ASRock", "A330GC", 1, "http://www.asrock.com/mb/overview.asp?Model=A330GC", NULL), - B("ASRock", "A770CrossFire", 1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2\%2b", NULL), + B("ASRock", "A770CrossFire", 1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2%%2b", NULL), B("ASRock", "ALiveNF6G-DVI", 1, "http://www.asrock.com/mb/overview.asp?Model=ALiveNF6G-DVI", NULL), B("ASRock", "K7S41", 1, "http://www.asrock.com/mb/overview.asp?Model=K7S41", NULL), B("ASRock", "K7VT4A+", 0, "http://www.asrock.com/mb/overview.asp?Model=K7VT4A%%2b&s=", "No chip found, probably due to flash translation. http://www.flashrom.org/pipermail/flashrom/2009-August/000393.html"), -- 1.7.2.2

2 1

[commit] r1256 - trunk
by repository service 25 Jan '11

25 Jan '11

Author: stepan Date: Tue Jan 25 01:23:32 2011 New Revision: 1256 URL: http://flashrom.org/trac/flashrom/changeset/1256 Log: flashrom: fix sparse warning: Unknown escape % This patch fixes wrong escaping of %. In print.c %%2b is correct instead of \%2b ("%%2b"=%2b=+) In board_enable.c %d is correct instead of \%d. Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> Acked-by: Stefan Reinauer <stepan(a)coreboot.org> Modified: trunk/board_enable.c trunk/print.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Mon Jan 24 20:15:51 2011 (r1255) +++ trunk/board_enable.c Tue Jan 25 01:23:32 2011 (r1256) @@ -1135,7 +1135,7 @@ if ( (((1 << gpo) & nonmuxed_gpos) == 0) && (pci_read_word(dev, piix4_gpo[gpo].reg) & piix4_gpo[gpo].mask) != piix4_gpo[gpo].value ) { - msg_perr("\nERROR: PIIX4 GPO\%d not programmed for output.\n", gpo); + msg_perr("\nERROR: PIIX4 GPO%d not programmed for output.\n", gpo); return -1; } Modified: trunk/print.c ============================================================================== --- trunk/print.c Mon Jan 24 20:15:51 2011 (r1255) +++ trunk/print.c Tue Jan 25 01:23:32 2011 (r1256) @@ -355,7 +355,7 @@ B("ASRock", "775i65G", 1, "http://www.asrock.com/mb/overview.asp?Model=775i65G", NULL), B("ASRock", "939A785GMH/128M", 1, "http://www.asrock.com/mb/overview.asp?Model=939A785GMH/128M&s=939", NULL), B("ASRock", "A330GC", 1, "http://www.asrock.com/mb/overview.asp?Model=A330GC", NULL), - B("ASRock", "A770CrossFire", 1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2\%2b", NULL), + B("ASRock", "A770CrossFire", 1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2%%2b", NULL), B("ASRock", "ALiveNF6G-DVI", 1, "http://www.asrock.com/mb/overview.asp?Model=ALiveNF6G-DVI", NULL), B("ASRock", "K7S41", 1, "http://www.asrock.com/mb/overview.asp?Model=K7S41", NULL), B("ASRock", "K7VT4A+", 0, "http://www.asrock.com/mb/overview.asp?Model=K7VT4A%%2b&s=", "No chip found, probably due to flash translation. http://www.flashrom.org/pipermail/flashrom/2009-August/000393.html"),

1 0

[commit] r1255 - trunk
by repository service 24 Jan '11

24 Jan '11

Author: stepan Date: Mon Jan 24 20:15:51 2011 New Revision: 1255 URL: http://flashrom.org/trac/flashrom/changeset/1255 Log: flashrom: fix sparse warning: Using plain integer as NULL pointer This patch fixes the "using plain integer as NULL pointer" warnings generated by running sparse on the flashrom source. Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> Acked-by: Mathias Krause <mathias.krause(a)secunet.com> Acked-by: Stefan Reinauer <stepan(a)coreboot.org> Modified: trunk/cbtable.c trunk/chipset_enable.c trunk/cli_classic.c trunk/physmap.c trunk/programmer.c trunk/serprog.c trunk/udelay.c Modified: trunk/cbtable.c ============================================================================== --- trunk/cbtable.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/cbtable.c Mon Jan 24 20:15:51 2011 (r1255) @@ -141,7 +141,7 @@ }; - return 0; + return NULL; } static void find_mainboard(struct lb_record *ptr, unsigned long addr) Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/chipset_enable.c Mon Jan 24 20:15:51 2011 (r1255) @@ -1173,7 +1173,7 @@ int chipset_flash_enable(void) { - struct pci_dev *dev = 0; + struct pci_dev *dev = NULL; int ret = -2; /* Nothing! */ int i; Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/cli_classic.c Mon Jan 24 20:15:51 2011 (r1255) @@ -116,23 +116,23 @@ static const char optstring[] = "r:Rw:v:nVEfc:m:l:i:p:Lzh"; static const struct option long_options[] = { - {"read", 1, 0, 'r'}, - {"write", 1, 0, 'w'}, - {"erase", 0, 0, 'E'}, - {"verify", 1, 0, 'v'}, - {"noverify", 0, 0, 'n'}, - {"chip", 1, 0, 'c'}, - {"mainboard", 1, 0, 'm'}, - {"verbose", 0, 0, 'V'}, - {"force", 0, 0, 'f'}, - {"layout", 1, 0, 'l'}, - {"image", 1, 0, 'i'}, - {"list-supported", 0, 0, 'L'}, - {"list-supported-wiki", 0, 0, 'z'}, - {"programmer", 1, 0, 'p'}, - {"help", 0, 0, 'h'}, - {"version", 0, 0, 'R'}, - {0, 0, 0, 0} + {"read", 1, NULL, 'r'}, + {"write", 1, NULL, 'w'}, + {"erase", 0, NULL, 'E'}, + {"verify", 1, NULL, 'v'}, + {"noverify", 0, NULL, 'n'}, + {"chip", 1, NULL, 'c'}, + {"mainboard", 1, NULL, 'm'}, + {"verbose", 0, NULL, 'V'}, + {"force", 0, NULL, 'f'}, + {"layout", 1, NULL, 'l'}, + {"image", 1, NULL, 'i'}, + {"list-supported", 0, NULL, 'L'}, + {"list-supported-wiki", 0, NULL, 'z'}, + {"programmer", 1, NULL, 'p'}, + {"help", 0, NULL, 'h'}, + {"version", 0, NULL, 'R'}, + {NULL, 0, NULL, 0} }; char *filename = NULL; Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/physmap.c Mon Jan 24 20:15:51 2011 (r1255) @@ -180,7 +180,7 @@ } } - virt_addr = mmap(0, len, PROT_WRITE | PROT_READ, MAP_SHARED, + virt_addr = mmap(NULL, len, PROT_WRITE | PROT_READ, MAP_SHARED, fd_mem, (off_t)phys_addr); return MAP_FAILED == virt_addr ? ERROR_PTR : virt_addr; } @@ -200,7 +200,7 @@ } } - virt_addr = mmap(0, len, PROT_READ, MAP_SHARED, + virt_addr = mmap(NULL, len, PROT_READ, MAP_SHARED, fd_mem_cached, (off_t)phys_addr); return MAP_FAILED == virt_addr ? ERROR_PTR : virt_addr; } Modified: trunk/programmer.c ============================================================================== --- trunk/programmer.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/programmer.c Mon Jan 24 20:15:51 2011 (r1255) @@ -30,7 +30,7 @@ void *fallback_map(const char *descr, unsigned long phys_addr, size_t len) { /* FIXME: Should return phys_addr. */ - return 0; + return NULL; } /* No-op/fallback unmap() for programmers which don't need special handling */ Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/serprog.c Mon Jan 24 20:15:51 2011 (r1255) @@ -541,7 +541,7 @@ { if ((sp_max_write_n) && (sp_write_n_bytes)) sp_pass_writen(); - sp_stream_buffer_op(S_CMD_O_EXEC, 0, 0); + sp_stream_buffer_op(S_CMD_O_EXEC, 0, NULL); msg_pspew(MSGHEADER "Executed operation buffer of %d bytes\n", sp_opbuf_usage); sp_opbuf_usage = 0; Modified: trunk/udelay.c ============================================================================== --- trunk/udelay.c Thu Jan 20 22:05:15 2011 (r1254) +++ trunk/udelay.c Mon Jan 24 20:15:51 2011 (r1255) @@ -45,11 +45,11 @@ struct timeval start, end; unsigned long counter = 0; - gettimeofday(&start, 0); + gettimeofday(&start, NULL); timeusec = 0; while (!timeusec && (++counter < 1000000000)) { - gettimeofday(&end, 0); + gettimeofday(&end, NULL); timeusec = 1000000 * (end.tv_sec - start.tv_sec) + (end.tv_usec - start.tv_usec); /* Protect against time going forward too much. */ @@ -68,9 +68,9 @@ unsigned long timeusec; struct timeval start, end; - gettimeofday(&start, 0); + gettimeofday(&start, NULL); myusec_delay(usecs); - gettimeofday(&end, 0); + gettimeofday(&end, NULL); timeusec = 1000000 * (end.tv_sec - start.tv_sec) + (end.tv_usec - start.tv_usec); /* Protect against time going forward too much. */

1 0

Gigabyte GA-880GM-UD2H
by Raphaël Doursenaud 24 Jan '11

24 Jan '11

Reading and writing works but flashrom even if flashrom displays "This flash part has status UNTESTED for operations: ERASE" Think you can add it to the wiki. Regards, -- Raphaël Doursenaud

1 0

asus mobo P4G8X - bios rom # and # ethernet rom chips
by wibo.fichten＠rogers.com 24 Jan '11

24 Jan '11

Hello to all, I am fairly new to flashrom, but I have successfully flashed a 3com nic's rom, not with a pxe image, but with a plop boot image so that my 1993(?) vintage Compaq EP would boot directly from from a usb key (it's a non-usb boot bios). For those interested, the write-up is here: http://sourceforge.net/apps/phpbb/freenas/viewtopic.php?f=102&t=5845 As you may have noted from the link, this was for a FreeNAS (FreeBSD kernel) installation. I now wnat to retire my Asus P4G8X-Deluxe motherboard, for this same FreeNAS installation, given the considerable jump in performance to be expected compared to my very old Compaq. This Asus motherboard unfortunately is just a little too old so that no usb-boot bios is available. I think usb booting bios came out the year after. The motherboard does have on-board ethernet with a rom chip, as it supports pxe booting. So I want to do the same trick as I did with my Compaq. Unfortunately, flashrom does not apear to detect the rom chip in question and I have found no documentation on the subject. I am solliciting your assistance in this regard. >From flashrom -V, I get: [...] Found chip "SST SST49LF004A/B" 512KB, FWH at physical adress 0xfff80000 [...] I *think* this is the BIOS rom, and if so, I think the P4G8X and P4G8X-Deluxe could be added to the list of flashable bios boards, but I haven't tested it, as I am still using this as my main computer for the time being and don't feel the need (or rather I don't need the risk) to replace the bios at this time. I could test it out if board members feel it useful. While booting FreeNAS (FreeBSD kernel), I get the following: [...] pci0:2:5:0: Bad VPD cksum, remain 14 bge0: <Broadcom NetXtreme Gigabit Ethernet Controller, ASIC rev. 0x001002> mem 0xca800000-0xca80ffff at device 5.0 on pci2 bge0: Reserved 0x10000 bytes for rid 0x10 type 3 at 0xca800000 pcib2: matched entry for 2.5.INTA pcib2: slot 5 INTA hardwired to IRQ 18 bge0: chip id 0x00001002; ASIC REV 0x01; CHIP REV 0x10; PCI [...] While browsing through the directory tree with debian linux, I found a rom chip at /sys/devices/pci0000:00:01e.0/0000:02:05.0, with a size of 64k (65536 bytes). I believe this is the pxe rom chip associated with the built-in ethernet as it confirms the FreeNAS boot log in that the location is on pci2 slot 5 and also that the size is 64k or 65,536 bytes, being 0x10000 in binary. Has anyone ever flashed such a beast before? Any suggestions as to how to have flashrom detect the chip and if so, how to read it, erase it and write to it? My issue is not with the basic command structure, but rather how to convince flashrom to get to the particular chip, given it did not detect it. Thanks for all and any response / interest. W

1 0

Read/Fast Read chip status sheet
by Steven Zakulec 23 Jan '11

23 Jan '11

Hi, here's a copy of the sheet I created covering most of the chips (it's the same chip list as in my previous list- the form factor & voltage one). If I couldn't figure out whether the chip had read/fast read, I left it blank. Otherwise, I filled in on the sheet the instruction code, any notes, and whether the mode(s) on the datasheet were the ones Flashrom wanted.

1 0

Bus Pirate Problem
by Eric Hokanson 23 Jan '11

23 Jan '11

Hello, I'm trying to flash a Macronix MX25L6405D chip I pulled from a router I bricked using the Bus Pirate and a recent version of Flashrom. The chip should be supported according to Flashrom but the ID the chip returns seems to be wrong. Are there still known problems with Flashrom and the Bus Pirate? I'm using the latest 5.10 firmware on the Bus Pirate. Output follows: []# flashrom -c MX25L6405 -p buspirate_spi:dev=/dev/ttyUSB0 -VV flashrom v0.9.3-r1250 on Linux 2.6.35.10-74.fc14.x86_64 (x86_64), built with libpci 3.1.7, GCC 4.5.1 20100924 (Red Hat 4.5.1-4), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 2 usecs, 827M loops per second, 10 myus = 11 us, 100 myus = 100 us, 1000 myus = 1013 us, 10000 myus = 10018 us, 8 myus = 9 us, OK. Initializing buspirate_spi programmer SPI speed is 8MHz buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 0 Sending 0x00, receiving buspirate_sendrecv: write 1, read 5 Sending 0x00, receiving 0x42 0x42 0x49 0x4f 0x31 Raw bitbang mode version 1 buspirate_sendrecv: write 1, read 4 Sending 0x01, receiving 0x53 0x50 0x49 0x31 Raw SPI mode version 1 buspirate_sendrecv: write 1, read 1 Sending 0x4b, receiving 0x01 buspirate_sendrecv: write 1, read 1 Sending 0x67, receiving 0x01 buspirate_sendrecv: write 1, read 1 Sending 0x8a, receiving 0x01 buspirate_sendrecv: write 1, read 1 Sending 0x03, receiving 0x01 Probing for Macronix MX25L6405, 8192 KB: buspirate_sendrecv: write 7, read 7 Sending 0x02 0x13 0x9f 0x00 0x00 0x00 0x03, receiving 0x01 0x01 0xff 0xc0 0x00 0x00 0x01 RDID returned 0xc0 0x00 0x00. RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0xc0, id2 0x00 No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. buspirate_sendrecv: write 1, read 5 Sending 0x00, receiving 0x42 0x42 0x49 0x4f 0x31 Raw bitbang mode version 1 buspirate_sendrecv: write 1, read 0 Sending 0x0f, receiving Bus Pirate shutdown completed. I can also get 'receiving 0x01 0x01 0x00 0xc0 0x00 0x00 0x01' instead of 'receiving 0x01 0x01 0xff 0xc0 0x00 0x00 0x01' on occasion. I've tried different spispeed settings but no change. I tried programming it in place at first by lifting the power pin but have since removed the chip with the same results. Eric

1 0

successfully flashed SST25VF040B
by Dennis Keller 21 Jan '11

21 Jan '11

Hi, i just want to let you know that i did succesfully flash my bios with your program. flashrom told me that there are two chips, SST25VF040B and SST25VF040B.REMS, but with the same physical address, so i decided to flash both. It just worked, but the model and s/n information from lshw got lost. if you want more information about my system just tell me. Thanks a lot, Dennis My Computer: HP Pavilion m7794.de-a Prod. #: RR837AA-ABD S/N: CZH7041H7N OS: Ubuntu 10.10 Maverick Meerkat 64Bit Lang: German Country: Germany

1 0

[commit] r1254 - trunk
by repository service 20 Jan '11

20 Jan '11

Author: stepan Date: Thu Jan 20 22:05:15 2011 New Revision: 1254 URL: http://flashrom.org/trac/flashrom/changeset/1254 Log: Secret knowledge is cool, but public knowledge is better. Implement all Dediprog commands found in USB traces, even if their purpose is not yet known. Annotate unknown commands with info about the call sequence they are embedded in and the firmware version of the log. Add a new shutdown command for firmware 5.x (of which Stefan thinks it's "switch the Pass light on" hence it is called late in the game) Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Reinauer <reinauer(a)google.com> Modified: trunk/dediprog.c Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Wed Jan 19 07:21:54 2011 (r1253) +++ trunk/dediprog.c Thu Jan 20 22:05:15 2011 (r1254) @@ -27,6 +27,7 @@ #define DEFAULT_TIMEOUT 3000 static usb_dev_handle *dediprog_handle; +static int dediprog_firmwareversion; static int dediprog_endpoint; #if 0 @@ -317,6 +318,7 @@ fw[1], fw[2]); return 1; } + dediprog_firmwareversion = fw[0]; return 0; } @@ -342,6 +344,32 @@ return 0; } +#if 0 +/* Something. + * Present in eng_detect_blink.log with firmware 3.1.8 + * Always preceded by Command Receive Device String + */ +static int dediprog_command_b(void) +{ + int ret; + char buf[0x3]; + + memset(buf, 0, sizeof(buf)); + ret = usb_control_msg(dediprog_handle, 0xc3, 0x7, 0x0, 0xef00, buf, 0x3, DEFAULT_TIMEOUT); + if (ret < 0) { + msg_perr("Command B failed (%s)!\n", usb_strerror()); + return 1; + } + if ((ret != 0x3) || (buf[0] != 0xff) || (buf[1] != 0xff) || + (buf[2] != 0xff)) { + msg_perr("Unexpected response to Command B!\n"); + return 1; + } + + return 0; +} +#endif + /* Command C is only sent after dediprog_check_devicestring, but not after every * invocation of dediprog_check_devicestring. It is only sent after the first * dediprog_command_a(); dediprog_check_devicestring() sequence in each session. @@ -353,7 +381,7 @@ ret = usb_control_msg(dediprog_handle, 0x42, 0x4, 0x0, 0x0, NULL, 0x0, DEFAULT_TIMEOUT); if (ret != 0x0) { - msg_perr("Unexpected response to Command C!\n"); + msg_perr("Command C failed (%s)!\n", usb_strerror()); return 1; } return 0; @@ -363,6 +391,7 @@ /* Very strange. Seems to be a programmer keepalive or somesuch. * Wait unsuccessfully for timeout ms to read one byte. * Is usually called after setting voltage to 0. + * Present in all logs with Firmware 2.1.1 and 3.1.8 */ static int dediprog_command_f(int timeout) { @@ -371,8 +400,85 @@ memset(buf, 0, sizeof(buf)); ret = usb_control_msg(dediprog_handle, 0xc2, 0x11, 0xff, 0xff, buf, 0x1, timeout); + /* This check is most probably wrong. Command F always causes a timeout + * in the logs, so we should check for timeout instead of checking for + * success. + */ + if (ret != 0x1) { + msg_perr("Command F failed (%s)!\n", usb_strerror()); + return 1; + } + return 0; +} + +/* Start/stop blinking? + * Present in eng_detect_blink.log with firmware 3.1.8 + * Preceded by Command J + */ +static int dediprog_command_g(void) +{ + int ret; + + ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x03, NULL, 0x0, DEFAULT_TIMEOUT); + if (ret != 0x0) { + msg_perr("Command G failed (%s)!\n", usb_strerror()); + return 1; + } + return 0; +} + +/* Something. + * Present in all logs with firmware 5.1.5 + * Always preceded by Command Receive Device String + * Always followed by Command Set SPI Voltage nonzero + */ +static int dediprog_command_h(void) +{ + int ret; + + ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x05, NULL, 0x0, DEFAULT_TIMEOUT); + if (ret != 0x0) { + msg_perr("Command H failed (%s)!\n", usb_strerror()); + return 1; + } + return 0; +} +#endif + +/* Shutdown for firmware 5.x? + * This command swithces the "Pass" LED on. + * Present in all logs with firmware 5.1.5 + * Often preceded by a SPI operation (Command Read SPI Bulk or Receive SPI) + * Always followed by Command Set SPI Voltage 0x0000 + */ +static int dediprog_command_i(void) +{ + int ret; + + ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x06, NULL, 0x0, DEFAULT_TIMEOUT); if (ret != 0x0) { - msg_perr("Unexpected response to Command F!\n"); + msg_perr("Command I failed (%s)!\n", usb_strerror()); + return 1; + } + return 0; +} + +#if 0 +/* Start/stop blinking? + * Present in all logs with firmware 5.1.5 + * Always preceded by Command Receive Device String on 5.1.5 + * Always followed by Command Set SPI Voltage nonzero on 5.1.5 + * Present in eng_detect_blink.log with firmware 3.1.8 + * Preceded by Command B in eng_detect_blink.log + * Followed by Command G in eng_detect_blink.log + */ +static int dediprog_command_j(void) +{ + int ret; + + ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x07, NULL, 0x0, DEFAULT_TIMEOUT); + if (ret != 0x0) { + msg_perr("Command J failed (%s)!\n", usb_strerror()); return 1; } return 0; @@ -550,9 +656,11 @@ /* URB 136 is just URB 9. */ /* URB 137 is just URB 11. */ - /* Command I is probably Start Bulk Read. Data is u16 blockcount, u16 blocksize. */ - /* Command J is probably Start Bulk Write. Data is u16 blockcount, u16 blocksize. */ - /* Bulk transfer sizes for Command I/J are always 512 bytes, rest is filled with 0xff. */ + /* Command Start Bulk Read. Data is u16 blockcount, u16 blocksize. */ + /* Command Start Bulk Write. Data is u16 blockcount, u16 blocksize. */ + /* Bulk transfer sizes for Command Start Bulk Read/Write are always + * 512 bytes, rest is filled with 0xff. + */ return 0; } @@ -562,6 +670,10 @@ { msg_pspew("%s\n", __func__); + /* Shutdown on firmware 5.x */ + if (dediprog_firmwareversion == 5) + if (dediprog_command_i()) + return 1; /* URB 28. Command Set SPI Voltage to 0. */ if (dediprog_set_spi_voltage(0x0)) return 1;

1 0

[commit] r1253 - trunk
by repository service 19 Jan '11

19 Jan '11

Author: stepan Date: Wed Jan 19 07:21:54 2011 New Revision: 1253 URL: http://flashrom.org/trac/flashrom/changeset/1253 Log: Don't print the local memory flash chip address on programmers that don't actually map the flash chip into local memory (like the dediprog) because the value does not make sense there. This version was reworked / rewritten by Mathias Krause to have less "impact" Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Acked-by: Mathias Krause <mathias.krause(a)secunet.com> Modified: trunk/flashrom.c Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Mon Jan 17 08:50:42 2011 (r1252) +++ trunk/flashrom.c Wed Jan 19 07:21:54 2011 (r1253) @@ -1127,6 +1127,7 @@ { struct flashchip *flash; unsigned long base = 0; + char location[64]; uint32_t size; enum chipbustype buses_common; char *tmp; @@ -1178,10 +1179,16 @@ if (!flash || !flash->name) return NULL; - msg_cinfo("%s chip \"%s %s\" (%d KB, %s) at physical address 0x%lx.\n", + if (programmer_table[programmer].map_flash_region == physmap) { + snprintf(location, sizeof(location), "at physical address 0x%lx", base); + } else { + snprintf(location, sizeof(location), "on %s", programmer_table[programmer].name); + } + + msg_cinfo("%s chip \"%s %s\" (%d KB, %s) %s.\n", force ? "Assuming" : "Found", flash->vendor, flash->name, flash->total_size, - flashbuses_to_text(flash->bustype), base); + flashbuses_to_text(flash->bustype), location); /* Flash registers will not be mapped if the chip was forced. Lock info * may be stored in registers, so avoid lock info printing.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom