flashrom

flashrom@flashrom.org

5 participants
9161 discussions

Re: [flashrom] [PATCH] fix unchecked malloc calls
by Uwe Hermann 13 Jul '11

13 Jul '11

On Fri, Jul 01, 2011 at 06:05:07AM +0200, Stefan Tauner wrote: > compile tested only. > btw... why dont we wrap malloc to automatically include these checks? > there is probably a patch somewhere that adds totally awesome shutdown code in OOM cases, > but afaics we just print a warning and exit right now... it is just stupid to do the checks in the real > code then. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> It's definately better than what we have now (no error checking at all), so: Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> A few notes for later though: - We should call any shutdown function which may need to be called in the respective places (and any free()s which may be needed). - Later we should not exit(1) upon the error, but rather return an error code instead (e.g. FL_ERR_MALLOC or similar), at least in all public "API" functions which are meant to be in the upcoming libflashrom. - A small xmalloc() wrapper (or use another name) would indeed be nice, too, but once we really return error codes etc. it's not really useful anymore I think. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org

2 1

[commit] r1370 - trunk
by repository service 13 Jul '11

13 Jul '11

Author: stefanct Date: Wed Jul 13 00:35:21 2011 New Revision: 1370 URL: http://flashrom.org/trac/flashrom/changeset/1370 Log: fix unchecked malloc calls and casts of malloc return values in the long term the exit calls should be replaced by returns. until then this is the correct way to handle failures. the casts are not needed (in C) and we don't cast malloc return values anywhere else. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/flashrom.c trunk/hwaccess.c trunk/pcidev.c trunk/serial.c Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Wed Jul 13 00:01:44 2011 (r1369) +++ trunk/flashrom.c Wed Jul 13 00:35:21 2011 (r1370) @@ -1513,7 +1513,11 @@ unsigned int usable_erasefunctions = count_usable_erasers(flash); msg_cinfo("Erasing and writing flash chip... "); - curcontents = (uint8_t *) malloc(size); + curcontents = malloc(size); + if (!curcontents) { + msg_gerr("Out of memory!\n"); + exit(1); + } /* Copy oldcontents to curcontents to avoid clobbering oldcontents. */ memcpy(curcontents, oldcontents, size); @@ -1880,10 +1884,18 @@ goto out_nofree; } - oldcontents = (uint8_t *) malloc(size); + oldcontents = malloc(size); + if (!oldcontents) { + msg_gerr("Out of memory!\n"); + exit(1); + } /* Assume worst case: All bits are 0. */ memset(oldcontents, 0x00, size); - newcontents = (uint8_t *) malloc(size); + newcontents = malloc(size); + if (!newcontents) { + msg_gerr("Out of memory!\n"); + exit(1); + } /* Assume best case: All bits should be 1. */ memset(newcontents, 0xff, size); /* Side effect of the assumptions above: Default write action is erase Modified: trunk/hwaccess.c ============================================================================== --- trunk/hwaccess.c Wed Jul 13 00:01:44 2011 (r1369) +++ trunk/hwaccess.c Wed Jul 13 00:35:21 2011 (r1370) @@ -226,6 +226,10 @@ { \ struct undo_mmio_write_data *undo_mmio_write_data; \ undo_mmio_write_data = malloc(sizeof(struct undo_mmio_write_data)); \ + if (!undo_mmio_write_data) { \ + msg_gerr("Out of memory!\n"); \ + exit(1); \ + } \ undo_mmio_write_data->addr = a; \ undo_mmio_write_data->type = mmio_write_type_##c; \ undo_mmio_write_data->c##data = mmio_read##c(a); \ Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Wed Jul 13 00:01:44 2011 (r1369) +++ trunk/pcidev.c Wed Jul 13 00:35:21 2011 (r1370) @@ -295,6 +295,10 @@ { \ struct undo_pci_write_data *undo_pci_write_data; \ undo_pci_write_data = malloc(sizeof(struct undo_pci_write_data)); \ + if (!undo_pci_write_data) { \ + msg_gerr("Out of memory!\n"); \ + exit(1); \ + } \ undo_pci_write_data->dev = *a; \ undo_pci_write_data->reg = b; \ undo_pci_write_data->type = pci_write_type_##c; \ Modified: trunk/serial.c ============================================================================== --- trunk/serial.c Wed Jul 13 00:01:44 2011 (r1369) +++ trunk/serial.c Wed Jul 13 00:35:21 2011 (r1370) @@ -110,6 +110,8 @@ (tolower((unsigned char)dev[1]) == 'o') && (tolower((unsigned char)dev[2]) == 'm')) { dev2 = malloc(strlen(dev) + 5); + if (!dev2) + sp_die("Error: Out of memory"); strcpy(dev2, "\\\\.\\"); strcpy(dev2 + 4, dev); }

1 0

MSI K9A2 Platinum OK
by Sylvain BERTRAND 12 Jul '11

12 Jul '11

Hi, Successfully flashed BIOS v1.9 on this motherboard. Cheers, Sylvain BERTRAND

2 2

MSI "K8MM-V" (MS-7142) successful BIOS update
by Benjamin Bellec 12 Jul '11

12 Jul '11

Hello, I successfully flash this motherboard with a "Winbond W39V040A" (512 kB, LPC) chip which is currently tagged as UNTESTED for ERASE and WRITE. Flash from BIOS version 1.0 to 1.A (the last one). http://eu.msi.com/product/mb/K8MM-V.html Here are the logs. Benjamin

2 1

Re: [flashrom] Report scan flashrom v0.9.3-r1299 for Asus M2N-MX SE Plus
by Paul Menzel 12 Jul '11

12 Jul '11

Dear Alexabder, Am Montag, den 11.07.2011, 20:46 +0300 schrieb Senior College Krikoon Hilton Enterprise: > I Alexabder > I very hope and trust you > How many time you need do this? I am sorry I do not understand your question. What do we need to do? > [root@localhost flashrom]# flashrom -V > flashrom v0.9.3-r1299 on Linux 2.6.38.8-32.fc15.i686 (i686), built with > libpci 3.1.7, GCC 4.6.0 20110428 (Red Hat 4.6.0-6), little endian > flashrom is free software, get the source code at http://www.flashrom.org […] If you want to upgrade you BIOS you should try a newer version [1][2] and make sure you can recover from a failed flashing operation if your motherboard is not marked as supported. Thanks, Paul [1] http://flashrom.org/Flashrom [2] http://flashrom.org/Downloads

1 0

Report scan flashrom v0.9.3-r1299
by Senior College Krikoon Hilton Enterprise 11 Jul '11

11 Jul '11

I Alexabder I very hope and trust you How many time you need do this? [root@localhost flashrom]# flashrom -V flashrom v0.9.3-r1299 on Linux 2.6.38.8-32.fc15.i686 (i686), built with libpci 3.1.7, GCC 4.6.0 20110428 (Red Hat 4.6.0-6), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 3 usecs, 1029M loops per second, 10 myus = 10 us, 100 myus = 95 us, 1000 myus = 1033 us, 10000 myus = 9413 us, 12 myus = 12 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "System manufacturer" DMI string system-product-name: "System Product Name" DMI string system-version: "System Version" DMI string baseboard-manufacturer: "ASUSTeK Computer INC." DMI string baseboard-product-name: "M2N-MX SE Plus" DMI string baseboard-version: "Rev x.xx" DMI string chassis-type: "Desktop" Found ITE Super I/O, ID 0x8712 on port 0x2e Found chipset "NVIDIA MCP61", enabling flash write... chipset PCI ID is 10de:03e0, This chipset is not really supported yet. Guesswork... ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0 Flash bus type is SPI SPI on this chipset is WIP. Write is unsupported! Found SMBus device 10de:03eb at 00:01:1 MCP SPI BAR is at 0xfec80000 Mapping NVIDIA MCP6x SPI at 0xfec80000, unaligned size 0x544. SPI control is 0x0002, req=0, gnt=0 Please send the output of "flashrom -V" to flashrom(a)flashrom.org with your board name: flashrom -V as the subject to help us finish support for your chipset. Thanks. OK. This chipset supports the following protocols: SPI. Super I/O ID 0x8712 is not on the list of flash capable controllers. Probing for AMD Am29F010A/B, 128 KB: skipped. Probing for AMD Am29F002(N)BB, 256 KB: skipped. Probing for AMD Am29F002(N)BT, 256 KB: skipped. Probing for AMD Am29F016D, 2048 KB: skipped. Probing for AMD Am29F040B, 512 KB: skipped. Probing for AMD Am29F080B, 1024 KB: skipped. Probing for AMD Am29LV001BB, 128 KB: skipped. Probing for AMD Am29LV001BT, 128 KB: skipped. Probing for AMD Am29LV002BB, 256 KB: skipped. Probing for AMD Am29LV002BT, 256 KB: skipped. Probing for AMD Am29LV004BB, 512 KB: skipped. Probing for AMD Am29LV004BT, 512 KB: skipped. Probing for AMD Am29LV008BB, 1024 KB: skipped. Probing for AMD Am29LV008BT, 1024 KB: skipped. Probing for AMD Am29LV040B, 512 KB: skipped. Probing for AMD Am29LV081B, 1024 KB: skipped. Probing for AMIC A25L05PT, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L05PU, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L10PT, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L10PU, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L20PT, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L20PU, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L40PT, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L40PU, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L80P, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L16PT, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L16PU, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L512, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L010, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L020, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L040, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L080, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L016, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L032, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25LQ032, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A29002B, 256 KB: skipped. Probing for AMIC A29002T, 256 KB: skipped. Probing for AMIC A29040B, 512 KB: skipped. Probing for AMIC A49LF040A, 512 KB: skipped. Probing for Atmel AT25DF021, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF041A, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF081, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF081A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF161, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF321, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF321A, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF641, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DQ161, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25F512B, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25FS010, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25FS040, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF041, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF081A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF161, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF161A, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26F004, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT29C512, 64 KB: skipped. Probing for Atmel AT29C010A, 128 KB: skipped. Probing for Atmel AT29C020, 256 KB: skipped. Probing for Atmel AT29C040A, 512 KB: skipped. Probing for Atmel AT45CS1282, 16896 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB011D, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB021D, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB041D, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB081D, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB161D, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB321C, 4224 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB321D, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB642D, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT49BV512, 64 KB: skipped. Probing for Atmel AT49F020, 256 KB: skipped. Probing for Atmel AT49F002(N), 256 KB: skipped. Probing for Atmel AT49F002(N)T, 256 KB: skipped. Probing for Bright BM29F040, 512 KB: skipped. Probing for EMST F49B002UA, 256 KB: skipped. Probing for EMST F25L008A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B05, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B05T, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B10T, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B20T, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B40T, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B80T, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B16T, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B32T, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B64T, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25D16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F05, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN29F010, 128 KB: skipped. Probing for Eon EN29F002(A)(N)B, 256 KB: skipped. Probing for Eon EN29F002(A)(N)T, 256 KB: skipped. Probing for Fujitsu MBM29F004BC, 512 KB: skipped. Probing for Fujitsu MBM29F004TC, 512 KB: skipped. Probing for Fujitsu MBM29F400BC, 512 KB: skipped. Probing for Fujitsu MBM29F400TC, 512 KB: skipped. Probing for Hyundai HY29F002T, 256 KB: skipped. Probing for Hyundai HY29F002B, 256 KB: skipped. Probing for Hyundai HY29F040A, 512 KB: skipped. Probing for Intel 28F001BN/BX-B, 128 KB: skipped. Probing for Intel 28F001BN/BX-T, 128 KB: skipped. Probing for Intel 28F002BC/BL/BV/BX-T, 256 KB: skipped. Probing for Intel 28F008S3/S5/SC, 512 KB: skipped. Probing for Intel 28F004B5/BE/BV/BX-B, 512 KB: skipped. Probing for Intel 28F004B5/BE/BV/BX-T, 512 KB: skipped. Probing for Intel 28F400BV/BX/CE/CV-B, 512 KB: skipped. Probing for Intel 28F400BV/BX/CE/CV-T, 512 KB: skipped. Probing for Intel 82802AB, 512 KB: skipped. Probing for Intel 82802AC, 1024 KB: skipped. Probing for Macronix MX25L512, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1005, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L2005, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L4005, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L8005, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Chip status register is 00 Chip status register: Status Register Write Disable (SRWD) is not set Chip status register: Bit 6 is not set Chip status register: Bit 5 / Block Protect 3 (BP3) is not set Chip status register: Bit 4 / Block Protect 2 (BP2) is not set Chip status register: Bit 3 / Block Protect 1 (BP1) is not set Chip status register: Bit 2 / Block Protect 0 (BP0) is not set Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Found chip "Macronix MX25L8005" (1024 KB, SPI) at physical address 0xfff00000. Probing for Macronix MX25L1605, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1635D, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1635E, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L3205, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L3235D, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L6405, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L12805, 16384 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX29F001B, 128 KB: skipped. Probing for Macronix MX29F001T, 128 KB: skipped. Probing for Macronix MX29F002B, 256 KB: skipped. Probing for Macronix MX29F002T, 256 KB: skipped. Probing for Macronix MX29F040, 512 KB: skipped. Probing for Macronix MX29LV040, 512 KB: skipped. Probing for MoselVitelic V29C51000B, 64 KB: skipped. Probing for MoselVitelic V29C51000T, 64 KB: skipped. Probing for MoselVitelic V29C51400B, 512 KB: skipped. Probing for MoselVitelic V29C51400T, 512 KB: skipped. Probing for MoselVitelic V29LC51000, 64 KB: skipped. Probing for MoselVitelic V29LC51001, 128 KB: skipped. Probing for MoselVitelic V29LC51002, 256 KB: skipped. Probing for Numonyx M25PE10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV010, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV016B, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV020, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV040, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV080B, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV512, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm29F002T, 256 KB: skipped. Probing for PMC Pm29F002B, 256 KB: skipped. Probing for PMC Pm39LV010, 128 KB: skipped. Probing for PMC Pm39LV020, 256 KB: skipped. Probing for PMC Pm39LV040, 512 KB: skipped. Probing for PMC Pm49FL002, 256 KB: skipped. Probing for PMC Pm49FL004, 512 KB: skipped. Probing for Sanyo LF25FW203A, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Sharp LHF00L04, 1024 KB: skipped. Probing for Spansion S25FL004A, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL008A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL016A, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL032A, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL064A, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF010.REMS, 128 KB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF016B, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF032B, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF064C, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF040.REMS, 512 KB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF040B, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25LF040A.RES, 512 KB: probe_spi_res2: id1 0x13, id2 0x13 Probing for SST SST25VF040B.REMS, 512 KB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF080B, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST28SF040A, 512 KB: skipped. Probing for SST SST29EE010, 128 KB: skipped. Probing for SST SST29LE010, 128 KB: skipped. Probing for SST SST29EE020A, 256 KB: skipped. Probing for SST SST29LE020, 256 KB: skipped. Probing for SST SST39SF512, 64 KB: skipped. Probing for SST SST39SF010A, 128 KB: skipped. Probing for SST SST39SF020A, 256 KB: skipped. Probing for SST SST39SF040, 512 KB: skipped. Probing for SST SST39VF512, 64 KB: skipped. Probing for SST SST39VF010, 128 KB: skipped. Probing for SST SST39VF020, 256 KB: skipped. Probing for SST SST39VF040, 512 KB: skipped. Probing for SST SST39VF080, 1024 KB: skipped. Probing for SST SST49LF002A/B, 256 KB: skipped. Probing for SST SST49LF003A/B, 384 KB: skipped. Probing for SST SST49LF004A/B, 512 KB: skipped. Probing for SST SST49LF004C, 512 KB: skipped. Probing for SST SST49LF008A, 1024 KB: skipped. Probing for SST SST49LF008C, 1024 KB: skipped. Probing for SST SST49LF016C, 2048 KB: skipped. Probing for SST SST49LF020, 256 KB: skipped. Probing for SST SST49LF020A, 256 KB: skipped. Probing for SST SST49LF040, 512 KB: skipped. Probing for SST SST49LF040B, 512 KB: skipped. Probing for SST SST49LF080A, 1024 KB: skipped. Probing for SST SST49LF160C, 2048 KB: skipped. Probing for ST M25P05-A, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P05.RES, 64 KB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P10.RES, 128 KB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P40-old, 512 KB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P128, 16384 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M29F002B, 256 KB: skipped. Probing for ST M29F002T/NT, 256 KB: skipped. Probing for ST M29F040B, 512 KB: skipped. Probing for ST M29F400BB, 512 KB: skipped. Probing for ST M29F400BT, 512 KB: skipped. Probing for ST M29W010B, 128 KB: skipped. Probing for ST M29W040B, 512 KB: skipped. Probing for ST M29W512B, 64 KB: skipped. Probing for ST M50FLW040A, 512 KB: skipped. Probing for ST M50FLW040B, 512 KB: skipped. Probing for ST M50FLW080A, 1024 KB: skipped. Probing for ST M50FLW080B, 1024 KB: skipped. Probing for ST M50FW002, 256 KB: skipped. Probing for ST M50FW016, 2048 KB: skipped. Probing for ST M50FW040, 512 KB: skipped. Probing for ST M50FW080, 1024 KB: skipped. Probing for ST M50LPW116, 2048 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001B, 128 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001T, 128 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51002B, 256 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51002T, 256 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51004B, 512 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51004T, 512 KB: skipped. Probing for SyncMOS/MoselVitelic {S,V}29C31004B, 512 KB: skipped. Probing for SyncMOS/MoselVitelic {S,V}29C31004T, 512 KB: skipped. Probing for TI TMS29F002RB, 256 KB: skipped. Probing for TI TMS29F002RT, 256 KB: skipped. Probing for Winbond W25Q80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 KB: skipped. Probing for Winbond W29C020(C)/W29C022, 256 KB: skipped. Probing for Winbond W29C040/P, 512 KB: skipped. Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 KB: skipped. Probing for Winbond W39L040, 512 KB: skipped. Probing for Winbond W39V040A, 512 KB: skipped. Probing for Winbond W39V040B, 512 KB: skipped. Probing for Winbond W39V040C, 512 KB: skipped. Probing for Winbond W39V040FA, 512 KB: skipped. Probing for Winbond W39V040FB, 512 KB: skipped. Probing for Winbond W39V040FC, 512 KB: skipped. Probing for Winbond W39V080A, 1024 KB: skipped. Probing for Winbond W49F002U/N, 256 KB: skipped. Probing for Winbond W49F020, 256 KB: skipped. Probing for Winbond W49V002A, 256 KB: skipped. Probing for Winbond W49V002FA, 256 KB: skipped. Probing for Winbond W39V080FA, 1024 KB: skipped. Probing for Winbond W39V080FA (dual mode), 512 KB: skipped. Probing for AMIC unknown AMIC SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel unknown Atmel SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon unknown Eon SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix unknown Macronix SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC unknown PMC SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST unknown SST SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST unknown ST SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Sanyo unknown Sanyo SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Generic unknown SPI chip (RDID), 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Generic unknown SPI chip (REMS), 0 KB: probe_spi_rems: id1 0xc2, id2 0x13 === This flash part has status UNTESTED for operations: WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! No operations were specified. [root@localhost flashrom]# A non-text attachment has been stripped: flash-rom-read It is available at http://paste.flashrom.org/view.php?id=691

1 0

Re: [flashrom] Additional voltages
by Stefan Tauner 11 Jul '11

11 Jul '11

On Sun, 10 Jul 2011 16:07:33 -0400 Steven Zakulec <spzakulec(a)gmail.com> wrote: > Index: flashchips.c > =================================================================== > --- flashchips.c (revision 1368) > +++ flashchips.c (working copy) > @@ -143,10 +143,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4750, 5250}, /* -55 speed is +-5%, all others +-10% */ > }, > > { > .vendor = "AMD", > .name = "Am29F016D", > @@ -254,10 +255,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -45R speed is 3.0-3.6V, others 2.7-3.6V */ > }, > > { > .vendor = "AMD", > .name = "Am29LV001BT", > @@ -284,10 +286,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -45R speed is 3.0-3.6V, others 2.7-3.6V */ > }, > > { > .vendor = "AMD", > .name = "Am29LV002BB", > @@ -315,10 +318,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -55 speed is 3.0-3.6V, others 2.7-3.6V */ > }, > > { > .vendor = "AMD", > .name = "Am29LV002BT", > @@ -346,10 +350,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -55 speed is 3.0-3.6V, others 2.7-3.6V */ > }, > > { > .vendor = "AMD", > .name = "Am29LV004BB", > @@ -377,10 +382,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "AMD", > .name = "Am29LV004BT", > @@ -408,10 +414,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "AMD", > .name = "Am29LV008BB", > @@ -439,10 +446,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600} /* 3.0-3.6V (-70R), 2.7-3.6V for others */ > }, > > { > .vendor = "AMD", > .name = "Am29LV008BT", > @@ -470,10 +478,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600} /* 3.0-3.6V (-70R), 2.7-3.6V for others */ > }, > > { > .vendor = "AMD", > .name = "Am29LV040B", > @@ -496,11 +505,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > - .voltage = {2700, 3600}, > + .voltage = {3000, 3600}, /* 3.0-3.6V (-60R), 2.7-3.6V for others */ > }, > > { > .vendor = "AMD", > .name = "Am29LV081B", > @@ -523,11 +532,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > - .voltage = {2700, 3600}, > + .voltage = {3000, 3600}, /* regulated voltage range- full range is 2.7-3.6V */ probably a speed grade distinction again? > }, > > { > .vendor = "AMIC", > .name = "A25L05PT", > @@ -589,10 +598,11 @@ > }, > .printlock = spi_prettyprint_status_register_amic_a25l05p, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "AMIC", > .name = "A25L10PT", > @@ -1330,11 +1340,11 @@ > }, > .printlock = spi_prettyprint_status_register_at25df, > .unlock = spi_disable_blockprotect_at25df, > .write = spi_chip_write_256, > .read = spi_chip_read, > - .voltage = {2300, 3600}, /* Datasheet says 2.3-3.6V or 2.7-3.6V */ > + .voltage = {2700, 3600}, /* Datasheet says there's a 2.3-3.6V & 2.7-3.6V model */ > }, > > { > .vendor = "Atmel", > .name = "AT25DF041A", > @@ -1368,11 +1378,11 @@ > }, > .printlock = spi_prettyprint_status_register_at25df, > .unlock = spi_disable_blockprotect_at25df, > .write = spi_chip_write_256, > .read = spi_chip_read, > - .voltage = {2300, 3600}, /* Datasheet says 2.3-3.6V or 2.7-3.6V */ > + .voltage = {2700, 3600}, /* Datasheet says there's a 2.3-3.6V & 2.7-3.6V model */ > }, > > { > .vendor = "Atmel", > .name = "AT25DF081", > @@ -1444,10 +1454,11 @@ > }, > .printlock = spi_prettyprint_status_register_at25df_sec, > .unlock = spi_disable_blockprotect_at25df_sec, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "Atmel", > .name = "AT25DF161", > @@ -1771,11 +1782,11 @@ > .block_erase = spi_block_erase_20, > } > }, > .write = NULL /* Incompatible Page write */, > .read = spi_chip_read, > - .voltage = {2700, 3600}, /* Datasheet says 3.0-3.6 V or 2.7-3.6 V */ > + .voltage = {2700, 3600}, /* Datasheet says 3.0-3.6 V or 2.7-3.6 V- either range is fine */ that comment is a bit vague... i like the one of the AT25DF041A above better. > }, > > { > .vendor = "Atmel", > .name = "AT26DF081A", > @@ -2112,11 +2123,11 @@ > .tested = TEST_BAD_READ, > .probe = probe_spi_rdid, > .probe_timing = TIMING_ZERO, > .write = NULL, > .read = NULL, > - .voltage = {2500, 3600}, /* Datasheet says 2.5-3.6 V or 2.7-3.6 V */ > + .voltage = {2700, 3600}, /* Datasheet says 2.5-3.6 V or 2.7-3.6 V */ > }, > > { > .vendor = "Atmel", > .name = "AT45DB161D", > @@ -2128,11 +2139,11 @@ > .tested = TEST_BAD_READ, > .probe = probe_spi_rdid, > .probe_timing = TIMING_ZERO, > .write = NULL, > .read = NULL, > - .voltage = {2500, 3600}, /* Datasheet says 2.5-3.6 V or 2.7-3.6 V */ > + .voltage = {2700, 3600}, /* Datasheet says 2.5-3.6 V or 2.7-3.6 V */ > }, > > { > .vendor = "Atmel", > .name = "AT45DB321C", > @@ -2315,10 +2326,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, > }, > > { > .vendor = "EMST", > .name = "F49B002UA", > @@ -3499,10 +3511,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, > }, > > { > .vendor = "Intel", > .name = "28F001BN/BX-B", > @@ -4050,10 +4063,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "Macronix", > .name = "MX25L3205", > @@ -4342,10 +4356,11 @@ > .block_erase = erase_chip_block_jedec, > }, > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, > }, > > { > .vendor = "Macronix", > .name = "MX29LV040", > @@ -4773,10 +4788,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "PMC", > .name = "Pm25LV020", > @@ -4898,10 +4914,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "PMC", > .name = "Pm29F002T", > @@ -5199,10 +5216,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "Spansion", > .name = "S25FL008A", > @@ -5279,10 +5297,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "Spansion", > .name = "S25FL064A", > @@ -5305,10 +5324,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "SST", > .name = "SST25VF010.REMS", > @@ -5334,10 +5354,11 @@ > }, > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_1, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "SST", > .name = "SST25VF016B", > @@ -5471,10 +5492,11 @@ > }, > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_1, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "SST", > .name = "SST25VF040B", > @@ -5536,10 +5558,11 @@ > }, > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_1, > .read = spi_chip_read, > + .voltage = {3000, 3600}, > }, > > { > .vendor = "SST", > .name = "SST25VF040B.REMS", > @@ -5571,10 +5594,11 @@ > }, > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_1, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "SST", > .name = "SST25VF080B", > @@ -5769,11 +5793,11 @@ > .manufacture_id = SST_ID, > .model_id = SST_SST39SF010, > .total_size = 128, > .page_size = 4096, > .feature_bits = FEATURE_EITHER_RESET, > - .tested = TEST_OK_PREW, > + .tested = TEST_OK_PR, why? > .probe = probe_jedec, > .probe_timing = 1, /* 150 ns */ > .block_erasers = > { > { > @@ -6703,11 +6727,11 @@ > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = ST_ID, > .model_id = ST_M25P128, > .total_size = 16384, > .page_size = 256, > - .tested = TEST_OK_PREW, > + .tested = TEST_UNTESTED, why? > .probe = probe_spi_rdid, > .probe_timing = TIMING_ZERO, > .block_erasers = > { > { > @@ -6778,10 +6802,11 @@ > } > }, > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > .vendor = "ST", > .name = "M25PX64", > @@ -7774,11 +7799,11 @@ > .read = spi_chip_read, > }, > > { > .vendor = "Winbond", > - .name = "W25X10", > + .name = "W25x10", ah i think i see the pattern... you are reverting my last changes. you need to rebase your changes on top of mine/the ones in svn instead. > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X10, > .total_size = 128, > .page_size = 256, > @@ -7805,11 +7830,11 @@ > .voltage = {2700, 3600}, > }, > > { > .vendor = "Winbond", > - .name = "W25X20", > + .name = "W25x20", > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X20, > .total_size = 256, > .page_size = 256, > @@ -7836,11 +7861,11 @@ > .voltage = {2700, 3600}, > }, > > { > .vendor = "Winbond", > - .name = "W25X40", > + .name = "W25x40", > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X40, > .total_size = 512, > .page_size = 256, > @@ -7867,11 +7892,11 @@ > .voltage = {2700, 3600}, > }, > > { > .vendor = "Winbond", > - .name = "W25X80", > + .name = "W25x80", > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X80, > .total_size = 1024, > .page_size = 256, > @@ -7898,11 +7923,11 @@ > .voltage = {2700, 3600}, > }, > > { > .vendor = "Winbond", > - .name = "W25X16", > + .name = "W25x16", > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X16, > .total_size = 2048, > .page_size = 256, > @@ -7935,11 +7960,11 @@ > .voltage = {2700, 3600}, > }, > > { > .vendor = "Winbond", > - .name = "W25X32", > + .name = "W25x32", > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X32, > .total_size = 4096, > .page_size = 256, > @@ -7972,11 +7997,11 @@ > .voltage = {2700, 3600}, > }, > > { > .vendor = "Winbond", > - .name = "W25X64", > + .name = "W25x64", > .bustype = CHIP_BUSTYPE_SPI, > .manufacture_id = WINBOND_NEX_ID, > .model_id = WINBOND_NEX_W25X64, > .total_size = 8192, > .page_size = 256, > @@ -8039,13 +8064,13 @@ > .manufacture_id = WINBOND_ID, > .model_id = WINBOND_W29C020, > .total_size = 256, > .page_size = 128, > .feature_bits = FEATURE_LONG_RESET, > - .tested = TEST_OK_PREW, > + .tested = TEST_OK_PRE, > .probe = probe_jedec, > - .probe_timing = 10, > + .probe_timing = 10, > .block_erasers = > { > { > .eraseblocks = { {256 * 1024, 1} }, > .block_erase = erase_chip_block_jedec, > @@ -8129,10 +8154,11 @@ > } > }, > .printlock = printlock_w39l040, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, > }, > > { > .vendor = "Winbond", > .name = "W39V040A", > @@ -8273,10 +8299,11 @@ > }, > .printlock = printlock_w39v040fb, > .unlock = unlock_w39v040fb, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /*Also offers a 12V fast program */ space after /* please > }, > > { > .vendor = "Winbond", > .name = "W39V040FC", > @@ -8300,10 +8327,11 @@ > } > }, > .printlock = printlock_w39v040fc, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /*Also offers a 12V fast program */ again > }, > > { > .vendor = "Winbond", > .name = "W39V080A", > @@ -8395,13 +8423,13 @@ > .manufacture_id = WINBOND_ID, > .model_id = WINBOND_W49V002A, > .total_size = 256, > .page_size = 128, > .feature_bits = FEATURE_EITHER_RESET, > - .tested = TEST_OK_PREW, > + .tested = TEST_OK_PRE, > .probe = probe_jedec, > - .probe_timing = 10, > + .probe_timing = 10, > .block_erasers = > { > { > .eraseblocks = { > {64 * 1024, 3}, > @@ -8504,10 +8532,11 @@ > } > }, > .printlock = printlock_w39v080fa_dual, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* 12 V fast program mode */ > }, > > { > .vendor = "AMIC", > .name = "unknown AMIC SPI chip", i just skimmed through it, so i may have missed a few things. thanks for trying to provide more context in the patch. it is not enough though... the number of 5 i told you was just an example. this adds 5 lines above and 5 lines below every change in a patch. what i wanted to accomplish is that the model name of every chip that is changed is mentioned in the patch. so depending on the number of erasers in the affected chips a number as high as 20 or so is needed (another example number). > I believe I've addressed all of your issues. > What's the correct datasheet for M25PX16 ? There seem to be several of them > , by different companies. st created a joint venture with others forming numonyx. numonyx was acquired by micron later... http://www.micron.com/get-document/?documentId=5983 -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] ECS GeForce 8000 series, NVIDIA MCP78S: flashrom -V (v0.9.2-r1141)
by Paul Menzel 10 Jul '11

10 Jul '11

Dear Philipp, please always reply to the list too and use interleaved style [3]. Am Sonntag, den 10.07.2011, 22:08 +0200 schrieb Philipp Shah: > actually I wrote that message because it was written on the console by > your program. Understood. > So I just wanted to support the project and didn't check whether a new > version exist and could cover my "case" of bios; I just used the ubuntu > package and wasn't thinking of a newer version. Thank you for the follow up. It is good to know that there is no problem on your end. Thanks again for supporting flashrom, Paul [3] http://en.opensuse.org/openSUSE:Mailing_list_netiquette

1 0

Re: [flashrom] Additional voltages
by Stefan Tauner 10 Jul '11

10 Jul '11

On Mon, 4 Jul 2011 22:27:59 -0400 Steven Zakulec <spzakulec(a)gmail.com> wrote: > Hello, I've attached some additional voltages for a number of the remaining > chips in flashchips.c. thanks for your continuous contributions :) > I have some questions about some of the remaining > chips: > > Should the voltage range always be the most restrictive one offered, with > others mentioned in the comments? that's most probably what we want for now, yes. i dont know what we are gonna do with the values, but a possible use case could be to tell an external programmer what voltage it should supply. we would have to choose a safe value from a number of choices that the programmer supports. since we are not able to differentiate between different speed grades (or whatever the distinction of chips with different voltage ranges are), we have to choose one of the most conservative range in our database. later this could be extended to allow the user to set a voltage outside of the safe range, but inside the extended ranges. > Where can I find the datasheet for the Sanyo LF25FW203A? good question, i cant find one either. the guy who has added this (Sean Nelson <audiohacked(a)gmail.com>) is currently unavailable afaik. > Can I ignore the .REMS/etc text after a chip name when looking for the > datasheet? Is it something I need to be aware of? yes. the suffix corresponds with the opcode used to identify the chip. some chips do support multiple such opcodes and are added multiple times (for now) in flashchips.c supply voltage is independent and so should be equal for such variations. > Is there a difference for M25P40 and P40-old? similar to above the old version seems to use a different probing method. i have not looked at the datasheet(s) so i can't say if the supply voltages are different. http://www.coreboot.org/pipermail/coreboot/2008-May/034640.html and the preceding discussion may shed some light on this. if i were you i would just leave it out for now. > For the W25Q64, it seems to be on the same datasheet as the Q80, Q16, and > Q32, but it's only referenced once in the sheet, and makes me wonder if this > is the correct sheet then. there are multiple versions of the W25Q64 (and maybe also of the other chips in the 25Q series, i have not looked into it). http://www.winbond.com/hq/enu/ProductAndSales/ProductSearch/?partno=w25q64 V: 3V (no datasheet, probably predecessor of BV. BV: 3V (deprecated) CV: 3V (successor of BV) DW: 1.8V (not supported by flashrom yet, has a different id (0x6017) the difference between BV and CV regarding the supply voltage is, that the BV specs a supply voltage of at least 3.0V for "Octal Word Read Quad I/O (E3h)" when used with a clock of 50MHz. this can be ignored for now, just use 2.7-3.3 imho. > Index: flashchips.c > =================================================================== > --- flashchips.c (revision 1364) > +++ flashchips.c (working copy) i have not looked into it in detail yet, just a few comments... > @@ -145,6 +145,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4750, 5250}, /* -55 speed is +-5%, all others +-10% */ > }, > > { > @@ -256,6 +257,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -45R speed is 3.0-3.6V regulated, others 2.7-3.6V */ > }, i think you can drop "regulated" in those entries. its use in the datasheet is already a bit odd imho, but in the comments it is even less clear without the context of the datasheet. > { > @@ -286,6 +288,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -45R speed is 3.0-3.6V regulated, others 2.7-3.6V */ > }, > > { > @@ -317,6 +320,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -55 speed is 3.0-3.6V regulated, others 2.7-3.6V */ > }, > > { > @@ -348,6 +352,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600}, /* -55 speed is 3.0-3.6V regulated, others 2.7-3.6V */ > }, > > { > @@ -379,6 +384,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {2700, 3600}, > }, > > { > @@ -410,6 +416,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {2700, 3600}, > }, > > { > @@ -441,6 +448,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600} /* 3.0-3.6V regulated(-70R), 2.7-3.6V for others */ > }, > > { > @@ -472,6 +480,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {3000, 3600} /* 3.0-3.6V regulated(-70R), 2.7-3.6V for others */ > }, > > { > @@ -498,7 +507,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > - .voltage = {2700, 3600}, > + .voltage = {3000, 3600}, /* regulated voltage range- full range is 2.7-3.6V */ > }, NB: that's the diff for Am29LV040B >3.0V for the -60R speedgrade only, so essentially the line should be similar to the ones above. when reading that datasheet i noticed the following paragraph: "The device requires only a single power supply (2.7 V–3.6V) for both read and write functions. Internally generated and regulated voltages are provided for the program and erase operations." this indicates to me that at least for these "regulated" means that they have an internal voltage regulator to guarantee stable supply for write/erase operations. such regulators need a minimum difference between input (vcc) and output (some internal voltage rail), hence the 0.3V higher vcc requirement. i am not sure if the other chips we have encountered also have internal regulators, but they may have. these are implementation-specific details which are not necessarily interesting to flashrom or its users. i think just naming the speed grades for the noted ranges is the best way to deal with such chips for now. > { > @@ -525,7 +534,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > - .voltage = {2700, 3600}, > + .voltage = {3000, 3600}, /* regulated voltage range- full range is 2.7-3.6V */ > }, > > { > @@ -591,6 +600,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -1446,6 +1456,7 @@ > .unlock = spi_disable_blockprotect_at25df_sec, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -2317,6 +2328,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, > }, > > { > @@ -3501,6 +3513,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, > }, > > { > @@ -4052,6 +4065,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -4344,6 +4358,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, > }, > > { > @@ -4775,6 +4790,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -4900,6 +4916,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -5201,6 +5218,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -5281,6 +5299,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -5307,6 +5326,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { > @@ -6780,6 +6800,7 @@ > .unlock = spi_disable_blockprotect, > .write = spi_chip_write_256, > .read = spi_chip_read, > + .voltage = {2700, 3600}, > }, > > { to ease review you could post diffs with more context so that the chip models are included in each hunk. i cant remember the correct svn diff parameters right now for this though. i personally don't need it, but if you can figure it out quickly it may be nice to have. :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] Probe, Read, Erase, Write Success on Winbond W25Q16 with buspirate_spi
by Stefan Tauner 10 Jul '11

10 Jul '11

On Sat, 9 Jul 2011 21:28:42 -0400 Jon Szymaniak <jon.szymaniak(a)gmail.com> wrote: > Hi there, > > Per the "UNTESTED" message I received in v0.9.3-r1364, I just wanted to > report a couple successful PROBE, READ, WRITE and ERASE operations on a > Winbond W25Q16 with a BusPirate v2g0 (FW 4.1). I suppose this is expected > given that the W25X16 is supported, but thought someone might like to know > ;). > > I've attached the requested -V dumps for the aforementioned operations, as > well as 'time' output for each operation. With the BP v2g0 running FW v4.1, > I was seeing ~30 min on a 2MB read, and ~90 min on a 2MB write. I see that > somewhere above FW v5.7 and with some flashrom patches I should be able to > get some much quicker reads and writes. If I can get that going, I'd be > happy to do a bit more testing with this chip if you folks are interested. > > Thank you for providing a wonderful piece of software...cheers! > Jon Szymaniak hello jon and thanks for your (thorough) report! i have marked the chip as fully tested and will commit that later. PS: uncompressed logs are preferred (because they can be easier searched), no need to resend them though. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom