flashrom

flashrom@flashrom.org

9164 discussions

[PATCH 1/4] Let pcidev clean itself up.
by Stefan Tauner 31 Dec '12

31 Dec '12

We got a nice shutdown function registration infrastructure, but did not use it very wisely. Instead we added shutdown functions to a myriad of programmers unnecessarily. In this patch we get rid of those that do only call pci_cleanup(pacc) by adding a shutdown function the pcidev.c itself that gets registered by pcidev_init(). Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- atahpt.c | 10 ---------- drkaiser.c | 3 +-- gfxnvidia.c | 6 +----- nic3com.c | 2 +- nicintel.c | 5 +---- nicintel_spi.c | 2 +- nicrealtek.c | 7 +++++-- ogp_spi.c | 2 -- pcidev.c | 15 +++++++++++++++ satamv.c | 7 +------ satasii.c | 1 - 11 files changed, 26 insertions(+), 34 deletions(-) diff --git a/atahpt.c b/atahpt.c index 92f7deb..d19cb75 100644 --- a/atahpt.c +++ b/atahpt.c @@ -56,13 +56,6 @@ static const struct par_programmer par_programmer_atahpt = { .chip_writen = fallback_chip_writen, }; -static int atahpt_shutdown(void *data) -{ - /* Flash access is disabled automatically by PCI restore. */ - pci_cleanup(pacc); - return 0; -} - int atahpt_init(void) { uint32_t reg32; @@ -77,9 +70,6 @@ int atahpt_init(void) reg32 |= (1 << 24); rpci_write_long(pcidev_dev, REG_FLASH_ACCESS, reg32); - if (register_shutdown(atahpt_shutdown, NULL)) - return 1; - register_par_programmer(&par_programmer_atahpt, BUS_PARALLEL); return 0; diff --git a/drkaiser.c b/drkaiser.c index e461061..a6eca1c 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -59,8 +59,6 @@ static const struct par_programmer par_programmer_drkaiser = { static int drkaiser_shutdown(void *data) { physunmap(drkaiser_bar, DRKAISER_MEMMAP_SIZE); - /* Flash write is disabled automatically by PCI restore. */ - pci_cleanup(pacc); return 0; } @@ -71,6 +69,7 @@ int drkaiser_init(void) if (rget_io_perms()) return 1; + /* No need to check for errors, pcidev_init() will not return in case of errors. */ addr = pcidev_init(PCI_BASE_ADDRESS_2, drkaiser_pcidev); /* Write magic register to enable flash write. */ diff --git a/gfxnvidia.c b/gfxnvidia.c index 624fd7c..a994d68 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -80,10 +80,6 @@ static const struct par_programmer par_programmer_gfxnvidia = { static int gfxnvidia_shutdown(void *data) { physunmap(nvidia_bar, GFXNVIDIA_MEMMAP_SIZE); - /* Flash interface access is disabled (and screen enabled) automatically - * by PCI restore. - */ - pci_cleanup(pacc); return 0; } @@ -94,6 +90,7 @@ int gfxnvidia_init(void) if (rget_io_perms()) return 1; + /* No need to check for errors, pcidev_init() will not return in case of errors. */ io_base_addr = pcidev_init(PCI_BASE_ADDRESS_0, gfx_nvidia); io_base_addr += 0x300000; @@ -101,7 +98,6 @@ int gfxnvidia_init(void) nvidia_bar = physmap("NVIDIA", io_base_addr, GFXNVIDIA_MEMMAP_SIZE); - /* Must be done before rpci calls. */ if (register_shutdown(gfxnvidia_shutdown, NULL)) return 1; diff --git a/nic3com.c b/nic3com.c index 05eada6..4ec6193 100644 --- a/nic3com.c +++ b/nic3com.c @@ -81,7 +81,6 @@ static int nic3com_shutdown(void *data) OUTL(internal_conf, io_base_addr + INTERNAL_CONFIG); } - pci_cleanup(pacc); return 0; } @@ -90,6 +89,7 @@ int nic3com_init(void) if (rget_io_perms()) return 1; + /* No need to check for errors, pcidev_init() will not return in case of errors. */ io_base_addr = pcidev_init(PCI_BASE_ADDRESS_0, nics_3com); id = pcidev_dev->device_id; diff --git a/nicintel.c b/nicintel.c index d210d78..8481915 100644 --- a/nicintel.c +++ b/nicintel.c @@ -63,7 +63,6 @@ static int nicintel_shutdown(void *data) { physunmap(nicintel_control_bar, NICINTEL_CONTROL_MEMMAP_SIZE); physunmap(nicintel_bar, NICINTEL_MEMMAP_SIZE); - pci_cleanup(pacc); return 0; } @@ -77,8 +76,7 @@ int nicintel_init(void) if (rget_io_perms()) return 1; - /* No need to check for errors, pcidev_init() will not return in case - * of errors. + /* No need to check for errors, pcidev_init() will not return in case of errors. * FIXME: BAR2 is not available if the device uses the CardBus function. */ addr = pcidev_init(PCI_BASE_ADDRESS_2, nics_intel); @@ -117,7 +115,6 @@ int nicintel_init(void) error_out_unmap: physunmap(nicintel_bar, NICINTEL_MEMMAP_SIZE); error_out: - pci_cleanup(pacc); return 1; } diff --git a/nicintel_spi.c b/nicintel_spi.c index 325e61c..f61c2b1 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -160,7 +160,6 @@ static int nicintel_spi_shutdown(void *data) pci_mmio_writel(tmp, nicintel_spibar + EECD); physunmap(nicintel_spibar, MEMMAP_SIZE); - pci_cleanup(pacc); return 0; } @@ -172,6 +171,7 @@ int nicintel_spi_init(void) if (rget_io_perms()) return 1; + /* No need to check for errors, pcidev_init() will not return in case of errors. */ io_base_addr = pcidev_init(PCI_BASE_ADDRESS_0, nics_intel_spi); nicintel_spibar = physmap("Intel Gigabit NIC w/ SPI flash", diff --git a/nicrealtek.c b/nicrealtek.c index 3c3b261..0929e5d 100644 --- a/nicrealtek.c +++ b/nicrealtek.c @@ -51,22 +51,25 @@ static const struct par_programmer par_programmer_nicrealtek = { .chip_writen = fallback_chip_writen, }; +#if 0 static int nicrealtek_shutdown(void *data) { /* FIXME: We forgot to disable software access again. */ - pci_cleanup(pacc); return 0; } +#endif int nicrealtek_init(void) { if (rget_io_perms()) return 1; + /* No need to check for errors, pcidev_init() will not return in case of errors. */ io_base_addr = pcidev_init(PCI_BASE_ADDRESS_0, nics_realtek); - +#if 0 if (register_shutdown(nicrealtek_shutdown, NULL)) return 1; +#endif /* Beware, this ignores the vendor ID! */ switch (pcidev_dev->device_id) { diff --git a/ogp_spi.c b/ogp_spi.c index d1bb12f..6fb1a77 100644 --- a/ogp_spi.c +++ b/ogp_spi.c @@ -100,8 +100,6 @@ static const struct bitbang_spi_master bitbang_spi_master_ogp = { static int ogp_spi_shutdown(void *data) { physunmap(ogp_spibar, 4096); - pci_cleanup(pacc); - return 0; } diff --git a/pcidev.c b/pcidev.c index 1a26e99..37bcc22 100644 --- a/pcidev.c +++ b/pcidev.c @@ -154,6 +154,14 @@ uintptr_t pcidev_readbar(struct pci_dev *dev, int bar) return (uintptr_t)addr; } +static int pcidev_shutdown(void *data) +{ + if (pacc != NULL) + pci_cleanup(pacc); + pcidev_dev = NULL; + return 0; +} + uintptr_t pcidev_init(int bar, const struct dev_entry *devs) { struct pci_dev *dev; @@ -166,6 +174,8 @@ uintptr_t pcidev_init(int bar, const struct dev_entry *devs) pacc = pci_alloc(); /* Get the pci_access structure */ pci_init(pacc); /* Initialize the PCI library */ + if (register_shutdown(pcidev_shutdown, NULL)) + return 1; pci_scan_bus(pacc); /* We want to get the list of devices */ pci_filter_init(pacc, &filter); @@ -244,6 +254,11 @@ struct undo_pci_write_data { int undo_pci_write(void *p) { struct undo_pci_write_data *data = p; + if (pacc == NULL) { + msg_perr("%s: Tried to undo PCI writes without a valid PCI context!\n" + "Please report a bug at flashrom(a)flashrom.org\n", __func__); + return 1; + } msg_pdbg("Restoring PCI config space for %02x:%02x:%01x reg 0x%02x\n", data->dev.bus, data->dev.dev, data->dev.func, data->reg); switch (data->type) { diff --git a/satamv.c b/satamv.c index c0c1ffa..46a0e2d 100644 --- a/satamv.c +++ b/satamv.c @@ -60,7 +60,6 @@ static const struct par_programmer par_programmer_satamv = { static int satamv_shutdown(void *data) { physunmap(mv_bar, 0x20000); - pci_cleanup(pacc); return 0; } @@ -96,7 +95,7 @@ int satamv_init(void) mv_bar = physmap("Marvell 88SX7042 registers", addr, 0x20000); if (mv_bar == ERROR_PTR) - goto error_out; + return 1; if (register_shutdown(satamv_shutdown, NULL)) return 1; @@ -159,10 +158,6 @@ int satamv_init(void) register_par_programmer(&par_programmer_satamv, BUS_PARALLEL); return 0; - -error_out: - pci_cleanup(pacc); - return 1; } /* BAR2 (MEM) can map NVRAM and flash. We set it to flash in the init function. diff --git a/satasii.c b/satasii.c index 7b94203..730c420 100644 --- a/satasii.c +++ b/satasii.c @@ -57,7 +57,6 @@ static const struct par_programmer par_programmer_satasii = { static int satasii_shutdown(void *data) { physunmap(sii_bar, SATASII_MEMMAP_SIZE); - pci_cleanup(pacc); return 0; } -- Kind regards, Stefan Tauner

1 0

Re: [flashrom] [PATCH] automatically round address ranges requested from physmap_common to page boundaries
by Stefan Tauner 31 Dec '12

31 Dec '12

On Mon, 30 May 2011 02:45:44 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > this patch also changes the display width of all addresses in physmap.c to 16 hex characters. > > FIXME: what about unmappings? > munmap is safe. > djgpp's __dpmi_free_physical_address_mapping: unknown. > DirectHW's unmap_physical: unknown. > > FIXME: jakllsch suggested using PRIx64 instead of x, because it's more portable FIXME: in the case we can not map and 'mayfail' is true we should return ERROR_PTR instead of ERROR_PTR + diff -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 1

Re: [flashrom] 2theMax RAID 100 (HPT370)
by Roy 31 Dec '12

31 Dec '12

2012/12/28 Idwer Vollering <vidwer(a)gmail.com>: > 2012/12/27 Roy <roytam(a)gmail.com>: >> Hi all, >> >> I got a 2theMax RAID 100 card with SST MPF 39SF512 70-4C-NH 64KB ROm on >> PCB, >> flashrom segfaults at the end. > > Interesting. Can you run flashrom from GDB? > > 'gdb --args ./flashrom -p atahpt -V' > (gdb) start > (wait a little) > (gdb) bt > Sure. But isn't pcilib yells the prefix path is NULL? root@www6:~/flashrom-0.9.6.1# gdb -args ./flashrom -p atahpt GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i486-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /root/flashrom-0.9.6.1/flashrom...done. (gdb) r Starting program: /root/flashrom-0.9.6.1/flashrom -p atahpt flashrom v0.9.6.1-r1564 on Linux 2.6.32-5-686 (i686) flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. === This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output to flashrom(a)flashrom.org if it works for you. Please add the name of your PCI device to the subject. Thank you for your help! === No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. pcilib: Cannot open (null)/devices/0000:00:0f.0/config Program received signal SIGSEGV, Segmentation fault. 0xb7ee52ae in ?? () from /lib/i686/cmov/libc.so.6 (gdb) bt #0 0xb7ee52ae in ?? () from /lib/i686/cmov/libc.so.6 #1 0xb7ee6745 in ?? () from /lib/i686/cmov/libc.so.6 #2 0xb7ee98ad in free () from /lib/i686/cmov/libc.so.6 #3 0x0806dd5f in undo_pci_write (p=0x80a30e0) at pcidev.c:274 #4 0x08049ff2 in programmer_shutdown () at flashrom.c:367 #5 0x0804db16 in main (argc=3, argv=0xbffffd94) at cli_classic.c:521 (gdb) >> >> lspci: >> 00:0f.0 Mass storage controller [0180]: HighPoint Technologies, Inc. >> HPT366/368/370/370A/372/372N [1103:0004] (rev 03) >> Subsystem: HighPoint Technologies, Inc. HPT370 UDMA100 >> [1103:0005] >> Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- >> ParErr- >> Stepping- SERR- FastB2B- DisINTx- >> Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- >> <TAbort- <MAbort- >SERR- <PERR- INTx- >> Latency: 120 (2000ns min, 2000ns max), Cache Line Size: 32 bytes >> Interrupt: pin A routed to IRQ 18 >> Region 0: I/O ports at a800 [size=8] >> Region 1: I/O ports at a400 [size=4] >> Region 2: I/O ports at a000 [size=8] >> Region 3: I/O ports at 9800 [size=4] >> Region 4: I/O ports at 9400 [size=256] >> [virtual] Expansion ROM at 20020000 [disabled] [size=128K] >> Kernel driver in use: HPT366_IDE > > Does unloading/not loading hpt366_ide at boot time improve things? > >> 00: 03 11 04 00 05 00 00 02 03 00 80 01 08 78 00 00 >> 10: 01 a8 00 00 01 a4 00 00 01 a0 00 00 01 98 00 00 >> 20: 01 94 00 00 00 00 00 00 00 00 00 00 03 11 05 00 >> 30: 00 00 00 00 60 00 00 00 00 00 00 00 0a 01 08 08 >> 40: a7 4e 81 06 a7 4e 81 06 a7 4e 81 06 a7 4e 81 06 >> 50: 05 01 00 00 05 01 00 00 1b 00 00 23 24 00 26 00 >> 60: 01 00 22 00 00 00 00 00 00 00 00 00 00 00 00 00 >> 70: 00 00 00 00 00 00 00 00 94 00 00 00 00 00 00 00 >> 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >> >> flashrom v0.9.6.1-r1564 on Linux 2.6.32-5-686 (i686) >> flashrom is free software, get the source code at >> http://www.flashrom.org >> >> flashrom was built with libpci 3.1.7, GCC 4.4.5, little endian > > On which operating system is it built, segfaulting? Debian 6.0.6 i386. > >> Command line (3 args): ./flashrom -p atahpt -V >> Calibrating delay loop... OS timer resolution is 1 usecs, 230M loops per >> second, delay more than 10% too short (got 76% of expected delay), >> recalculating... 291M loops per second, 10 myus = 10 us, 100 myus = 97 >> us, >> 1000 myus = 962 us, 10000 myus = 9635 us, 4 myus = 5 us, OK. >> Initializing atahpt programmer >> Found "Highpoint HPT366/368/370/370A/372/372N" (1103:0004, BDF 00:0f.0). >> === >> This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output >> to flashrom(a)flashrom.org if it works for you. Please add the name of >> your >> PCI device to the subject. Thank you for your help! >> === >> Requested BAR is I/O >> The following protocols are supported: Parallel. >> Probing for AMD Am29F010A/B, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29F002(N)BB, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for AMD Am29F002(N)BT, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for AMD Am29F016D, 2048 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29F040B, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29F080B, 1024 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV001BB, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV001BT, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV002BB, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV002BT, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV004BB, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV004BT, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV008BB, 1024 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for AMD Am29LV008BT, 1024 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for AMD Am29LV040B, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMD Am29LV081B, 1024 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMIC A29002B, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMIC A29002T, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for AMIC A29040B, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT29C512, 64 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT29C010A, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT29C020, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT29C040A, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT49BV512, 64 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT49F002(N), 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Atmel AT49F002(N)T, 256 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Atmel AT49F020, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Atmel AT49F040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Catalyst CAT28F512, 64 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Bright BM29F040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for EMST F49B002UA, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Eon EN29F010, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Eon EN29F002(A)(N)B, 256 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Eon EN29F002(A)(N)T, 256 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Eon EN29LV640B, 8192 kB: probe_en29lv640b: id1 0x0000, id2 >> 0x0000 >> Probing for Fujitsu MBM29F004BC, 512 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Fujitsu MBM29F004TC, 512 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Fujitsu MBM29F400BC, 512 kB: probe_m29f400bt: id1 0x00, id2 >> 0x00 >> Probing for Fujitsu MBM29F400TC, 512 kB: probe_m29f400bt: id1 0x00, id2 >> 0x00 >> Probing for Hyundai HY29F002T, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Hyundai HY29F002B, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Hyundai HY29F040A, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F001BN/BX-B, 128 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F001BN/BX-T, 128 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F002BC/BL/BV/BX-T, 256 kB: probe_82802ab: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F008S3/S5/SC, 512 kB: probe_82802ab: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Intel 28F004B5/BE/BV/BX-B, 512 kB: probe_82802ab: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F004B5/BE/BV/BX-T, 512 kB: probe_82802ab: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F400BV/BX/CE/CV-B, 512 kB: probe_82802ab: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Intel 28F400BV/BX/CE/CV-T, 512 kB: probe_82802ab: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Macronix MX29F001B, 128 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Macronix MX29F001T, 128 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Macronix MX29F002(N)B, 256 kB: probe_jedec_common: id1 >> 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Macronix MX29F002(N)T, 256 kB: probe_jedec_common: id1 >> 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Macronix MX29F040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Macronix MX29LV040, 512 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for MoselVitelic V29C51000B, 64 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for MoselVitelic V29C51000T, 64 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for MoselVitelic V29C51400B, 512 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for MoselVitelic V29C51400T, 512 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for MoselVitelic V29LC51000, 64 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for MoselVitelic V29LC51001, 128 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for MoselVitelic V29LC51002, 256 kB: probe_jedec_common: id1 >> 0x00, >> id2 0x00, id1 parity violation, id1 is normal flash content, id2 is >> normal >> flash content >> Probing for PMC Pm29F002T, 256 kB: Chip lacks correct probe timing >> information, using default 10mS/40uS. probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for PMC Pm29F002B, 256 kB: Chip lacks correct probe timing >> information, using default 10mS/40uS. probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for PMC Pm39LV010, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for PMC Pm39LV020, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for PMC Pm39LV040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for PMC Pm39LV512, 64 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Sharp LH28F008BJT-BTLZ1, 1024 kB: probe_82802ab: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for SST SST28SF040A, 512 kB: probe_82802ab: id1 0x00, id2 0x00, >> id1 >> parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST29EE010, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST29LE010, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST29EE020A, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST29LE020, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39SF512, 64 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39SF010A, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39SF020A, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39SF040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39VF512, 64 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39VF010, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39VF020, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39VF040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SST SST39VF080, 1024 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for ST M29F002B, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 >> parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for ST M29F002T/NT, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for ST M29F040B, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 >> parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for ST M29F400BB, 512 kB: probe_m29f400bt: id1 0x00, id2 0x00 >> Probing for ST M29F400BT, 512 kB: probe_m29f400bt: id1 0x00, id2 0x00 >> Probing for ST M29W010B, 128 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 >> parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for ST M29W040B, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 >> parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for ST M29W512B, 64 kB: probe_jedec_common: id1 0x00, id2 0x00, >> id1 >> parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for SyncMOS/MoselVitelic {F,S,V}29C51001B, 128 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for SyncMOS/MoselVitelic {F,S,V}29C51001T, 128 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for SyncMOS/MoselVitelic {F,S,V}29C51002B, 256 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for SyncMOS/MoselVitelic {F,S,V}29C51002T, 256 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for SyncMOS/MoselVitelic {F,S,V}29C51004B, 512 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for SyncMOS/MoselVitelic {F,S,V}29C51004T, 512 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for SyncMOS/MoselVitelic {S,V}29C31004B, 512 kB: >> probe_jedec_common: >> id1 0x00, id2 0x00, id1 parity violation, id1 is normal flash content, >> id2 >> is normal flash content >> Probing for SyncMOS/MoselVitelic {S,V}29C31004T, 512 kB: >> probe_jedec_common: >> id1 0x00, id2 0x00, id1 parity violation, id1 is normal flash content, >> id2 >> is normal flash content >> Probing for TI TMS29F002RB, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for TI TMS29F002RT, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old, 128 kB: >> Old >> Winbond W29* probe method disabled because the probing sequence puts the >> AMIC A49LF040A in a funky state. Use 'flashrom -c >> W29C010(M)/W29C011A/W29EE011/W29EE012-old' if you have a board with >> such a >> chip. >> Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: >> probe_jedec_common: id1 0x00, id2 0x00, id1 parity violation, id1 is >> normal >> flash content, id2 is normal flash content >> Probing for Winbond W29C020(C)/W29C022, 256 kB: probe_jedec_common: id1 >> 0x00, id2 0x00, id1 parity violation, id1 is normal flash content, id2 >> is >> normal flash content >> Probing for Winbond W29C040/P, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Winbond W39L040, 512 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> Probing for Winbond W49F002U/N, 256 kB: probe_jedec_common: id1 0x00, >> id2 >> 0x00, id1 parity violation, id1 is normal flash content, id2 is normal >> flash >> content >> Probing for Winbond W49F020, 256 kB: probe_jedec_common: id1 0x00, id2 >> 0x00, >> id1 parity violation, id1 is normal flash content, id2 is normal flash >> content >> No EEPROM/flash device found. >> Note: flashrom can never write if the flash chip isn't found >> automatically. >> Restoring PCI config space for 00:0f:0 reg 0x58 >> pcilib: Cannot open (null)/devices/0000:00:0f.0/config >> >> HTH, >> Roy >> >> >> _______________________________________________ >> flashrom mailing list >> flashrom(a)flashrom.org >> http://www.flashrom.org/mailman/listinfo/flashrom

2 2

VIA VT6421A (HZ-006)
by Roy 31 Dec '12

31 Dec '12

Hi all, It has "HZ-006" printed on the PCB. It does have Pm39LV512-70JCB on the board, but it seems no firmware written and no boot ROM messages. lspci: 00:0f.0 RAID bus controller [0104]: VIA Technologies, Inc. VT6421 IDE RAID Controller [1106:3249] (rev 50) Subsystem: VIA Technologies, Inc. VT6421 IDE RAID Controller [1106:3249] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 32 Interrupt: pin A routed to IRQ 18 Region 0: I/O ports at a800 [size=16] Region 1: I/O ports at a400 [size=16] Region 2: I/O ports at a000 [size=16] Region 3: I/O ports at 9800 [size=16] Region 4: I/O ports at 9400 [size=32] Region 5: I/O ports at 9000 [size=256] [virtual] Expansion ROM at 20020000 [disabled] [size=64K] Capabilities: [e0] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: sata_via 00: 06 11 49 32 07 00 90 02 50 00 04 01 00 20 00 00 10: 01 a8 00 00 01 a4 00 00 01 a0 00 00 01 98 00 00 20: 01 94 00 00 01 90 00 00 00 00 00 00 06 11 49 32 30: 00 00 00 00 e0 00 00 00 00 00 00 00 0a 01 00 00 40: 33 03 f1 44 0e af 00 00 00 00 00 03 00 00 00 00 50: 00 00 04 00 00 00 00 00 00 10 10 00 05 00 20 00 60: 00 00 ff ff 00 00 00 00 00 00 00 00 00 00 ff ff 70: 00 00 00 00 01 f0 00 00 01 00 01 00 11 00 00 00 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 a0: 0b f2 c9 35 10 ac c0 00 a8 a8 a8 a8 ff 00 b6 b6 b0: 0f 0f 0f 0f 34 00 00 00 00 00 20 00 00 00 00 00 c0: 00 02 00 00 00 00 00 00 00 02 00 00 00 00 00 00 d0: 02 01 00 00 00 00 00 00 02 01 00 00 00 00 00 00 e0: 01 00 02 00 00 00 00 00 50 01 49 32 06 11 49 32 f0: 00 00 70 00 00 00 00 00 00 00 00 00 00 00 00 00 flashrom v0.9.6.1-r1564 on Linux 2.6.32-5-686 (i686) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.7, GCC 4.4.5, little endian Command line (3 args): ./flashrom -p atavia -V Calibrating delay loop... OS timer resolution is 1 usecs, 261M loops per second, delay more than 10% too short (got 87% of expected delay), recalculating... 296M loops per second, 10 myus = 10 us, 100 myus = 98 us, 1000 myus = 986 us, 10000 myus = 9789 us, 4 myus = 5 us, OK. Initializing atavia programmer Found "VIA VT6421A" (1106:3249, BDF 00:0f.0). === This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output to flashrom(a)flashrom.org if it works for you. Please add the name of your PCI device to the subject. Thank you for your help! === Requested BAR is ROM Error: No supported PCI device found. HTH, Roy

2 4

W836xx: Compaq Presario CQ60: flashrom -V
by Narcis Garcia - GiLUG 30 Dec '12

30 Dec '12

$ sudo flashrom -p internal -V flashrom v0.9.6.1-r1563 on Linux 3.5.0-21-generic (i686) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.9, GCC 4.7.1, little endian Command line (3 args): flashrom -p internal -V Calibrating delay loop... OS timer resolution is 1 usecs, 1661M loops per second, 10 myus = 10 us, 100 myus = 100 us, 1000 myus = 1017 us, 10000 myus = 10012 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "Hewlett-Packard" DMI string system-product-name: "Compaq Presario CQ60 Notebook PC" DMI string system-version: "F.26" DMI string baseboard-manufacturer: "Wistron" DMI string baseboard-product-name: "3612" DMI string baseboard-version: "09.45" DMI string chassis-type: "Notebook" Laptop detected via DMI. W836xx enter config mode worked or we were already in config mode. W836xx leave config mode had no effect. Active config mode, unknown reg 0x20 ID: fc. Please send the output of "flashrom -V" to flashrom(a)flashrom.org with W836xx: your board name: flashrom -V as the subject to help us finish support for your Super I/O. Thanks. ======================================================================== WARNING! You seem to be running flashrom on an unsupported laptop. Laptops, notebooks and netbooks are difficult to support and we recommend to use the vendor flashing utility. The embedded controller (EC) in these machines often interacts badly with flashing. See http://www.flashrom.org/Laptops for details. If flash is shared with the EC, erase is guaranteed to brick your laptop and write may brick your laptop. Read and probe may irritate your EC and cause fan failure, backlight failure and sudden poweroff. You have been warned. ======================================================================== Aborting. Error: Programmer initialization failed.

1 0

[commit] r1639 - trunk
by repository service 30 Dec '12

30 Dec '12

Author: stefanct Date: Sun Dec 30 02:23:17 2012 New Revision: 1639 URL: http://flashrom.org/trac/flashrom/changeset/1639 Log: Constify parameters and globals. This makes some stuff const (partially to get a more convenient libflashrom interface). Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/cli_classic.c trunk/flash.h trunk/flashrom.c trunk/programmer.h Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Sat Dec 29 20:26:55 2012 (r1638) +++ trunk/cli_classic.c Sun Dec 30 02:23:17 2012 (r1639) @@ -532,7 +532,7 @@ free(layoutfile); free(pparam); /* clean up global variables */ - free(chip_to_probe); + free((char *)chip_to_probe); /* Silence! Freeing is not modifying contents. */ chip_to_probe = NULL; #ifndef STANDALONE ret |= close_logfile(); Modified: trunk/flash.h ============================================================================== --- trunk/flash.h Sat Dec 29 20:26:55 2012 (r1638) +++ trunk/flash.h Sun Dec 30 02:23:17 2012 (r1639) @@ -222,7 +222,7 @@ extern int verbose_screen; extern int verbose_logfile; extern const char flashrom_version[]; -extern char *chip_to_probe; +extern const char *chip_to_probe; void map_flash_registers(struct flashctx *flash); int read_memmapped(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int erase_flash(struct flashctx *flash); @@ -231,7 +231,7 @@ int min(int a, int b); int max(int a, int b); void tolower_string(char *str); -char *extract_param(char **haystack, const char *needle, const char *delim); +char *extract_param(const char *const *haystack, const char *needle, const char *delim); int verify_range(struct flashctx *flash, uint8_t *cmpbuf, unsigned int start, unsigned int len); int need_erase(uint8_t *have, uint8_t *want, unsigned int len, enum write_granularity gran); char *strcat_realloc(char *dest, const char *src); Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Sat Dec 29 20:26:55 2012 (r1638) +++ trunk/flashrom.c Sun Dec 30 02:23:17 2012 (r1639) @@ -40,13 +40,13 @@ #include "hwaccess.h" const char flashrom_version[] = FLASHROM_VERSION; -char *chip_to_probe = NULL; +const char *chip_to_probe = NULL; int verbose_screen = MSG_INFO; int verbose_logfile = MSG_DEBUG2; static enum programmer programmer = PROGRAMMER_INVALID; -static char *programmer_param = NULL; +static const char *programmer_param = NULL; /* * Programmers supporting multiple buses can have differing size limits on @@ -351,7 +351,7 @@ return 0; } -int programmer_init(enum programmer prog, char *param) +int programmer_init(enum programmer prog, const char *param) { int ret; @@ -517,7 +517,7 @@ * needle and remove everything from the first occurrence of needle to the next * delimiter from haystack. */ -char *extract_param(char **haystack, const char *needle, const char *delim) +char *extract_param(const char *const *haystack, const char *needle, const char *delim) { char *param_pos, *opt_pos, *rest; char *opt = NULL; Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Sat Dec 29 20:26:55 2012 (r1638) +++ trunk/programmer.h Sun Dec 30 02:23:17 2012 (r1639) @@ -122,7 +122,7 @@ extern const struct programmer_entry programmer_table[]; -int programmer_init(enum programmer prog, char *param); +int programmer_init(enum programmer prog, const char *param); int programmer_shutdown(void); enum bitbang_spi_master_type {

1 0

Re: [flashrom] [PATCH] Simplify hwaccess.c.
by Stefan Tauner 29 Dec '12

29 Dec '12

On Sun, 26 Aug 2012 20:59:25 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > Previously the code was focused on architectures which led to lots of > duplicate code and spread the information regarding differences between > the architectures accross the file. > > With this patch there is a single function header for any function and the > differentiation between architectures (and OS where needed) happens > in one place. Also, this patch adds simple defines to bundle often used arch > and os checks. A central check for unknown architectures and OSes has > been added on top. > > Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> self-acked and committed in r1638. thanks again, peter! -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1638 - trunk
by repository service 29 Dec '12

29 Dec '12

Author: stefanct Date: Sat Dec 29 20:26:55 2012 New Revision: 1638 URL: http://flashrom.org/trac/flashrom/changeset/1638 Log: Simplify hwaccess.c. Previously the code was focused on architectures which led to lots of duplicate code and spread the information regarding differences between the architectures accross the file. With this patch there is a single function header for any function and the differentiation between architectures (and OS where needed) happens in one place for each function. Also, this patch adds simple defines to bundle often used arch and os checks. A central check for unknown architectures and OSes has been added on top. Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/hwaccess.c Modified: trunk/hwaccess.c ============================================================================== --- trunk/hwaccess.c Sat Dec 29 16:04:20 2012 (r1637) +++ trunk/hwaccess.c Sat Dec 29 20:26:55 2012 (r1638) @@ -18,6 +18,20 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#define IS_X86 (defined(__i386__) || defined(__x86_64__) || defined(__amd64__)) +#define IS_MIPS (defined (__mips) || defined (__mips__) || defined (__MIPS__) || defined (mips)) +#define IS_PPC (defined(__powerpc__) || defined(__powerpc64__) || defined(__ppc__) || defined(__ppc64__)) +#define IS_ARM (defined (__arm__) || defined (_ARM)) +#if !(IS_X86 || IS_MIPS || IS_PPC || IS_ARM) +#error Unknown architecture +#endif + +#define IS_BSD (defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__OpenBSD__)) +#define IS_LINUX (defined(__gnu_linux__) || defined(__linux__)) +#if !(IS_BSD || IS_LINUX || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun)) +#error "Unknown operating system" +#endif + #include <stdint.h> #include <string.h> #include <stdlib.h> @@ -32,30 +46,39 @@ #include "flash.h" #include "hwaccess.h" -#if defined(__i386__) || defined(__x86_64__) +#if IS_X86 && IS_BSD +int io_fd; +#endif -/* sync primitive is not needed because x86 uses uncached accesses - * which have a strongly ordered memory model. +/* Prevent reordering and/or merging of reads/writes to hardware. + * Such reordering and/or merging would break device accesses which depend on the exact access order. */ static inline void sync_primitive(void) { -} - -#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) -int io_fd; +/* This is needed only on PowerPC because... + * - x86 uses uncached accesses which have a strongly ordered memory model and + * - MIPS uses uncached accesses in mode 2 on /dev/mem which has also a strongly ordered memory model + * - ARM uses a strongly ordered memory model for device memories. + */ +#if IS_PPC + asm("eieio" : : : "memory"); #endif +} -int release_io_perms(void *p) +static int release_io_perms(void *p) { +#if IS_X86 #if defined(__DJGPP__) || defined(__LIBPAYLOAD__) -#else -#if defined (__sun) && (defined(__i386) || defined(__amd64)) + /* Nothing to release */ +#elif defined (__sun) sysi86(SI86V86, V86SC_IOPL, 0); -#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined (__DragonFly__) +#elif IS_BSD close(io_fd); -#else +#elif IS_LINUX iopl(0); #endif +#else +/* PCI port I/O support is unimplemented on PPC/MIPS and unavailable on ARM. */ #endif return 0; } @@ -63,81 +86,32 @@ /* Get I/O permissions with automatic permission release on shutdown. */ int rget_io_perms(void) { +#if IS_X86 #if defined(__DJGPP__) || defined(__LIBPAYLOAD__) /* We have full permissions by default. */ - return 0; -#else -#if defined (__sun) && (defined(__i386) || defined(__amd64)) +#elif defined (__sun) if (sysi86(SI86V86, V86SC_IOPL, PS_IOPL) != 0) { -#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined (__DragonFly__) +#elif IS_BSD if ((io_fd = open("/dev/io", O_RDWR)) < 0) { -#else +#elif IS_LINUX if (iopl(3) != 0) { #endif msg_perr("ERROR: Could not get I/O privileges (%s).\n" "You need to be root.\n", strerror(errno)); #if defined (__OpenBSD__) - msg_perr("Please set securelevel=-1 in /etc/rc.securelevel " - "and reboot, or reboot into \n"); + msg_perr("Please set securelevel=-1 in /etc/rc.securelevel and reboot, or reboot into \n"); msg_perr("single user mode.\n"); #endif return 1; } else { register_shutdown(release_io_perms, NULL); } - return 0; +#else +/* PCI port I/O support is unimplemented on PPC/MIPS and unavailable on ARM. */ #endif -} - -#elif defined(__powerpc__) || defined(__powerpc64__) || defined(__ppc__) || defined(__ppc64__) - -static inline void sync_primitive(void) -{ - /* Prevent reordering and/or merging of reads/writes to hardware. - * Such reordering and/or merging would break device accesses which - * depend on the exact access order. - */ - ___asm___ volatile ("eieio" : : : "memory"); -} - -/* PCI port I/O is not yet implemented on PowerPC. */ -int rget_io_perms(void) -{ return 0; } -#elif defined (__mips) || defined (__mips__) || defined (_mips) || defined (mips) - -/* sync primitive is not needed because /dev/mem on MIPS uses uncached accesses - * in mode 2 which has a strongly ordered memory model. - */ -static inline void sync_primitive(void) -{ -} - -/* PCI port I/O is not yet implemented on MIPS. */ -int rget_io_perms(void) -{ - return 0; -} - -#elif defined (__arm__) - -static inline void sync_primitive(void) -{ -} - -int rget_io_perms(void) -{ - return 0; -} - -#else - -#error Unknown architecture - -#endif - void mmio_writeb(uint8_t val, void *addr) { *(volatile uint8_t *) addr = val;

1 0

Re: [flashrom] [PATCH 0/4] SPI status registers.
by Stefan Tauner 29 Dec '12

29 Dec '12

On Sun, 23 Sep 2012 16:54:53 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > Nuff said. > Well, the S33 naming might be no ideal, RFC. > > Stefan Tauner (4): > Improve SPI status register pretty printing. > Add a generic SPI block unprotect function. > Add support for Intel S33 series flash chips. > Add support for Atmel's AT25F series of SPI flash chips. > > Makefile | 4 +- > a25.c | 100 --------- > at25.c | 281 ------------------------- > chipdrivers.h | 50 +++-- > flash.h | 1 + > flashchips.c | 522 ++++++++++++++++++++++++++++++++++++++++++++-- > flashchips.h | 17 +- > spi.h | 8 +- > spi25.c | 298 ++------------------------ > spi25_statusreg.c | 601 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 10 files changed, 1169 insertions(+), 713 deletions(-) > delete mode 100644 a25.c > delete mode 100644 at25.c > create mode 100644 spi25_statusreg.c Self-acked and committed in r1634-r1637 with small improvements in 1/4. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1637 - trunk
by repository service 29 Dec '12

29 Dec '12

Author: stefanct Date: Sat Dec 29 16:04:20 2012 New Revision: 1637 URL: http://flashrom.org/trac/flashrom/changeset/1637 Log: Add support for Atmel's AT25F series of SPI flash chips. This adds support for the following chips: - AT25F512, AT25F512A, AT25F512B - AT25F1024, AT25F1024A - AT25F2048 - AT25F4096 Besides the definitions of the the chips in flashchips.c this includes - a dedicated probing method (probe_spi_at25f) - pretty printing methods (spi_prettyprint_status_register_at25f*), and - unlocking methods (spi_disable_blockprotect_at25f*) Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/chipdrivers.h trunk/flashchips.c trunk/flashchips.h trunk/spi.h trunk/spi25.c trunk/spi25_statusreg.c Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Sat Dec 29 16:04:12 2012 (r1636) +++ trunk/chipdrivers.h Sat Dec 29 16:04:20 2012 (r1637) @@ -38,6 +38,7 @@ int probe_spi_rems(struct flashctx *flash); int probe_spi_res1(struct flashctx *flash); int probe_spi_res2(struct flashctx *flash); +int probe_spi_at25f(struct flashctx *flash); int spi_write_enable(struct flashctx *flash); int spi_write_disable(struct flashctx *flash); int spi_block_erase_20(struct flashctx *flash, unsigned int addr, unsigned int blocklen); @@ -68,13 +69,19 @@ int spi_prettyprint_status_register_amic_a25l032(struct flashctx *flash); int spi_prettyprint_status_register_at25df(struct flashctx *flash); int spi_prettyprint_status_register_at25df_sec(struct flashctx *flash); +int spi_prettyprint_status_register_at25f(struct flashctx *flash); +int spi_prettyprint_status_register_at25f512a(struct flashctx *flash); int spi_prettyprint_status_register_at25f512b(struct flashctx *flash); +int spi_prettyprint_status_register_at25f4096(struct flashctx *flash); int spi_prettyprint_status_register_at25fs010(struct flashctx *flash); int spi_prettyprint_status_register_at25fs040(struct flashctx *flash); int spi_prettyprint_status_register_at26df081a(struct flashctx *flash); int spi_disable_blockprotect_at25df(struct flashctx *flash); int spi_disable_blockprotect_at25df_sec(struct flashctx *flash); +int spi_disable_blockprotect_at25f(struct flashctx *flash); +int spi_disable_blockprotect_at25f512a(struct flashctx *flash); int spi_disable_blockprotect_at25f512b(struct flashctx *flash); +int spi_disable_blockprotect_at25f4096(struct flashctx *flash); int spi_disable_blockprotect_at25fs010(struct flashctx *flash); int spi_disable_blockprotect_at25fs040(struct flashctx *flash); int spi_prettyprint_status_register_s33(struct flashctx *flash); Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Sat Dec 29 16:04:12 2012 (r1636) +++ trunk/flashchips.c Sat Dec 29 16:04:20 2012 (r1637) @@ -1667,6 +1667,65 @@ { .vendor = "Atmel", + .name = "AT25F512", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25F512, + .total_size = 64, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_at25f, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {32 * 1024, 2} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 1} }, + .block_erase = spi_block_erase_62, + } + }, + .printlock = spi_prettyprint_status_register_at25f, + .unlock = spi_disable_blockprotect_at25f, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Atmel", + .name = "AT25F512A", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25F512A, + .total_size = 64, + .page_size = 128, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_at25f, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {32 * 1024, 2} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 1} }, + .block_erase = spi_block_erase_62, + } + }, + .printlock = spi_prettyprint_status_register_at25f512a, + /* FIXME: It is not correct to use this one, because the BP1 bit is N/A. */ + .unlock = spi_disable_blockprotect_at25f512a, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Atmel", .name = "AT25F512B", .bustype = BUS_SPI, .manufacture_id = ATMEL_ID, @@ -1705,6 +1764,95 @@ .write = spi_chip_write_256, .read = spi_chip_read, .voltage = {2700, 3600}, + }, + + { + .vendor = "Atmel", + /* The A suffix indicates 33MHz instead of 20MHz clock rate. + * All other properties seem to be the same.*/ + .name = "AT25F1024(A)", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25F1024, + .total_size = 128, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_at25f, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {32 * 1024, 4} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {128 * 1024, 1} }, + .block_erase = spi_block_erase_62, + } + }, + .printlock = spi_prettyprint_status_register_at25f, + .unlock = spi_disable_blockprotect_at25f, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Atmel", + .name = "AT25F2048", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25F2048, + .total_size = 256, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_at25f, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_62, + } + }, + .printlock = spi_prettyprint_status_register_at25f, + .unlock = spi_disable_blockprotect_at25f, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Atmel", + .name = "AT25F4096", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25F4096, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_at25f, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_62, + } + }, + .printlock = spi_prettyprint_status_register_at25f4096, + .unlock = spi_disable_blockprotect_at25f4096, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, }, { Modified: trunk/flashchips.h ============================================================================== --- trunk/flashchips.h Sat Dec 29 16:04:12 2012 (r1636) +++ trunk/flashchips.h Sat Dec 29 16:04:20 2012 (r1637) @@ -137,13 +137,12 @@ #define ATMEL_AT25DF321A 0x4701 #define ATMEL_AT25DF641 0x4800 #define ATMEL_AT25DQ161 0x8600 -#define ATMEL_AT25F512 /* No device ID found in datasheet. Vendor ID - * can be read with AT25F512A_RDID */ -#define ATMEL_AT25F512A 0x65 /* Needs AT25F512A_RDID */ +#define ATMEL_AT25F512 0x65 /* guessed, no device ID in datasheet. Needs AT25F_RDID */ +#define ATMEL_AT25F512A 0x65 /* Needs AT25F_RDID */ #define ATMEL_AT25F512B 0x6500 -#define ATMEL_AT25F1024 /* No device ID found in datasheet. Vendor ID - * can be read with AT25F512A_RDID */ -#define ATMEL_AT25F1024A 0x60 /* Needs AT25F512A_RDID */ +#define ATMEL_AT25F1024 0x60 /* Needs AT25F_RDID */ +#define ATMEL_AT25F2048 0x63 /* Needs AT25F_RDID */ +#define ATMEL_AT25F4096 0x64 /* Needs AT25F_RDID */ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 #define ATMEL_AT26DF041 0x4400 Modified: trunk/spi.h ============================================================================== --- trunk/spi.h Sat Dec 29 16:04:12 2012 (r1636) +++ trunk/spi.h Sat Dec 29 16:04:20 2012 (r1637) @@ -30,10 +30,10 @@ /* INSIZE may be 0x04 for some chips*/ #define JEDEC_RDID_INSIZE 0x03 -/* AT25F512A has bit 3 as don't care bit in commands */ -#define AT25F512A_RDID 0x15 /* 0x15 or 0x1d */ -#define AT25F512A_RDID_OUTSIZE 0x01 -#define AT25F512A_RDID_INSIZE 0x02 +/* Some Atmel AT25F* models have bit 3 as don't care bit in commands */ +#define AT25F_RDID 0x15 /* 0x15 or 0x1d */ +#define AT25F_RDID_OUTSIZE 0x01 +#define AT25F_RDID_INSIZE 0x02 /* Read Electronic Manufacturer Signature */ #define JEDEC_REMS 0x90 Modified: trunk/spi25.c ============================================================================== --- trunk/spi25.c Sat Dec 29 16:04:12 2012 (r1636) +++ trunk/spi25.c Sat Dec 29 16:04:20 2012 (r1637) @@ -279,6 +279,28 @@ return 1; } +/* Only used for some Atmel chips. */ +int probe_spi_at25f(struct flashctx *flash) +{ + static const unsigned char cmd[AT25F_RDID_OUTSIZE] = { AT25F_RDID }; + unsigned char readarr[AT25F_RDID_INSIZE]; + uint32_t id1; + uint32_t id2; + + if (spi_send_command(flash, sizeof(cmd), sizeof(readarr), cmd, readarr)) + return 0; + + id1 = readarr[0]; + id2 = readarr[1]; + + msg_cdbg("%s: id1 0x%02x, id2 0x%02x\n", __func__, id1, id2); + + if (id1 == flash->chip->manufacture_id && id2 == flash->chip->model_id) + return 1; + + return 0; +} + int spi_chip_erase_60(struct flashctx *flash) { int result; Modified: trunk/spi25_statusreg.c ============================================================================== --- trunk/spi25_statusreg.c Sat Dec 29 16:04:12 2012 (r1636) +++ trunk/spi25_statusreg.c Sat Dec 29 16:04:20 2012 (r1637) @@ -378,6 +378,40 @@ return spi_prettyprint_status_register_at25df(flash); } +/* used for AT25F512, AT25F1024(A), AT25F2048 */ +int spi_prettyprint_status_register_at25f(struct flashctx *flash) +{ + uint8_t status; + + status = spi_read_status_register(flash); + spi_prettyprint_status_register_hex(status); + + spi_prettyprint_status_register_atmel_at25_wpen(status); + spi_prettyprint_status_register_bit(status, 6); + spi_prettyprint_status_register_bit(status, 5); + spi_prettyprint_status_register_bit(status, 4); + spi_prettyprint_status_register_bp(status, 1); + spi_prettyprint_status_register_welwip(status); + return 0; +} + +int spi_prettyprint_status_register_at25f512a(struct flashctx *flash) +{ + uint8_t status; + + status = spi_read_status_register(flash); + spi_prettyprint_status_register_hex(status); + + spi_prettyprint_status_register_atmel_at25_wpen(status); + spi_prettyprint_status_register_bit(status, 6); + spi_prettyprint_status_register_bit(status, 5); + spi_prettyprint_status_register_bit(status, 4); + spi_prettyprint_status_register_bit(status, 3); + spi_prettyprint_status_register_bp(status, 0); + spi_prettyprint_status_register_welwip(status); + return 0; +} + int spi_prettyprint_status_register_at25f512b(struct flashctx *flash) { uint8_t status = spi_read_status_register(flash); @@ -392,6 +426,21 @@ return 0; } +int spi_prettyprint_status_register_at25f4096(struct flashctx *flash) +{ + uint8_t status; + + status = spi_read_status_register(flash); + spi_prettyprint_status_register_hex(status); + + spi_prettyprint_status_register_atmel_at25_wpen(status); + spi_prettyprint_status_register_bit(status, 6); + spi_prettyprint_status_register_bit(status, 5); + spi_prettyprint_status_register_bp(status, 2); + spi_prettyprint_status_register_welwip(status); + return 0; +} + int spi_prettyprint_status_register_at25fs010(struct flashctx *flash) { uint8_t status = spi_read_status_register(flash); @@ -450,6 +499,16 @@ return spi_disable_blockprotect_at25df(flash); } +int spi_disable_blockprotect_at25f(struct flashctx *flash) +{ + return spi_disable_blockprotect_generic(flash, 0x0C, 1 << 7, 0); +} + +int spi_disable_blockprotect_at25f512a(struct flashctx *flash) +{ + return spi_disable_blockprotect_generic(flash, 0x04, 1 << 7, 0); +} + int spi_disable_blockprotect_at25f512b(struct flashctx *flash) { /* spi_disable_blockprotect_at25df is not really the right way to do @@ -458,6 +517,11 @@ return spi_disable_blockprotect_at25df(flash); } +int spi_disable_blockprotect_at25f4096(struct flashctx *flash) +{ + return spi_disable_blockprotect_generic(flash, 0x1C, 1 << 7, 0); +} + int spi_disable_blockprotect_at25fs010(struct flashctx *flash) { return spi_disable_blockprotect_generic(flash, 0x6C, 1 << 7, 0);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom