flashrom

flashrom@flashrom.org

8 participants
9164 discussions

Re: [flashrom] [PATCH] Introduce serialport_config().
by Stefan Tauner 12 Apr '13

12 Apr '13

On Mon, 1 Apr 2013 18:35:47 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > Also, initialize sp_fd and fix baud rate setting on windows. I have extracted those two changes into a separate patch and committed them in r1669 - because... that's almost 2 weeks again. :/ -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1669 - trunk
by repository service 12 Apr '13

12 Apr '13

Author: stefanct Date: Sat Apr 13 02:29:30 2013 New Revision: 1669 URL: http://flashrom.org/trac/flashrom/changeset/1669 Log: Initialize sp_fd and fix baud rate setting on windows. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/serial.c Modified: trunk/serial.c ============================================================================== --- trunk/serial.c Sun Apr 7 15:08:30 2013 (r1668) +++ trunk/serial.c Sat Apr 13 02:29:30 2013 (r1669) @@ -39,7 +39,7 @@ #include "flash.h" #include "programmer.h" -fdtype sp_fd; +fdtype sp_fd = SER_INV_FD; void __attribute__((noreturn)) sp_die(char *msg) { @@ -189,7 +189,7 @@ goto out_close; } const struct baudentry *entry = round_baud(baud); - dcb.BaudRate = entry->baud; + dcb.BaudRate = entry->flag; dcb.ByteSize = 8; dcb.Parity = NOPARITY; dcb.StopBits = ONESTOPBIT;

1 0

[PATCH 2/2] Add support for AMD Geode's MSR on OpenBSD.
by Stefan Tauner 12 Apr '13

12 Apr '13

Previously the default implementation was used, which always failed. On other systems than the Geode the code is not equal to that anymore, but should not explode because setup_cpu_msr() returns an error and therefore no other MSR functions should be called. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- physmap.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 84 insertions(+), 10 deletions(-) diff --git a/physmap.c b/physmap.c index 4ebfb06..b6a9163 100644 --- a/physmap.c +++ b/physmap.c @@ -282,6 +282,8 @@ void *physmap_try_ro(const char *descr, unsigned long phys_addr, size_t len) PHYSMAP_RO); } +/* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload + * and a non-working default implemenation on the bottom. See also hwaccess.h for some (re)declarations. */ #if defined(__i386__) || defined(__x86_64__) #ifdef __linux__ @@ -381,8 +383,83 @@ void cleanup_cpu_msr(void) /* Clear MSR file descriptor. */ fd_msr = -1; } -#else -#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) +#elif defined(__OpenBSD__) /* This does only work for certain AMD Geode LX systems see amdmsr(4). */ +#include <sys/ioctl.h> +#include <machine/amdmsr.h> + +static int fd_msr = -1; + +msr_t rdmsr(int addr) +{ + struct amdmsr_req args; + + msr_t msr = { 0xffffffff, 0xffffffff }; + + args.addr = (uint32_t)addr; + + if (ioctl(fd_msr, RDMSR, &args) < 0) { + msg_perr("Error while executing RDMSR ioctl: %s\n", strerror(errno)); + close(fd_msr); + exit(1); + } + + msr.lo = args.val & 0xffffffff; + msr.hi = args.val >> 32; + + return msr; +} + +int wrmsr(int addr, msr_t msr) +{ + struct amdmsr_req args; + + args.msr = addr; + args.val = (((uint64_t)msr.hi) << 32) | msr.lo; + + if (ioctl(fd_msr, WRMSR, &args) < 0) { + msg_perr("Error while executing WRMSR ioctl: %s\n", strerror(errno)); + close(fd_msr); + exit(1); + } + + return 0; +} + +int setup_cpu_msr(int cpu) +{ + char msrfilename[64]; + memset(msrfilename, 0, sizeof(msrfilename)); + snprintf(msrfilename, sizeof(msrfilename), "/dev/amdmsr"); + + if (fd_msr != -1) { + msg_pinfo("MSR was already initialized\n"); + return -1; + } + + fd_msr = open(msrfilename, O_RDWR); + + if (fd_msr < 0) { + msg_perr("Error while opening %s: %s\n", msrfilename, strerror(errno)); + return -1; + } + + return 0; +} + +void cleanup_cpu_msr(void) +{ + if (fd_msr == -1) { + msg_pinfo("No MSR initialized.\n"); + return; + } + + close(fd_msr); + + /* Clear MSR file descriptor. */ + fd_msr = -1; +} + +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) #include <sys/ioctl.h> typedef struct { @@ -465,9 +542,7 @@ void cleanup_cpu_msr(void) fd_msr = -1; } -#else - -#if defined(__MACH__) && defined(__APPLE__) +#elif defined(__MACH__) && defined(__APPLE__) int setup_cpu_msr(int cpu) { // Always succeed for now @@ -494,6 +569,7 @@ int libpayload_wrmsr(int addr, msr_t msr) return 0; } #else +/* default MSR implementation */ msr_t rdmsr(int addr) { msr_t ret = { 0xffffffff, 0xffffffff }; @@ -516,9 +592,7 @@ void cleanup_cpu_msr(void) { // Nothing, yet. } -#endif -#endif -#endif -#else +#endif // OS switches for MSR code +#else // x86 /* Does MSR exist on non-x86 architectures? */ -#endif +#endif // arch switches for MSR code -- Kind regards, Stefan Tauner

1 0

[PATCH 1/2] Fix hwaccess (again).
by Stefan Tauner 12 Apr '13

12 Apr '13

Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- hwaccess.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hwaccess.c b/hwaccess.c index 598aa67..df0306f 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -26,10 +26,9 @@ #error Unknown architecture #endif -#define IS_BSD (defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__OpenBSD__)) #define IS_LINUX (defined(__gnu_linux__) || defined(__linux__)) #define IS_MACOSX (defined(__APPLE__) && defined(__MACH__)) -#if !(IS_BSD || IS_LINUX || IS_MACOSX || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun)) +#if !(IS_LINUX || IS_MACOSX || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun)) #error "Unknown operating system" #endif @@ -47,7 +46,10 @@ #include "flash.h" #include "hwaccess.h" -#if IS_X86 && IS_BSD +#define USE_IOPL (IS_LINUX || IS_MACOSX || defined(__NetBSD__) || defined(__OpenBSD__)) +#define USE_DEV_IO (defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)) + +#if IS_X86 && USE_DEV_IO int io_fd; #endif @@ -71,9 +73,9 @@ static int release_io_perms(void *p) { #if defined (__sun) sysi86(SI86V86, V86SC_IOPL, 0); -#elif IS_BSD +#elif USE_DEV_IO close(io_fd); -#elif IS_LINUX || IS_MACOSX +#elif USE_IOPL iopl(0); #endif return 0; @@ -86,14 +88,14 @@ int rget_io_perms(void) #if IS_X86 && !(defined(__DJGPP__) || defined(__LIBPAYLOAD__)) #if defined (__sun) if (sysi86(SI86V86, V86SC_IOPL, PS_IOPL) != 0) { -#elif IS_BSD +#elif USE_DEV_IO if ((io_fd = open("/dev/io", O_RDWR)) < 0) { -#elif IS_LINUX || IS_MACOSX +#elif USE_IOPL if (iopl(3) != 0) { #endif msg_perr("ERROR: Could not get I/O privileges (%s).\n" "You need to be root.\n", strerror(errno)); -#if defined (__OpenBSD__) +#if defined(__NetBSD__) || defined (__OpenBSD__) msg_perr("Please set securelevel=-1 in /etc/rc.securelevel and reboot, or reboot into \n"); msg_perr("single user mode.\n"); #endif -- Kind regards, Stefan Tauner

1 0

Re: [flashrom] Added chipsets
by Stefan Tauner 12 Apr '13

12 Apr '13

> On Apr 12, 2013 1:42 AM, "Николай Николаев" <evrinoma(a)gmail.com> wrote: > > i think if the flashrom wiki page to give the link on chip documentation > that It will be great decision to avoid problem with name chip and > searching documentations. the problem is that most flash chip datasheets are not available (any longer) from the original manufacturer and that we can not host them on our own (although there might be some legal loopholes to do so, this is pretty much out of question). maintaining a list to somewhat stable manufacturer sites is a lot of work. i know that because i am mostly the one who maintains the mainboard links. maintaining a list of links to other sources like alldatasheets.com or whatever will be even more work because they change URLs or become otherwise defunct is even more frequently. if someone wants to do this feel free to create a wikipage for it, i certainly will not. the solution that has worked in the past is: naming the revision of datasheets and source links in reviews and patches, especially in cases of ambiguity; and if the datasheets are not available anymore one can share them privately without a huge legal risk. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] Added chipsets
by Steven Zakulec 12 Apr '13

12 Apr '13

Thanks- please keep the flashrom list included so everyone else can see your response as well. On Apr 12, 2013 1:42 AM, "Николай Николаев" <evrinoma(a)gmail.com> wrote: > > hi > > |Eon EN25S10: > |+ .eraseblocks = { {32 * 1024, 4} }, > |+ .block_erase = spi_block_erase_d8, > |The .block_erase appears to be wrong here- it should be spi_block_erase_52 according to the datasheet. > | > |Eon EN25S16: > |+ .eraseblocks = { {32 * 1024, 64} }, > |+ .block_erase = spi_block_erase_52, > > |It appears both the .eraseblocks and the .block_erase are wrong: > |.eraseblocks should be { {64 * 1024, 32} } - there are 32 blocks of 64 KBytes, not 64 blocks of 32 KBytes. > |.block_erase uses spi_block_erase_52 when it should use spi_block_erase_d8. > > > you are right. this is my a typos. And i rechecked my patch with all chips parameters and found new some typos. I will rewrite a patch and resend him. > > |AMIC A25LQ016: I couldn't find a datasheet for this chip available- I've got a A25LQ032 datasheet, but not one for the A25LQ016. Could you point me to that > |sheet, or provide me with a copy? > > Sorry this is my typos. > Could you try to search again something like a A25LQ16 > > |Eon EN25S32: > |+ .eraseblocks = { {32 * 1024, 128} }, > |+ .block_erase = spi_block_erase_52, > |I don't see where you are getting that .eraseblocks from- I can't find it in the datasheet. > |I also don't know where the .block_erase came from- there is no 0x52 opcode in the datasheet. > > http://www.transonics.com/images/file/pdf/eon/EN25S32.pdf > please see page 1 and page 5 - memory organization > •Uniform Sector Architecture: > -1024 sectors of 4-Kbyte > -128 blocks of 32-Kbyte > -64 blocks of 64-Kbyte > -Any sector or block can be erased individually > > please see page 12 - Table 4A. Instruction Set > this is chip has a 0x52 opcode in the datasheet > > i think if the flashrom wiki page to give the link on chip documentation that It will be great decision to avoid problem with name chip and searching documentations. > > -- > With best regards Nikolay Nikolaev > С Уважением Николаев Николай

1 0

Re: [flashrom] Added chipsets
by Steven Zakulec 11 Apr '13

11 Apr '13

On Mon, Mar 4, 2013 at 7:00 AM, Николай Николаев <evrinoma(a)gmail.com> wrote: > > Hi > > "Some additions of chips are non-functional yet... e.g. there is no > support for more than 24 bits in addresses, but some chips require that. > Also, please do not send patches as base64 encoded attachments." > > All these chips has a 24 addressing limit, or three bytes. To addressing > above 16Mbyte we must program special register - extend addressing space - > it's look like a fetcher bit. > > "I took a closer look at your patch. It contains a lot of white space > errors. Please make sure that this won't happen again. Checking data > sheets to review such patches is no fun, dealing with other's > white space errors is even worse ;)" > > sorry i now rechecked my patches by linux checkpatch.pl script. > > 8) > -- > With best regards Nikolay Nikolaev > С Уважением Николаев Николай > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom > So, I've started reviewing some of this patch against the datasheets. General questions to flashrom developers/things I haven't reviewed/non-specific comments: .manufacture_id, model_id: Not sure how to check these. .page_size: I assume they are all 256 as per point 6 here: http://flashrom.org/index.php?title=Development_Guidelines .probe, .probe_timing: Make sure it has probe_spi_rdid & TIMING_ZERO if SPI chip and probe opcode 0x9F. .printlock, .unlock, .write, .read : I'm not sure how to review any of these items. Comments on specific chips: AMIC A25LQ016: I couldn't find a datasheet for this chip available- I've got a A25LQ032 datasheet, but not one for the A25LQ016. Could you point me to that sheet, or provide me with a copy? Eon EN25S10: + .eraseblocks = { {32 * 1024, 4} }, + .block_erase = spi_block_erase_d8, The .block_erase appears to be wrong here- it should be spi_block_erase_52 according to the datasheet. Eon EN25S16: + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = spi_block_erase_52, It appears both the .eraseblocks and the .block_erase are wrong: .eraseblocks should be { {64 * 1024, 32} } - there are 32 blocks of 64 KBytes, not 64 blocks of 32 KBytes. .block_erase uses spi_block_erase_52 when it should use spi_block_erase_d8. Eon EN25S32: + .eraseblocks = { {32 * 1024, 128} }, + .block_erase = spi_block_erase_52, I don't see where you are getting that .eraseblocks from- I can't find it in the datasheet. I also don't know where the .block_erase came from- there is no 0x52 opcode in the datasheet. I'll send follow-up emails later for the next group of chips.

1 0

Re: [flashrom] [PATCH 1/2] Get rid of perror().
by Carl-Daniel Hailfinger 08 Apr '13

08 Apr '13

Am 07.04.2013 04:30 schrieb Stefan Tauner: > It prints to stderr and that's not what we want necesserily; > using msg_*err gives us more control. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Thanks! A long overdue cleanup. Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

What alternatives of SPI flash Winbond 25Q32BVSIG is exists?
by CarelessChaser 08 Apr '13

08 Apr '13

Hi guys! I have motherboard Gigabyte GA-970A-UD3 with DualBIOS (two chips Winbond 25Q32BVSIG). I want to test coreboot, and I'm looking for alternatives of Winbond 25Q32BVSIG. Can you help me? //Also, I'm planning to buy BusPirate. Is this good choice for newbie?

2 1

[commit] r1668 - trunk
by repository service 07 Apr '13

07 Apr '13

Author: stefanct Date: Sun Apr 7 15:08:30 2013 New Revision: 1668 URL: http://flashrom.org/trac/flashrom/changeset/1668 Log: Get rid of perror(). It prints to stderr and that's not what we want necesserily; using msg_*err gives us more control. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/cli_output.c trunk/flashrom.c trunk/physmap.c Modified: trunk/cli_output.c ============================================================================== --- trunk/cli_output.c Fri Apr 5 10:06:10 2013 (r1667) +++ trunk/cli_output.c Sun Apr 7 15:08:30 2013 (r1668) @@ -50,7 +50,7 @@ return 1; } if ((logfile = fopen(filename, "w")) == NULL) { - perror(filename); + msg_gerr("Error: opening log file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } return 0; Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Fri Apr 5 10:06:10 2013 (r1667) +++ trunk/flashrom.c Sun Apr 7 15:08:30 2013 (r1668) @@ -29,6 +29,7 @@ #endif #include <string.h> #include <stdlib.h> +#include <errno.h> #include <ctype.h> #include <getopt.h> #if HAVE_UTSNAME == 1 @@ -1158,11 +1159,11 @@ struct stat image_stat; if ((image = fopen(filename, "rb")) == NULL) { - perror(filename); + msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } if (fstat(fileno(image), &image_stat) != 0) { - perror(filename); + msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno)); fclose(image); return 1; } @@ -1174,7 +1175,7 @@ } numbytes = fread(buf, 1, size, image); if (fclose(image)) { - perror(filename); + msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } if (numbytes != size) { @@ -1196,7 +1197,7 @@ return 1; } if ((image = fopen(filename, "wb")) == NULL) { - perror(filename); + msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Fri Apr 5 10:06:10 2013 (r1667) +++ trunk/physmap.c Sun Apr 7 15:08:30 2013 (r1668) @@ -172,7 +172,7 @@ if (-1 == fd_mem) { /* Open the memory device UNCACHED. Important for MMIO. */ if (-1 == (fd_mem = open(MEM_DEV, O_RDWR | O_SYNC))) { - perror("Critical error: open(" MEM_DEV ")"); + msg_perr("Critical error: open(" MEM_DEV "): %s\n", strerror(errno)); exit(2); } } @@ -192,8 +192,7 @@ if (-1 == fd_mem_cached) { /* Open the memory device CACHED. */ if (-1 == (fd_mem_cached = open(MEM_DEV, O_RDWR))) { - msg_perr("Critical error: open(" MEM_DEV "): %s", - strerror(errno)); + msg_perr("Critical error: open(" MEM_DEV "): %s\n", strerror(errno)); exit(2); } } @@ -250,7 +249,7 @@ descr = "memory"; msg_perr("Error accessing %s, 0x%lx bytes at 0x%08lx\n", descr, (unsigned long)len, phys_addr); - perror(MEM_DEV " mmap failed"); + msg_perr(MEM_DEV " mmap failed: %s\n", strerror(errno)); #ifdef __linux__ if (EINVAL == errno) { msg_perr("In Linux this error can be caused by the CONFIG_NONPROMISC_DEVMEM (<2.6.27),\n"); @@ -302,7 +301,7 @@ msr_t msr = { 0xffffffff, 0xffffffff }; if (lseek(fd_msr, (off_t) addr, SEEK_SET) == -1) { - perror("Could not lseek() to MSR"); + msg_perr("Could not lseek() MSR: %s\n", strerror(errno)); close(fd_msr); exit(1); } @@ -315,7 +314,7 @@ if (errno != EIO) { // A severe error. - perror("Could not read() MSR"); + msg_perr("Could not read() MSR: %s\n", strerror(errno)); close(fd_msr); exit(1); } @@ -330,13 +329,13 @@ buf[1] = msr.hi; if (lseek(fd_msr, (off_t) addr, SEEK_SET) == -1) { - perror("Could not lseek() to MSR"); + msg_perr("Could not lseek() MSR: %s\n", strerror(errno)); close(fd_msr); exit(1); } if (write(fd_msr, buf, 8) != 8 && errno != EIO) { - perror("Could not write() MSR"); + msg_perr("Could not write() MSR: %s\n", strerror(errno)); close(fd_msr); exit(1); } @@ -362,7 +361,7 @@ fd_msr = open(msrfilename, O_RDWR); if (fd_msr < 0) { - perror("Error while opening /dev/cpu/0/msr"); + msg_perr("Error while opening %s: %s\n", msrfilename, strerror(errno)); msg_pinfo("Did you run 'modprobe msr'?\n"); return -1; } @@ -404,7 +403,7 @@ args.msr = addr; if (ioctl(fd_msr, CPU_RDMSR, &args) < 0) { - perror("CPU_RDMSR"); + msg_perr("Error while executing CPU_RDMSR ioctl: %s\n", strerror(errno)); close(fd_msr); exit(1); } @@ -423,7 +422,7 @@ args.data = (((uint64_t)msr.hi) << 32) | msr.lo; if (ioctl(fd_msr, CPU_WRMSR, &args) < 0) { - perror("CPU_WRMSR"); + msg_perr("Error while executing CPU_WRMSR ioctl: %s\n", strerror(errno)); close(fd_msr); exit(1); } @@ -445,7 +444,7 @@ fd_msr = open(msrfilename, O_RDWR); if (fd_msr < 0) { - perror("Error while opening /dev/cpu0"); + msg_perr("Error while opening %s: %s\n", msrfilename, strerror(errno)); msg_pinfo("Did you install ports/sysutils/devcpu?\n"); return -1; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom