flashrom

flashrom@flashrom.org

6 participants
9186 discussions

[commit] r1775 - trunk
by repository service 26 Apr '14

26 Apr '14

Author: stefanct Date: Sat Apr 26 18:12:03 2014 New Revision: 1775 URL: http://flashrom.org/trac/flashrom/changeset/1775 Log: CID1130009: Resource leak in sp_opensocket(). Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/serprog.c Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Sat Apr 26 18:11:50 2014 (r1774) +++ trunk/serprog.c Sat Apr 26 18:12:03 2014 (r1775) @@ -100,6 +100,7 @@ if (NULL == hostPtr) { hostPtr = gethostbyaddr(ip, strlen(ip), AF_INET); if (NULL == hostPtr) { + close(sock); msg_perr("Error: cannot resolve %s\n", ip); return -1; }

1 0

[commit] r1774 - trunk
by repository service 26 Apr '14

26 Apr '14

Author: stefanct Date: Sat Apr 26 18:11:50 2014 New Revision: 1774 URL: http://flashrom.org/trac/flashrom/changeset/1774 Log: CID1130007: Resource leak in ogp_spi. Memory leak in ogp_spi_init(). Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/ogp_spi.c Modified: trunk/ogp_spi.c ============================================================================== --- trunk/ogp_spi.c Sat Apr 26 18:11:39 2014 (r1773) +++ trunk/ogp_spi.c Sat Apr 26 18:11:50 2014 (r1774) @@ -120,8 +120,10 @@ ogp_reg_sck = OGA1_XP10_CPROM_SCK; } else { msg_perr("Invalid or missing rom= parameter.\n"); + free(type); return 1; } + free(type); if (rget_io_perms()) return 1;

1 0

[commit] r1773 - trunk
by repository service 26 Apr '14

26 Apr '14

Author: stefanct Date: Sat Apr 26 18:11:39 2014 New Revision: 1773 URL: http://flashrom.org/trac/flashrom/changeset/1773 Log: CID1130008: Resource leak read_romlayout(). Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/layout.c Modified: trunk/layout.c ============================================================================== --- trunk/layout.c Sat Apr 26 18:11:30 2014 (r1772) +++ trunk/layout.c Sat Apr 26 18:11:39 2014 (r1773) @@ -65,6 +65,7 @@ if (num_rom_entries >= MAX_ROMLAYOUT) { msg_gerr("Maximum number of ROM images (%i) in layout " "file reached.\n", MAX_ROMLAYOUT); + fclose(romlayout); return 1; } if (2 != fscanf(romlayout, "%s %s\n", tempstr, rom_entries[num_rom_entries].name))

1 0

[commit] r1772 - trunk
by repository service 26 Apr '14

26 Apr '14

Author: stefanct Date: Sat Apr 26 18:11:30 2014 New Revision: 1772 URL: http://flashrom.org/trac/flashrom/changeset/1772 Log: CID1130012: Double free in pony_spi_init(). Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/pony_spi.c Modified: trunk/pony_spi.c ============================================================================== --- trunk/pony_spi.c Sat Apr 26 18:11:21 2014 (r1771) +++ trunk/pony_spi.c Sat Apr 26 18:11:30 2014 (r1772) @@ -140,6 +140,7 @@ } else if (arg && !strlen(arg)) { msg_perr("Error: Missing argument for programmer type.\n"); free(arg); + return 1; } else if (arg){ msg_perr("Error: Invalid programmer type specified.\n"); free(arg);

1 0

[commit] r1771 - trunk/util/ich_descriptors_tool
by repository service 26 Apr '14

26 Apr '14

Author: stefanct Date: Sat Apr 26 18:11:21 2014 New Revision: 1771 URL: http://flashrom.org/trac/flashrom/changeset/1771 Log: CID1130011: Use after free in ich_descriptor_tool. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/util/ich_descriptors_tool/ich_descriptors_tool.c Modified: trunk/util/ich_descriptors_tool/ich_descriptors_tool.c ============================================================================== --- trunk/util/ich_descriptors_tool/ich_descriptors_tool.c Sat Apr 26 18:11:07 2014 (r1770) +++ trunk/util/ich_descriptors_tool/ich_descriptors_tool.c Sat Apr 26 18:11:21 2014 (r1771) @@ -77,12 +77,13 @@ printf("Dumping %u bytes of the %s region from 0x%08x-0x%08x to %s... ", file_len, region_names[i], base, limit, fn); int fh = open(fn, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR); - free(fn); if (fh < 0) { fprintf(stderr, "ERROR: couldn't open(%s): %s\n", fn, strerror(errno)); + free(fn); exit(1); } + free(fn); ret = write(fh, &dump[base >> 2], file_len); if (ret != file_len) {

1 0

[commit] r1770 - trunk
by repository service 26 Apr '14

26 Apr '14

Author: stefanct Date: Sat Apr 26 18:11:07 2014 New Revision: 1770 URL: http://flashrom.org/trac/flashrom/changeset/1770 Log: CID1130004: Nesting level does not match indentation. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/print.c Modified: trunk/print.c ============================================================================== --- trunk/print.c Wed Mar 19 18:17:06 2014 (r1769) +++ trunk/print.c Sat Apr 26 18:11:07 2014 (r1770) @@ -436,12 +436,13 @@ msg_ginfo("%s", b->name); for (i = 0; i < maxboardlen - strlen(b->name); i++) msg_ginfo(" "); - if (b->working == OK) - msg_ginfo("OK "); - else if (b->working == NT) - msg_ginfo("NT "); - else - msg_ginfo("BAD "); + + if (b->working == OK) + msg_ginfo("OK "); + else if (b->working == NT) + msg_ginfo("NT "); + else + msg_ginfo("BAD "); for (e = board_matches; e->vendor_name != NULL; e++) { if (strcmp(e->vendor_name, b->vendor)

1 0

FAILED: M2N-MX SE PLUS
by Antonio 26 Apr '14

26 Apr '14

root@debian# flashrom -w M2N-MX-SE-Plus-0602.ROM flashrom v0.9.5.2-r1546 on Linux 3.13-0.bpo.1-amd64 (x86_64) flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. Found chipset "NVIDIA MCP61". Enabling flash write... This chipset is not really supported yet. Guesswork... SPI on this chipset is WIP. Please report any success or failure by mailing us the verbose output to flashrom(a)flashrom.org, thanks! Mapping NVIDIA MCP6x SPI at 0xfec80000, unaligned size 0x544. Please send the output of "flashrom -V" to flashrom(a)flashrom.org with your board name: flashrom -V as the subject to help us finish support for your chipset. Thanks. OK. Found Winbond flash chip "W25X80" (1024 kB, SPI) at physical address 0xfff00000. Flash image seems to be a legacy BIOS. Disabling coreboot-related checks. Reading old flash chip contents... done. Erasing and writing flash chip... Erase/write done. Verifying flash... VERIFY FAILED at 0x0002ea00! Expected=0x55, Read=0xff, failed byte count from 0x00000000-0x000fffff: 0x1fc Your flash chip is in an unknown state. Get help on IRC at chat.freenode.net (channel #flashrom) or mail flashrom(a)flashrom.org with the subject "FAILED: <your board name>"! ------------------------------------------------------------------------------- DO NOT REBOOT OR POWEROFF!

1 0

Heads up, new mail address
by Stefan Tauner 26 Apr '14

26 Apr '14

Hi, my old stefan.tauner(a)student.tuwien.ac.at mail address will vanish this year (unless I find a suitable PhD topic :) In any case I will use my alumni address from now on (for sign-offs too): stefan.tauner(a)alumni.tuwien.ac.at -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] flashrom support for Intel Rangeley/Avoton/C2000
by Rajasekhar Pulluru 23 Apr '14

23 Apr '14

Hi Rich, Attached the patch which compiled to me on top of flashrom-0.9.7-r1769 Please let me know the result if you experiment it (at your own risk ;-) . Thanks & Regards, Rajasekhar On Wed, Apr 23, 2014 at 4:22 AM, Rich Futyma <rich.futyma(a)sanmina.com>wrote: > Rajasekhar, > > I tried to apply your patch and got the following error. Could you > regenerate the patch and attach it > to email - I think this may be a copy and paste problem? > > patch -p0 < c2000.diff.txt > patching file flashrom-0.9.7-r1769/chipset_enable.c > patch: **** malformed patch at line 51: @@ -651,6 +694,113 @@ > --- > Rich > > > > On Tue, Apr 22, 2014 at 2:48 PM, Stefan Tauner < > stefan.tauner(a)student.tuwien.ac.at> wrote: > >> On Tue, 22 Apr 2014 20:54:04 +0530 >> Rajasekhar Pulluru <pullururajasekhar(a)gmail.com> wrote: >> >> > Hi Stefan, >> > >> > Thanks for the response. I have tried adding support for Rangeley >> following >> > the spec. Attached the patch. But, flashrom -E is failing with below >> error >> > messages >> > >> > Pasting only the failure messages: >> > .. >> > ... >> > Erasing and writing flash chip... spi_block_erase_20 failed during >> command >> > execution at address 0x0 >> > Reading current flash chip contents... done. FAILED at 0x00010000! >> > Expected=0xff, Found=0x00, failed byte count from 0x00000000-0x0003ffff: >> > 0x30000 >> > ERASE FAILED! >> > Reading current flash chip contents... done. spi_chip_erase_60 failed >> > during command execution >> > Reading current flash chip contents... done. spi_chip_erase_c7 failed >> > during command execution >> > FAILED! >> > Your flash chip is in an unknown state. >> > Get help on IRC at chat.freenode.net (channel #flashrom) or >> > mail flashrom(a)flashrom.org with the subject "FAILED: <your board >> name>"! >> > >> ------------------------------------------------------------------------------- >> > DO NOT REBOOT OR POWEROFF! >> >> Thank you for the patch. The errors alone do not really help, please >> post the full (verbose) log (you can redact DMI information if you >> want). >> >> -- >> Kind regards/Mit freundlichen Grüßen, Stefan Tauner >> >> _______________________________________________ >> flashrom mailing list >> flashrom(a)flashrom.org >> http://www.flashrom.org/mailman/listinfo/flashrom > > > CONFIDENTIALITY > This e-mail message and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail message, you are hereby notified that any dissemination, distribution or copying of this e-mail message, and any attachments thereto, is strictly prohibited. If you have received this e-mail message in error, please immediately notify the sender and permanently delete the original and any copies of this email and any prints thereof. > ABSENT AN EXPRESS STATEMENT TO THE CONTRARY HEREINABOVE, THIS E-MAIL IS NOT INTENDED AS A SUBSTITUTE FOR A WRITING. Notwithstanding the Uniform Electronic Transactions Act or the applicability of any other law of similar substance and effect, absent an express statement to the contrary hereinabove, this e-mail message its contents, and any attachments hereto are not intended to represent an offer or acceptance to enter into a contract and are not otherwise intended to bind the sender, Sanmina Corporation (or any of its subsidiaries), or any other person or entity. > > >

1 0

Re: [flashrom] flashrom support for Intel Rangeley/Avoton/C2000
by Stefan Tauner 23 Apr '14

23 Apr '14

On Tue, 22 Apr 2014 20:54:04 +0530 Rajasekhar Pulluru <pullururajasekhar(a)gmail.com> wrote: > Hi Stefan, > > Thanks for the response. I have tried adding support for Rangeley following > the spec. Attached the patch. But, flashrom -E is failing with below error > messages > > Pasting only the failure messages: > .. > ... > Erasing and writing flash chip... spi_block_erase_20 failed during command > execution at address 0x0 > Reading current flash chip contents... done. FAILED at 0x00010000! > Expected=0xff, Found=0x00, failed byte count from 0x00000000-0x0003ffff: > 0x30000 > ERASE FAILED! > Reading current flash chip contents... done. spi_chip_erase_60 failed > during command execution > Reading current flash chip contents... done. spi_chip_erase_c7 failed > during command execution > FAILED! > Your flash chip is in an unknown state. > Get help on IRC at chat.freenode.net (channel #flashrom) or > mail flashrom(a)flashrom.org with the subject "FAILED: <your board name>"! > ------------------------------------------------------------------------------- > DO NOT REBOOT OR POWEROFF! Thank you for the patch. The errors alone do not really help, please post the full (verbose) log (you can redact DMI information if you want). -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom