- flashrom - mail.coreboot.org

Re: [flashrom] [PATCH 5/5] dediprog: Enable by default.
by Stefan Tauner 01 Jul '15

01 Jul '15

On Sat, 27 Jun 2015 18:50:09 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Acked-by: David Hendricks <dhendrix(a)chromium.org> Well... I certainly would like to see some testing with both protocols before that... :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

need a windows snapshot for flashrom v 0.9.8 or v 0.9.7
by David G ZHAO 01 Jul '15

01 Jul '15

Dear sir, My name is David Zhao, from Sydney Australia. I was using buspirate for writting firmware for bios on the motherboard. The flashrom I used is 0.9.6.1 only. I did check your link for the new version of flashrom v 0.9.8. I tried a few days to compile version 0.9.8 from your source code, but not being successful. I also notice the snapshots url http://ra.openbios.org/~idwer/flashrom/mingw/ <http://ra.openbios.org/%7Eidwer/flashrom/mingw/> can not be opened. Now I am asking you a big favour, can you please email me the snapshots for the windows command line version (for v0.9.8 or v0.9.7)? Your help is much appreciated Kind regards David Zhao

2 1

Re: [flashrom] [PATCH 1/5] dediprog: Invert the LED polarity in the code.
by Stefan Tauner 01 Jul '15

01 Jul '15

On Sat, 27 Jun 2015 17:24:55 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Acked-by: David Hendricks <dhendrix(a)chromium.org> Thanks David. I have committed a slightly revised version in r1894 after realising that there are two mistakes in the proposed change. dediprog_firmwareversion was defined already, it was simply initialized in the hunk below to some (in)sane default. However, this should not happen at all in this patch but a later one. > > @@ -45,6 +45,17 @@ static int dediprog_endpoint; > > #define DEDI_SPI_CMD_PAGEWRITE 0x1 > > #define DEDI_SPI_CMD_AAIWRITE 0x4 > > > > +enum dediprog_leds { > > + LED_INVALID = -1, > > + LED_NONE = 0, > > + LED_PASS = 1 << 0, > > + LED_BUSY = 1 << 1, > > + LED_ERROR = 1 << 2, > > + LED_ALL = 7, > > +}; > > + > > +static int dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > > + > > #if 0 > > /* Might be useful for other pieces of code as well. */ > > static void print_hex(void *buf, size_t len) The else path below was simply wrong. > > @@ -406,10 +399,10 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > > /* Round down. */ > > bulklen = (len - residue) / chunksize * chunksize; > > ret = dediprog_spi_bulk_write(flash, buf + residue, chunksize, start + residue, bulklen, dedi_spi_cmd); > > - if (ret) { > > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > > - return ret; > > - } > > + if (ret) > > + dediprog_set_leds(LED_ERROR); > > + else > > + dediprog_set_leds(LED_PASS); > > > > len -= residue + bulklen; > > if (len) { This ensures the firmware version is reset at shutdown, but this has nothing to do with the LEDs handling... > > @@ -781,6 +774,8 @@ static int dediprog_shutdown(void *data) > > return 1; > > #endif > > > > + dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > > + > > /* URB 28. Command Set SPI Voltage to 0. */ > > if (dediprog_set_spi_voltage(0x0)) > > return 1; -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

C232HM + MX25L1606E
by an jacker 30 Jun '15

30 Jun '15

flashrom v0.9.7-r1711 on Linux 3.11.0-15-generic (i686) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.8, GCC 4.6.3, little endian Command line (3 args): flashrom -p ft2232_spi:type=232H -V Calibrating delay loop... OS timer resolution is 1 usecs, 3356M loops per second, 10 myus = 9 us, 100 myus = 93 us, 1000 myus = 999 us, 10000 myus = 10557 us, 4 myus = 4 us, OK. Initializing ft2232_spi programmer Using device type FTDI FT232H channel A. FTDI chip type 1 is not high-speed. Set clock divisor MPSSE clock: 12.000000 MHz, divisor: 2, SPI clock: 6.000000 MHz No loopback of TDI/DO TDO/DI Set data bits The following protocols are supported: SPI. Probing for AMIC A25L05PT, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L05PU, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L10PT, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L10PU, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L20PT, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L20PU, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L40PT, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L40PU, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L80P, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L16PT, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L16PU, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L512, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L010, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L020, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L080, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L016, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L032, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25LQ16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25LQ032/A25LQ32A, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25LQ64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF021, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF041A, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF081, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF081A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF161, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF321, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF321A, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF641(A), 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DQ161, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25F512, 64 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F512A, 64 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F512B, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25F1024(A), 128 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F2048, 256 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F4096, 512 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25FS010, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25FS040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF041, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF081A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF161, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF161A, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26F004, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45CS1282, 16896 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB011D, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB021D, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB041D, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB081D, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB161D, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB321C, 4224 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB321D, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB642D, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for ESMT F25L008A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B05, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B05T, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B10T, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B20T, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B40T, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B80T, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B16T, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B32T, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B64T, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F05, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q80(A), 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q32(A/B), 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q128, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH128, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25LQ32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q512, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q20(B), 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q40(B), 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q80(B), 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q16(B), 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q32(B), 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q64(B), 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q128B, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25T80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F160S33B8, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F160S33T8, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F320S33B8, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F320S33T8, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F640S33B8, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F640S33T8, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L512(E)/MX25V512(C), 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1005(C)/MX25L1006E, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L2005(C), 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L4005(A/C), 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L8005/MX25V8005, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1605, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1605A/MX25L1606E, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1605D/MX25L1608D, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1635D, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1635E, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3205(A), 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3205D/MX25L3208D, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3206E, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3235D, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L6405(D), 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L6406E/MX25L6436E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L6445E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L12805(D), 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25U1635E, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25U3235E/F, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25U6435E/F, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P05-A, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P05, 64 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P10-A, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P10, 128 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P20-old, 256 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P40-old, 512 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P128, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q016, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q032..1E, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q032..3E, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q064..1E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q064..3E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q128..1E, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q128..3E, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD256C, 32 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD512(C), 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD010(C), 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD020(C), 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD040(C), 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV512(A), 64 kB: probe_spi_res3: id1 0x0, id2 0x0 Probing for PMC Pm25LV010, 128 kB: probe_spi_res3: id1 0x0, id2 0x0 Probing for PMC Pm25LV010A, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV020, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV080B, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV016B, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo LE25FW203A, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo LE25FW403A, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo LE25FW418A, 512 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for Sanyo LE25FW806, 1024 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for Sanyo LE25FW808, 1024 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for Spansion S25FL004A, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL008A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL016A, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL032A/P, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL064A/P, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL204K, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL208K, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL116K/S25FL216K, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL128S......0, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25LF040A, 512 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for SST SST25LF080(A), 1024 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for SST SST25VF010, 128 kB: probe_spi_rems: id1 0x0, id2 0x0 Probing for SST SST25VF016B, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF032B, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF064C, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF040, 512 kB: probe_spi_rems: id1 0x0, id2 0x0 Probing for SST SST25VF040B, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0x0, id2 0x0 Probing for SST SST25VF080B, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF512, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF010, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF020, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q80.V, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q16.V, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q32.V, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q64.V, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q128.V, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q20.W, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q40.W, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q80.W, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q16.W, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q32.W, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q64.W, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Unknown SFDP-capable chip, 0 kB: No SFDP signature found. Probing for AMIC unknown AMIC SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel unknown Atmel SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon unknown Eon SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix unknown Macronix SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC unknown PMC SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST unknown SST SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for ST unknown ST SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond unknown Winbond (ex Nexcom) SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Generic unknown SPI chip (RDID), 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Found Generic flash chip "unknown SPI chip (RDID)" (0 kB, SPI) on ft2232_spi. Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0x0, id2 0x0 Found Generic flash chip "unknown SPI chip (RDID)" (0 kB, SPI). === This flash part has status NOT WORKING for operations: PROBE READ ERASE WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -VE, -Vw), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! No operations were specified.

1 0

Re: [flashrom] [PATCH v2] serprog: Fix FWH/LPC by implementing serprog_map
by Stefan Tauner 30 Jun '15

30 Jun '15

Thanks Urja for the explanation. I have refined the comments and committed the result in r1895. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1895 - trunk
by repository service 30 Jun '15

30 Jun '15

Author: stefanct Date: Tue Jun 30 01:24:23 2015 New Revision: 1895 URL: http://flashrom.org/trac/flashrom/changeset/1895 Log: serprog: Fix FWH/LPC by implementing serprog_map. The serprog protocol does only transmit 24 bit-wide address and ignores the top 8 bit. This is fine as long as the underlying hardware ignores the latter anyway (which is the case for parallel chips that even lack the respective pins). FWH/LPC chips, however, operate on a full 32-bit (LPC) or 28-bit (FWH) address space and would fail with the fallback mapping to NULL. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/flashrom.c trunk/programmer.h trunk/serprog.c Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Sun Jun 28 15:31:19 2015 (r1894) +++ trunk/flashrom.c Tue Jun 30 01:24:23 2015 (r1895) @@ -212,7 +212,7 @@ /* FIXME */ .devs.note = "All programmer devices speaking the serprog protocol\n", .init = serprog_init, - .map_flash_region = fallback_map, + .map_flash_region = serprog_map, .unmap_flash_region = fallback_unmap, .delay = serprog_delay, }, Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Sun Jun 28 15:31:19 2015 (r1894) +++ trunk/programmer.h Tue Jun 30 01:24:23 2015 (r1895) @@ -706,6 +706,7 @@ #if CONFIG_SERPROG == 1 int serprog_init(void); void serprog_delay(unsigned int usecs); +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len); #endif /* serial.c */ Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Sun Jun 28 15:31:19 2015 (r1894) +++ trunk/serprog.c Tue Jun 30 01:24:23 2015 (r1895) @@ -943,3 +943,19 @@ } return 0; } + +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len) +{ + /* Serprog transmits 24 bits only and assumes the underlying implementation handles any remaining bits + * correctly (usually setting them to one either in software (for FWH/LPC) or relying on the fact that + * the hardware observes a subset of the address bits only). Combined with the standard mapping of + * flashrom this creates a 16 MB-wide window just below the 4 GB boundary where serprog can operate (as + * needed for non-SPI chips). Below we make sure that the requested range is within this window. */ + if ((phys_addr & 0xFF000000) == 0xFF000000) { + return (void*)phys_addr; + } else { + msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n", + descr, len, PRIxPTR_WIDTH, phys_addr); + return NULL; + } +}

1 0

[PATCH v2] serprog: Fix FWH/LPC by implementing serprog_map
by Urja Rannikko 29 Jun '15

29 Jun '15

also make serprog_map report if mapping doesnt fit in the 24-bit address space of serprog. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- The previous version didnt compile on 64-bit because size_t and -Werror ... thus v2. --- flashrom.c | 2 +- programmer.h | 1 + serprog.c | 12 ++++++++++++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/flashrom.c b/flashrom.c index a389cb2..d51a44c 100644 --- a/flashrom.c +++ b/flashrom.c @@ -212,7 +212,7 @@ const struct programmer_entry programmer_table[] = { /* FIXME */ .devs.note = "All programmer devices speaking the serprog protocol\n", .init = serprog_init, - .map_flash_region = fallback_map, + .map_flash_region = serprog_map, .unmap_flash_region = fallback_unmap, .delay = serprog_delay, }, diff --git a/programmer.h b/programmer.h index 913522b..3bf292d 100644 --- a/programmer.h +++ b/programmer.h @@ -706,6 +706,7 @@ int register_master(const struct registered_master *mst); #if CONFIG_SERPROG == 1 int serprog_init(void); void serprog_delay(unsigned int usecs); +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len); #endif /* serial.c */ diff --git a/serprog.c b/serprog.c index 3de0182..8e4286a 100644 --- a/serprog.c +++ b/serprog.c @@ -943,3 +943,15 @@ static int serprog_spi_read(struct flashctx *flash, uint8_t *buf, } return 0; } + +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len) +{ + if ((phys_addr & 0xFF000000) == 0xFF000000) { + /* This is normal, no need to report anything. */ + return (void*)phys_addr; + } else { + msg_pwarn(MSGHEADER "incompatible mapping %s, 0x%zx bytes at 0x%0*" PRIxPTR ", returning NULL\n", + descr, len, PRIxPTR_WIDTH, phys_addr); + return NULL; + } +} -- 2.3.1

2 2

Re: [flashrom] [PATCH 2/5] dediprog: Tidy up commands and remove dead nonsense code.
by Stefan Tauner 29 Jun '15

29 Jun '15

On Sat, 27 Jun 2015 17:24:43 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Mostly looks good to me, just a couple minor comments. > > > + > > +enum dediprog_target { > > + FLASH_TYPE_APPLICATION_FLASH_1 = 0, > > + FLASH_TYPE_FLASH_CARD, > > + FLASH_TYPE_APPLICATION_FLASH_2, > > > FLASH_TYPE_SOCKET, /* SF600 */ Thank you. > > + > > +enum dediprog_writemode { > > + WRITE_MODE_PAGE_PGM = 1, > > + WRITE_MODE_PAGE_WRITE = 2, > > + WRITE_MODE_1B_AAI = 3, > > + WRITE_MODE_2B_AAI = 4, > > + WRITE_MODE_128B_PAGE = 5, > > + WRITE_MODE_PAGE_AT26DF041 = 6, > > + WRITE_MODE_SILICON_BLUE_FPGA = 7, > > + WRITE_MODE_64B_PAGE_NUMONYX_PCM = 8, /* unit of length 512 bytes */ > > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM = 9, > > + WRITE_MODE_32B_PAGE_PGM_MXIC_512K = 10, /* unit of length 512 bytes */ > > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12 = 11, > > 11 seems to only apply for the new protocol? The old protocol spec > just says "For SF100" but I have no idea what that actually means. I don't know... and I don't think they do either. :P Since it is present in both specs I'll just leave it as is for now. The 0x12 opcode is rather clear in the flash datasheets... it is just like normal page write but with 4 mandatory bytes for the address. So it should be easy to verify if the old firmware/protocol uses that... when we implement those write modes eventually. I have not seen an acked-by line in your mail... may I add it to the respective commit? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] [PATCH 3/5] dediprog: Show UID.
by Stefan Tauner 28 Jun '15

28 Jun '15

On Sat, 27 Jun 2015 17:34:11 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Apply this patch after patch 4 so that dediprog_read() is defined. > > Aside from that: > Acked-by: David Hendricks <dhendrix(a)chromium.org> Right. On the other hand no one yet knows what this UID actually is. So we agreed on IRC to postpone this patch completely. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1894 - trunk
by repository service 28 Jun '15

28 Jun '15

Author: stefanct Date: Sun Jun 28 15:31:19 2015 New Revision: 1894 URL: http://flashrom.org/trac/flashrom/changeset/1894 Log: dediprog: Invert the LED polarity in the code. Previously we have used low-active macros (because the hardware and old protocol were so too) and set every single LED explicitly although we only used a limited number of combinations. Using an enumeration for commonly used values instead makes things easier. Based on the following chromiumos change: Change-Id: Ie481a583e623cdc45e3649a4db69b15570f65a7b Signed-off-by: Simon Glass <sjg(a)chromium.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: David Hendricks <dhendrix(a)chromium.org> Modified: trunk/dediprog.c Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Tue Jun 23 01:59:15 2015 (r1893) +++ trunk/dediprog.c Sun Jun 28 15:31:19 2015 (r1894) @@ -45,6 +45,15 @@ #define DEDI_SPI_CMD_PAGEWRITE 0x1 #define DEDI_SPI_CMD_AAIWRITE 0x4 +enum dediprog_leds { + LED_INVALID = -1, + LED_NONE = 0, + LED_PASS = 1 << 0, + LED_BUSY = 1 << 1, + LED_ERROR = 1 << 2, + LED_ALL = 7, +}; + #if 0 /* Might be useful for other pieces of code as well. */ static void print_hex(void *buf, size_t len) @@ -77,24 +86,11 @@ //int usb_control_msg(usb_dev_handle *dev, int requesttype, int request, int value, int index, char *bytes, int size, int timeout); -/* Set/clear LEDs on dediprog */ -#define PASS_ON (0 << 0) -#define PASS_OFF (1 << 0) -#define BUSY_ON (0 << 1) -#define BUSY_OFF (1 << 1) -#define ERROR_ON (0 << 2) -#define ERROR_OFF (1 << 2) -static int current_led_status = -1; - +/* This function sets the GPIOs connected to the LEDs as well as IO1-IO4. */ static int dediprog_set_leds(int leds) { - int ret, target_leds; - - if (leds < 0 || leds > 7) - leds = 0; // Bogus value, enable all LEDs - - if (leds == current_led_status) - return 0; + if (leds < LED_NONE || leds > LED_ALL) + leds = LED_ALL; /* Older Dediprogs with 2.x.x and 3.x.x firmware only had * two LEDs, and they were reversed. So map them around if @@ -103,23 +99,21 @@ * bit 2 == 0: green light is on. * bit 0 == 0: red light is on. */ + int target_leds; if (dediprog_firmwareversion < FIRMWARE_VERSION(5,0,0)) { - target_leds = ((leds & ERROR_OFF) >> 2) | - ((leds & PASS_OFF) << 2); + target_leds = ((leds & LED_ERROR) >> 2) | + ((leds & LED_PASS) << 2); } else { target_leds = leds; } - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, - NULL, 0x0, DEFAULT_TIMEOUT); + target_leds ^= 7; + int ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, NULL, 0x0, DEFAULT_TIMEOUT); if (ret != 0x0) { - msg_perr("Command Set LED 0x%x failed (%s)!\n", - leds, usb_strerror()); + msg_perr("Command Set LED 0x%x failed (%s)!\n", leds, usb_strerror()); return 1; } - current_led_status = leds; - return 0; } @@ -271,26 +265,22 @@ unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; unsigned int bulklen; - dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); + dediprog_set_leds(LED_BUSY); if (residue) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, residue); ret = spi_read_chunked(flash, buf, start, residue, 16); - if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); - return ret; - } + if (ret) + goto err; } /* Round down. */ bulklen = (len - residue) / chunksize * chunksize; ret = dediprog_spi_bulk_read(flash, buf + residue, start + residue, bulklen); - if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); - return ret; - } + if (ret) + goto err; len -= residue + bulklen; if (len) { @@ -298,14 +288,15 @@ start, len); ret = spi_read_chunked(flash, buf + residue + bulklen, start + residue + bulklen, len, 16); - if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); - return ret; - } + if (ret) + goto err; } - dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); + dediprog_set_leds(LED_PASS); return 0; +err: + dediprog_set_leds(LED_ERROR); + return ret; } /* Bulk write interface, will write multiple chunksize byte chunks aligned to chunksize bytes. @@ -383,7 +374,7 @@ unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; unsigned int bulklen; - dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); + dediprog_set_leds(LED_BUSY); if (chunksize != 256) { msg_pdbg("Page sizes other than 256 bytes are unsupported as " @@ -398,7 +389,7 @@ /* No idea about the real limit. Maybe 12, maybe more. */ ret = spi_write_chunked(flash, buf, start, residue, 12); if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return ret; } } @@ -407,7 +398,7 @@ bulklen = (len - residue) / chunksize * chunksize; ret = dediprog_spi_bulk_write(flash, buf + residue, chunksize, start + residue, bulklen, dedi_spi_cmd); if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return ret; } @@ -418,12 +409,12 @@ ret = spi_write_chunked(flash, buf + residue + bulklen, start + residue + bulklen, len, 12); if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return ret; } } - dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); + dediprog_set_leds(LED_PASS); return 0; } @@ -918,23 +909,25 @@ if (register_shutdown(dediprog_shutdown, NULL)) return 1; - dediprog_set_leds(PASS_ON|BUSY_ON|ERROR_ON); - /* Perform basic setup. */ if (dediprog_setup(target)) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; } + /* Set all possible LEDs as soon as possible to indicate activity. + * Because knowing the firmware version is required to set the LEDs correctly we need to this after + * dediprog_setup() has queried the device and set dediprog_firmwareversion. */ + dediprog_set_leds(LED_ALL); + /* After setting voltage and speed, perform setup again. */ if (dediprog_set_spi_voltage(0) || dediprog_set_spi_speed(spispeed_idx) || dediprog_setup(target)) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return 1; } /* URB 11. Command Set SPI Voltage. */ if (dediprog_set_spi_voltage(millivolt)) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return 1; } @@ -946,7 +939,7 @@ dediprog_do_stuff(); #endif - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_OFF); + dediprog_set_leds(LED_NONE); return 0; }

1 0

[PATCH 3/3] serprog: allow to omit specifying a baud rate.
by Stefan Tauner 28 Jun '15

28 Jun '15

On USB-based serial connections (VCP) the requested baud rate usually does not matter (much). Remove the arbitrary restriction and use whatever default values the OS/hardware provides. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- flashrom.8.tmpl | 26 ++++++++++++++------------ programmer.h | 4 +--- serial.c | 25 +++++++++++++++---------- serprog.c | 44 +++++++++++++++++++++++--------------------- 4 files changed, 53 insertions(+), 46 deletions(-) diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 8b5f98c..26ea6e9 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -203,10 +203,9 @@ JTAGkey/JTAGkey-tiny/JTAGkey-2, Dangerous Prototypes Bus Blaster, \ Olimex ARM-USB-TINY/-H, Olimex ARM-USB-OCD/-H, TIAO/DIYGADGET USB Multi-Protocol Adapter (TUMPA), TUMPA Lite, and GOEPEL PicoTAP. .sp -.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog), \ -including AVR flasher by Urja Rannikko, AVR flasher by eightdot, \ -Arduino Mega flasher by fritz, InSystemFlasher by Juhana Helovuo, and \ -atmegaXXu2-flasher by Stefan Tauner." +.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog, \ +including Arduino-based devices as well as various programmers by Urja Rannikko, \ +Juhana Helovuo, Stefan Tauner and others)." .sp .BR "* buspirate_spi" " (for SPI flash ROMs attached to a Bus Pirate)" .sp @@ -683,19 +682,22 @@ parameter with the syntax. .SS .BR "serprog " programmer -A mandatory parameter specifies either a serial -device/baud combination or an IP/port combination for communication with the -programmer. In the device/baud combination, the device has to start with a -slash. For serial, you have to use the +A mandatory parameter specifies either a serial device (and baud rate) or an IP/port combination for +communicating with the programmer. +The device/baud combination has to start with +.B dev= +and separate the optional baud rate with a colon. +For example .sp -.B " flashrom \-p serprog:dev=/dev/device:baud" +.B " flashrom \-p serprog:dev=/dev/ttyS0:115200" .sp -syntax and for IP, you have to use +If no baud rate is given the default values by the operating system/hardware will be used. +For IP connections you have to use the .sp .B " flashrom \-p serprog:ip=ipaddr:port" .sp -instead. In case the device supports it, you can set the SPI clock frequency -with the optional +syntax. +In case the device supports it, you can set the SPI clock frequency with the optional .B spispeed parameter. The frequency is parsed as hertz, unless an .BR M ", or " k diff --git a/programmer.h b/programmer.h index 913522b..ea58e17 100644 --- a/programmer.h +++ b/programmer.h @@ -718,10 +718,8 @@ typedef int fdtype; #endif void sp_flush_incoming(void); -fdtype sp_openserport(char *dev, unsigned int baud); -int serialport_config(fdtype fd, unsigned int baud); +fdtype sp_openserport(char *dev, int baud); extern fdtype sp_fd; -/* expose serialport_shutdown as it's currently used by buspirate */ int serialport_shutdown(void *data); int serialport_write(const unsigned char *buf, unsigned int writecnt); int serialport_write_nonblock(const unsigned char *buf, unsigned int writecnt, unsigned int timeout, unsigned int *really_wrote); diff --git a/serial.c b/serial.c index b216143..c9ce3af 100644 --- a/serial.c +++ b/serial.c @@ -116,7 +116,7 @@ static const struct baudentry sp_baudtable[] = { {0, 0} /* Terminator */ }; -const struct baudentry *round_baud(unsigned int baud) +static const struct baudentry *round_baud(unsigned int baud) { int i; /* Round baud rate to next lower entry in sp_baudtable if it exists, else use the lowest entry. */ @@ -125,11 +125,12 @@ const struct baudentry *round_baud(unsigned int baud) return &sp_baudtable[i]; if (sp_baudtable[i].baud < baud) { - msg_pinfo("Warning: given baudrate %d rounded down to %d.\n", + msg_pwarn("Warning: given baudrate %d rounded down to %d.\n", baud, sp_baudtable[i].baud); return &sp_baudtable[i]; } } + msg_pinfo("Using slowest possible baudrate: %d.\n", sp_baudtable[0].baud); return &sp_baudtable[0]; } @@ -154,7 +155,7 @@ static void msg_perr_strerror(const char *msg) #endif } -int serialport_config(fdtype fd, unsigned int baud) +int serialport_config(fdtype fd, int baud) { if (fd == SER_INV_FD) { msg_perr("%s: File descriptor is invalid.\n", __func__); @@ -167,8 +168,10 @@ int serialport_config(fdtype fd, unsigned int baud) msg_perr_strerror("Could not fetch original serial port configuration: "); return 1; } - const struct baudentry *entry = round_baud(baud); - dcb.BaudRate = entry->flag; + if (baud >= 0) { + const struct baudentry *entry = round_baud(baud); + dcb.BaudRate = entry->flag; + } dcb.ByteSize = 8; dcb.Parity = NOPARITY; dcb.StopBits = ONESTOPBIT; @@ -188,10 +191,12 @@ int serialport_config(fdtype fd, unsigned int baud) return 1; } wanted = observed; - const struct baudentry *entry = round_baud(baud); - if (cfsetispeed(&wanted, entry->flag) != 0 || cfsetospeed(&wanted, entry->flag) != 0) { - msg_perr_strerror("Could not set serial baud rate: "); - return 1; + if (baud >= 0) { + const struct baudentry *entry = round_baud(baud); + if (cfsetispeed(&wanted, entry->flag) != 0 || cfsetospeed(&wanted, entry->flag) != 0) { + msg_perr_strerror("Could not set serial baud rate: "); + return 1; + } } wanted.c_cflag &= ~(PARENB | CSTOPB | CSIZE | CRTSCTS); wanted.c_cflag |= (CS8 | CLOCAL | CREAD); @@ -232,7 +237,7 @@ int serialport_config(fdtype fd, unsigned int baud) return 0; } -fdtype sp_openserport(char *dev, unsigned int baud) +fdtype sp_openserport(char *dev, int baud) { fdtype fd; #if IS_WINDOWS diff --git a/serprog.c b/serprog.c index 3de0182..4f671ce 100644 --- a/serprog.c +++ b/serprog.c @@ -342,26 +342,28 @@ int serprog_init(void) unsigned char rbuf[3]; unsigned char c; char *device; - char *baudport; int have_device = 0; - /* the parameter is either of format "dev=/dev/device:baud" or "ip=ip:port" */ + /* the parameter is either of format "dev=/dev/device[:baud]" or "ip=ip:port" */ device = extract_programmer_param("dev"); if (device && strlen(device)) { - baudport = strstr(device, ":"); - if (baudport) { + char *baud_str = strstr(device, ":"); + if (baud_str) { /* Split device from baudrate. */ - *baudport = '\0'; - baudport++; + *baud_str = '\0'; + baud_str++; } - if (!baudport || !strlen(baudport)) { - msg_perr("Error: No baudrate specified.\n" - "Use flashrom -p serprog:dev=/dev/device:baud\n"); - free(device); - return 1; - } - if (strlen(device)) { - sp_fd = sp_openserport(device, atoi(baudport)); + int baud; + /* Convert baud string to value. + * baud_str is either NULL (if strstr can't find the colon), points to the \0 after the colon + * if no characters where given after the colon, or a string to convert... */ + if (baud_str == NULL || *baud_str == '\0') { + baud = -1; + msg_pdbg("No baudrate specified, using the hardware's defaults.\n"); + } else + baud = atoi(baud_str); // FIXME: replace atoi with strtoul + if (strlen(device) > 0) { + sp_fd = sp_openserport(device, baud); if (sp_fd == SER_INV_FD) { free(device); return 1; @@ -371,7 +373,7 @@ int serprog_init(void) } if (device && !strlen(device)) { msg_perr("Error: No device specified.\n" - "Use flashrom -p serprog:dev=/dev/device:baud\n"); + "Use flashrom -p serprog:dev=/dev/device[:baud]\n"); free(device); return 1; } @@ -386,20 +388,20 @@ int serprog_init(void) return 1; } if (device && strlen(device)) { - baudport = strstr(device, ":"); - if (baudport) { + char *port = strstr(device, ":"); + if (port) { /* Split host from port. */ - *baudport = '\0'; - baudport++; + *port = '\0'; + port++; } - if (!baudport || !strlen(baudport)) { + if (!port || !strlen(port)) { msg_perr("Error: No port specified.\n" "Use flashrom -p serprog:ip=ipaddr:port\n"); free(device); return 1; } if (strlen(device)) { - sp_fd = sp_opensocket(device, atoi(baudport)); + sp_fd = sp_opensocket(device, atoi(port)); if (sp_fd < 0) { free(device); return 1; -- Kind regards, Stefan Tauner

1 0

[PATCH 2/3] serprog: ignore failures when setting serial port options.
by Stefan Tauner 28 Jun '15

28 Jun '15

There is no good reason to abort earlier just because some options did not stick. This should improve compatibility without negative effects. If communication is affected by the missing flag(s) then we abort later anyway. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- serial.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/serial.c b/serial.c index 63774a5..b216143 100644 --- a/serial.c +++ b/serial.c @@ -209,12 +209,25 @@ int serialport_config(fdtype fd, unsigned int baud) if (observed.c_cflag != wanted.c_cflag || observed.c_lflag != wanted.c_lflag || observed.c_iflag != wanted.c_iflag || - observed.c_oflag != wanted.c_oflag || - cfgetispeed(&observed) != cfgetispeed(&wanted)) { - msg_perr("%s: Some requested options did not stick.\n", __func__); - return 1; + observed.c_oflag != wanted.c_oflag) { + msg_pwarn("Some requested serial options did not stick, continuing anyway.\n"); + msg_pdbg(" observed wanted\n" + "c_cflag: 0x%08X 0x%08X\n" + "c_lflag: 0x%08X 0x%08X\n" + "c_iflag: 0x%08X 0x%08X\n" + "c_oflag: 0x%08X 0x%08X\n", + observed.c_cflag, wanted.c_cflag, + observed.c_lflag, wanted.c_lflag, + observed.c_iflag, wanted.c_iflag, + observed.c_oflag, wanted.c_oflag + ); + } + if (cfgetispeed(&observed) != cfgetispeed(&wanted) || + cfgetospeed(&observed) != cfgetospeed(&wanted)) { + msg_pwarn("Could not set baud rates exactly\n"); + msg_pdbg("Actual baud flags are: ispeed: 0x%08lX, ospeed: 0x%08lX\n", + (long)cfgetispeed(&observed), (long)cfgetispeed(&wanted)); } - msg_pdbg("Baud rate is %d now.\n", entry->baud); #endif return 0; } -- Kind regards, Stefan Tauner

1 0

[PATCH 1/3] serprog: clear NDELAY flag only once after opening the port.
by Stefan Tauner 28 Jun '15

28 Jun '15

Change sp_openserport() to directly clear the O_NONBLOCK flag that is potentially set by opening the device with O_NDELAY instead of clearing ALL flags in serialport_config() unconditionally. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- serial.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/serial.c b/serial.c index 94f9b7d..63774a5 100644 --- a/serial.c +++ b/serial.c @@ -183,10 +183,6 @@ int serialport_config(fdtype fd, unsigned int baud) msg_pdbg("Baud rate is %ld.\n", dcb.BaudRate); #else struct termios wanted, observed; - if (fcntl(fd, F_SETFL, 0) != 0) { - msg_perr_strerror("Could not clear serial port mode: "); - return 1; - } if (tcgetattr(fd, &observed) != 0) { msg_perr_strerror("Could not fetch original serial port configuration: "); return 1; @@ -254,11 +250,23 @@ fdtype sp_openserport(char *dev, unsigned int baud) } return fd; #else - fd = open(dev, O_RDWR | O_NOCTTY | O_NDELAY); + fd = open(dev, O_RDWR | O_NOCTTY | O_NDELAY); // Use O_NDELAY to ignore DCD state if (fd < 0) { msg_perr_strerror("Cannot open serial port: "); return SER_INV_FD; } + + /* Ensure that we use blocking I/O */ + const int flags = fcntl(fd, F_GETFL); + if (flags == -1) { + msg_perr_strerror("Could not get serial port mode: "); + return SER_INV_FD; + } + if (fcntl(fd, F_SETFL, flags & ~O_NONBLOCK) != 0) { + msg_perr_strerror("Could not set serial port mode to blocking: "); + return SER_INV_FD; + } + if (serialport_config(fd, baud) != 0) { close(fd); return SER_INV_FD; -- Kind regards, Stefan Tauner

1 0

[PATCH 0/3] Some serprog improvements
by Stefan Tauner 28 Jun '15

28 Jun '15

I plan to include them (and probably some of Urja's patches too) in flashrom 0.9.8.1. Stefan Tauner (3): serprog: clear NDELAY flag only once after opening the port. serprog: ignore failures when setting serial port options. serprog: allow to omit specifying a baud rate. flashrom.8.tmpl | 26 ++++++++++++----------- programmer.h | 4 +--- serial.c | 66 ++++++++++++++++++++++++++++++++++++++++----------------- serprog.c | 44 ++++++++++++++++++++------------------ 4 files changed, 84 insertions(+), 56 deletions(-) -- Kind regards, Stefan Tauner

1 0

Re: [flashrom] [PATCH 5/5] dediprog: Enable by default.
by David Hendricks 28 Jun '15

28 Jun '15

Acked-by: David Hendricks <dhendrix(a)chromium.org> On Sun, Jun 21, 2015 at 6:37 PM, Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index c439d8d..e7c8fde 100644 > --- a/Makefile > +++ b/Makefile > @@ -469,8 +469,8 @@ CONFIG_OGP_SPI ?= yes > # Always enable Bus Pirate SPI for now. > CONFIG_BUSPIRATE_SPI ?= yes > > -# Disable Dediprog SF100 until support is complete and tested. > -CONFIG_DEDIPROG ?= no > +# Always enable Dediprog SF100 for now. > +CONFIG_DEDIPROG ?= yes > > # Always enable Marvell SATA controllers for now. > CONFIG_SATAMV ?= yes > -- > Kind regards, Stefan Tauner > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] [PATCH 3/5] dediprog: Show UID.
by David Hendricks 28 Jun '15

28 Jun '15

Apply this patch after patch 4 so that dediprog_read() is defined. Aside from that: Acked-by: David Hendricks <dhendrix(a)chromium.org> On Sun, Jun 21, 2015 at 6:37 PM, Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > Whatever that is... > To that end, send the respective command and print result with a "new" > helpers.c function. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > --- > dediprog.c | 19 +++++++++++++++++++ > flash.h | 1 + > helpers.c | 7 +++++++ > 3 files changed, 27 insertions(+) > > diff --git a/dediprog.c b/dediprog.c > index ce7ff7a..a6801be 100644 > --- a/dediprog.c > +++ b/dediprog.c > @@ -730,6 +730,18 @@ static int dediprog_shutdown(void *data) > return 0; > } > > +/* Return the 8-byte UID for the flash */ > +static int get_uid(uint8_t buf[8]) > +{ > + int ret = dediprog_read(CMD_GET_UID, 0, 0, buf, 8); > + if (ret != 8) { > + msg_perr("get_uid failed (%s)!\n", usb_strerror()); > + return 1; > + } > + > + return 0; > +} > + > /* URB numbers refer to the first log ever captured. */ > int dediprog_init(void) > { > @@ -872,6 +884,13 @@ int dediprog_init(void) > return 1; > } > > + uint8_t uid[8]; > + if (get_uid(uid) != 0) > + return 1; > + msg_pdbg("UID:"); > + print_hex_buf(uid, sizeof(uid)); > + msg_pdbg("\n"); > + > register_spi_master(&spi_master_dediprog); > > dediprog_set_leds(LED_NONE); > diff --git a/flash.h b/flash.h > index 2c2839f..f7bd94b 100644 > --- a/flash.h > +++ b/flash.h > @@ -251,6 +251,7 @@ void print_supported_wiki(void); > > /* helpers.c */ > uint32_t address_to_bits(uint32_t addr); > +void print_hex_buf(uint8_t *buf, size_t len); > int bitcount(unsigned long a); > int max(int a, int b); > int min(int a, int b); > diff --git a/helpers.c b/helpers.c > index 7a146c3..a82ba55 100644 > --- a/helpers.c > +++ b/helpers.c > @@ -34,6 +34,13 @@ uint32_t address_to_bits(uint32_t addr) > return 32 - lzb; > } > > +void print_hex_buf(uint8_t *buf, size_t len) > +{ > + size_t i; > + for (i = 0; i < len; i++) > + msg_pdbg(" %02x", buf[i]); > +} > + > int bitcount(unsigned long a) > { > int i = 0; > -- > Kind regards, Stefan Tauner > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] [PATCH 1/5] dediprog: Invert the LED polarity in the code.
by David Hendricks 28 Jun '15

28 Jun '15

Acked-by: David Hendricks <dhendrix(a)chromium.org> On Sun, Jun 21, 2015 at 6:37 PM, Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > > Previously we have used low-active macros (because the hardware and > old protocol were so too) and set every single LED explicitly although we > only used a limited number of combinations. Using an enumeration for > commonly used values instead makes things easier. > > Based on the following chromiumos change: > Change-Id: Ie481a583e623cdc45e3649a4db69b15570f65a7b > > Signed-off-by: Simon Glass <sjg(a)chromium.org> > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > --- > dediprog.c | 101 ++++++++++++++++++++++++++++++------------------------------- > 1 file changed, 49 insertions(+), 52 deletions(-) > > diff --git a/dediprog.c b/dediprog.c > index 851dbae..b45e061 100644 > --- a/dediprog.c > +++ b/dediprog.c > @@ -45,6 +45,17 @@ static int dediprog_endpoint; > #define DEDI_SPI_CMD_PAGEWRITE 0x1 > #define DEDI_SPI_CMD_AAIWRITE 0x4 > > +enum dediprog_leds { > + LED_INVALID = -1, > + LED_NONE = 0, > + LED_PASS = 1 << 0, > + LED_BUSY = 1 << 1, > + LED_ERROR = 1 << 2, > + LED_ALL = 7, > +}; > + > +static int dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > + > #if 0 > /* Might be useful for other pieces of code as well. */ > static void print_hex(void *buf, size_t len) > @@ -77,24 +88,11 @@ static struct usb_device *get_device_by_vid_pid(uint16_t vid, uint16_t pid, unsi > > //int usb_control_msg(usb_dev_handle *dev, int requesttype, int request, int value, int index, char *bytes, int size, int timeout); > > -/* Set/clear LEDs on dediprog */ > -#define PASS_ON (0 << 0) > -#define PASS_OFF (1 << 0) > -#define BUSY_ON (0 << 1) > -#define BUSY_OFF (1 << 1) > -#define ERROR_ON (0 << 2) > -#define ERROR_OFF (1 << 2) > -static int current_led_status = -1; > - > +/* This function sets the GPIOs connected to the LEDs as well as IO1-IO4. */ > static int dediprog_set_leds(int leds) > { > - int ret, target_leds; > - > - if (leds < 0 || leds > 7) > - leds = 0; // Bogus value, enable all LEDs > - > - if (leds == current_led_status) > - return 0; > + if (leds < LED_NONE || leds > LED_ALL) > + leds = LED_ALL; > > /* Older Dediprogs with 2.x.x and 3.x.x firmware only had > * two LEDs, and they were reversed. So map them around if > @@ -103,23 +101,21 @@ static int dediprog_set_leds(int leds) > * bit 2 == 0: green light is on. > * bit 0 == 0: red light is on. > */ > + int target_leds; > if (dediprog_firmwareversion < FIRMWARE_VERSION(5,0,0)) { > - target_leds = ((leds & ERROR_OFF) >> 2) | > - ((leds & PASS_OFF) << 2); > + target_leds = ((leds & LED_ERROR) >> 2) | > + ((leds & LED_PASS) << 2); > } else { > target_leds = leds; > } > > - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, > - NULL, 0x0, DEFAULT_TIMEOUT); > + target_leds ^= 7; > + int ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, NULL, 0x0, DEFAULT_TIMEOUT); > if (ret != 0x0) { > - msg_perr("Command Set LED 0x%x failed (%s)!\n", > - leds, usb_strerror()); > + msg_perr("Command Set LED 0x%x failed (%s)!\n", leds, usb_strerror()); > return 1; > } > > - current_led_status = leds; > - > return 0; > } > > @@ -271,26 +267,22 @@ static int dediprog_spi_read(struct flashctx *flash, uint8_t *buf, > unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; > unsigned int bulklen; > > - dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); > + dediprog_set_leds(LED_BUSY); > > if (residue) { > msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", > start, residue); > ret = spi_read_chunked(flash, buf, start, residue, 16); > - if (ret) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > - return ret; > - } > + if (ret) > + goto err; > } > > /* Round down. */ > bulklen = (len - residue) / chunksize * chunksize; > ret = dediprog_spi_bulk_read(flash, buf + residue, start + residue, > bulklen); > - if (ret) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > - return ret; > - } > + if (ret) > + goto err; > > len -= residue + bulklen; > if (len) { > @@ -298,14 +290,15 @@ static int dediprog_spi_read(struct flashctx *flash, uint8_t *buf, > start, len); > ret = spi_read_chunked(flash, buf + residue + bulklen, > start + residue + bulklen, len, 16); > - if (ret) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > - return ret; > - } > + if (ret) > + goto err; > } > > - dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); > + dediprog_set_leds(LED_PASS); > return 0; > +err: > + dediprog_set_leds(LED_ERROR); > + return ret; > } > > /* Bulk write interface, will write multiple chunksize byte chunks aligned to chunksize bytes. > @@ -383,7 +376,7 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; > unsigned int bulklen; > > - dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); > + dediprog_set_leds(LED_BUSY); > > if (chunksize != 256) { > msg_pdbg("Page sizes other than 256 bytes are unsupported as " > @@ -398,7 +391,7 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > /* No idea about the real limit. Maybe 12, maybe more. */ > ret = spi_write_chunked(flash, buf, start, residue, 12); > if (ret) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > + dediprog_set_leds(LED_ERROR); > return ret; > } > } > @@ -406,10 +399,10 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > /* Round down. */ > bulklen = (len - residue) / chunksize * chunksize; > ret = dediprog_spi_bulk_write(flash, buf + residue, chunksize, start + residue, bulklen, dedi_spi_cmd); > - if (ret) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > - return ret; > - } > + if (ret) > + dediprog_set_leds(LED_ERROR); > + else > + dediprog_set_leds(LED_PASS); > > len -= residue + bulklen; > if (len) { > @@ -418,12 +411,12 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > ret = spi_write_chunked(flash, buf + residue + bulklen, > start + residue + bulklen, len, 12); > if (ret) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > + dediprog_set_leds(LED_ERROR); > return ret; > } > } > > - dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); > + dediprog_set_leds(LED_PASS); > return 0; > } > > @@ -781,6 +774,8 @@ static int dediprog_shutdown(void *data) > return 1; > #endif > > + dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > + > /* URB 28. Command Set SPI Voltage to 0. */ > if (dediprog_set_spi_voltage(0x0)) > return 1; > @@ -918,23 +913,25 @@ int dediprog_init(void) > if (register_shutdown(dediprog_shutdown, NULL)) > return 1; > > - dediprog_set_leds(PASS_ON|BUSY_ON|ERROR_ON); > - > /* Perform basic setup. */ > if (dediprog_setup(target)) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > return 1; > } > > + /* Set all possible LEDs as soon as possible to indicate activity. > + * Because knowing the firmware version is required to set the LEDs correctly we need to this after > + * dediprog_setup() has queried the device and set dediprog_firmwareversion. */ > + dediprog_set_leds(LED_ALL); > + > /* After setting voltage and speed, perform setup again. */ > if (dediprog_set_spi_voltage(0) || dediprog_set_spi_speed(spispeed_idx) || dediprog_setup(target)) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > + dediprog_set_leds(LED_ERROR); > return 1; > } > > /* URB 11. Command Set SPI Voltage. */ > if (dediprog_set_spi_voltage(millivolt)) { > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > + dediprog_set_leds(LED_ERROR); > return 1; > } > > @@ -946,7 +943,7 @@ int dediprog_init(void) > dediprog_do_stuff(); > #endif > > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_OFF); > + dediprog_set_leds(LED_NONE); > > return 0; > } > -- > Kind regards, Stefan Tauner > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] [PATCH 2/5] dediprog: Tidy up commands and remove dead nonsense code.
by David Hendricks 28 Jun '15

28 Jun '15

Mostly looks good to me, just a couple minor comments. On Sun, Jun 21, 2015 at 6:37 PM, Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > Use names for the commands and request types instead of magic > numbers and remove some of the unnecessary unexplained arguments. > Also, cleanup the nonsense code left over from RE. Most of it can > not explained by official documentation and was recorded with > ancient firmware/software. > > Based on the following chromiumos changes: > Change-Id: I80a0dcdf40eedc89da48fb2c54cd9d9fd13e6fa1 > Change-Id: If61bac2c8194b3ec30a80422d871842c66f0cd74 > > Signed-off-by: Simon Glass <sjg(a)chromium.org> > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > --- > dediprog.c | 386 +++++++++++++++++++++---------------------------------------- > 1 file changed, 132 insertions(+), 254 deletions(-) > > diff --git a/dediprog.c b/dediprog.c > index b45e061..ce7ff7a 100644 > --- a/dediprog.c > +++ b/dediprog.c > @@ -2,6 +2,8 @@ > * This file is part of the flashrom project. > * > * Copyright (C) 2010 Carl-Daniel Hailfinger > + * Copyright (C) 2015 Simon Glass > + * Copyright (C) 2015 Stefan Tauner > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > @@ -38,13 +40,14 @@ > > #define FIRMWARE_VERSION(x,y,z) ((x << 16) | (y << 8) | z) > #define DEFAULT_TIMEOUT 3000 > +#define REQTYPE_OTHER_OUT (USB_ENDPOINT_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER) /* 0x43 */ > +#define REQTYPE_OTHER_IN (USB_ENDPOINT_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER) /* 0xC3 */ > +#define REQTYPE_EP_OUT (USB_ENDPOINT_OUT | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT) /* 0x42 */ > +#define REQTYPE_EP_IN (USB_ENDPOINT_IN | USB_TYPE_VENDOR | USB_RECIP_ENDPOINT) /* 0xC2 */ > static usb_dev_handle *dediprog_handle; > static int dediprog_firmwareversion; > static int dediprog_endpoint; > > -#define DEDI_SPI_CMD_PAGEWRITE 0x1 > -#define DEDI_SPI_CMD_AAIWRITE 0x4 > - > enum dediprog_leds { > LED_INVALID = -1, > LED_NONE = 0, > @@ -54,6 +57,77 @@ enum dediprog_leds { > LED_ALL = 7, > }; > > +/* IO bits for CMD_SET_IO_LED message */ > +enum dediprog_ios { > + IO1 = 1 << 0, > + IO2 = 1 << 1, > + IO3 = 1 << 2, > + IO4 = 1 << 3, > +}; > + > +enum dediprog_cmds { > + CMD_TRANSCEIVE = 0x01, > + CMD_POLL_STATUS_REG = 0x02, > + CMD_SET_VPP = 0x03, > + CMD_SET_TARGET = 0x04, > + CMD_READ_EEPROM = 0x05, > + CMD_WRITE_EEPROM = 0x06, > + CMD_SET_IO_LED = 0x07, > + CMD_READ_PROG_INFO = 0x08, > + CMD_SET_VCC = 0x09, > + CMD_SET_STANDALONE = 0x0A, > + CMD_GET_BUTTON = 0x11, > + CMD_GET_UID = 0x12, > + CMD_SET_CS = 0x14, > + CMD_IO_MODE = 0x15, > + CMD_FW_UPDATE = 0x1A, > + CMD_FPGA_UPDATE = 0x1B, > + CMD_READ_FPGA_VERSION = 0x1C, > + CMD_SET_HOLD = 0x1D, > + CMD_READ = 0x20, > + CMD_WRITE = 0x30, > + CMD_WRITE_AT45DB = 0x31, > + CMD_NAND_WRITE = 0x32, > + CMD_NAND_READ = 0x33, > + CMD_SET_SPI_CLK = 0x61, > + CMD_CHECK_SOCKET = 0x62, > + CMD_DOWNLOAD_PRJ = 0x63, > + CMD_READ_PRJ_NAME = 0x64, > + // New protocol/firmware only > + CMD_CHECK_SDCARD = 0x65, > + CMD_READ_PRJ = 0x66, > +}; > + > +enum dediprog_target { > + FLASH_TYPE_APPLICATION_FLASH_1 = 0, > + FLASH_TYPE_FLASH_CARD, > + FLASH_TYPE_APPLICATION_FLASH_2, FLASH_TYPE_SOCKET, /* SF600 */ > +}; > + > +enum dediprog_readmode { > + READ_MODE_STD = 1, > + READ_MODE_FAST = 2, > + READ_MODE_ATMEL45 = 3, > + READ_MODE_4B_ADDR_FAST = 4, > + READ_MODE_4B_ADDR_FAST_0x0C = 5, /* New protocol only */ > +}; > + > +enum dediprog_writemode { > + WRITE_MODE_PAGE_PGM = 1, > + WRITE_MODE_PAGE_WRITE = 2, > + WRITE_MODE_1B_AAI = 3, > + WRITE_MODE_2B_AAI = 4, > + WRITE_MODE_128B_PAGE = 5, > + WRITE_MODE_PAGE_AT26DF041 = 6, > + WRITE_MODE_SILICON_BLUE_FPGA = 7, > + WRITE_MODE_64B_PAGE_NUMONYX_PCM = 8, /* unit of length 512 bytes */ > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM = 9, > + WRITE_MODE_32B_PAGE_PGM_MXIC_512K = 10, /* unit of length 512 bytes */ > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12 = 11, 11 seems to only apply for the new protocol? The old protocol spec just says "For SF100" but I have no idea what that actually means. > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM_FLAGS = 12, > +}; > + > + > static int dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > > #if 0 > @@ -86,8 +160,6 @@ static struct usb_device *get_device_by_vid_pid(uint16_t vid, uint16_t pid, unsi > return NULL; > } > > -//int usb_control_msg(usb_dev_handle *dev, int requesttype, int request, int value, int index, char *bytes, int size, int timeout); > - > /* This function sets the GPIOs connected to the LEDs as well as IO1-IO4. */ > static int dediprog_set_leds(int leds) > { > @@ -110,7 +182,8 @@ static int dediprog_set_leds(int leds) > } > > target_leds ^= 7; > - int ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, NULL, 0x0, DEFAULT_TIMEOUT); > + int ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_SET_IO_LED, 0x09, target_leds, > + NULL, 0x0, DEFAULT_TIMEOUT); > if (ret != 0x0) { > msg_perr("Command Set LED 0x%x failed (%s)!\n", leds, usb_strerror()); > return 1; > @@ -149,8 +222,8 @@ static int dediprog_set_spi_voltage(int millivolt) > /* Wait some time as the original driver does. */ > programmer_delay(200 * 1000); > } > - ret = usb_control_msg(dediprog_handle, 0x42, 0x9, voltage_selector, > - 0xff, NULL, 0x0, DEFAULT_TIMEOUT); > + ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_SET_VCC, voltage_selector, 0, > + NULL, 0x0, DEFAULT_TIMEOUT); > if (ret != 0x0) { > msg_perr("Command Set SPI Voltage 0x%x failed!\n", > voltage_selector); > @@ -180,13 +253,6 @@ static const struct dediprog_spispeeds spispeeds[] = { > { NULL, 0x0 }, > }; > > -/* After dediprog_set_spi_speed, the original app always calls > - * dediprog_set_spi_voltage(0) and then > - * dediprog_check_devicestring() four times in a row. > - * After that, dediprog_command_a() is called. > - * This looks suspiciously like the microprocessor in the SF100 has to be > - * restarted/reinitialized in case the speed changes. > - */ > static int dediprog_set_spi_speed(unsigned int spispeed_idx) > { > if (dediprog_firmwareversion < FIRMWARE_VERSION(5, 0, 0)) { > @@ -194,12 +260,13 @@ static int dediprog_set_spi_speed(unsigned int spispeed_idx) > return 0; > } > > - msg_pdbg("SPI speed is %s Hz\n", spispeeds[spispeed_idx].name); > + const struct dediprog_spispeeds *spispeed = &spispeeds[spispeed_idx]; > + msg_pdbg("SPI speed is %sHz\n", spispeed->name); > > - int ret = usb_control_msg(dediprog_handle, 0x42, 0x61, spispeeds[spispeed_idx].speed, 0xff, > + int ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_SET_SPI_CLK, spispeed->speed, 0xff, > NULL, 0x0, DEFAULT_TIMEOUT); > if (ret != 0x0) { > - msg_perr("Command Set SPI Speed 0x%x failed!\n", spispeeds[spispeed_idx].speed); > + msg_perr("Command Set SPI Speed 0x%x failed!\n", spispeed->speed); > return 1; > } > return 0; > @@ -235,7 +302,7 @@ static int dediprog_spi_bulk_read(struct flashctx *flash, uint8_t *buf, > /* Command Read SPI Bulk. No idea which read command is used on the > * SPI side. > */ > - ret = usb_control_msg(dediprog_handle, 0x42, 0x20, start % 0x10000, > + ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_READ, start % 0x10000, > start / 0x10000, (char *)count_and_chunk, > sizeof(count_and_chunk), DEFAULT_TIMEOUT); > if (ret != sizeof(count_and_chunk)) { > @@ -344,7 +411,7 @@ static int dediprog_spi_bulk_write(struct flashctx *flash, const uint8_t *buf, u > /* Command Write SPI Bulk. No idea which write command is used on the > * SPI side. > */ > - ret = usb_control_msg(dediprog_handle, 0x42, 0x30, start % 0x10000, start / 0x10000, > + ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_WRITE, start % 0x10000, start / 0x10000, > (char *)count_and_cmd, sizeof(count_and_cmd), DEFAULT_TIMEOUT); > if (ret != sizeof(count_and_cmd)) { > msg_perr("Command Write SPI Bulk failed, %i %s!\n", ret, > @@ -422,12 +489,12 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > > static int dediprog_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len) > { > - return dediprog_spi_write(flash, buf, start, len, DEDI_SPI_CMD_PAGEWRITE); > + return dediprog_spi_write(flash, buf, start, len, WRITE_MODE_PAGE_PGM); > } > > static int dediprog_spi_write_aai(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len) > { > - return dediprog_spi_write(flash, buf, start, len, DEDI_SPI_CMD_AAIWRITE); > + return dediprog_spi_write(flash, buf, start, len, WRITE_MODE_2B_AAI); > } > > static int dediprog_spi_send_command(struct flashctx *flash, > @@ -439,29 +506,26 @@ static int dediprog_spi_send_command(struct flashctx *flash, > int ret; > > msg_pspew("%s, writecnt=%i, readcnt=%i\n", __func__, writecnt, readcnt); > - /* Paranoid, but I don't want to be blamed if anything explodes. */ > - if (writecnt > 16) { > - msg_perr("Untested writecnt=%i, aborting.\n", writecnt); > + if (writecnt > UINT16_MAX) { > + msg_perr("Invalid writecnt=%i, aborting.\n", writecnt); > return 1; > } > - /* 16 byte reads should work. */ > - if (readcnt > 16) { > - msg_perr("Untested readcnt=%i, aborting.\n", readcnt); > + if (readcnt > UINT16_MAX) { > + msg_perr("Invalid readcnt=%i, aborting.\n", readcnt); > return 1; > } > > - ret = usb_control_msg(dediprog_handle, 0x42, 0x1, 0xff, > - readcnt ? 0x1 : 0x0, (char *)writearr, writecnt, > - DEFAULT_TIMEOUT); > + ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_TRANSCEIVE, 0, readcnt ? 0x1 : 0x0, > + (char *)writearr, writecnt, DEFAULT_TIMEOUT); > if (ret != writecnt) { > msg_perr("Send SPI failed, expected %i, got %i %s!\n", > writecnt, ret, usb_strerror()); > return 1; > } > - if (!readcnt) > + if (readcnt == 0) > return 0; > - memset(readarr, 0, readcnt); > - ret = usb_control_msg(dediprog_handle, 0xc2, 0x01, 0xbb8, 0x0000, > + > + ret = usb_control_msg(dediprog_handle, REQTYPE_EP_IN, CMD_TRANSCEIVE, 0, 0, > (char *)readarr, readcnt, DEFAULT_TIMEOUT); > if (ret != readcnt) { > msg_perr("Receive SPI failed, expected %i, got %i %s!\n", > @@ -477,27 +541,27 @@ static int dediprog_check_devicestring(void) > int fw[3]; > char buf[0x11]; > > +#if 0 > /* Command Prepare Receive Device String. */ > - memset(buf, 0, sizeof(buf)); > - ret = usb_control_msg(dediprog_handle, 0xc3, 0x7, 0x0, 0xef03, buf, > - 0x1, DEFAULT_TIMEOUT); > + ret = usb_control_msg(dediprog_handle, REQTYPE_OTHER_IN, 0x7, 0x0, 0xef03, > + buf, 0x1, DEFAULT_TIMEOUT); > /* The char casting is needed to stop gcc complaining about an always true comparison. */ > if ((ret != 0x1) || (buf[0] != (char)0xff)) { > msg_perr("Unexpected response to Command Prepare Receive Device" > " String!\n"); > return 1; > } > +#endif > /* Command Receive Device String. */ > - memset(buf, 0, sizeof(buf)); > - ret = usb_control_msg(dediprog_handle, 0xc2, 0x8, 0xff, 0xff, buf, > - 0x10, DEFAULT_TIMEOUT); > + ret = usb_control_msg(dediprog_handle, REQTYPE_EP_IN, CMD_READ_PROG_INFO, 0, 0, > + buf, 0x10, DEFAULT_TIMEOUT); > if (ret != 0x10) { > msg_perr("Incomplete/failed Command Receive Device String!\n"); > return 1; > } > buf[0x10] = '\0'; > msg_pdbg("Found a %s\n", buf); > - if (memcmp(buf, "SF100", 0x5)) { > + if (memcmp(buf, "SF100", 0x5) != 0) { > msg_perr("Device not a SF100!\n"); > return 1; > } > @@ -515,24 +579,20 @@ static int dediprog_check_devicestring(void) > return 0; > } > > -/* Command A seems to be some sort of device init. It is either followed by > - * dediprog_check_devicestring (often) or Command A (often) or > - * Command F (once). > - */ > -static int dediprog_command_a(void) > +static int dediprog_device_init(void) > { > int ret; > char buf[0x1]; > > memset(buf, 0, sizeof(buf)); > - ret = usb_control_msg(dediprog_handle, 0xc3, 0xb, 0x0, 0x0, buf, > - 0x1, DEFAULT_TIMEOUT); > + ret = usb_control_msg(dediprog_handle, REQTYPE_OTHER_IN, 0x0B, 0x0, 0x0, > + buf, 0x1, DEFAULT_TIMEOUT); > if (ret < 0) { > msg_perr("Command A failed (%s)!\n", usb_strerror()); > return 1; > } > if ((ret != 0x1) || (buf[0] != 0x6f)) { > - msg_perr("Unexpected response to Command A!\n"); > + msg_perr("Unexpected response to init!\n"); > return 1; > } > return 0; > @@ -548,9 +608,8 @@ static int dediprog_command_b(void) > int ret; > char buf[0x3]; > > - memset(buf, 0, sizeof(buf)); > - ret = usb_control_msg(dediprog_handle, 0xc3, 0x7, 0x0, 0xef00, buf, > - 0x3, DEFAULT_TIMEOUT); > + ret = usb_control_msg(dediprog_handle, REQTYPE_OTHER_IN, 0x7, 0x0, 0xef00, > + buf, 0x3, DEFAULT_TIMEOUT); > if (ret < 0) { > msg_perr("Command B failed (%s)!\n", usb_strerror()); > return 1; > @@ -565,120 +624,29 @@ static int dediprog_command_b(void) > } > #endif > > -/* Command Chip Select is only sent after dediprog_check_devicestring, but not after every > - * invocation of dediprog_check_devicestring. It is only sent after the first > - * dediprog_command_a(); dediprog_check_devicestring() sequence in each session. > - * Bit #1 of the value changes the chip select: 0 is target 1, 1 is target 2 and parameter target can be 1 or 2 > - * respectively. We don't know how to encode "3, Socket" and "0, reference card" yet. On SF100 the vendor > - * software "DpCmd 6.0.4.06" selects target 2 when requesting 3 (which is unavailable on that hardware). > - */ > -static int dediprog_chip_select(int target) > +static int set_target_flash(enum dediprog_target target) > { > - int ret; > - uint16_t value = ((target - 1) & 1) << 1; > - msg_pdbg("Selecting target chip %i\n", target); > - ret = usb_control_msg(dediprog_handle, 0x42, 0x4, value, 0x0, NULL, > - 0x0, DEFAULT_TIMEOUT); > - if (ret != 0x0) { > - msg_perr("Command Chip Select failed (%s)!\n", usb_strerror()); > + int ret = usb_control_msg(dediprog_handle, REQTYPE_EP_OUT, CMD_SET_TARGET, target, 0, > + NULL, 0, DEFAULT_TIMEOUT); > + if (ret != 0) { > + msg_perr("set_target_flash failed (%s)!\n", usb_strerror()); > return 1; > } > return 0; > } > > #if 0 > -/* Very strange. Seems to be a programmer keepalive or somesuch. > - * Wait unsuccessfully for timeout ms to read one byte. > - * Is usually called after setting voltage to 0. > - * Present in all logs with Firmware 2.1.1 and 3.1.8 > - */ > -static int dediprog_command_f(int timeout) > +/* Returns true if the button is currently pressed. */ > +static bool dediprog_get_button(void) > { > - int ret; > - char buf[0x1]; > - > - memset(buf, 0, sizeof(buf)); > - ret = usb_control_msg(dediprog_handle, 0xc2, 0x11, 0xff, 0xff, buf, > - 0x1, timeout); > - /* This check is most probably wrong. Command F always causes a timeout > - * in the logs, so we should check for timeout instead of checking for > - * success. > - */ > - if (ret != 0x1) { > - msg_perr("Command F failed (%s)!\n", usb_strerror()); > - return 1; > - } > - return 0; > -} > - > -/* Start/stop blinking? > - * Present in eng_detect_blink.log with firmware 3.1.8 > - * Preceded by Command J > - */ > -static int dediprog_command_g(void) > -{ > - int ret; > - > - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x03, NULL, 0x0, DEFAULT_TIMEOUT); > - if (ret != 0x0) { > - msg_perr("Command G failed (%s)!\n", usb_strerror()); > - return 1; > - } > - return 0; > -} > - > -/* Something. > - * Present in all logs with firmware 5.1.5 > - * Always preceded by Command Receive Device String > - * Always followed by Command Set SPI Voltage nonzero > - */ > -static int dediprog_command_h(void) > -{ > - int ret; > - > - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x05, NULL, 0x0, DEFAULT_TIMEOUT); > - if (ret != 0x0) { > - msg_perr("Command H failed (%s)!\n", usb_strerror()); > + char buf[1]; > + int ret = usb_control_msg(dediprog_handle, REQTYPE_EP_IN, CMD_GET_BUTTON, 0, 0, > + buf, 0x1, DEFAULT_TIMEOUT); > + if (ret != 0) { > + msg_perr("Could not get button state (%s)!\n", usb_strerror()); > return 1; > } > - return 0; > -} > - > -/* Shutdown for firmware 5.x? > - * Present in all logs with firmware 5.1.5 > - * Often preceded by a SPI operation (Command Read SPI Bulk or Receive SPI) > - * Always followed by Command Set SPI Voltage 0x0000 > - */ > -static int dediprog_command_i(void) > -{ > - int ret; > - > - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x06, NULL, 0x0, DEFAULT_TIMEOUT); > - if (ret != 0x0) { > - msg_perr("Command I failed (%s)!\n", usb_strerror()); > - return 1; > - } > - return 0; > -} > - > -/* Start/stop blinking? > - * Present in all logs with firmware 5.1.5 > - * Always preceded by Command Receive Device String on 5.1.5 > - * Always followed by Command Set SPI Voltage nonzero on 5.1.5 > - * Present in eng_detect_blink.log with firmware 3.1.8 > - * Preceded by Command B in eng_detect_blink.log > - * Followed by Command G in eng_detect_blink.log > - */ > -static int dediprog_command_j(void) > -{ > - int ret; > - > - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x07, NULL, 0x0, DEFAULT_TIMEOUT); > - if (ret != 0x0) { > - msg_perr("Command J failed (%s)!\n", usb_strerror()); > - return 1; > - } > - return 0; > + return buf[0] != 1; > } > #endif > > @@ -730,28 +698,6 @@ static int parse_voltage(char *voltage) > return millivolt; > } > > -static int dediprog_setup(long target) > -{ > - /* URB 6. Command A. */ > - if (dediprog_command_a()) { > - return 1; > - } > - /* URB 7. Command A. */ > - if (dediprog_command_a()) { > - return 1; > - } > - /* URB 8. Command Prepare Receive Device String. */ > - /* URB 9. Command Receive Device String. */ > - if (dediprog_check_devicestring()) { > - return 1; > - } > - /* URB 10. Command Chip Select */ > - if (dediprog_chip_select(target)) { > - return 1; > - } > - return 0; > -} > - > static const struct spi_master spi_master_dediprog = { > .type = SPI_CONTROLLER_DEDIPROG, > .max_data_read = MAX_DATA_UNSPECIFIED, > @@ -767,13 +713,6 @@ static int dediprog_shutdown(void *data) > { > msg_pspew("%s\n", __func__); > > -#if 0 > - /* Shutdown on firmware 5.x */ > - if (dediprog_firmwareversion == 5) > - if (dediprog_command_i()) > - return 1; > -#endif > - > dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > > /* URB 28. Command Set SPI Voltage to 0. */ > @@ -819,6 +758,7 @@ int dediprog_init(void) > } > free(spispeed); > } > + > voltage = extract_programmer_param("voltage"); > if (voltage) { > millivolt = parse_voltage(voltage); > @@ -914,90 +854,28 @@ int dediprog_init(void) > return 1; > > /* Perform basic setup. */ > - if (dediprog_setup(target)) { > + if (dediprog_device_init()) > + return 1; > + if (dediprog_check_devicestring()) > return 1; > - } > > /* Set all possible LEDs as soon as possible to indicate activity. > * Because knowing the firmware version is required to set the LEDs correctly we need to this after > * dediprog_setup() has queried the device and set dediprog_firmwareversion. */ > dediprog_set_leds(LED_ALL); > > - /* After setting voltage and speed, perform setup again. */ > - if (dediprog_set_spi_voltage(0) || dediprog_set_spi_speed(spispeed_idx) || dediprog_setup(target)) { > - dediprog_set_leds(LED_ERROR); > - return 1; > - } > - > - /* URB 11. Command Set SPI Voltage. */ > - if (dediprog_set_spi_voltage(millivolt)) { > + /* Select target/socket, frequency and VCC. */ > + if (set_target_flash(FLASH_TYPE_APPLICATION_FLASH_1) || > + dediprog_set_spi_speed(spispeed_idx) || > + dediprog_set_spi_voltage(millivolt)) { > dediprog_set_leds(LED_ERROR); > return 1; > } > > register_spi_master(&spi_master_dediprog); > > - /* RE leftover, leave in until the driver is complete. */ > -#if 0 > - /* Execute RDID by hand if you want to test it. */ > - dediprog_do_stuff(); > -#endif > - > dediprog_set_leds(LED_NONE); > > return 0; > } > > -#if 0 > -/* Leftovers from reverse engineering. Keep for documentation purposes until > - * completely understood. > - */ > -static int dediprog_do_stuff(void) > -{ > - char buf[0x4]; > - /* SPI command processing starts here. */ > - > - /* URB 12. Command Send SPI. */ > - /* URB 13. Command Receive SPI. */ > - memset(buf, 0, sizeof(buf)); > - /* JEDEC RDID */ > - msg_pdbg("Sending RDID\n"); > - buf[0] = JEDEC_RDID; > - if (dediprog_spi_send_command(JEDEC_RDID_OUTSIZE, JEDEC_RDID_INSIZE, > - (unsigned char *)buf, (unsigned char *)buf)) > - return 1; > - msg_pdbg("Receiving response: "); > - print_hex(buf, JEDEC_RDID_INSIZE); > - /* URB 14-27 are more SPI commands. */ > - /* URB 28. Command Set SPI Voltage. */ > - if (dediprog_set_spi_voltage(0x0)) > - return 1; > - /* URB 29-38. Command F, unsuccessful wait. */ > - if (dediprog_command_f(544)) > - return 1; > - /* URB 39. Command Set SPI Voltage. */ > - if (dediprog_set_spi_voltage(0x10)) > - return 1; > - /* URB 40. Command Set SPI Speed. */ > - if (dediprog_set_spi_speed(0x2)) > - return 1; > - /* URB 41 is just URB 28. */ > - /* URB 42,44,46,48,51,53 is just URB 8. */ > - /* URB 43,45,47,49,52,54 is just URB 9. */ > - /* URB 50 is just URB 6/7. */ > - /* URB 55-131 is just URB 29-38. (wait unsuccessfully for 4695 (maybe 4751) ms)*/ > - /* URB 132,134 is just URB 6/7. */ > - /* URB 133 is just URB 29-38. */ > - /* URB 135 is just URB 8. */ > - /* URB 136 is just URB 9. */ > - /* URB 137 is just URB 11. */ > - > - /* Command Start Bulk Read. Data is u16 blockcount, u16 blocksize. */ > - /* Command Start Bulk Write. Data is u16 blockcount, u16 blocksize. */ > - /* Bulk transfer sizes for Command Start Bulk Read/Write are always > - * 512 bytes, rest is filled with 0xff. > - */ > - > - return 0; > -} > -#endif > -- > Kind regards, Stefan Tauner > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] 404 error on link to precompiled windows exe
by Idwer Vollering 27 Jun '15

27 Jun '15

Hi, 2015-06-25 12:52 GMT+02:00 Michael Ayles <michael.ayles(a)ttelectronics-ims.com>: > Hi, > > I’m a test development engineer and one of our clients has developed a board > with an EON EN25F20 SPI Flash. They provided a Bus Pirate and the firmware > file to be programmed and told us they use linux with flashrom to program > the parts. > > Unfortunately the test solution we have developed runs windows for our test > solution. I’ve been unable to find a valid link to a precompiled executable > of flashrom for windows. The link on the (flashrom.org/windows) page > (http://ra.openbios.org/~idwer/flashrom/mingw/) returns a 404 error. Indeed. Server configuration (which is outside my control) has rendered this URL unreahable. However, you can find win32 builds over here: http://buildbot.flashrom.org/buildresults/ > > Could you please help me locate a .exe, I’m more of a hardware guy than > software and am struggling with the MINGW stuff. You can find an (alpha quality) prebuilt .exe here: http://buildbot.flashrom.org/buildresults/flashrom-000174-CcG/win32/ If you wish to reproduce the build yourself, here are in-a-nutshell instructions: http://flashrom.org/Windows#Building_.28cross-compiling.29_flashrom_on_Linu…. > > Many thanks, > > > > Michael Ayles > > Test Development Engineer > > > > IMS Testing Solutions (Abtest) > > Abtest Ltd is a UKAS approved facility : Accreditation Number 0042 > > Tregwilym Industrial Estate, Rogerstone, Newport, South Wales, UK, NP10 9YA > > T: +44 (0) 1443 290030 F: +44 (0) 1633 892770 > > E: Michael.Ayles(a)ttelectronics-ims.com > > > > www.abtest.com > > > > Abtest Ltd. Registration Number 620992 trading as IMS Testing Solutions > > > > General Note: Please be aware,due to new security requirements , all visits > to Abtest must be booked in at least 24 hours in advance. > > > > Confidentiality Notice: > > > > This message is private and confidential. If received in error, please > destroy and notify sender. Sender does not intend to waive confidentiality > or privilege. Dissemination, use of or reliance upon this email is > prohibited when received in error. Email may be susceptible to data > corruption, interception and unauthorised amendment, and no liability is > accepted by the sender for any of the foregoing. It is the recipient’s > responsibility to scan the email and any attachment for viruses. flashrom is open source software (GPL), and its mailing list is public as well. Meeting such confidentiality disclaimers is impossible. See http://www.flashrom.org/pipermail/flashrom/ HTH, Idwer > > > > TT electronics integrated manufacturing services Limited is a company > registered in England and Wales. > > Registered number: 896672 > > Registered Office: Tregwilym Industrial Estate, Rogerstone, Newport, South > Wales, NP10 9YA, UK > > > > Please consider your environmental responsibility before printing this > e-mail > > > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] MX25L6445E erase and write failed!
by Stefan Tauner 26 Jun '15

26 Jun '15

On Wed, 4 Mar 2015 11:32:04 +0200 Urja Rannikko <urjaman(a)gmail.com> wrote: > Hi, > > > I've an idea. Maybe you've managed to switch the MX25L6445E into the > > "individual block protection mode" (read the datasheet page 30 - its > > an OTP, once done once its for good) and now it isnt actually > > erasing/writing anything at all (that 1M just happens to have > > succeeded previously) because flashrom currently doesnt know of the > > invidividual block unlock commands (or even the GBULK gang block > > unlock) and thinks everything is ok because the status register looks > > like unlocked. > > > > So maybe read the current contents into a file and modify a little bit > > in the erased area (eg. swap out the first 4k to random data*) and see > > if it writes. My theory is it wont. > > > > *here's example commands: > > flashrom <insert your parameters> -r current.bin > > dd if=/dev/urandom of=4krandom.bin bs=1024 count=4 > > dd if=current.bin bs=1024 skip=4 of=current-4.bin > > cat 4krandom.bin current-4.bin > modified.bin > > flashrom <parameters> -w modified.bin > > > > Somebody'd need to write a patch to flashrom to use the RDSCUR command > > to see if WPSEL is set to see for sure. But support for this wouldnt > > hurt anyways. I'll see if i have time later in the evening to make a > > prototype/test patch for this... > > I already had the datasheet open, so... here it is (in slightly crude form). > https://github.com/urjaman/flashrom/commit/b51f09e5f21bf14d492c7d006e0bdd86… > there's the commit if somebody wants to just web see. > To test, in the flashrom-serprog git tree you have: > git pull > git checkout mx25l6445e-debug > make > ./flashrom ... Hi, was this ever tested? I have a MX25L25635F which is yet unsupported due to the larger address space etc. and I could test this eventually some time in the future... but I would prefer to get support for this into flashrom earlier than that (2016? :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

404 error on link to precompiled windows exe
by Michael Ayles 25 Jun '15

25 Jun '15

Hi, I'm a test development engineer and one of our clients has developed a board with an EON EN25F20 SPI Flash. They provided a Bus Pirate and the firmware file to be programmed and told us they use linux with flashrom to program the parts. Unfortunately the test solution we have developed runs windows for our test solution. I've been unable to find a valid link to a precompiled executable of flashrom for windows. The link on the (flashrom.org/windows) page (http://ra.openbios.org/~idwer/flashrom/mingw/) returns a 404 error. Could you please help me locate a .exe, I'm more of a hardware guy than software and am struggling with the MINGW stuff. Many thanks, Michael Ayles Test Development Engineer IMS Testing Solutions (Abtest) Abtest Ltd is a UKAS approved facility : Accreditation Number 0042 Tregwilym Industrial Estate, Rogerstone, Newport, South Wales, UK, NP10 9YA T: +44 (0) 1443 290030 F: +44 (0) 1633 892770 E: Michael.Ayles(a)ttelectronics-ims.com www.abtest.com<http://www.abtest.com/> Abtest Ltd. Registration Number 620992 trading as IMS Testing Solutions General Note: Please be aware,due to new security requirements , all visits to Abtest must be booked in at least 24 hours in advance. Confidentiality Notice: This message is private and confidential. If received in error, please destroy and notify sender. Sender does not intend to waive confidentiality or privilege. Dissemination, use of or reliance upon this email is prohibited when received in error. Email may be susceptible to data corruption, interception and unauthorised amendment, and no liability is accepted by the sender for any of the foregoing. It is the recipient's responsibility to scan the email and any attachment for viruses. TT electronics integrated manufacturing services Limited is a company registered in England and Wales. Registered number: 896672 Registered Office: Tregwilym Industrial Estate, Rogerstone, Newport, South Wales, NP10 9YA, UK Please consider your environmental responsibility before printing this e-mail

1 0

Re: [flashrom] external programmer
by Stefan Tauner 23 Jun '15

23 Jun '15

On Sun, 21 Jun 2015 14:35:33 +0300 Julian Shulika <hercares(a)gmail.com> wrote: > Hello! Please, advise external programmer which can be bought on ebay or > aliexpress. Thank you Any supported by flashrom if you don't plan to use it all the time (like for firmware development). Otherwise it depends very much on the use cases... for coreboot development I would recommend a Beaglebone Black because it is very versatile (e.g. works as EHCI debug device too), fast and not too expensive. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Reading the GPU ROM on a mid-2014 15" rMBP from Linux/Mac
by Stefan Tauner 23 Jun '15

23 Jun '15

On Tue, 23 Jun 2015 14:09:02 +0800 Ry <ryanblonna3(a)gmail.com> wrote: > Hi Stefan, > > Thank your very much! I was able to extract the ROM using the mapped memory > method listed at the end of that article. I am sort of bummed out by the > generated ROM file however, because it does not seem to support EFI > according to this article: > http://vfio.blogspot.com/2014/08/does-my-graphics-card-rom-support-efi.html. > Does this sound right? > I have no idea, sorry. I don't see how the EFI support of the VBIOS is related to QEMU pass-through at all... but in any case, I can't help you with that. Asking the QEMU or KVM guys is probably a better option. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Reading the GPU ROM on a mid-2014 15" rMBP from Linux/Mac
by Stefan Tauner 23 Jun '15

23 Jun '15

Hello Ryan, you might be able to achieve what you want by following one of the procedures described in the coreboot wiki, especially http://coreboot.org/VGA_support#UEFI_Method Good luck! -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

[PATCH] spi25: ignore 0x00 as a manufacturer id in the generic match
by Urja Rannikko 23 Jun '15

23 Jun '15

Saying that manufacturer id 0x00 is an "unknown SPI chip" just confuses people with external programmers without a proper connection to a chip and makes them think flashrom doesnt support the chip they're trying to use. Also causes unnecessary -c requirement with a multiple-slot (FWH/LPC and SPI) serprog device i was testing. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- spi25.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spi25.c b/spi25.c index 673bdf5..af4b6db 100644 --- a/spi25.c +++ b/spi25.c @@ -156,7 +156,7 @@ static int probe_spi_rdid_generic(struct flashctx *flash, int bytes) return 1; /* Test if there is any vendor ID. */ - if (GENERIC_MANUF_ID == chip->manufacture_id && id1 != 0xff) + if (GENERIC_MANUF_ID == chip->manufacture_id && id1 != 0xff && id1 != 0x00) return 1; return 0; @@ -212,7 +212,7 @@ int probe_spi_rems(struct flashctx *flash) return 1; /* Test if there is any vendor ID. */ - if (GENERIC_MANUF_ID == chip->manufacture_id && id1 != 0xff) + if (GENERIC_MANUF_ID == chip->manufacture_id && id1 != 0xff && id1 != 0x00) return 1; return 0; -- 2.3.1

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom