flashrom June 2015

flashrom@flashrom.org

30 participants
88 discussions

need a windows snapshot for flashrom v 0.9.8 or v 0.9.7
by David G ZHAO 01 Jul '15

01 Jul '15

Dear sir, My name is David Zhao, from Sydney Australia. I was using buspirate for writting firmware for bios on the motherboard. The flashrom I used is 0.9.6.1 only. I did check your link for the new version of flashrom v 0.9.8. I tried a few days to compile version 0.9.8 from your source code, but not being successful. I also notice the snapshots url http://ra.openbios.org/~idwer/flashrom/mingw/ <http://ra.openbios.org/%7Eidwer/flashrom/mingw/> can not be opened. Now I am asking you a big favour, can you please email me the snapshots for the windows command line version (for v0.9.8 or v0.9.7)? Your help is much appreciated Kind regards David Zhao

2 1

Re: [flashrom] [PATCH 1/5] dediprog: Invert the LED polarity in the code.
by Stefan Tauner 01 Jul '15

01 Jul '15

On Sat, 27 Jun 2015 17:24:55 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Acked-by: David Hendricks <dhendrix(a)chromium.org> Thanks David. I have committed a slightly revised version in r1894 after realising that there are two mistakes in the proposed change. dediprog_firmwareversion was defined already, it was simply initialized in the hunk below to some (in)sane default. However, this should not happen at all in this patch but a later one. > > @@ -45,6 +45,17 @@ static int dediprog_endpoint; > > #define DEDI_SPI_CMD_PAGEWRITE 0x1 > > #define DEDI_SPI_CMD_AAIWRITE 0x4 > > > > +enum dediprog_leds { > > + LED_INVALID = -1, > > + LED_NONE = 0, > > + LED_PASS = 1 << 0, > > + LED_BUSY = 1 << 1, > > + LED_ERROR = 1 << 2, > > + LED_ALL = 7, > > +}; > > + > > +static int dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > > + > > #if 0 > > /* Might be useful for other pieces of code as well. */ > > static void print_hex(void *buf, size_t len) The else path below was simply wrong. > > @@ -406,10 +399,10 @@ static int dediprog_spi_write(struct flashctx *flash, const uint8_t *buf, > > /* Round down. */ > > bulklen = (len - residue) / chunksize * chunksize; > > ret = dediprog_spi_bulk_write(flash, buf + residue, chunksize, start + residue, bulklen, dedi_spi_cmd); > > - if (ret) { > > - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); > > - return ret; > > - } > > + if (ret) > > + dediprog_set_leds(LED_ERROR); > > + else > > + dediprog_set_leds(LED_PASS); > > > > len -= residue + bulklen; > > if (len) { This ensures the firmware version is reset at shutdown, but this has nothing to do with the LEDs handling... > > @@ -781,6 +774,8 @@ static int dediprog_shutdown(void *data) > > return 1; > > #endif > > > > + dediprog_firmwareversion = FIRMWARE_VERSION(0, 0, 0); > > + > > /* URB 28. Command Set SPI Voltage to 0. */ > > if (dediprog_set_spi_voltage(0x0)) > > return 1; -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

C232HM + MX25L1606E
by an jacker 30 Jun '15

30 Jun '15

flashrom v0.9.7-r1711 on Linux 3.11.0-15-generic (i686) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.8, GCC 4.6.3, little endian Command line (3 args): flashrom -p ft2232_spi:type=232H -V Calibrating delay loop... OS timer resolution is 1 usecs, 3356M loops per second, 10 myus = 9 us, 100 myus = 93 us, 1000 myus = 999 us, 10000 myus = 10557 us, 4 myus = 4 us, OK. Initializing ft2232_spi programmer Using device type FTDI FT232H channel A. FTDI chip type 1 is not high-speed. Set clock divisor MPSSE clock: 12.000000 MHz, divisor: 2, SPI clock: 6.000000 MHz No loopback of TDI/DO TDO/DI Set data bits The following protocols are supported: SPI. Probing for AMIC A25L05PT, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L05PU, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L10PT, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L10PU, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L20PT, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L20PU, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L40PT, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L40PU, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L80P, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L16PT, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L16PU, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L512, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L010, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L020, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L080, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L016, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25L032, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25LQ16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25LQ032/A25LQ32A, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for AMIC A25LQ64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF021, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF041A, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF081, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF081A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF161, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF321, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF321A, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DF641(A), 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25DQ161, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25F512, 64 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F512A, 64 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F512B, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25F1024(A), 128 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F2048, 256 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25F4096, 512 kB: probe_spi_at25f: id1 0x00, id2 0x00 Probing for Atmel AT25FS010, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT25FS040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF041, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF081A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF161, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26DF161A, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT26F004, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45CS1282, 16896 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB011D, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB021D, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB041D, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB081D, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB161D, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB321C, 4224 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB321D, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel AT45DB642D, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for ESMT F25L008A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B05, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B05T, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B10T, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B20T, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B40T, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B80T, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B16T, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B32T, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25B64T, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F05, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25F64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q80(A), 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q32(A/B), 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25Q128, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25QH128, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon EN25S64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25LQ32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q512, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q20(B), 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q40(B), 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q80(B), 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q16(B), 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q32(B), 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q64(B), 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25Q128B, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for GigaDevice GD25T80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F160S33B8, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F160S33T8, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F320S33B8, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F320S33T8, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F640S33B8, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Intel 25F640S33T8, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L512(E)/MX25V512(C), 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1005(C)/MX25L1006E, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L2005(C), 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L4005(A/C), 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L8005/MX25V8005, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1605, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1605A/MX25L1606E, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1605D/MX25L1608D, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1635D, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L1635E, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3205(A), 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3205D/MX25L3208D, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3206E, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L3235D, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L6405(D), 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L6406E/MX25L6436E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L6445E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25L12805(D), 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25U1635E, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25U3235E/F, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix MX25U6435E/F, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P05-A, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P05, 64 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P10-A, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P10, 128 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P20-old, 256 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P40-old, 512 kB: probe_spi_res1: id 0x0 Probing for Micron/Numonyx/ST M25P80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25P128, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PE16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M25PX64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST M45PE16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q016, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q032..1E, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q032..3E, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q064..1E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q064..3E, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q128..1E, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Micron/Numonyx/ST N25Q128..3E, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Nantronics N25S16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD256C, 32 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD512(C), 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD010(C), 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD020(C), 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LD040(C), 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV512(A), 64 kB: probe_spi_res3: id1 0x0, id2 0x0 Probing for PMC Pm25LV010, 128 kB: probe_spi_res3: id1 0x0, id2 0x0 Probing for PMC Pm25LV010A, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV020, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV080B, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC Pm25LV016B, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo LE25FW203A, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo LE25FW403A, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo LE25FW418A, 512 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for Sanyo LE25FW806, 1024 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for Sanyo LE25FW808, 1024 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for Spansion S25FL004A, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL008A, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL016A, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL032A/P, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL064A/P, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL204K, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL208K, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL116K/S25FL216K, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Spansion S25FL128S......0, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25LF040A, 512 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for SST SST25LF080(A), 1024 kB: probe_spi_res2: id1 0x0, id2 0x0 Probing for SST SST25VF010, 128 kB: probe_spi_rems: id1 0x0, id2 0x0 Probing for SST SST25VF016B, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF032B, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF064C, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF040, 512 kB: probe_spi_rems: id1 0x0, id2 0x0 Probing for SST SST25VF040B, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0x0, id2 0x0 Probing for SST SST25VF080B, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF512, 64 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF010, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF020, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST SST25WF040, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q80.V, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q16.V, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q32.V, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q64.V, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q128.V, 16384 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q20.W, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q40.W, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q80.W, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q16.W, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q32.W, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25Q64.W, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X10, 128 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X20, 256 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X40, 512 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X80, 1024 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X16, 2048 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X32, 4096 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond W25X64, 8192 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Unknown SFDP-capable chip, 0 kB: No SFDP signature found. Probing for AMIC unknown AMIC SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Atmel unknown Atmel SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Eon unknown Eon SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Macronix unknown Macronix SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for PMC unknown PMC SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for SST unknown SST SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for ST unknown ST SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Winbond unknown Winbond (ex Nexcom) SPI chip, 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Probing for Generic unknown SPI chip (RDID), 0 kB: RDID byte 0 parity violation. probe_spi_rdid_generic: id1 0x00, id2 0x00 Found Generic flash chip "unknown SPI chip (RDID)" (0 kB, SPI) on ft2232_spi. Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0x0, id2 0x0 Found Generic flash chip "unknown SPI chip (RDID)" (0 kB, SPI). === This flash part has status NOT WORKING for operations: PROBE READ ERASE WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -VE, -Vw), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! No operations were specified.

1 0

Re: [flashrom] [PATCH v2] serprog: Fix FWH/LPC by implementing serprog_map
by Stefan Tauner 30 Jun '15

30 Jun '15

Thanks Urja for the explanation. I have refined the comments and committed the result in r1895. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1895 - trunk
by repository service 30 Jun '15

30 Jun '15

Author: stefanct Date: Tue Jun 30 01:24:23 2015 New Revision: 1895 URL: http://flashrom.org/trac/flashrom/changeset/1895 Log: serprog: Fix FWH/LPC by implementing serprog_map. The serprog protocol does only transmit 24 bit-wide address and ignores the top 8 bit. This is fine as long as the underlying hardware ignores the latter anyway (which is the case for parallel chips that even lack the respective pins). FWH/LPC chips, however, operate on a full 32-bit (LPC) or 28-bit (FWH) address space and would fail with the fallback mapping to NULL. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/flashrom.c trunk/programmer.h trunk/serprog.c Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Sun Jun 28 15:31:19 2015 (r1894) +++ trunk/flashrom.c Tue Jun 30 01:24:23 2015 (r1895) @@ -212,7 +212,7 @@ /* FIXME */ .devs.note = "All programmer devices speaking the serprog protocol\n", .init = serprog_init, - .map_flash_region = fallback_map, + .map_flash_region = serprog_map, .unmap_flash_region = fallback_unmap, .delay = serprog_delay, }, Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Sun Jun 28 15:31:19 2015 (r1894) +++ trunk/programmer.h Tue Jun 30 01:24:23 2015 (r1895) @@ -706,6 +706,7 @@ #if CONFIG_SERPROG == 1 int serprog_init(void); void serprog_delay(unsigned int usecs); +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len); #endif /* serial.c */ Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Sun Jun 28 15:31:19 2015 (r1894) +++ trunk/serprog.c Tue Jun 30 01:24:23 2015 (r1895) @@ -943,3 +943,19 @@ } return 0; } + +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len) +{ + /* Serprog transmits 24 bits only and assumes the underlying implementation handles any remaining bits + * correctly (usually setting them to one either in software (for FWH/LPC) or relying on the fact that + * the hardware observes a subset of the address bits only). Combined with the standard mapping of + * flashrom this creates a 16 MB-wide window just below the 4 GB boundary where serprog can operate (as + * needed for non-SPI chips). Below we make sure that the requested range is within this window. */ + if ((phys_addr & 0xFF000000) == 0xFF000000) { + return (void*)phys_addr; + } else { + msg_pwarn(MSGHEADER "requested mapping %s is incompatible: 0x%zx bytes at 0x%0*" PRIxPTR ".\n", + descr, len, PRIxPTR_WIDTH, phys_addr); + return NULL; + } +}

1 0

[PATCH v2] serprog: Fix FWH/LPC by implementing serprog_map
by Urja Rannikko 29 Jun '15

29 Jun '15

also make serprog_map report if mapping doesnt fit in the 24-bit address space of serprog. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- The previous version didnt compile on 64-bit because size_t and -Werror ... thus v2. --- flashrom.c | 2 +- programmer.h | 1 + serprog.c | 12 ++++++++++++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/flashrom.c b/flashrom.c index a389cb2..d51a44c 100644 --- a/flashrom.c +++ b/flashrom.c @@ -212,7 +212,7 @@ const struct programmer_entry programmer_table[] = { /* FIXME */ .devs.note = "All programmer devices speaking the serprog protocol\n", .init = serprog_init, - .map_flash_region = fallback_map, + .map_flash_region = serprog_map, .unmap_flash_region = fallback_unmap, .delay = serprog_delay, }, diff --git a/programmer.h b/programmer.h index 913522b..3bf292d 100644 --- a/programmer.h +++ b/programmer.h @@ -706,6 +706,7 @@ int register_master(const struct registered_master *mst); #if CONFIG_SERPROG == 1 int serprog_init(void); void serprog_delay(unsigned int usecs); +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len); #endif /* serial.c */ diff --git a/serprog.c b/serprog.c index 3de0182..8e4286a 100644 --- a/serprog.c +++ b/serprog.c @@ -943,3 +943,15 @@ static int serprog_spi_read(struct flashctx *flash, uint8_t *buf, } return 0; } + +void *serprog_map(const char *descr, uintptr_t phys_addr, size_t len) +{ + if ((phys_addr & 0xFF000000) == 0xFF000000) { + /* This is normal, no need to report anything. */ + return (void*)phys_addr; + } else { + msg_pwarn(MSGHEADER "incompatible mapping %s, 0x%zx bytes at 0x%0*" PRIxPTR ", returning NULL\n", + descr, len, PRIxPTR_WIDTH, phys_addr); + return NULL; + } +} -- 2.3.1

2 2

Re: [flashrom] [PATCH 2/5] dediprog: Tidy up commands and remove dead nonsense code.
by Stefan Tauner 29 Jun '15

29 Jun '15

On Sat, 27 Jun 2015 17:24:43 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Mostly looks good to me, just a couple minor comments. > > > + > > +enum dediprog_target { > > + FLASH_TYPE_APPLICATION_FLASH_1 = 0, > > + FLASH_TYPE_FLASH_CARD, > > + FLASH_TYPE_APPLICATION_FLASH_2, > > > FLASH_TYPE_SOCKET, /* SF600 */ Thank you. > > + > > +enum dediprog_writemode { > > + WRITE_MODE_PAGE_PGM = 1, > > + WRITE_MODE_PAGE_WRITE = 2, > > + WRITE_MODE_1B_AAI = 3, > > + WRITE_MODE_2B_AAI = 4, > > + WRITE_MODE_128B_PAGE = 5, > > + WRITE_MODE_PAGE_AT26DF041 = 6, > > + WRITE_MODE_SILICON_BLUE_FPGA = 7, > > + WRITE_MODE_64B_PAGE_NUMONYX_PCM = 8, /* unit of length 512 bytes */ > > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM = 9, > > + WRITE_MODE_32B_PAGE_PGM_MXIC_512K = 10, /* unit of length 512 bytes */ > > + WRITE_MODE_4B_ADDR_256B_PAGE_PGM_0x12 = 11, > > 11 seems to only apply for the new protocol? The old protocol spec > just says "For SF100" but I have no idea what that actually means. I don't know... and I don't think they do either. :P Since it is present in both specs I'll just leave it as is for now. The 0x12 opcode is rather clear in the flash datasheets... it is just like normal page write but with 4 mandatory bytes for the address. So it should be easy to verify if the old firmware/protocol uses that... when we implement those write modes eventually. I have not seen an acked-by line in your mail... may I add it to the respective commit? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] [PATCH 3/5] dediprog: Show UID.
by Stefan Tauner 28 Jun '15

28 Jun '15

On Sat, 27 Jun 2015 17:34:11 -0700 David Hendricks <david.hendricks(a)gmail.com> wrote: > Apply this patch after patch 4 so that dediprog_read() is defined. > > Aside from that: > Acked-by: David Hendricks <dhendrix(a)chromium.org> Right. On the other hand no one yet knows what this UID actually is. So we agreed on IRC to postpone this patch completely. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1894 - trunk
by repository service 28 Jun '15

28 Jun '15

Author: stefanct Date: Sun Jun 28 15:31:19 2015 New Revision: 1894 URL: http://flashrom.org/trac/flashrom/changeset/1894 Log: dediprog: Invert the LED polarity in the code. Previously we have used low-active macros (because the hardware and old protocol were so too) and set every single LED explicitly although we only used a limited number of combinations. Using an enumeration for commonly used values instead makes things easier. Based on the following chromiumos change: Change-Id: Ie481a583e623cdc45e3649a4db69b15570f65a7b Signed-off-by: Simon Glass <sjg(a)chromium.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: David Hendricks <dhendrix(a)chromium.org> Modified: trunk/dediprog.c Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Tue Jun 23 01:59:15 2015 (r1893) +++ trunk/dediprog.c Sun Jun 28 15:31:19 2015 (r1894) @@ -45,6 +45,15 @@ #define DEDI_SPI_CMD_PAGEWRITE 0x1 #define DEDI_SPI_CMD_AAIWRITE 0x4 +enum dediprog_leds { + LED_INVALID = -1, + LED_NONE = 0, + LED_PASS = 1 << 0, + LED_BUSY = 1 << 1, + LED_ERROR = 1 << 2, + LED_ALL = 7, +}; + #if 0 /* Might be useful for other pieces of code as well. */ static void print_hex(void *buf, size_t len) @@ -77,24 +86,11 @@ //int usb_control_msg(usb_dev_handle *dev, int requesttype, int request, int value, int index, char *bytes, int size, int timeout); -/* Set/clear LEDs on dediprog */ -#define PASS_ON (0 << 0) -#define PASS_OFF (1 << 0) -#define BUSY_ON (0 << 1) -#define BUSY_OFF (1 << 1) -#define ERROR_ON (0 << 2) -#define ERROR_OFF (1 << 2) -static int current_led_status = -1; - +/* This function sets the GPIOs connected to the LEDs as well as IO1-IO4. */ static int dediprog_set_leds(int leds) { - int ret, target_leds; - - if (leds < 0 || leds > 7) - leds = 0; // Bogus value, enable all LEDs - - if (leds == current_led_status) - return 0; + if (leds < LED_NONE || leds > LED_ALL) + leds = LED_ALL; /* Older Dediprogs with 2.x.x and 3.x.x firmware only had * two LEDs, and they were reversed. So map them around if @@ -103,23 +99,21 @@ * bit 2 == 0: green light is on. * bit 0 == 0: red light is on. */ + int target_leds; if (dediprog_firmwareversion < FIRMWARE_VERSION(5,0,0)) { - target_leds = ((leds & ERROR_OFF) >> 2) | - ((leds & PASS_OFF) << 2); + target_leds = ((leds & LED_ERROR) >> 2) | + ((leds & LED_PASS) << 2); } else { target_leds = leds; } - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, - NULL, 0x0, DEFAULT_TIMEOUT); + target_leds ^= 7; + int ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, NULL, 0x0, DEFAULT_TIMEOUT); if (ret != 0x0) { - msg_perr("Command Set LED 0x%x failed (%s)!\n", - leds, usb_strerror()); + msg_perr("Command Set LED 0x%x failed (%s)!\n", leds, usb_strerror()); return 1; } - current_led_status = leds; - return 0; } @@ -271,26 +265,22 @@ unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; unsigned int bulklen; - dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); + dediprog_set_leds(LED_BUSY); if (residue) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, residue); ret = spi_read_chunked(flash, buf, start, residue, 16); - if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); - return ret; - } + if (ret) + goto err; } /* Round down. */ bulklen = (len - residue) / chunksize * chunksize; ret = dediprog_spi_bulk_read(flash, buf + residue, start + residue, bulklen); - if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); - return ret; - } + if (ret) + goto err; len -= residue + bulklen; if (len) { @@ -298,14 +288,15 @@ start, len); ret = spi_read_chunked(flash, buf + residue + bulklen, start + residue + bulklen, len, 16); - if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); - return ret; - } + if (ret) + goto err; } - dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); + dediprog_set_leds(LED_PASS); return 0; +err: + dediprog_set_leds(LED_ERROR); + return ret; } /* Bulk write interface, will write multiple chunksize byte chunks aligned to chunksize bytes. @@ -383,7 +374,7 @@ unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; unsigned int bulklen; - dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); + dediprog_set_leds(LED_BUSY); if (chunksize != 256) { msg_pdbg("Page sizes other than 256 bytes are unsupported as " @@ -398,7 +389,7 @@ /* No idea about the real limit. Maybe 12, maybe more. */ ret = spi_write_chunked(flash, buf, start, residue, 12); if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return ret; } } @@ -407,7 +398,7 @@ bulklen = (len - residue) / chunksize * chunksize; ret = dediprog_spi_bulk_write(flash, buf + residue, chunksize, start + residue, bulklen, dedi_spi_cmd); if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return ret; } @@ -418,12 +409,12 @@ ret = spi_write_chunked(flash, buf + residue + bulklen, start + residue + bulklen, len, 12); if (ret) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return ret; } } - dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); + dediprog_set_leds(LED_PASS); return 0; } @@ -918,23 +909,25 @@ if (register_shutdown(dediprog_shutdown, NULL)) return 1; - dediprog_set_leds(PASS_ON|BUSY_ON|ERROR_ON); - /* Perform basic setup. */ if (dediprog_setup(target)) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; } + /* Set all possible LEDs as soon as possible to indicate activity. + * Because knowing the firmware version is required to set the LEDs correctly we need to this after + * dediprog_setup() has queried the device and set dediprog_firmwareversion. */ + dediprog_set_leds(LED_ALL); + /* After setting voltage and speed, perform setup again. */ if (dediprog_set_spi_voltage(0) || dediprog_set_spi_speed(spispeed_idx) || dediprog_setup(target)) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return 1; } /* URB 11. Command Set SPI Voltage. */ if (dediprog_set_spi_voltage(millivolt)) { - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + dediprog_set_leds(LED_ERROR); return 1; } @@ -946,7 +939,7 @@ dediprog_do_stuff(); #endif - dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_OFF); + dediprog_set_leds(LED_NONE); return 0; }

1 0

[PATCH 3/3] serprog: allow to omit specifying a baud rate.
by Stefan Tauner 28 Jun '15

28 Jun '15

On USB-based serial connections (VCP) the requested baud rate usually does not matter (much). Remove the arbitrary restriction and use whatever default values the OS/hardware provides. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- flashrom.8.tmpl | 26 ++++++++++++++------------ programmer.h | 4 +--- serial.c | 25 +++++++++++++++---------- serprog.c | 44 +++++++++++++++++++++++--------------------- 4 files changed, 53 insertions(+), 46 deletions(-) diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 8b5f98c..26ea6e9 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -203,10 +203,9 @@ JTAGkey/JTAGkey-tiny/JTAGkey-2, Dangerous Prototypes Bus Blaster, \ Olimex ARM-USB-TINY/-H, Olimex ARM-USB-OCD/-H, TIAO/DIYGADGET USB Multi-Protocol Adapter (TUMPA), TUMPA Lite, and GOEPEL PicoTAP. .sp -.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog), \ -including AVR flasher by Urja Rannikko, AVR flasher by eightdot, \ -Arduino Mega flasher by fritz, InSystemFlasher by Juhana Helovuo, and \ -atmegaXXu2-flasher by Stefan Tauner." +.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog, \ +including Arduino-based devices as well as various programmers by Urja Rannikko, \ +Juhana Helovuo, Stefan Tauner and others)." .sp .BR "* buspirate_spi" " (for SPI flash ROMs attached to a Bus Pirate)" .sp @@ -683,19 +682,22 @@ parameter with the syntax. .SS .BR "serprog " programmer -A mandatory parameter specifies either a serial -device/baud combination or an IP/port combination for communication with the -programmer. In the device/baud combination, the device has to start with a -slash. For serial, you have to use the +A mandatory parameter specifies either a serial device (and baud rate) or an IP/port combination for +communicating with the programmer. +The device/baud combination has to start with +.B dev= +and separate the optional baud rate with a colon. +For example .sp -.B " flashrom \-p serprog:dev=/dev/device:baud" +.B " flashrom \-p serprog:dev=/dev/ttyS0:115200" .sp -syntax and for IP, you have to use +If no baud rate is given the default values by the operating system/hardware will be used. +For IP connections you have to use the .sp .B " flashrom \-p serprog:ip=ipaddr:port" .sp -instead. In case the device supports it, you can set the SPI clock frequency -with the optional +syntax. +In case the device supports it, you can set the SPI clock frequency with the optional .B spispeed parameter. The frequency is parsed as hertz, unless an .BR M ", or " k diff --git a/programmer.h b/programmer.h index 913522b..ea58e17 100644 --- a/programmer.h +++ b/programmer.h @@ -718,10 +718,8 @@ typedef int fdtype; #endif void sp_flush_incoming(void); -fdtype sp_openserport(char *dev, unsigned int baud); -int serialport_config(fdtype fd, unsigned int baud); +fdtype sp_openserport(char *dev, int baud); extern fdtype sp_fd; -/* expose serialport_shutdown as it's currently used by buspirate */ int serialport_shutdown(void *data); int serialport_write(const unsigned char *buf, unsigned int writecnt); int serialport_write_nonblock(const unsigned char *buf, unsigned int writecnt, unsigned int timeout, unsigned int *really_wrote); diff --git a/serial.c b/serial.c index b216143..c9ce3af 100644 --- a/serial.c +++ b/serial.c @@ -116,7 +116,7 @@ static const struct baudentry sp_baudtable[] = { {0, 0} /* Terminator */ }; -const struct baudentry *round_baud(unsigned int baud) +static const struct baudentry *round_baud(unsigned int baud) { int i; /* Round baud rate to next lower entry in sp_baudtable if it exists, else use the lowest entry. */ @@ -125,11 +125,12 @@ const struct baudentry *round_baud(unsigned int baud) return &sp_baudtable[i]; if (sp_baudtable[i].baud < baud) { - msg_pinfo("Warning: given baudrate %d rounded down to %d.\n", + msg_pwarn("Warning: given baudrate %d rounded down to %d.\n", baud, sp_baudtable[i].baud); return &sp_baudtable[i]; } } + msg_pinfo("Using slowest possible baudrate: %d.\n", sp_baudtable[0].baud); return &sp_baudtable[0]; } @@ -154,7 +155,7 @@ static void msg_perr_strerror(const char *msg) #endif } -int serialport_config(fdtype fd, unsigned int baud) +int serialport_config(fdtype fd, int baud) { if (fd == SER_INV_FD) { msg_perr("%s: File descriptor is invalid.\n", __func__); @@ -167,8 +168,10 @@ int serialport_config(fdtype fd, unsigned int baud) msg_perr_strerror("Could not fetch original serial port configuration: "); return 1; } - const struct baudentry *entry = round_baud(baud); - dcb.BaudRate = entry->flag; + if (baud >= 0) { + const struct baudentry *entry = round_baud(baud); + dcb.BaudRate = entry->flag; + } dcb.ByteSize = 8; dcb.Parity = NOPARITY; dcb.StopBits = ONESTOPBIT; @@ -188,10 +191,12 @@ int serialport_config(fdtype fd, unsigned int baud) return 1; } wanted = observed; - const struct baudentry *entry = round_baud(baud); - if (cfsetispeed(&wanted, entry->flag) != 0 || cfsetospeed(&wanted, entry->flag) != 0) { - msg_perr_strerror("Could not set serial baud rate: "); - return 1; + if (baud >= 0) { + const struct baudentry *entry = round_baud(baud); + if (cfsetispeed(&wanted, entry->flag) != 0 || cfsetospeed(&wanted, entry->flag) != 0) { + msg_perr_strerror("Could not set serial baud rate: "); + return 1; + } } wanted.c_cflag &= ~(PARENB | CSTOPB | CSIZE | CRTSCTS); wanted.c_cflag |= (CS8 | CLOCAL | CREAD); @@ -232,7 +237,7 @@ int serialport_config(fdtype fd, unsigned int baud) return 0; } -fdtype sp_openserport(char *dev, unsigned int baud) +fdtype sp_openserport(char *dev, int baud) { fdtype fd; #if IS_WINDOWS diff --git a/serprog.c b/serprog.c index 3de0182..4f671ce 100644 --- a/serprog.c +++ b/serprog.c @@ -342,26 +342,28 @@ int serprog_init(void) unsigned char rbuf[3]; unsigned char c; char *device; - char *baudport; int have_device = 0; - /* the parameter is either of format "dev=/dev/device:baud" or "ip=ip:port" */ + /* the parameter is either of format "dev=/dev/device[:baud]" or "ip=ip:port" */ device = extract_programmer_param("dev"); if (device && strlen(device)) { - baudport = strstr(device, ":"); - if (baudport) { + char *baud_str = strstr(device, ":"); + if (baud_str) { /* Split device from baudrate. */ - *baudport = '\0'; - baudport++; + *baud_str = '\0'; + baud_str++; } - if (!baudport || !strlen(baudport)) { - msg_perr("Error: No baudrate specified.\n" - "Use flashrom -p serprog:dev=/dev/device:baud\n"); - free(device); - return 1; - } - if (strlen(device)) { - sp_fd = sp_openserport(device, atoi(baudport)); + int baud; + /* Convert baud string to value. + * baud_str is either NULL (if strstr can't find the colon), points to the \0 after the colon + * if no characters where given after the colon, or a string to convert... */ + if (baud_str == NULL || *baud_str == '\0') { + baud = -1; + msg_pdbg("No baudrate specified, using the hardware's defaults.\n"); + } else + baud = atoi(baud_str); // FIXME: replace atoi with strtoul + if (strlen(device) > 0) { + sp_fd = sp_openserport(device, baud); if (sp_fd == SER_INV_FD) { free(device); return 1; @@ -371,7 +373,7 @@ int serprog_init(void) } if (device && !strlen(device)) { msg_perr("Error: No device specified.\n" - "Use flashrom -p serprog:dev=/dev/device:baud\n"); + "Use flashrom -p serprog:dev=/dev/device[:baud]\n"); free(device); return 1; } @@ -386,20 +388,20 @@ int serprog_init(void) return 1; } if (device && strlen(device)) { - baudport = strstr(device, ":"); - if (baudport) { + char *port = strstr(device, ":"); + if (port) { /* Split host from port. */ - *baudport = '\0'; - baudport++; + *port = '\0'; + port++; } - if (!baudport || !strlen(baudport)) { + if (!port || !strlen(port)) { msg_perr("Error: No port specified.\n" "Use flashrom -p serprog:ip=ipaddr:port\n"); free(device); return 1; } if (strlen(device)) { - sp_fd = sp_opensocket(device, atoi(baudport)); + sp_fd = sp_opensocket(device, atoi(port)); if (sp_fd < 0) { free(device); return 1; -- Kind regards, Stefan Tauner

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom June 2015