September 2013 - flashrom - mail.coreboot.org

[commit] r1738 - trunk
by repository service Sept. 12, 2013

Sept. 12, 2013

Author: stefanct Date: Thu Sep 12 10:29:06 2013 New Revision: 1738 URL: http://flashrom.org/trac/flashrom/changeset/1738 Log: Enable sector erase function for selected ST M50 chips. Affected chips: M50FLW040A, M50FLW040B, M50FLW080A, M50FLW080B. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/flashchips.c trunk/stm50.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Thu Sep 12 10:29:00 2013 (r1737) +++ trunk/flashchips.c Thu Sep 12 10:29:06 2013 (r1738) @@ -11022,7 +11022,7 @@ {4 * 1024, 16}, /* sector */ {4 * 1024, 16}, /* sector */ }, - .block_erase = NULL, + .block_erase = erase_sector_stm50, }, { .eraseblocks = { {64 * 1024, 8}, }, .block_erase = erase_block_82802ab, @@ -11055,7 +11055,7 @@ {64 * 1024, 5}, /* block */ {4 * 1024, 16}, /* sector */ }, - .block_erase = NULL, + .block_erase = erase_sector_stm50, }, { .eraseblocks = { {64 * 1024, 8}, }, .block_erase = erase_block_82802ab, @@ -11088,7 +11088,7 @@ {4 * 1024, 16}, /* sector */ {4 * 1024, 16}, /* sector */ }, - .block_erase = NULL, + .block_erase = erase_sector_stm50, }, { .eraseblocks = { {64 * 1024, 16}, }, .block_erase = erase_block_82802ab, @@ -11121,7 +11121,7 @@ {64 * 1024, 13}, /* block */ {4 * 1024, 16}, /* sector */ }, - .block_erase = NULL, + .block_erase = erase_sector_stm50, }, { .eraseblocks = { {64 * 1024, 16}, }, .block_erase = erase_block_82802ab, Modified: trunk/stm50.c ============================================================================== --- trunk/stm50.c Thu Sep 12 10:29:00 2013 (r1737) +++ trunk/stm50.c Thu Sep 12 10:29:06 2013 (r1738) @@ -84,10 +84,9 @@ return 0; } -/* This function is unused. */ -int erase_sector_stm50(struct flashctx *flash, unsigned int sector, unsigned int sectorsize) +static int stm50_erase_sector(struct flashctx *flash, unsigned int addr) { - chipaddr bios = flash->virtual_memory + sector; + chipaddr bios = flash->virtual_memory + addr; // clear status register chip_writeb(flash, 0x50, bios); @@ -96,8 +95,21 @@ chip_writeb(flash, 0xd0, bios); programmer_delay(10); - wait_82802ab(flash); + uint8_t status = wait_82802ab(flash); + print_status_82802ab(status); - /* FIXME: Check the status register for errors. */ - return 0; + return status == 0x80; +} + +/* Some ST M50* chips do support erasing of sectors. This function will derive the erase function to use from + * the length of the of the block. For calls that apparently do not address a sector (but a block) we just call + * the block erase function instead. FIXME: This duplicates the behavior of the remaining erasers for blocks and + * might be fixed when flashrom supports multiple functions per eraser or erasers that do erase parts of the + * chip only. */ +int erase_sector_stm50(struct flashctx *flash, unsigned int addr, unsigned int len) +{ + if (len == 4096) + return stm50_erase_sector(flash, addr); + else + return erase_block_82802ab(flash, addr, len); }

1 0

[commit] r1737 - trunk
by repository service Sept. 12, 2013

Sept. 12, 2013

Author: stefanct Date: Thu Sep 12 10:29:00 2013 New Revision: 1737 URL: http://flashrom.org/trac/flashrom/changeset/1737 Log: Add support for ST M50LPW080. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/flashchips.c trunk/flashchips.h Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Thu Sep 12 10:28:56 2013 (r1736) +++ trunk/flashchips.c Thu Sep 12 10:29:00 2013 (r1737) @@ -11240,6 +11240,31 @@ { .vendor = "ST", + .name = "M50LPW080", + .bustype = BUS_LPC, /* A/A Mux */ + .manufacture_id = ST_ID, + .model_id = ST_M50LPW080, + .total_size = 1024, + .page_size = 0, + .feature_bits = FEATURE_REGISTERMAP, + .tested = TEST_UNTESTED, + .probe = probe_82802ab, + .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 16}, }, + .block_erase = erase_block_82802ab, + } + }, + .unlock = unlock_stm50_uniform, + .write = write_82802ab, + .read = read_memmapped, + .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ + }, + + { + .vendor = "ST", .name = "M50LPW116", .bustype = BUS_LPC, /* A/A Mux */ .manufacture_id = ST_ID, Modified: trunk/flashchips.h ============================================================================== --- trunk/flashchips.h Thu Sep 12 10:28:56 2013 (r1736) +++ trunk/flashchips.h Thu Sep 12 10:29:00 2013 (r1737) @@ -668,6 +668,7 @@ #define ST_M50FW040 0x2C #define ST_M50FW080 0x2D #define ST_M50FW016 0x2E +#define ST_M50LPW080 0x2F #define ST_M50LPW116 0x30 #define ST_M29F002B 0x34 /* Same as M29F002BB */ #define ST_M29F002T 0xB0 /* Same as M29F002BT/M29F002NT/M29F002BNT */

1 0

[commit] r1736 - trunk
by repository service Sept. 12, 2013

Sept. 12, 2013

Author: stefanct Date: Thu Sep 12 10:28:56 2013 New Revision: 1736 URL: http://flashrom.org/trac/flashrom/changeset/1736 Log: Cleanup ST M50 driver. There are two locking strategies used by this umbrella family, one uniform and one that matches the sector layout of the chip. Refactor the functions involved and rename the overly complicated file to just stm50.c and the functions accordingly. This fixes unlocking of some of the non-uniform chips and gets rid of the abuse of page_size. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Added: trunk/stm50.c (contents, props changed) Deleted: trunk/stm50flw0x0x.c Modified: trunk/82802ab.c trunk/Makefile trunk/chipdrivers.h trunk/flashchips.c Modified: trunk/82802ab.c ============================================================================== --- trunk/82802ab.c Thu Sep 12 01:35:03 2013 (r1735) +++ trunk/82802ab.c Thu Sep 12 10:28:56 2013 (r1736) @@ -89,6 +89,7 @@ return 1; } +/* FIXME: needs timeout */ uint8_t wait_82802ab(struct flashctx *flash) { uint8_t status; Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Thu Sep 12 01:35:03 2013 (r1735) +++ trunk/Makefile Thu Sep 12 10:28:56 2013 (r1736) @@ -320,7 +320,7 @@ ############################################################################### # Flash chip drivers and bus support infrastructure. -CHIP_OBJS = jedec.o stm50flw0x0x.o w39.o w29ee011.o \ +CHIP_OBJS = jedec.o stm50.o w39.o w29ee011.o \ sst28sf040.o m29f400bt.o 82802ab.o pm49fl00x.o \ sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o spi25.o spi25_statusreg.o \ opaque.o sfdp.o en29lv640b.o at45db.o Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Thu Sep 12 01:35:03 2013 (r1735) +++ trunk/chipdrivers.h Thu Sep 12 10:28:56 2013 (r1736) @@ -193,9 +193,10 @@ /* w29ee011.c */ int probe_w29ee011(struct flashctx *flash); -/* stm50flw0x0x.c */ -int erase_sector_stm50flw0x0x(struct flashctx *flash, unsigned int block, unsigned int blocksize); -int unlock_stm50flw0x0x(struct flashctx *flash); +/* stm50.c */ +int erase_sector_stm50(struct flashctx *flash, unsigned int block, unsigned int blocksize); +int unlock_stm50_uniform(struct flashctx *flash); +int unlock_stm50_nonuniform(struct flashctx *flash); /* en29lv640b.c */ int probe_en29lv640b(struct flashctx *flash); Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Thu Sep 12 01:35:03 2013 (r1735) +++ trunk/flashchips.c Thu Sep 12 10:28:56 2013 (r1736) @@ -11008,7 +11008,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FLW040A, .total_size = 512, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -11028,8 +11028,8 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, .write = write_82802ab, + .unlock = unlock_stm50_uniform, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ }, @@ -11041,7 +11041,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FLW040B, .total_size = 512, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -11061,8 +11061,8 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, .write = write_82802ab, + .unlock = unlock_stm50_uniform, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ }, @@ -11074,7 +11074,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FLW080A, .total_size = 1024, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PRE, .probe = probe_82802ab, @@ -11094,7 +11094,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_nonuniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ @@ -11107,7 +11107,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FLW080B, .total_size = 1024, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -11127,7 +11127,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_nonuniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ @@ -11140,7 +11140,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FW002, .total_size = 256, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -11157,7 +11157,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_nonuniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ @@ -11170,7 +11170,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FW016, .total_size = 2048, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -11182,7 +11182,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_uniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ @@ -11195,7 +11195,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FW040, .total_size = 512, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PR, .probe = probe_82802ab, @@ -11207,7 +11207,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_uniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ @@ -11220,7 +11220,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50FW080, .total_size = 1024, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PREW, .probe = probe_82802ab, @@ -11232,7 +11232,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_uniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ @@ -11245,7 +11245,7 @@ .manufacture_id = ST_ID, .model_id = ST_M50LPW116, .total_size = 2048, - .page_size = 64 * 1024, + .page_size = 0, .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -11263,7 +11263,7 @@ .block_erase = erase_block_82802ab, } }, - .unlock = unlock_stm50flw0x0x, + .unlock = unlock_stm50_nonuniform, .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program & erase */ Added: trunk/stm50.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/stm50.c Thu Sep 12 10:28:56 2013 (r1736) @@ -0,0 +1,103 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2008 Claus Gindhart <claus.gindhart(a)kontron.com> + * Copyright (C) 2009 Sean Nelson <audiohacked(a)gmail.com> + * Copyright (C) 2013 Stefan Tauner + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/* + * All ST M50 chips are locked on startup. Most of them have a uniform 64 kB block layout, but some have + * a non-uniform block/sector segmentation which has to be handled with more care. Some of the non-uniform + * chips support erasing of the 4 kB sectors with another command. + */ + +#include "flash.h" +#include "flashchips.h" +#include "chipdrivers.h" + +static int stm50_unlock_address(struct flashctx *flash, int offset) +{ + chipaddr wrprotect = flash->virtual_registers + 2; + static const uint8_t unlock_sector = 0x00; + msg_cdbg("unlocking at 0x%x\n", offset); + chip_writeb(flash, unlock_sector, wrprotect + offset); + if (chip_readb(flash, wrprotect + offset) != unlock_sector) { + msg_cerr("Cannot unlock address 0x%x\n", offset); + return -1; + } + return 0; +} + +/* Chips known to use a non-uniform block and sector layout for locking (as well as for erasing): + * Name Size Address range of lock registers + * M50FLW080A 1MB FFB00002 - FFBFF002 + * M50FLW080B 1MB FFB00002 - FFBFF002 + * M50FW002 256k FFBC0002 - FFBFC002 + * M50LPW116 2MB FFA00002 - FFBFC002 + */ +int unlock_stm50_nonuniform(struct flashctx *flash) +{ + int i; + struct eraseblock *eraseblocks = flash->chip->block_erasers[0].eraseblocks; + unsigned int done = 0; + for (i = 0; i < NUM_ERASEREGIONS && eraseblocks[i].count != 0; i++) { + unsigned int block_size = eraseblocks[i].size; + unsigned int block_count = eraseblocks[i].count; + + int j; + for (j = 0; j < block_count; j++) { + if (stm50_unlock_address(flash, done)) { + msg_cerr("UNLOCK FAILED!\n"); + return -1; + } + done += block_count * block_size; + } + } + return 0; +} + +/* Unlocking for uniform 64 kB blocks starting at offset 2 of the feature registers. */ +int unlock_stm50_uniform(struct flashctx *flash) +{ + int i; + for (i = 0; i < flash->chip->total_size * 1024; i+= 64 * 1024) { + if (stm50_unlock_address(flash, i)) { + msg_cerr("UNLOCK FAILED!\n"); + return -1; + } + } + return 0; +} + +/* This function is unused. */ +int erase_sector_stm50(struct flashctx *flash, unsigned int sector, unsigned int sectorsize) +{ + chipaddr bios = flash->virtual_memory + sector; + + // clear status register + chip_writeb(flash, 0x50, bios); + // now start it + chip_writeb(flash, 0x32, bios); + chip_writeb(flash, 0xd0, bios); + programmer_delay(10); + + wait_82802ab(flash); + + /* FIXME: Check the status register for errors. */ + return 0; +}

1 0

Re: [flashrom] [PATCH] Add an internal DMI decoder.
by Stefan Tauner Sept. 11, 2013

Sept. 11, 2013

On Wed, 28 Aug 2013 18:16:12 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > Previously we had to rely on dmidecode to decode the DMI/SMBIOS table. > This patch integrates a DMI decoder into flashrom. The old behavior of calling > dmidecode can be brought back by using CONFIG_INTERNAL_DMI=no. > > Significant portions of this patch were taken from dmidecode, hence add its > authors to the copyright notice (dmidecode is also GPL2+). We do a few things > differently though. First of all we do more bounds checking to prevent accessing > unmapped memory. We do not support disovery via EFI (yet), but memory > scanning only. We handle the chassis-type lock bit correctly which dmidecode > did not for a long while. > > The API to the rest of flashrom remains stable, but the output changes slightly. > To share as much code as possible (which actually is not much), i have added > dmi_fill methods that get called in dmi_init. They are reponsible to fill the > dmi_strings array and setting the is_laptop variable. After it is called, dmi_init > prints all dmi_strings. Previously the strings were printed in the order they were > discovered, followed by the chassis-type, which is now output earlier (in dmi_fill). > > Because DJGPP does not support strnlen a simple implementation was added > for it. > > This is still only available on x86; actually it is not even compiled in for other > architectures at all anymore. > > Signed-off-by: Sean Nelson<audiohacked(a)gmail.com> > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> > Tested-by: Maciej Pijanka <maciej.pijanka(a)gmail.com> > Tested-by: Idwer Vollering <vidwer(a)gmail.com> > Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Committed in r1735 after testing it with FreeDOS too. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] [PATCH] DOS refinements.
by Stefan Tauner Sept. 11, 2013

Sept. 11, 2013

On Fri, 6 Sep 2013 11:24:40 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > This allows to use the DOS library trees stored in a user-specified directory. > > I have mirrored the needed patches, sources and binaries (the latter > are properly licensed to allow that) in the flashrom wiki, so use those > URLs instead of the original sources. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> self-acked and committed in r1734. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1735 - trunk
by repository service Sept. 11, 2013

Sept. 11, 2013

Author: stefanct Date: Thu Sep 12 01:35:03 2013 New Revision: 1735 URL: http://flashrom.org/trac/flashrom/changeset/1735 Log: Add an internal DMI decoder. Previously we had to rely on dmidecode to decode the DMI/SMBIOS table. This patch integrates a DMI decoder into flashrom. The old behavior of calling dmidecode can be brought back by using CONFIG_INTERNAL_DMI=no. Significant portions of this patch were taken from dmidecode, hence add its authors to the copyright notice (dmidecode is also GPL2+). We do a few things differently though. First of all we do more bounds checking to prevent accessing unmapped memory. We do not support disovery via EFI (yet), but memory scanning only. We handle the chassis-type lock bit correctly which dmidecode did not for a long while. The API to the rest of flashrom remains stable, but the output changes slightly. To share as much code as possible (which actually is not much), i have added dmi_fill methods that get called in dmi_init. They are reponsible to fill the dmi_strings array and setting the is_laptop variable. After it is called, dmi_init prints all dmi_strings. Previously the strings were printed in the order they were discovered, followed by the chassis-type, which is now output earlier (in dmi_fill). Because DJGPP does not support strnlen a simple implementation was added for it. This is still only available on x86; actually it is not even compiled in for other architectures at all anymore. Signed-off-by: Sean Nelson<audiohacked(a)gmail.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Tested-by: Maciej Pijanka <maciej.pijanka(a)gmail.com> Tested-by: Idwer Vollering <vidwer(a)gmail.com> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/Makefile trunk/board_enable.c trunk/dmi.c trunk/physmap.c trunk/programmer.h Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Thu Sep 12 01:34:57 2013 (r1734) +++ trunk/Makefile Thu Sep 12 01:35:03 2013 (r1735) @@ -440,6 +440,23 @@ endif ############################################################################### +# Handle CONFIG_* variables that depend on others set (and verified) above. + +# The external DMI decoder (dmidecode) does not work in libpayload. Bail out if the internal one got disabled. +ifeq ($(TARGET_OS), libpayload) +ifeq ($(CONFIG_INTERNAL), yes) +ifeq ($(CONFIG_INTERNAL_DMI), no) +UNSUPPORTED_FEATURES += CONFIG_INTERNAL_DMI=no +else +override CONFIG_INTERNAL_DMI = yes +endif +endif +endif + +# Use internal DMI/SMBIOS decoder by default instead of relying on dmidecode. +CONFIG_INTERNAL_DMI ?= yes + +############################################################################### # Programmer drivers and programmer support infrastructure. # Depending on the CONFIG_* variables set and verified above we set compiler flags and parameters below. @@ -447,10 +464,13 @@ ifeq ($(CONFIG_INTERNAL), yes) FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1' -PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o dmi.o internal.o +PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o internal.o ifeq ($(ARCH), x86) PROGRAMMER_OBJS += it87spi.o it85spi.o sb600spi.o amd_imc.o wbsio_spi.o mcp6x_spi.o -PROGRAMMER_OBJS += ichspi.o ich_descriptors.o +PROGRAMMER_OBJS += ichspi.o ich_descriptors.o dmi.o +ifeq ($(CONFIG_INTERNAL_DMI), yes) +FEATURE_CFLAGS += -D'CONFIG_INTERNAL_DMI=1' +endif else endif NEED_PCI := yes Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Thu Sep 12 01:34:57 2013 (r1734) +++ trunk/board_enable.c Thu Sep 12 01:35:03 2013 (r1735) @@ -2560,6 +2560,7 @@ } } +#if defined(__i386__) || defined(__x86_64__) if (board->dmi_pattern) { if (!has_dmi_support) { msg_pwarn("Warning: Can't autodetect %s %s, DMI info unavailable.\n", @@ -2572,7 +2573,7 @@ continue; } } - +#endif // defined(__i386__) || defined(__x86_64__) return board; } Modified: trunk/dmi.c ============================================================================== --- trunk/dmi.c Thu Sep 12 01:34:57 2013 (r1734) +++ trunk/dmi.c Thu Sep 12 01:35:03 2013 (r1735) @@ -1,7 +1,10 @@ /* * This file is part of the flashrom project. * + * Copyright (C) 2000-2002 Alan Cox <alan(a)redhat.com> + * Copyright (C) 2002-2010 Jean Delvare <khali(a)linux-fr.org> * Copyright (C) 2009,2010 Michael Karcher + * Copyright (C) 2011-2013 Stefan Tauner * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -26,33 +29,28 @@ #include "flash.h" #include "programmer.h" -int has_dmi_support = 0; - -#if STANDALONE +#if defined(__i386__) || defined(__x86_64__) -/* Stub to indicate missing DMI functionality. - * has_dmi_support is 0 by default, so nothing to do here. - * Because dmidecode is not available on all systems, the goal is to implement - * the DMI subset we need directly in this file. - */ -void dmi_init(void) -{ -} +/* Enable SMBIOS decoding. Currently legacy DMI decoding is enough. */ +#define SM_SUPPORT 0 -int dmi_match(const char *pattern) -{ - return 0; -} +/* Strings longer than 4096 in DMI are just insane. */ +#define DMI_MAX_ANSWER_LEN 4096 -#else /* STANDALONE */ +int has_dmi_support = 0; -static const char *dmidecode_names[] = { - "system-manufacturer", - "system-product-name", - "system-version", - "baseboard-manufacturer", - "baseboard-product-name", - "baseboard-version", +static struct { + const char *const keyword; + const uint8_t type; + const uint8_t offset; + char *value; +} dmi_strings[] = { + { "system-manufacturer", 1, 0x04, NULL }, + { "system-product-name", 1, 0x05, NULL }, + { "system-version", 1, 0x06, NULL }, + { "baseboard-manufacturer", 2, 0x04, NULL }, + { "baseboard-product-name", 2, 0x05, NULL }, + { "baseboard-version", 2, 0x06, NULL }, }; /* This list is used to identify supposed laptops. The is_laptop field has the @@ -66,9 +64,9 @@ * The types below are the most common ones. */ static const struct { - unsigned char type; - unsigned char is_laptop; - const char *name; + uint8_t type; + uint8_t is_laptop; + char *name; } dmi_chassis_types[] = { {0x01, 2, "Other"}, {0x02, 2, "Unknown"}, @@ -86,20 +84,206 @@ {0x18, 0, "Sealed-case PC"}, /* used by Supermicro (X8SIE) */ }; -#define DMI_COMMAND_LEN_MAX 260 -static const char *dmidecode_command = "dmidecode"; +#if CONFIG_INTERNAL_DMI == 1 +#ifdef __DJGPP__ /* There is no strnlen in DJGPP. FIXME: Move this to a common utility file. */ +size_t strnlen(const char *str, size_t n) +{ + size_t i; + for (i = 0; i < n && str[i] != '\0'; i++) + ; + return i; +} +#endif -static char *dmistrings[ARRAY_SIZE(dmidecode_names)]; +static bool dmi_checksum(const uint8_t * const buf, size_t len) +{ + uint8_t sum = 0; + size_t a; -/* Strings longer than 4096 in DMI are just insane. */ -#define DMI_MAX_ANSWER_LEN 4096 + for (a = 0; a < len; a++) + sum += buf[a]; + return (sum == 0); +} + +static char *dmi_string(uint8_t *buf, uint8_t string_id, uint8_t *limit) +{ + size_t i, len; + + if (string_id == 0) + return "Not Specified"; + + while (string_id > 1 && string_id--) { + if (buf > limit) { + msg_perr("DMI table is broken (string portion out of bounds)!\n"); + return "<OUT OF BOUNDS>"; + } + buf += strnlen((char *)buf, limit - buf) + 1; + } + + if (!*buf) /* as long as the current byte we're on isn't null */ + return "<BAD INDEX>"; + + len = strnlen((char *)buf, limit - buf); + if (len > DMI_MAX_ANSWER_LEN) + len = DMI_MAX_ANSWER_LEN; + + /* fix junk bytes in the string */ + for (i = 0; i < len; i++) + if (buf[i] < 32 || buf[i] >= 127) + buf[i] = ' '; + + return (char *)buf; +} + +static void dmi_chassis_type(uint8_t code) +{ + int i; + code &= 0x7f; /* bits 6:0 are chassis type, 7th bit is the lock bit */ + is_laptop = 2; + for (i = 0; i < ARRAY_SIZE(dmi_chassis_types); i++) { + if (code == dmi_chassis_types[i].type) { + msg_pdbg("DMI string chassis-type: \"%s\"\n", dmi_chassis_types[i].name); + is_laptop = dmi_chassis_types[i].is_laptop; + break; + } + } +} + +static void dmi_table(uint32_t base, uint16_t len, uint16_t num) +{ + int i = 0, j = 0; + + uint8_t *dmi_table_mem = physmap_round("DMI Table", base, len); + if (dmi_table_mem == NULL) { + msg_perr("Unable to access DMI Table\n"); + return; + } + + uint8_t *data = dmi_table_mem; + uint8_t *limit = dmi_table_mem + len; + + /* SMBIOS structure header is always 4 B long and contains: + * - uint8_t type; // see dmi_chassis_types's type + * - uint8_t length; // data section w/ header w/o strings + * - uint16_t handle; + */ + while (i < num && data + 4 <= limit) { + /* - If a short entry is found (less than 4 bytes), not only it + * is invalid, but we cannot reliably locate the next entry. + * - If the length value indicates that this structure spreads + * accross the table border, something is fishy too. + * Better stop at this point, and let the user know his/her + * table is broken. + */ + if (data[1] < 4 || data + data[1] > limit) { + msg_perr("DMI table is broken (bogus header)!\n"); + break; + } + + if(data[0] == 3) { + if (data + 5 <= limit) + dmi_chassis_type(data[5]); + /* else the table is broken, but laptop detection is optional, hence continue. */ + } else + for (j = 0; j < ARRAY_SIZE(dmi_strings); j++) { + uint8_t offset = dmi_strings[j].offset; + uint8_t type = dmi_strings[j].type; + + if (data[0] != type) + continue; + + if (data[1] <= offset || data+offset > limit) { + msg_perr("DMI table is broken (offset out of bounds)!\n"); + goto out; + } + + /* Table will be unmapped, hence fill the struct with duplicated strings. */ + dmi_strings[j].value = strdup(dmi_string(data + data[1], data[offset], limit)); + } + /* Find next structure by skipping data and string sections */ + data += data[1]; + while (data + 1 <= limit) { + if (data[0] == 0 && data[1] == 0) + break; + data++; + } + data += 2; + i++; + } +out: + physunmap(dmi_table_mem, len); +} + +#if SM_SUPPORT +static int smbios_decode(uint8_t *buf) +{ + /* TODO: other checks mentioned in the conformance guidelines? */ + if (!dmi_checksum(buf, buf[0x05]) || + (memcmp(buf + 0x10, "_DMI_", 5) != 0) || + !dmi_checksum(buf + 0x10, 0x0F)) + return 0; + + dmi_table(mmio_readl(buf + 0x18), mmio_readw(buf + 0x16), mmio_readw(buf + 0x1C)); + + return 1; +} +#endif + +static int legacy_decode(uint8_t *buf) +{ + if (!dmi_checksum(buf, 0x0F)) + return 1; + + dmi_table(mmio_readl(buf + 0x08), mmio_readw(buf + 0x06), mmio_readw(buf + 0x0C)); + + return 0; +} + +int dmi_fill(void) +{ + size_t fp; + uint8_t *dmi_mem; + int ret = 1; + + msg_pdbg("Using Internal DMI decoder.\n"); + /* There are two ways specified to gain access to the SMBIOS table: + * - EFI's configuration table contains a pointer to the SMBIOS table. On linux it can be obtained from + * sysfs. EFI's SMBIOS GUID is: {0xeb9d2d31,0x2d88,0x11d3,0x9a,0x16,0x0,0x90,0x27,0x3f,0xc1,0x4d} + * - Scanning physical memory address range 0x000F0000h to 0x000FFFFF for the anchor-string(s). */ + dmi_mem = physmap_try_ro("DMI", 0xF0000, 0x10000); + if (dmi_mem == NULL) + return ret; + + for (fp = 0; fp <= 0xFFF0; fp += 16) { +#if SM_SUPPORT + if (memcmp(dmi_mem + fp, "_SM_", 4) == 0 && fp <= 0xFFE0) { + if (smbios_decode(dmi_mem + fp)) // FIXME: length check + goto out; + } else +#endif + if (memcmp(dmi_mem + fp, "_DMI_", 5) == 0) + if (legacy_decode(dmi_mem + fp) == 0) { + ret = 0; + goto out; + } + } + msg_pinfo("No DMI table found.\n"); +out: + physunmap(dmi_mem, 0x10000); + return ret; +} + +#else /* CONFIG_INTERNAL_DMI */ + +#define DMI_COMMAND_LEN_MAX 300 +static const char *dmidecode_command = "dmidecode"; static char *get_dmi_string(const char *string_name) { FILE *dmidecode_pipe; char *result; char answerbuf[DMI_MAX_ANSWER_LEN]; - char commandline[DMI_COMMAND_LEN_MAX + 40]; + char commandline[DMI_COMMAND_LEN_MAX]; snprintf(commandline, sizeof(commandline), "%s -s %s", dmidecode_command, string_name); @@ -138,46 +322,31 @@ /* Chomp trailing newline. */ if (answerbuf[0] != 0 && answerbuf[strlen(answerbuf) - 1] == '\n') answerbuf[strlen(answerbuf) - 1] = 0; - msg_pdbg("DMI string %s: \"%s\"\n", string_name, answerbuf); result = strdup(answerbuf); - if (!result) + if (result == NULL) msg_pwarn("Warning: Out of memory - DMI support fails"); return result; } -static int dmi_shutdown(void *data) -{ - int i; - for (i = 0; i < ARRAY_SIZE(dmistrings); i++) { - free(dmistrings[i]); - dmistrings[i] = NULL; - } - return 0; -} - -void dmi_init(void) +int dmi_fill(void) { int i; char *chassis_type; - if (register_shutdown(dmi_shutdown, NULL)) - return; - - has_dmi_support = 1; - for (i = 0; i < ARRAY_SIZE(dmidecode_names); i++) { - dmistrings[i] = get_dmi_string(dmidecode_names[i]); - if (!dmistrings[i]) { - has_dmi_support = 0; - return; - } + msg_pdbg("Using External DMI decoder.\n"); + for (i = 0; i < ARRAY_SIZE(dmi_strings); i++) { + dmi_strings[i].value = get_dmi_string(dmi_strings[i].keyword); + if (dmi_strings[i].value == NULL) + return 1; } chassis_type = get_dmi_string("chassis-type"); if (chassis_type == NULL) - return; + return 0; /* chassis-type handling is optional anyway */ + msg_pdbg("DMI string chassis-type: \"%s\"\n", chassis_type); is_laptop = 2; for (i = 0; i < ARRAY_SIZE(dmi_chassis_types); i++) { if (strcasecmp(chassis_type, dmi_chassis_types[i].name) == 0) { @@ -185,6 +354,33 @@ break; } } + free(chassis_type); + return 0; +} + +#endif /* CONFIG_INTERNAL_DMI */ + +static int dmi_shutdown(void *data) +{ + int i; + for (i = 0; i < ARRAY_SIZE(dmi_strings); i++) { + free(dmi_strings[i].value); + dmi_strings[i].value = NULL; + } + return 0; +} + +void dmi_init(void) +{ + /* Register shutdown function before we allocate anything. */ + if (register_shutdown(dmi_shutdown, NULL)) { + msg_pwarn("Warning: Could not register DMI shutdown function - continuing without DMI info.\n"); + return; + } + + /* dmi_fill fills the dmi_strings array, and if possible sets the global is_laptop variable. */ + if (dmi_fill() != 0) + return; switch (is_laptop) { case 1: @@ -194,7 +390,13 @@ msg_pdbg("DMI chassis-type is not specific enough.\n"); break; } - free(chassis_type); + + has_dmi_support = 1; + int i; + for (i = 0; i < ARRAY_SIZE(dmi_strings); i++) { + msg_pdbg("DMI string %s: \"%s\"\n", dmi_strings[i].keyword, + (dmi_strings[i].value == NULL) ? "" : dmi_strings[i].value); + } } /** @@ -252,11 +454,11 @@ if (!has_dmi_support) return 0; - for (i = 0; i < ARRAY_SIZE(dmidecode_names); i++) - if (dmi_compare(dmistrings[i], pattern)) + for (i = 0; i < ARRAY_SIZE(dmi_strings); i++) + if (dmi_compare(dmi_strings[i].value, pattern)) return 1; return 0; } -#endif /* STANDALONE */ +#endif // defined(__i386__) || defined(__x86_64__) Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Thu Sep 12 01:34:57 2013 (r1734) +++ trunk/physmap.c Thu Sep 12 01:35:03 2013 (r1735) @@ -328,6 +328,11 @@ return physmap_common(descr, phys_addr, len, PHYSM_NOFAIL, PHYSM_RW, PHYSM_CLEANUP, PHYSM_ROUND); } +void *physmap_round(const char *descr, uintptr_t phys_addr, size_t len) +{ + return physmap_common(descr, phys_addr, len, PHYSM_NOFAIL, PHYSM_RW, PHYSM_NOCLEANUP, PHYSM_ROUND); +} + void *physmap_try_ro(const char *descr, uintptr_t phys_addr, size_t len) { return physmap_common(descr, phys_addr, len, PHYSM_MAYFAIL, PHYSM_RO, PHYSM_NOCLEANUP, PHYSM_EXACT); Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Thu Sep 12 01:34:57 2013 (r1734) +++ trunk/programmer.h Thu Sep 12 01:35:03 2013 (r1735) @@ -277,6 +277,7 @@ /* physmap.c */ void *physmap(const char *descr, uintptr_t phys_addr, size_t len); void *rphysmap(const char *descr, uintptr_t phys_addr, size_t len); +void *physmap_round(const char *descr, uintptr_t phys_addr, size_t len); void *physmap_try_ro(const char *descr, uintptr_t phys_addr, size_t len); void physunmap(void *virt_addr, size_t len); #if CONFIG_INTERNAL == 1 @@ -288,9 +289,11 @@ int cb_check_image(uint8_t *bios, int size); /* dmi.c */ +#if defined(__i386__) || defined(__x86_64__) extern int has_dmi_support; void dmi_init(void); int dmi_match(const char *pattern); +#endif // defined(__i386__) || defined(__x86_64__) /* internal.c */ struct superio {

1 0

[commit] r1734 - trunk
by repository service Sept. 11, 2013

Sept. 11, 2013

Author: stefanct Date: Thu Sep 12 01:34:57 2013 New Revision: 1734 URL: http://flashrom.org/trac/flashrom/changeset/1734 Log: DOS refinements. This allows to use the DOS library trees stored in a user-specified directory. I have mirrored the needed patches, sources and binaries (the latter are properly licensed to allow that) in the flashrom wiki, so use those URLs instead of the original sources. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/Makefile trunk/README Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Sep 10 12:42:48 2013 (r1733) +++ trunk/Makefile Thu Sep 12 01:34:57 2013 (r1734) @@ -39,6 +39,7 @@ EXPORTDIR ?= . AR ?= ar RANLIB ?= ranlib +DOSLIBS_BASE ?= .. # The following parameter changes the default programmer that will be used if there is no -p/--programmer # argument given when running flashrom. The predefined setting does not enable any default so that every # user has to declare the programmer he wants to use on every run. The rationale for this to be not set @@ -99,11 +100,12 @@ ifeq ($(TARGET_OS), DOS) EXEC_SUFFIX := .exe -CPPFLAGS += -I../libgetopt +CPPFLAGS += -I$(DOSLIBS_BASE)/libgetopt # DJGPP has odd uint*_t definitions which cause lots of format string warnings. CFLAGS += -Wno-format # FIXME Check if we can achieve the same effect with -L../libgetopt -lgetopt -LIBS += ../libgetopt/libgetopt.a +LIBS += -lgetopt +LDFLAGS += -L$(DOSLIBS_BASE)/libgetopt/ # Bus Pirate, Serprog and PonyProg are not supported under DOS (missing serial support). ifeq ($(CONFIG_BUSPIRATE_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_BUSPIRATE_SPI=yes @@ -611,9 +613,9 @@ PCILIBS += -l$(shell uname -p) else ifeq ($(TARGET_OS), DOS) -# FIXME There needs to be a better way to do this -CPPFLAGS += -I../libpci/include -PCILIBS += ../libpci/lib/libpci.a +CPPFLAGS += -I$(DOSLIBS_BASE)/libpci/include +LDFLAGS += -L$(DOSLIBS_BASE)/libpci/lib/ +PCILIBS += -lpci else PCILIBS += -lpci ifeq ($(TARGET_OS), OpenBSD) Modified: trunk/README ============================================================================== --- trunk/README Tue Sep 10 12:42:48 2013 (r1733) +++ trunk/README Thu Sep 12 01:34:57 2013 (r1734) @@ -105,20 +105,24 @@ djcrx-2.04pre_20090725-13ap.i386.rpm The cross toolchain packages for your distribution may have slightly different names (look for packages named *djgpp*). - Download pciutils 3.1.5 and apply http://assembler.cz/flashrom/pciutils.patch - Download and compile http://assembler.cz/flashrom/libgetopt/ + + You will need the following library source trees containing their compiled + static libraries either in the parent directory of the flashrom source or + specify the base folder on compile time with the DOSLIBS_BASE parameter. + The default as described above is equal to calling + 'make djgpp-dos DOSLIBS_BASE=..' + + To get and build said libraries... + Download pciutils 3.1.5 and apply http://flashrom.org/File:Pciutils.patch.gz Compile pciutils, see README.DJGPP for instructions. + Download and compile http://flashrom.org/File:Libgetopt.tar.gz Enter the flashrom directory. - ../libpci should contain pciutils source and binaries. - ../libgetopt should contain getopt.a from libgetopt. Run either (change settings where appropriate) make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip or (above settings hardcoded) make djgpp-dos - You might have to add WARNERROR=no to the make command line. - To run flashrom.exe, download and unpack - http://homer.rice.edu/~sandmann/cwsdpmi/csdpmi7b.zip and make sure - CWSDPMI.EXE is in the current directory. + To run flashrom.exe, download http://flashrom.org/File:Csdpmi7b.zip and + unpack CWSDPMI.EXE into the current directory or one in PATH. To cross-compile on Linux for Windows:

1 0

Supermicro server BIOS update question
by Ben Schwartz Sept. 11, 2013

Sept. 11, 2013

Hello! I came across your page today in search of an easy way to update BIOS on ~800 Supermicro servers around the world at different datacenters. I have used the asulnx tool in the past for another board but it doesn't seem to work for these. I saw in your supported hardware page that the Supermicro X8SIE-F and X9SCM-F boards are not supported under flashrom utility because: 113. ↑<http://www.flashrom.org/Supported_hardware#boards_ref113> Requires unlocking the ME although the registers are set up correctly by the descriptor/BIOS already (tested with swseq and hwseq)." What exactly does this reason mean and do you know of another BIOS update utility that will work for these motherboards that can be run from Linux (centos5-6)? Thanks! -Ben

1 0

Re: [flashrom] BCOM WinNET P680 patch
by Stefan Tauner Sept. 10, 2013

Sept. 10, 2013

On Sun, 8 Sep 2013 22:39:11 -0400 Corey Osgood <corey.osgood(a)gmail.com> wrote: > > On Sun, Sep 8, 2013 at 10:24 PM, Corey Osgood <corey.osgood(a)gmail.com>wrote: > > > >> This patch replaces Alex Mauer's previous patch for this board. Tested to > >> read, erase, and write on 2 different boards, both with AMIC A29040BL flash > >> chips, using both stock BIOS and coreboot images. Patch marks the AMIC chip > >> as tested at the same time. > >> > >> Signed-off-by: Corey Osgood <corey.osgood(a)gmail.com> Thanks Corey! I was not aware of that patch from 2008(!). Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> and committed in r1733 after some minor changes. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1733 - trunk
by repository service Sept. 10, 2013

Sept. 10, 2013

Author: stefanct Date: Tue Sep 10 12:42:48 2013 New Revision: 1733 URL: http://flashrom.org/trac/flashrom/changeset/1733 Log: Add board enable for Bcom WinNET P680. This patch replaces Alex Mauer's previous patch for this board (from 2008). Tested to read, erase, and write on 2 different boards, both with AMIC A29040BL flash chips, using both stock BIOS and coreboot images. This patch marks the AMIC chip as tested at the same time. Signed-off-by: Corey Osgood <corey.osgood(a)gmail.com> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/board_enable.c trunk/flashchips.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Sat Aug 31 00:23:02 2013 (r1732) +++ trunk/board_enable.c Tue Sep 10 12:42:48 2013 (r1733) @@ -2378,6 +2378,7 @@ {0x8086, 0x24dd, 0x1043, 0x80a6, 0x8086, 0x2570, 0x1043, 0x8157, NULL, NULL, NULL, P3, "ASUS", "P5PE-VM", 0, OK, intel_ich_gpio21_raise}, {0x8086, 0x2443, 0x1043, 0x8027, 0x8086, 0x1130, 0x1043, 0x8027, "^CUSL2-C", NULL, NULL, P3, "ASUS", "CUSL2-C", 0, OK, intel_ich_gpio21_raise}, {0x8086, 0x2443, 0x1043, 0x8027, 0x8086, 0x1130, 0x1043, 0x8027, "^TUSL2-C", NULL, NULL, P3, "ASUS", "TUSL2-C", 0, NT, intel_ich_gpio21_raise}, + {0x1106, 0x3059, 0x1106, 0x4161, 0x1106, 0x3065, 0x1106, 0x0102, NULL, NULL, NULL, P3, "Bcom/Clientron", "WinNET P680", 0, OK, w836xx_memw_enable_2e}, {0x1106, 0x3177, 0x1106, 0x3177, 0x1106, 0x3116, 0x1106, 0x3116, "^KM266-8235$", "biostar", "m7viq", P3, "Biostar", "M7VIQ", 0, NT, w83697xx_memw_enable_2e}, {0x10b7, 0x9055, 0x1028, 0x0082, 0x8086, 0x7190, 0, 0, NULL, NULL, NULL, P3, "Dell", "OptiPlex GX1", 0, OK, intel_piix4_gpo30_lower}, {0x8086, 0x3590, 0x1028, 0x016c, 0x1000, 0x0030, 0x1028, 0x016c, NULL, NULL, NULL, P3, "Dell", "PowerEdge 1850", 0, OK, intel_ich_gpio23_raise}, Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Sat Aug 31 00:23:02 2013 (r1732) +++ trunk/flashchips.c Tue Sep 10 12:42:48 2013 (r1733) @@ -1355,7 +1355,7 @@ .total_size = 512, .page_size = 64 * 1024, .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_jedec, .probe_timing = TIMING_ZERO, .block_erasers =

1 0