flashrom November 2012

flashrom@flashrom.org

36 participants
95 discussions

[PATCH 3/3] Fix sp_openserport users on Windows.
by Stefan Tauner 26 Nov '12

26 Nov '12

Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- buspirate_spi.c | 2 +- pony_spi.c | 2 +- serprog.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/buspirate_spi.c b/buspirate_spi.c index 92d7fb4..55d4133 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -40,7 +40,7 @@ static int buspirate_serialport_setup(char *dev) { /* 115200bps, 8 databits, no parity, 1 stopbit */ sp_fd = sp_openserport(dev, 115200); - if (sp_fd < 0) + if (sp_fd == SER_INV_FD) return 1; return 0; } diff --git a/pony_spi.c b/pony_spi.c index 7875200..101751f 100644 --- a/pony_spi.c +++ b/pony_spi.c @@ -116,7 +116,7 @@ int pony_spi_init(void) arg = extract_programmer_param("dev"); if (arg && strlen(arg)) { sp_fd = sp_openserport(arg, 9600); - if (sp_fd < 0) { + if (sp_fd == SER_INV_FD) { free(arg); return 1; } diff --git a/serprog.c b/serprog.c index edc5a7b..98c839e 100644 --- a/serprog.c +++ b/serprog.c @@ -372,7 +372,7 @@ int serprog_init(void) } if (strlen(device)) { sp_fd = sp_openserport(device, atoi(baudport)); - if (sp_fd < 0) { + if (sp_fd == SER_INV_FD) { free(device); return 1; } -- Kind regards, Stefan Tauner

1 0

[PATCH 2/3] Break endless loop in serialport_write().
by Stefan Tauner 26 Nov '12

26 Nov '12

serialport_write could loop endlessly when used with a seemingly valid port that does always return 0 on writes instead of an error. Give up after 10k tries. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- serial.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/serial.c b/serial.c index 11a749c..a3cdefb 100644 --- a/serial.c +++ b/serial.c @@ -264,6 +264,7 @@ int serialport_write(unsigned char *buf, unsigned int writecnt) #else ssize_t tmp = 0; #endif + uint empty_writes = 10000; while (writecnt > 0) { #ifdef _WIN32 @@ -275,9 +276,15 @@ int serialport_write(unsigned char *buf, unsigned int writecnt) msg_perr("Serial port write error!\n"); return 1; } - if (!tmp) + if (!tmp) { msg_pdbg("Empty write\n"); - writecnt -= tmp; + empty_writes--; + if (empty_writes == 0) { + msg_perr("Serial port seems dead!\n"); + return 1; + } + } + writecnt -= tmp; buf += tmp; } -- Kind regards, Stefan Tauner

1 0

[PATCH 1/3] Fix error message in sp_openserport().
by Stefan Tauner 26 Nov '12

26 Nov '12

free seems to touch errno on windows...? Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- serial.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/serial.c b/serial.c index 7e47dcc..11a749c 100644 --- a/serial.c +++ b/serial.c @@ -109,6 +109,7 @@ fdtype sp_openserport(char *dev, unsigned int baud) #ifdef _WIN32 HANDLE fd; char *dev2 = dev; + int err; if ((strlen(dev) > 3) && (tolower((unsigned char)dev[0]) == 'c') && (tolower((unsigned char)dev[1]) == 'o') && (tolower((unsigned char)dev[2]) == 'm')) { @@ -122,10 +123,11 @@ fdtype sp_openserport(char *dev, unsigned int baud) } fd = CreateFile(dev2, GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, NULL); + err = errno; // free may change errno if (dev2 != dev) free(dev2); if (fd == INVALID_HANDLE_VALUE) { - msg_perr("Error: cannot open serial port: %s\n", strerror(errno)); + msg_perr("Error: cannot open serial port: %s\n", strerror(err)); return SER_INV_FD; } DCB dcb; -- Kind regards, Stefan Tauner

1 0

[PATCH 0/3] serial woes
by Stefan Tauner 26 Nov '12

26 Nov '12

Idwer noticed a few problems... these patches try to fix them. Idwer please try one at the time and report if they work as intended: the first one should fix the "no error" message, the second one should stop the loop after 10k tries, the third one should fix the underlying problem for good. Stefan Tauner (3): Fix error message in sp_openserport(). Break endless loop in serialport_write(). Fix sp_openserport users on Windows. buspirate_spi.c | 2 +- pony_spi.c | 2 +- serial.c | 15 ++++++++++++--- serprog.c | 2 +- 4 files changed, 15 insertions(+), 6 deletions(-) -- Kind regards, Stefan Tauner

1 0

W836xx: Vico : flashrom -V
by Siniša R. 25 Nov '12

25 Nov '12

flashrom v0.9.6.1-r1563 on Linux 3.5.0-19-generic (i686) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.9, GCC 4.7.1, little endian Command line (3 args): flashrom -V -p internal Calibrating delay loop... OS timer resolution is 2 usecs, 1728M loops per second, 10 myus = 11 us, 100 myus = 101 us, 1000 myus = 998 us, 10000 myus = 14494 us, 8 myus = 9 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "Acer, inc." DMI string system-product-name: "TravelMate 6231 " DMI string system-version: "Not Applicable" DMI string baseboard-manufacturer: "Acer, Inc." DMI string baseboard-product-name: "Vico " DMI string baseboard-version: "Not Applicable" DMI string chassis-type: "Other" DMI chassis-type is not specific enough. W836xx enter config mode worked or we were already in config mode. W836xx leave config mode had no effect. Active config mode, unknown reg 0x20 ID: fc. Please send the output of "flashrom -V" to flashrom(a)flashrom.org with W836xx: your board name: flashrom -V as the subject to help us finish support for your Super I/O. Thanks. ======================================================================== WARNING! You may be running flashrom on an unsupported laptop. We could not detect this for sure because your vendor has not setup the SMBIOS tables correctly. You can enforce execution by adding '-p internal:laptop=this_is_not_a_laptop' to the command line, but please read the following warning if you are not sure. Laptops, notebooks and netbooks are difficult to support and we recommend to use the vendor flashing utility. The embedded controller (EC) in these machines often interacts badly with flashing. See http://www.flashrom.org/Laptops for details. If flash is shared with the EC, erase is guaranteed to brick your laptop and write may brick your laptop. Read and probe may irritate your EC and cause fan failure, backlight failure and sudden poweroff. You have been warned. ======================================================================== Aborting. Error: Programmer initialization failed.

1 0

flashrom -V
by nicolas gras 24 Nov '12

24 Nov '12

flashrom v0.9.5.2-r1517 on Linux 3.2.0-24-generic (x86_64), built with libpci 3.1.8, GCC 4.6.3, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 1 usecs, 869M loops per second, 10 myus = 11 us, 100 myus = 100 us, 1000 myus = 999 us, 10000 myus = 10072 us, 4 myus = 5 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "System manufacturer" DMI string system-product-name: "System Product Name" DMI string system-version: "System Version" DMI string baseboard-manufacturer: "ASUSTeK Computer INC." DMI string baseboard-product-name: "M2N-MX SE Plus" DMI string baseboard-version: "Rev x.xx" DMI string chassis-type: "Desktop" Found ITE Super I/O, ID 0x8712 on port 0x2e Found chipset "NVIDIA MCP61" with PCI ID 10de:03e0. Enabling flash write... This chipset is not really supported yet. Guesswork... ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0 Flash bus type is SPI SPI on this chipset is WIP. Please report any success or failure by mailing us the verbose output to flashrom(a)flashrom.org, thanks! Found SMBus device 10de:03eb at 00:01:1 MCP SPI BAR is at 0xfec80000 SPI control is 0x0002, req=0, gnt=0 Please send the output of "flashrom -V" to flashrom(a)flashrom.org with your board name: flashrom -V as the subject to help us finish support for your chipset. Thanks. OK. Super I/O ID 0x8712 is not on the list of flash capable controllers. The following protocols are supported: SPI. Probing for AMIC A25L05PT, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L05PU, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L10PT, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L10PU, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L20PT, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L20PU, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L40PT, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L40PU, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L80P, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L16PT, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L16PU, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L512, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L010, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L020, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L040, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L080, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L016, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L032, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25LQ032, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF021, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF041A, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF081, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF081A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF161, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF321, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF321A, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF641(A), 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DQ161, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25F512B, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25FS010, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25FS040, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF041, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF081A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF161, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF161A, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26F004, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45CS1282, 16896 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB011D, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB021D, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB041D, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB081D, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB161D, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB321C, 4224 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB321D, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB642D, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for EMST F25L008A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B05, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B05T, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B10T, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B20T, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B40T, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B80T, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B16T, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B32T, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B64T, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F05, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25Q40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25Q80(A), 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25Q32(A/B), 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25QH16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L512, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1005, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L2005, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L4005, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L8005, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Chip status register is 00 Chip status register: Status Register Write Disable (SRWD) is not set Chip status register: Bit 6 is not set Chip status register: Bit 5 / Block Protect 3 (BP3) is not set Chip status register: Bit 4 / Block Protect 2 (BP2) is not set Chip status register: Bit 3 / Block Protect 1 (BP1) is not set Chip status register: Bit 2 / Block Protect 0 (BP0) is not set Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Found Macronix flash chip "MX25L8005" (1024 kB, SPI) at physical address 0xfff00000. Probing for Macronix MX25L1605, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1635D, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1635E, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L3205, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L3235D, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L6405, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L12805, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV010, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV016B, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV020, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV040, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV080B, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV512, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Sanyo LF25FW203A, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL004A, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL008A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL016A, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL032A, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25LF040A, 512 kB: probe_spi_res2: id1 0x13, id2 0x13 Probing for SST SST25LF080A, 1024 kB: probe_spi_res2: id1 0x13, id2 0x13 Probing for SST SST25VF010, 128 kB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF032B, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF064C, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF040, 512 kB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF040B, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF080B, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P05-A, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P05, 64 kB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P10, 128 kB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P40-old, 512 kB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P128, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25X64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Unknown SFDP-capable chip, 0 kB: No SFDP signature found. Probing for AMIC unknown AMIC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel unknown Atmel SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon unknown Eon SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix unknown Macronix SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC unknown PMC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST unknown SST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST unknown ST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Generic unknown SPI chip (RDID), 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0xc2, id2 0x13 Found Macronix flash chip "MX25L8005" (1024 kB, SPI). No operations were specified.

1 0

Re: [flashrom] [PATCH] Enable VX855 chipset
by Stefan Tauner 24 Nov '12

24 Nov '12

On Sat, 20 Oct 2012 23:31:52 -0400 John Schmerge <jbschmerge(a)gmail.com> wrote: > Hi Stefan, i'm sorry for the rather slow response, i've been taking > some time away from everything tech related. Someone you may wish to > reach out to to ask about this is Ian Geiser at Devon IT (my former > employer)... His email address is igeiser(a)devonit.com Hello Ian, is Devon still using flashrom with (newer) VIA chipsets? We have included a number of improvements/support for additional models in r1578*, but were not able to test them on real hardware but VX900 with SPI. If you have access to affected boards, we would be glad if you could at least run some probing runs (and send us the output). * http://flashrom.org/trac/flashrom/changeset/1578/trunk -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] [PATCH] Improve --help and friends.
by Paul Menzel 24 Nov '12

24 Nov '12

Am Samstag, den 24.11.2012, 18:44 +0100 schrieb Stefan Tauner: > More clear "variable" names, better explanation if now programmer is selected etc. s,now,no, > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> > --- > cli_classic.c | 78 +++++++++++++++++++++++++-------------------------------- > flashrom.c | 1 - > print.c | 1 + > 3 files changed, 35 insertions(+), 45 deletions(-) > > diff --git a/cli_classic.c b/cli_classic.c > index ccf75e9..0d28d15 100644 > --- a/cli_classic.c > +++ b/cli_classic.c > @@ -33,58 +33,42 @@ > > static void cli_classic_usage(const char *name) > { > - printf("Usage: flashrom [-h|-R|-L|" > + printf("Please note that the command line interface for flashrom has changed between\n" > + "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n"); > + > + printf("Usage: %s [-h|-R|-L|" > #if CONFIG_PRINT_WIKI == 1 > - "-z|" > + "-z|" Indentation is changed? > #endif […] I quickly looked over it and could not find any suspicious. It is hard though as there are a lot of white space changes. Acked-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Thanks, Paul

2 1

[commit] r1624 - trunk
by repository service 24 Nov '12

24 Nov '12

Author: stefanct Date: Sat Nov 24 19:59:39 2012 New Revision: 1624 URL: http://flashrom.org/trac/flashrom/changeset/1624 Log: Improve --help and friends. More clear "variable" names, better explanation if no programmer is selected etc. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Modified: trunk/cli_classic.c trunk/flashrom.c trunk/print.c Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Tue Nov 20 22:06:16 2012 (r1623) +++ trunk/cli_classic.c Sat Nov 24 19:59:39 2012 (r1624) @@ -33,58 +33,42 @@ static void cli_classic_usage(const char *name) { - printf("Usage: flashrom [-h|-R|-L|" + printf("Please note that the command line interface for flashrom has changed between\n" + "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n"); + + printf("Usage: %s [-h|-R|-L|" #if CONFIG_PRINT_WIKI == 1 - "-z|" + "-z|" #endif - "-p <programmername>[:<parameters>]\n" - " [-E|-r <file>|-w <file>|-v <file>] [-c <chipname>]\n" - " [-l <file> [-i <image>]] [-n] [-f]]\n" - " [-V[V[V]]] [-o <logfile>]\n\n"); - - printf("Please note that the command line interface for flashrom has " - "changed between\n" - "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n" - "Do not use flashrom in scripts or other automated tools " - "without checking\n" - "that your flashrom version won't interpret options in a " - "different way.\n\n"); - - printf(" -h | --help print this help text\n" - " -R | --version print version (release)\n" - " -r | --read <file> read flash and save to " - "<file>\n" - " -w | --write <file> write <file> to flash\n" - " -v | --verify <file> verify flash against " - "<file>\n" - " -E | --erase erase flash device\n" - " -V | --verbose more verbose output\n" - " -c | --chip <chipname> probe only for specified " - "flash chip\n" - " -f | --force force specific operations " - "(see man page)\n" - " -n | --noverify don't auto-verify\n" - " -l | --layout <file> read ROM layout from " - "<file>\n" - " -i | --image <name> only flash image <name> " - "from flash layout\n" - " -o | --output <name> log to file <name>\n" - " -L | --list-supported print supported devices\n" + "-p <programmername>[:<parameters>] [-c <chipname>]\n" + "[-E|(-r|-w|-v) <file>] [-l <layoutfile> [-i <imagename>]...] [-n] [-f]]\n" + "[-V[V[V]]] [-o <logfile>]\n\n", name); + + printf(" -h | --help print this help text\n" + " -R | --version print version (release)\n" + " -r | --read <file> read flash and save to <file>\n" + " -w | --write <file> write <file> to flash\n" + " -v | --verify <file> verify flash against <file>\n" + " -E | --erase erase flash memory\n" + " -V | --verbose more verbose output\n" + " -c | --chip <chipname> probe only for specified flash chip\n" + " -f | --force force specific operations (see man page)\n" + " -n | --noverify don't auto-verify\n" + " -l | --layout <layoutfile> read ROM layout from <layoutfile>\n" + " -i | --image <name> only flash image <name> from flash layout\n" + " -o | --output <logfile> log output to <logfile>\n" + " -L | --list-supported print supported devices\n" #if CONFIG_PRINT_WIKI == 1 - " -z | --list-supported-wiki print supported devices " - "in wiki syntax\n" + " -z | --list-supported-wiki print supported devices in wiki syntax\n" #endif - " -p | --programmer <name>[:<param>] specify the programmer " - "device\n"); - - list_programmers_linebreak(37, 80, 1); - printf("\nYou can specify one of -h, -R, -L, " + " -p | --programmer <name>[:<param>] specify the programmer device. One of\n"); + list_programmers_linebreak(4, 80, 0); + printf(".\n\nYou can specify one of -h, -R, -L, " #if CONFIG_PRINT_WIKI == 1 "-z, " #endif "-E, -r, -w, -v or no operation.\n" - "If no operation is specified, flashrom will only probe for " - "flash chips.\n\n"); + "If no operation is specified, flashrom will only probe for flash chips.\n"); } static void cli_classic_abort_usage(void) @@ -296,6 +280,7 @@ fprintf(stderr, "Error: Unknown programmer \"%s\". Valid choices are:\n", optarg); list_programmers_linebreak(0, 80, 0); + msg_ginfo(".\n"); cli_classic_abort_usage(); } break; @@ -407,8 +392,13 @@ programmer_table[CONFIG_DEFAULT_PROGRAMMER].name); } else { msg_perr("Please select a programmer with the --programmer parameter.\n" + "Previously this was not necessary because there was a default set.\n" +#if CONFIG_INTERNAL == 1 + "To choose the mainboard of this computer use 'internal'. " +#endif "Valid choices are:\n"); list_programmers_linebreak(0, 80, 0); + msg_ginfo(".\n"); ret = 1; goto out; } Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Tue Nov 20 22:06:16 2012 (r1623) +++ trunk/flashrom.c Sat Nov 24 19:59:39 2012 (r1624) @@ -1461,7 +1461,6 @@ } else { if (paren) msg_ginfo(")"); - msg_ginfo("\n"); } } } Modified: trunk/print.c ============================================================================== --- trunk/print.c Tue Nov 20 22:06:16 2012 (r1623) +++ trunk/print.c Sat Nov 24 19:59:39 2012 (r1624) @@ -440,6 +440,7 @@ msg_ginfo("\nSupported programmers:\n"); list_programmers_linebreak(0, 80, 0); + msg_ginfo("\n"); #if CONFIG_INTERNAL == 1 msg_ginfo("\nSupported devices for the %s programmer:\n\n", programmer_table[PROGRAMMER_INTERNAL].name);

1 0

[PATCH] Improve --help and friends.
by Stefan Tauner 24 Nov '12

24 Nov '12

More clear "variable" names, better explanation if now programmer is selected etc. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- cli_classic.c | 78 +++++++++++++++++++++++++-------------------------------- flashrom.c | 1 - print.c | 1 + 3 files changed, 35 insertions(+), 45 deletions(-) diff --git a/cli_classic.c b/cli_classic.c index ccf75e9..0d28d15 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -33,58 +33,42 @@ static void cli_classic_usage(const char *name) { - printf("Usage: flashrom [-h|-R|-L|" + printf("Please note that the command line interface for flashrom has changed between\n" + "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n"); + + printf("Usage: %s [-h|-R|-L|" #if CONFIG_PRINT_WIKI == 1 - "-z|" + "-z|" #endif - "-p <programmername>[:<parameters>]\n" - " [-E|-r <file>|-w <file>|-v <file>] [-c <chipname>]\n" - " [-l <file> [-i <image>]] [-n] [-f]]\n" - " [-V[V[V]]] [-o <logfile>]\n\n"); - - printf("Please note that the command line interface for flashrom has " - "changed between\n" - "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n" - "Do not use flashrom in scripts or other automated tools " - "without checking\n" - "that your flashrom version won't interpret options in a " - "different way.\n\n"); - - printf(" -h | --help print this help text\n" - " -R | --version print version (release)\n" - " -r | --read <file> read flash and save to " - "<file>\n" - " -w | --write <file> write <file> to flash\n" - " -v | --verify <file> verify flash against " - "<file>\n" - " -E | --erase erase flash device\n" - " -V | --verbose more verbose output\n" - " -c | --chip <chipname> probe only for specified " - "flash chip\n" - " -f | --force force specific operations " - "(see man page)\n" - " -n | --noverify don't auto-verify\n" - " -l | --layout <file> read ROM layout from " - "<file>\n" - " -i | --image <name> only flash image <name> " - "from flash layout\n" - " -o | --output <name> log to file <name>\n" - " -L | --list-supported print supported devices\n" + "-p <programmername>[:<parameters>] [-c <chipname>]\n" + "[-E|(-r|-w|-v) <imagefile>] [-l <layoutfile> [-i <imagename>]...] [-n] [-f]]\n" + "[-V[V[V]]] [-o <logfile>]\n\n", name); + + printf(" -h | --help print this help text\n" + " -R | --version print version (release)\n" + " -r | --read <imagefile> read flash and save to <imagefile>\n" + " -w | --write <imagefile> write <imagefile> to flash\n" + " -v | --verify <imagefile> verify flash against <imagefile>\n" + " -E | --erase erase flash memory\n" + " -V | --verbose more verbose output\n" + " -c | --chip <chipname> probe only for specified flash chip\n" + " -f | --force force specific operations (see man page)\n" + " -n | --noverify don't auto-verify\n" + " -l | --layout <layoutfile> read ROM layout from <layoutfile>\n" + " -i | --image <name> only flash image <name> from flash layout\n" + " -o | --output <logfile> log output to <logfile>\n" + " -L | --list-supported print supported devices\n" #if CONFIG_PRINT_WIKI == 1 - " -z | --list-supported-wiki print supported devices " - "in wiki syntax\n" + " -z | --list-supported-wiki print supported devices in wiki syntax\n" #endif - " -p | --programmer <name>[:<param>] specify the programmer " - "device\n"); - - list_programmers_linebreak(37, 80, 1); - printf("\nYou can specify one of -h, -R, -L, " + " -p | --programmer <name>[:<param>] specify the programmer device. One of\n"); + list_programmers_linebreak(4, 80, 0); + printf(".\n\nYou can specify one of -h, -R, -L, " #if CONFIG_PRINT_WIKI == 1 "-z, " #endif "-E, -r, -w, -v or no operation.\n" - "If no operation is specified, flashrom will only probe for " - "flash chips.\n\n"); + "If no operation is specified, flashrom will only probe for flash chips.\n"); } static void cli_classic_abort_usage(void) @@ -296,6 +280,7 @@ int main(int argc, char *argv[]) fprintf(stderr, "Error: Unknown programmer \"%s\". Valid choices are:\n", optarg); list_programmers_linebreak(0, 80, 0); + msg_ginfo(".\n"); cli_classic_abort_usage(); } break; @@ -407,8 +392,13 @@ int main(int argc, char *argv[]) programmer_table[CONFIG_DEFAULT_PROGRAMMER].name); } else { msg_perr("Please select a programmer with the --programmer parameter.\n" + "Previously this was not necessary because there was a default set.\n" +#if CONFIG_INTERNAL == 1 + "To choose the mainboard of this computer use 'internal'. " +#endif "Valid choices are:\n"); list_programmers_linebreak(0, 80, 0); + msg_ginfo(".\n"); ret = 1; goto out; } diff --git a/flashrom.c b/flashrom.c index 2299b06..e2ad170 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1461,7 +1461,6 @@ void list_programmers_linebreak(int startcol, int cols, int paren) } else { if (paren) msg_ginfo(")"); - msg_ginfo("\n"); } } } diff --git a/print.c b/print.c index d7bdbfe..5f6ae43 100644 --- a/print.c +++ b/print.c @@ -440,6 +440,7 @@ int print_supported(void) msg_ginfo("\nSupported programmers:\n"); list_programmers_linebreak(0, 80, 0); + msg_ginfo("\n"); #if CONFIG_INTERNAL == 1 msg_ginfo("\nSupported devices for the %s programmer:\n\n", programmer_table[PROGRAMMER_INTERNAL].name); -- Kind regards, Stefan Tauner

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom November 2012