flashrom November 2012

flashrom@flashrom.org

36 participants
95 discussions

Re: [flashrom] [PATCH] Bus Pirate: Speedup and firmware workarounds
by Carl-Daniel Hailfinger 02 Nov '12

02 Nov '12

Am 15.07.2012 21:28 schrieb Idwer Vollering: > 2012/6/13 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>: >> > Bus Pirate Firmware v5.5 and newer support a new SPI binary mode. Use it >> > if available. >> > Bus Pirate Firmware v6.1 and older have broken (too slow) SPI clock >> > divisor for any requested speed above 2 MHz. Force a downgrade to 2 MHz >> > for affected firmware versions. >> > flashrom will recommend to upgrade the Bus Pirate Firmware if it is >> > older than v6.2. >> > >> > Somewhat tested, code still needs to be cleaned up in a few spots. > Tested with reading/erasing/writing a MX25L1605 on a Thinkpad X60 > mainboard, using buspirate hardware v3.a running firmware v6.2-test > that can be found here (bp-spifix.zip): > http://dangerousprototypes.com/forum/viewtopic.php?f=40&t=3864&sid=426d3213… Thanks for the comments! There are indeed quite a few magic constants, and replacing them with #defines makes sense. That's something I'd leave to another patch, though. New version. Support the new fast SPI mode present in Bus Pirate firmware v5.5 or newer. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-buspirate_newcommands/buspirate_spi.c =================================================================== --- flashrom-buspirate_newcommands/buspirate_spi.c (Revision 1620) +++ flashrom-buspirate_newcommands/buspirate_spi.c (Arbeitskopie) @@ -1,7 +1,7 @@ /* * This file is part of the flashrom project. * - * Copyright (C) 2009, 2010 Carl-Daniel Hailfinger + * Copyright (C) 2009, 2010, 2011, 2012 Carl-Daniel Hailfinger * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -129,14 +129,16 @@ return ret; } -static int buspirate_spi_send_command(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, - const unsigned char *writearr, unsigned char *readarr); +static int buspirate_spi_send_command_v1(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr); +static int buspirate_spi_send_command_v2(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr); -static const struct spi_programmer spi_programmer_buspirate = { +static struct spi_programmer spi_programmer_buspirate = { .type = SPI_CONTROLLER_BUSPIRATE, - .max_data_read = 12, - .max_data_write = 12, - .command = buspirate_spi_send_command, + .max_data_read = MAX_DATA_UNSPECIFIED, + .max_data_write = MAX_DATA_UNSPECIFIED, + .command = NULL, .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, @@ -253,7 +255,11 @@ if (register_shutdown(buspirate_spi_shutdown, NULL)) return 1; - /* This is the brute force version, but it should work. */ + /* This is the brute force version, but it should work. + * It is likely to fail if a previous flashrom run was aborted during a write with the new SPI commands + * in firmware v5.5 because that firmware may wait for up to 4096 bytes of input before responding to + * 0x00 again. The obvious workaround (sending 4096 bytes of \0) may cause significant startup delays. + */ for (i = 0; i < 20; i++) { /* Enter raw bitbang mode */ bp_commbuf[0] = 0x00; @@ -327,6 +333,27 @@ return SPI_PROGRAMMER_ERROR; } + /* Use fast SPI mode in firmware 5.5 and newer. */ + if (BP_FWVERSION(fw_version_major, fw_version_minor) >= BP_FWVERSION(5, 5)) { + msg_pdbg("Using SPI command set v2.\n"); + /* Sensible default buffer size. */ + if (buspirate_commbuf_grow(260 + 5)) + return ERROR_OOM; + spi_programmer_buspirate.max_data_read = 2048; + spi_programmer_buspirate.max_data_write = 256; + spi_programmer_buspirate.command = buspirate_spi_send_command_v2; + } else { + msg_pinfo("Bus Pirate firmware 5.4 and older does not support fast SPI access.\n"); + msg_pinfo("Reading/writing a flash chip may take hours.\n"); + msg_pinfo("It is recommended to upgrade to firmware 5.5 or newer.\n"); + /* Sensible default buffer size. */ + if (buspirate_commbuf_grow(16 + 3)) + return ERROR_OOM; + spi_programmer_buspirate.max_data_read = 12; + spi_programmer_buspirate.max_data_write = 12; + spi_programmer_buspirate.command = buspirate_spi_send_command_v1; + } + /* Workaround for broken speed settings in firmware 6.1 and older. */ if (BP_FWVERSION(fw_version_major, fw_version_minor) < BP_FWVERSION(6, 2)) if (spispeed > 0x4) { @@ -412,11 +439,8 @@ return 0; } -static int buspirate_spi_send_command(struct flashctx *flash, - unsigned int writecnt, - unsigned int readcnt, - const unsigned char *writearr, - unsigned char *readarr) +static int buspirate_spi_send_command_v1(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr) { unsigned int i = 0; int ret = 0; @@ -467,3 +491,43 @@ return ret; } + +static int buspirate_spi_send_command_v2(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr) +{ + int i = 0, ret = 0; + + if (writecnt > 4096 || readcnt > 4096 || (readcnt + writecnt) > 4096) + return SPI_INVALID_LENGTH; + + /* 5 bytes extra for command, writelen, readlen. + * 1 byte extra for Ack/Nack. + */ + if (buspirate_commbuf_grow(max(writecnt + 5, readcnt + 1))) + return ERROR_OOM; + + /* Combined SPI write/read. */ + bp_commbuf[i++] = 0x04; + bp_commbuf[i++] = (writecnt >> 8) & 0xff; + bp_commbuf[i++] = writecnt & 0xff; + bp_commbuf[i++] = (readcnt >> 8) & 0xff; + bp_commbuf[i++] = readcnt & 0xff; + memcpy(bp_commbuf + i, writearr, writecnt); + + ret = buspirate_sendrecv(bp_commbuf, i + writecnt, 1 + readcnt); + + if (ret) { + msg_perr("Bus Pirate communication error!\n"); + return SPI_GENERIC_ERROR; + } + + if (bp_commbuf[0] != 0x01) { + msg_perr("Protocol error while sending SPI write/read!\n"); + return SPI_GENERIC_ERROR; + } + + /* Skip Ack. */ + memcpy(readarr, bp_commbuf + 1, readcnt); + + return ret; +} -- http://www.hailfinger.org/

1 1

[commit] r1621 - trunk
by repository service 02 Nov '12

02 Nov '12

Author: hailfinger Date: Fri Nov 2 00:38:51 2012 New Revision: 1621 URL: http://flashrom.org/trac/flashrom/changeset/1621 Log: Support the new fast SPI mode present in Bus Pirate firmware v5.5 or newer. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/buspirate_spi.c Modified: trunk/buspirate_spi.c ============================================================================== --- trunk/buspirate_spi.c Sun Oct 28 02:50:08 2012 (r1620) +++ trunk/buspirate_spi.c Fri Nov 2 00:38:51 2012 (r1621) @@ -1,7 +1,7 @@ /* * This file is part of the flashrom project. * - * Copyright (C) 2009, 2010 Carl-Daniel Hailfinger + * Copyright (C) 2009, 2010, 2011, 2012 Carl-Daniel Hailfinger * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -129,14 +129,16 @@ return ret; } -static int buspirate_spi_send_command(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, - const unsigned char *writearr, unsigned char *readarr); +static int buspirate_spi_send_command_v1(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr); +static int buspirate_spi_send_command_v2(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr); -static const struct spi_programmer spi_programmer_buspirate = { +static struct spi_programmer spi_programmer_buspirate = { .type = SPI_CONTROLLER_BUSPIRATE, - .max_data_read = 12, - .max_data_write = 12, - .command = buspirate_spi_send_command, + .max_data_read = MAX_DATA_UNSPECIFIED, + .max_data_write = MAX_DATA_UNSPECIFIED, + .command = NULL, .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, @@ -253,7 +255,11 @@ if (register_shutdown(buspirate_spi_shutdown, NULL)) return 1; - /* This is the brute force version, but it should work. */ + /* This is the brute force version, but it should work. + * It is likely to fail if a previous flashrom run was aborted during a write with the new SPI commands + * in firmware v5.5 because that firmware may wait for up to 4096 bytes of input before responding to + * 0x00 again. The obvious workaround (sending 4096 bytes of \0) may cause significant startup delays. + */ for (i = 0; i < 20; i++) { /* Enter raw bitbang mode */ bp_commbuf[0] = 0x00; @@ -327,6 +333,27 @@ return SPI_PROGRAMMER_ERROR; } + /* Use fast SPI mode in firmware 5.5 and newer. */ + if (BP_FWVERSION(fw_version_major, fw_version_minor) >= BP_FWVERSION(5, 5)) { + msg_pdbg("Using SPI command set v2.\n"); + /* Sensible default buffer size. */ + if (buspirate_commbuf_grow(260 + 5)) + return ERROR_OOM; + spi_programmer_buspirate.max_data_read = 2048; + spi_programmer_buspirate.max_data_write = 256; + spi_programmer_buspirate.command = buspirate_spi_send_command_v2; + } else { + msg_pinfo("Bus Pirate firmware 5.4 and older does not support fast SPI access.\n"); + msg_pinfo("Reading/writing a flash chip may take hours.\n"); + msg_pinfo("It is recommended to upgrade to firmware 5.5 or newer.\n"); + /* Sensible default buffer size. */ + if (buspirate_commbuf_grow(16 + 3)) + return ERROR_OOM; + spi_programmer_buspirate.max_data_read = 12; + spi_programmer_buspirate.max_data_write = 12; + spi_programmer_buspirate.command = buspirate_spi_send_command_v1; + } + /* Workaround for broken speed settings in firmware 6.1 and older. */ if (BP_FWVERSION(fw_version_major, fw_version_minor) < BP_FWVERSION(6, 2)) if (spispeed > 0x4) { @@ -412,11 +439,8 @@ return 0; } -static int buspirate_spi_send_command(struct flashctx *flash, - unsigned int writecnt, - unsigned int readcnt, - const unsigned char *writearr, - unsigned char *readarr) +static int buspirate_spi_send_command_v1(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr) { unsigned int i = 0; int ret = 0; @@ -467,3 +491,43 @@ return ret; } + +static int buspirate_spi_send_command_v2(struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, + const unsigned char *writearr, unsigned char *readarr) +{ + int i = 0, ret = 0; + + if (writecnt > 4096 || readcnt > 4096 || (readcnt + writecnt) > 4096) + return SPI_INVALID_LENGTH; + + /* 5 bytes extra for command, writelen, readlen. + * 1 byte extra for Ack/Nack. + */ + if (buspirate_commbuf_grow(max(writecnt + 5, readcnt + 1))) + return ERROR_OOM; + + /* Combined SPI write/read. */ + bp_commbuf[i++] = 0x04; + bp_commbuf[i++] = (writecnt >> 8) & 0xff; + bp_commbuf[i++] = writecnt & 0xff; + bp_commbuf[i++] = (readcnt >> 8) & 0xff; + bp_commbuf[i++] = readcnt & 0xff; + memcpy(bp_commbuf + i, writearr, writecnt); + + ret = buspirate_sendrecv(bp_commbuf, i + writecnt, 1 + readcnt); + + if (ret) { + msg_perr("Bus Pirate communication error!\n"); + return SPI_GENERIC_ERROR; + } + + if (bp_commbuf[0] != 0x01) { + msg_perr("Protocol error while sending SPI write/read!\n"); + return SPI_GENERIC_ERROR; + } + + /* Skip Ack. */ + memcpy(readarr, bp_commbuf + 1, readcnt); + + return ret; +}

1 0

Add a "device" parameter for Dediprog
by David Hendricks 01 Nov '12

01 Nov '12

This patch adds a "device" parameter for Dediprog which enables use of multiple dediprogs connected to a single machine. Very handy for test racks. Example usage: flashrom -p dediprog:device=0 flashrom -p dediprog:device=1 etc... The patch was originally written by Nathan Laredo, I'm just forwarding it upstream: Signed-off-by: Nathan Laredo <nil(a)google.com> Signed-off-by: David Hendricks <dhendrix(a)google.com> Index: dediprog.c =================================================================== --- dediprog.c (revision 1620) +++ dediprog.c (working copy) @@ -46,7 +46,9 @@ #endif /* Might be useful for other USB devices as well. static for now. */ -static struct usb_device *get_device_by_vid_pid(uint16_t vid, uint16_t pid) +/* device parameter allows user to specify one device of multiple installed */ +static struct usb_device *get_device_by_vid_pid(uint16_t vid, uint16_t pid, + int device) { struct usb_bus *bus; struct usb_device *dev; @@ -54,8 +56,11 @@ for (bus = usb_get_busses(); bus; bus = bus->next) for (dev = bus->devices; dev; dev = dev->next) if ((dev->descriptor.idVendor == vid) && - (dev->descriptor.idProduct == pid)) - return dev; + (dev->descriptor.idProduct == pid)) { + if (device == 0) + return dev; + device--; + } return NULL; } @@ -777,8 +782,9 @@ int dediprog_init(void) { struct usb_device *dev; - char *voltage; + char *voltage, *device; int millivolt = 3500; + int usedevice = 0; int ret; msg_pspew("%s\n", __func__); @@ -792,11 +798,21 @@ msg_pinfo("Setting voltage to %i mV\n", millivolt); } + device = extract_programmer_param("device"); + if (device) { + usedevice = strtol(device, NULL, 0); + free(device); + if (usedevice < 0) + return 1; + msg_pinfo("Using device %i\n", usedevice); + } + + /* Here comes the USB stuff. */ usb_init(); usb_find_busses(); usb_find_devices(); - dev = get_device_by_vid_pid(0x0483, 0xdada); + dev = get_device_by_vid_pid(0x0483, 0xdada, usedevice); if (!dev) { msg_perr("Could not find a Dediprog SF100 on USB!\n"); return 1; -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.

1 0

Re: [flashrom] laptop with no BIOS? or BIOS reflash pain
by Anton Shterenlikht 01 Nov '12

01 Nov '12

Date: Tue, 30 Oct 2012 21:28:22 +0100 Subject: Re: laptop with no BIOS? or BIOS reflash pain From: Idwer Vollering <vidwer(a)gmail.com> To: freebsd-questions(a)freebsd.org, flashrom(a)flashrom.org Another approach is to use an external SPI programmer: http://flashrom.org/Supported_programmers The 'downside' of this is that you need to take your laptop apart. ODM schematics of your laptop are found here: http://notebookschematic.com/wp-content/uploads/2010/06/6515b_6715s.png Downloads for BIOS updates: http://h20000.www2.hp.com/bizsupport/TechSupport/SoftwareIndex.jsp?lang=en&… and ftp://ftp.hp.com/pub/softpaq/sp55501-56000/sp55556.exe My guess (I am not a HP service technician) is that you need ROM.CAB/Rom.bin from sp55556.exe - you can use 7zip to extract Rom.bin This is probably way beyond my skills, but thanks anyway. Anton

1 0

Re: [flashrom] Reading EPROM on RTL8139
by Stefan Tauner 01 Nov '12

01 Nov '12

On Wed, 31 Oct 2012 20:58:36 +0300 Dmitry the Zuryanovich <dreadbit(a)gmail.com> wrote: > I'm tryng to read some old UV-erased 28 pin 27xx hi! which one? is it known to work with flashrom? please also include a verbose log (i.e. add -V to the command line). -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom November 2012