flashrom June 2011

flashrom@flashrom.org

50 participants
297 discussions

[PATCH] flashrom: fix typos in comments
by Peter Huewe 30 Jun '11

30 Jun '11

This patch fixes some common misspellings/typos in comments. Changes generated using codespell and reviewed manually lenght->length 2 ocassional->occasional 1 unsucessfull->unsuccessful 1 upto->up to 5 Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> --- buspirate_spi.c | 2 +- dmi.c | 2 +- serprog-protocol.txt | 2 +- serprog.c | 10 +++++----- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/buspirate_spi.c b/buspirate_spi.c index 3b9f487..f872309 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -203,7 +203,7 @@ int buspirate_spi_init(void) * sufficient either. Use a 1.5 ms delay inside the loop to make * mostly sure that at least one USB frame had time to arrive. * Looping only 5 times is not sufficient and causes the - * ocassional failure. + * occasional failure. * Folding the delay into the loop above is not reliable either. */ for (i = 0; i < 10; i++) { diff --git a/dmi.c b/dmi.c index cda6656..836b38b 100644 --- a/dmi.c +++ b/dmi.c @@ -119,7 +119,7 @@ static char *get_dmi_string(const char *string_name) while (!feof(dmidecode_pipe)) getc(dmidecode_pipe); if (pclose(dmidecode_pipe) != 0) { - msg_pinfo("dmidecode execution unsucessfull - continuing " + msg_pinfo("dmidecode execution unsuccessful - continuing " "without DMI info\n"); return NULL; } diff --git a/serprog-protocol.txt b/serprog-protocol.txt index c5464a4..52f901a 100644 --- a/serprog-protocol.txt +++ b/serprog-protocol.txt @@ -88,7 +88,7 @@ This define listing should help C coders - (it's here to be the single source fo #define S_CMD_Q_BUSTYPE 0x05 /* Query supported bustypes */ #define S_CMD_Q_CHIPSIZE 0x06 /* Query supported chipsize (2^n format) */ #define S_CMD_Q_OPBUF 0x07 /* Query operation buffer size */ -#define S_CMD_Q_WRNMAXLEN 0x08 /* Query Write to opbuf: Write-N maximum lenght */ +#define S_CMD_Q_WRNMAXLEN 0x08 /* Query Write to opbuf: Write-N maximum length */ #define S_CMD_R_BYTE 0x09 /* Read a single byte */ #define S_CMD_R_NBYTES 0x0A /* Read n bytes */ #define S_CMD_O_INIT 0x0B /* Initialize operation buffer */ diff --git a/serprog.c b/serprog.c index b91e376..124aa41 100644 --- a/serprog.c +++ b/serprog.c @@ -56,7 +56,7 @@ static int serprog_shutdown(void *data); #define S_CMD_Q_BUSTYPE 0x05 /* Query supported bustypes */ #define S_CMD_Q_CHIPSIZE 0x06 /* Query supported chipsize (2^n format) */ #define S_CMD_Q_OPBUF 0x07 /* Query operation buffer size */ -#define S_CMD_Q_WRNMAXLEN 0x08 /* Query opbuf-write-N maximum lenght */ +#define S_CMD_Q_WRNMAXLEN 0x08 /* Query opbuf-write-N maximum length */ #define S_CMD_R_BYTE 0x09 /* Read a single byte */ #define S_CMD_R_NBYTES 0x0A /* Read n bytes */ #define S_CMD_O_INIT 0x0B /* Initialize operation buffer */ @@ -168,9 +168,9 @@ static void sp_synchronize(void) usleep(1000 * 1000); sp_flush_incoming(); - /* Then try upto 8 times to send syncnop and get the correct special * - * return of NAK+ACK. Timing note: upto 10 characters, 10*50ms = * - * upto 500ms per try, 8*0.5s = 4s; +1s (above) = upto 5s sync * + /* Then try up to 8 times to send syncnop and get the correct special * + * return of NAK+ACK. Timing note: up to 10 characters, 10*50ms = * + * up to 500ms per try, 8*0.5s = 4s; +1s (above) = up to 5s sync * * attempt, ~1s if immediate success. */ for (i = 0; i < 8; i++) { int n; @@ -180,7 +180,7 @@ static void sp_synchronize(void) msg_pdbg("."); fflush(stdout); for (n = 0; n < 10; n++) { - c = sp_sync_read_timeout(5); /* wait upto 50ms */ + c = sp_sync_read_timeout(5); /* wait up to 50ms */ if (c != S_NAK) continue; c = sp_sync_read_timeout(2); -- 1.7.3.4

2 1

[PATCH 10/10] fixup! ichspi.c: add support for Intel Hardware Sequencing (was Re: [PATCH 8/8] squash! ichspi:c add support for Intel Hardware Sequencing)
by Stefan Tauner 30 Jun '11

30 Jun '11

the missing "& HSFC_FDBC" there makes it possible to enable smm interrupts as happened to dhendrix. lesson to learn: always check/limit input values even if they were previously constants ;) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] [PATCH 5/8] ichspi.c: refactor filling and reading the fdata/spid registers
by David Hendricks 30 Jun '11

30 Jun '11

A couple quick comments in-line below... On Mon, Jun 27, 2011 at 8:33 PM, Stefan Tauner < stefan.tauner(a)student.tuwien.ac.at> wrote: > > + static void ich_read_data(uint8_t *data, uint8_t len, int reg0_off) > + { > + int a; > + uint32_t temp32 = 0; > + > + if (len > spi_programmer->max_data_read) > + len = spi_programmer->max_data_read; > + > + for (a = 0; a < len; a++) { > + if ((a % 4) == 0) > + temp32 = REGREAD32(reg0_off + (a)); > + > + data[a] = (temp32 & (((uint32_t) 0xff) << ((a % 4) * 8))) > + >> ((a % 4) * 8); > How about "data[a] = (temp32 >> ((a % 4) * 8)) & 0xff" instead? That is clearer IMHO, and you won't even need to break the line. (80 columns really *is* enough :-P) On Mon, Jun 27, 2011 at 8:33 PM, Stefan Tauner < stefan.tauner(a)student.tuwien.ac.at> wrote: > +static uint8_t ich_fill_data(const uint8_t *data, uint8_t len, int > reg0_off) As mentioned on IRC, the caller tends to pass in a "len" value > 255, e.g. 1 block of 4096 bytes or more. Since len is handled as an int in the caller, it should probably get passed in as an int here. -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.

1 0

Re: [flashrom] [PATCH] Macronix MX25L6445E
by Wagner, Helge (GE Intelligent Platforms) 29 Jun '11

29 Jun '11

Sending once again 'cause my outlook introduced many extra line breaks in the patch. Now I am attaching it. Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> Regards, Helge -----Original Message----- From: flashrom-bounces(a)flashrom.org [mailto:flashrom-bounces@flashrom.org] On Behalf Of Wagner, Helge (GE Intelligent Platforms) Sent: Mittwoch, 29. Juni 2011 15:56 To: flashrom(a)flashrom.org Subject: Re: [flashrom] [PATCH] Macronix MX25L6445E Hello all, i have now re-worked my patch. This is the full description of the complete patch: -Fixed spi_block_erase_d8() block size for MX25L3205 was wrong. -Now using spi_block_erase_20_4or64k() erase function instead of spi_block_erase_20() which can handle both 4KB and 64KB block sizes for those flash chips that might have same id but different erase block sizes. -New probe function added (probe_spi_mx_2017()) to differentiate MX25L6445E and MX25L6405. Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> I have also included log files for the MX25L6445E. Regards, Helge Wagner diff -u flashrom/chipdrivers.h flashrom-patched/chipdrivers.h --- flashrom/chipdrivers.h 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/chipdrivers.h 2011-06-28 14:38:54.000000000 +0200 @@ -31,9 +31,11 @@ int probe_spi_rems(struct flashchip *flash); int probe_spi_res1(struct flashchip *flash); int probe_spi_res2(struct flashchip *flash); +int probe_spi_mx_2017(struct flashchip *flash); int spi_write_enable(void); int spi_write_disable(void); int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen); +int spi_block_erase_20_4or64k(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_52(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_d7(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_d8(struct flashchip *flash, unsigned int addr, unsigned int blocklen); diff -u flashrom/flashchips.c flashrom-patched/flashchips.c --- flashrom/flashchips.c 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/flashchips.c 2011-06-29 13:22:51.000000000 +0200 @@ -3959,14 +3959,14 @@ .total_size = 2048, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PRW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { { - .eraseblocks = { {4 * 1024, 512} }, - .block_erase = spi_block_erase_20, /* This erase function has 64k blocksize for eLiteFlash */ + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_20_4or64k, /* This erase function has 64k blocksize for eLiteFlash */ }, { .eraseblocks = { {64 * 1024, 32} }, /* Not supported in MX25L1605 (eLiteFlash) and MX25L1605D */ .block_erase = spi_block_erase_52, @@ -4063,16 +4063,16 @@ .total_size = 4096, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PRW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { { - .eraseblocks = { {4 * 1024, 1024} }, - .block_erase = spi_block_erase_20, + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_20_4or64k, }, { - .eraseblocks = { {4 * 1024, 1024} }, + .eraseblocks = { {64 * 1024, 64} }, .block_erase = spi_block_erase_d8, }, { .eraseblocks = { {4 * 1024 * 1024, 1} }, @@ -4132,12 +4132,46 @@ .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, .tested = TEST_OK_PROBE, - .probe = probe_spi_rdid, + .probe = probe_spi_mx_2017, .probe_timing = TIMING_ZERO, .block_erasers = { { .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_20_4or64k, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Macronix", + .name = "MX25L6445E", + .bustype = CHIP_BUSTYPE_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25L6445E, + .total_size = 8192, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_mx_2017, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, .block_erase = spi_block_erase_20, }, { .eraseblocks = { {64 * 1024, 128} }, diff -u flashrom/flashchips.h flashrom-patched/flashchips.h --- flashrom/flashchips.h 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/flashchips.h 2011-06-28 16:24:07.000000000 +0200 @@ -356,7 +356,8 @@ #define MACRONIX_MX25L8005 0x2014 /* Same as MX25V8005 */ #define MACRONIX_MX25L1605 0x2015 /* MX25L1605{,A,D} */ #define MACRONIX_MX25L3205 0x2016 /* MX25L3205{,A} */ -#define MACRONIX_MX25L6405 0x2017 /* MX25L3205{,D} */ +#define MACRONIX_MX25L6405 0x2017 /* MX25L6405, MX25L6406E */ +#define MACRONIX_MX25L6445E 0x16 /* MX25L6445E, MX25L6405D ID = REMS2 answer */ #define MACRONIX_MX25L12805 0x2018 /* MX25L12805 */ #define MACRONIX_MX25L1635D 0x2415 #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ diff -u flashrom/spi.h flashrom-patched/spi.h --- flashrom/spi.h 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/spi.h 2011-06-29 13:32:55.000000000 +0200 @@ -40,6 +40,21 @@ #define JEDEC_REMS_OUTSIZE 0x04 #define JEDEC_REMS_INSIZE 0x02 +/* Read Electronic Manufacturer Signature for 2x I/O mode */ +#define JEDEC_REMS2 0xef +#define JEDEC_REMS2_OUTSIZE 0x04 +#define JEDEC_REMS2_INSIZE 0x02 + +/* Read Electronic Manufacturer Signature for 4x I/O mode */ +#define JEDEC_REMS4 0xdf +#define JEDEC_REMS4_OUTSIZE 0x04 +#define JEDEC_REMS4_INSIZE 0x02 + +/* Read Electronic Manufacturer Signature for 4x I/O DT mode */ +#define JEDEC_REMS4D 0xcf +#define JEDEC_REMS4D_OUTSIZE 0x04 +#define JEDEC_REMS4D_INSIZE 0x02 + /* Read Electronic Signature */ #define JEDEC_RES 0xab #define JEDEC_RES_OUTSIZE 0x04 diff -u flashrom/spi25.c flashrom-patched/spi25.c --- flashrom/spi25.c 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/spi25.c 2011-06-29 13:09:59.000000000 +0200 @@ -22,6 +22,7 @@ * Contains the common SPI chip driver functions */ +#include <stdlib.h> #include <string.h> #include "flash.h" #include "flashchips.h" @@ -66,6 +67,27 @@ return 0; } +static int spi_rems2(unsigned char *readarr) { + unsigned char cmd[JEDEC_REMS2_OUTSIZE] = { JEDEC_REMS2, 0, 0, 0 }; + uint32_t readaddr; + int ret; + + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); + if (ret == SPI_INVALID_ADDRESS) { + /* Find the lowest even address allowed for reads. */ + readaddr = (spi_get_valid_read_addr() + 1) & ~1; + cmd[1] = (readaddr >> 16) & 0xff, + cmd[2] = (readaddr >> 8) & 0xff, + cmd[3] = (readaddr >> 0) & 0xff, + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); + } + if (ret) + return ret; + msg_cspew("REMS2 returned %02x %02x. ", readarr[0], readarr[1]); + return 0; +} + static int spi_res(unsigned char *readarr, int bytes) { unsigned char cmd[JEDEC_RES_OUTSIZE] = { JEDEC_RES, 0, 0, 0 }; @@ -173,6 +195,58 @@ return probe_spi_rdid_generic(flash, 3); } +int probe_spi_mx_2017(struct flashchip *flash) { + unsigned char readarr[4]; + uint32_t id1; + uint32_t id2; + uint32_t id3; + uint32_t id4; + + if (spi_rdid(readarr, 3)) { + msg_cdbg("\n"); + return 0; + } + id1 = readarr[0]; + id2 = (readarr[1] << 8) | readarr[2]; + + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6405) { + /* Now we have detected the 2017h class of Macronix flash devices. + * We can further differentiate two classes: + * -those who support the REMS2 function do always have 4KB sector size + * (at least i have not found one with 64KB yet), + * and + * -those who don't support the REMS2 function might have 4KB or 64KB + * (some have 4KB, e.g. MX25L6406E, some have 64KB, e.g. MX25L6405 (not D)) + * for erase function 20h. + */ + if (spi_rems2(readarr)) { + msg_cdbg("\n"); + return 0; + } + id3 = readarr[0]; + id4 = readarr[1]; + msg_cdbg("%s: id1 0x%02x, id2 0x%02x, id3 0x%02x, id4 0x%02x\n", __func__, id1, id2, id3, id4); + if (id3 == MACRONIX_ID && id4 == MACRONIX_MX25L6445E) { + /* MACRONIX_MX25L6445E class, always 4KB sector */ + if (flash->model_id == MACRONIX_MX25L6445E) + return 1; + else + return 0; + } else { + /* MACRONIX_MX25L6405 class, might have 4KB or 64KB sector */ + if (flash->model_id == MACRONIX_MX25L6405) + return 1; + else + return 0; + } + } else { + msg_cdbg("%s: id1 0x%02x, id2 0x%02x\n", __func__, id1, id2); + } + /* neither MACRONIX_MX25L6405 nor MACRONIX_MX25L6445E */ + return 0; +} + int probe_spi_rdid4(struct flashchip *flash) { /* Some SPI controllers do not support commands with writecnt=1 and @@ -694,6 +768,79 @@ return 0; } +/* Sector size might be 4KB or 64KB, but on call to this function this is unknown. + * So we do a first erase command and then check if mem in the complete 64KB sector is erased. + * If not we assume 4KB and so we repeat the erase for each 4KB sector in the 64KB block + * (which is not erased already). + * PLEASE NOTE: the .eraseblocks block size must be set to 64KB if you use this function. + */ +int spi_block_erase_20_4or64k(struct flashchip *flash, unsigned int addr, unsigned int blocklen) +{ + int result, i, j, fully_erased, sector_erased; + unsigned int curraddr, currblocklen; + uint8_t *readbuf; + + if (blocklen != (64 * 1024)) { + msg_gerr("%s: blocklen not 64KB! Please report a bug at " + "flashrom(a)flashrom.org\n", __func__); + return 1; + } + + readbuf = malloc(blocklen); + if (!readbuf) { + msg_gerr("Out of memory!\n"); + exit(1); + } + + for (i = 0; i < 16; i++) { /* there are 16 4KB sectors in 64KB */ + + curraddr = addr + (i * (4 * 1024)); + + if (i > 0) { + /* Skip the sector erase if the sector is already erased */ + sector_erased = 1; + result = flash->read(flash, readbuf, curraddr, (4 * 1024)); + if (result) { + msg_gerr("Erase impossible because read failed " + "at 0x%x (len 0x%x)\n", curraddr, (4 * 1024)); + break; + } + for (j = 0; j < currblocklen; j++) + if (readbuf[j] != 0xFF) + sector_erased = 0; + if (sector_erased) + continue; /* Sector is already erased */ + } + + result = spi_block_erase_20 (flash, curraddr, (4 * 1024)); /* last parameter (blocklen) is unused */ + if (result) break; + + if (0 == i) { + curraddr += 4 * 1024; + currblocklen = (64*1024)-(4*1024); + fully_erased = 1; + result = flash->read(flash, readbuf, curraddr, currblocklen); + if (result) { + msg_gerr("Erase impossible because read failed " + "at 0x%x (len 0x%x)\n", curraddr, currblocklen); + break; + } + for (j = 0; j < currblocklen; j++) + if (readbuf[j] != 0xFF) + fully_erased = 0; + if (fully_erased) { + /* This means either that the SE command has erased the full 64KB + * or that the remaining 64KB sector was already erased before. + * Anyhow, we can now exit without calling the SE command again. + */ + break; + } + } + } + free(readbuf); + return result; +} + int spi_block_erase_60(struct flashchip *flash, unsigned int addr, unsigned int blocklen) { if ((addr != 0) || (blocklen != flash->total_size * 1024)) { -----Original Message----- From: flashrom-bounces(a)flashrom.org [mailto:flashrom-bounces@flashrom.org] On Behalf Of Wagner, Helge (GE Intelligent Platforms) Sent: Mittwoch, 29. Juni 2011 13:57 To: flashrom(a)flashrom.org Subject: Re: [flashrom] [PATCH] Macronix MX25L6445E Hello all, as Stefan suggested ("what about 0x2015, 0x2016, 0x2018? do they also have such problems?"), I was looking at some more Macronix data sheets. While doing this, I found out that my solution is NOT sufficient for some of the Macronix 0x2017 flash chips. I am currently working on a solution for this problem. Please stand by. Regards, Helge -----Original Message----- From: flashrom-bounces+helge.wagner=ge.com(a)flashrom.org [mailto:flashrom-bounces+helge.wagner=ge.com@flashrom.org] On Behalf Of Carl-Daniel Hailfinger Sent: Montag, 27. Juni 2011 20:28 To: flashrom(a)flashrom.org Subject: Re: [flashrom] [PATCH] Macronix MX25L6445E Hello Helge, thanks for your patch. It looks good to me on a first glance, and I hope to review it in detail soon. A short comment (in reply to Stefan's review) is at the end of this mail. Am 27.06.2011 17:50 schrieb Stefan Tauner: > On Mon, 27 Jun 2011 17:06:42 +0200 > "Wagner, Helge (GE Intelligent Platforms)" <Helge.Wagner(a)ge.com> wrote: > > >> Hello Stefan, >> >> >>> i have not looked at the datasheet(s), but maybe there is a way to distinguish the two devices (with another id command for example)? >>> >> I have asked Macronix, and they suggest to use the REMS2 function, which is supported on the MX25L6445E (returns 0xC216) and is not supported on the MX25L6405 (according to Macronix, it returns 0x0000 or 0xFFFF for this command). >> >> So now there is no longer a need to re-order the erase functions for the MX25L6405. >> >> Here is my new patch. >> >> Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> >> >> Regards, >> Helge Wagner >> >> diff -u flashrom/chipdrivers.h flashrom-patched/chipdrivers.h >> --- flashrom/chipdrivers.h 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/chipdrivers.h 2011-06-27 16:29:25.000000000 +0200 >> @@ -31,6 +31,7 @@ >> int probe_spi_rems(struct flashchip *flash); int >> probe_spi_res1(struct flashchip *flash); int probe_spi_res2(struct >> flashchip *flash); >> +int probe_spi_mx_2017(struct flashchip *flash); >> int spi_write_enable(void); >> int spi_write_disable(void); >> int spi_block_erase_20(struct flashchip *flash, unsigned int addr, >> unsigned int blocklen); diff -u flashrom/flashchips.c flashrom-patched/flashchips.c >> --- flashrom/flashchips.c 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/flashchips.c 2011-06-27 16:26:34.000000000 +0200 >> @@ -4131,8 +4131,8 @@ >> .total_size = 8192, >> .page_size = 256, >> .feature_bits = FEATURE_WRSR_WREN, >> - .tested = TEST_OK_PROBE, >> - .probe = probe_spi_rdid, >> + .tested = TEST_UNTESTED, >> + .probe = probe_spi_mx_2017, >> .probe_timing = TIMING_ZERO, >> .block_erasers = >> { >> @@ -4141,6 +4141,40 @@ >> .block_erase = spi_block_erase_20, >> }, { >> .eraseblocks = { {64 * 1024, 128} }, >> + .block_erase = spi_block_erase_d8, >> + }, { >> + .eraseblocks = { {8 * 1024 * 1024, 1} }, >> + .block_erase = spi_block_erase_60, >> + }, { >> + .eraseblocks = { {8 * 1024 * 1024, 1} }, >> + .block_erase = spi_block_erase_c7, >> + } >> + }, >> + .unlock = spi_disable_blockprotect, >> + .write = spi_chip_write_256, >> + .read = spi_chip_read, >> + .voltage = {2700, 3600}, >> + }, >> + >> + { >> + .vendor = "Macronix", >> + .name = "MX25L6445E", >> + .bustype = CHIP_BUSTYPE_SPI, >> + .manufacture_id = MACRONIX_ID, >> + .model_id = MACRONIX_MX25L6445E, >> + .total_size = 8192, >> + .page_size = 256, >> + .feature_bits = FEATURE_WRSR_WREN, >> + .tested = TEST_OK_PREW, >> + .probe = probe_spi_mx_2017, >> + .probe_timing = TIMING_ZERO, >> + .block_erasers = >> + { >> + { >> + .eraseblocks = { {4 * 1024, 2048} }, >> + .block_erase = spi_block_erase_20, >> + }, { >> + .eraseblocks = { {64 * 1024, 128} }, >> .block_erase = spi_block_erase_d8, >> }, { >> .eraseblocks = { {8 * 1024 * 1024, 1} }, diff -u >> flashrom/flashchips.h flashrom-patched/flashchips.h >> --- flashrom/flashchips.h 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/flashchips.h 2011-06-27 15:46:22.000000000 +0200 >> @@ -356,7 +356,8 @@ >> #define MACRONIX_MX25L8005 0x2014 /* Same as MX25V8005 */ >> #define MACRONIX_MX25L1605 0x2015 /* MX25L1605{,A,D} */ >> #define MACRONIX_MX25L3205 0x2016 /* MX25L3205{,A} */ >> -#define MACRONIX_MX25L6405 0x2017 /* MX25L3205{,D} */ >> +#define MACRONIX_MX25L6405 0x2017 /* MX25L6405{,D} */ >> +#define MACRONIX_MX25L6445E 0x16 /* MX25L6445E, ID = REMS2 answer */ >> #define MACRONIX_MX25L12805 0x2018 /* MX25L12805 */ >> #define MACRONIX_MX25L1635D 0x2415 >> #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ >> diff -u flashrom/spi.h flashrom-patched/spi.h >> --- flashrom/spi.h 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/spi.h 2011-06-27 16:29:38.000000000 +0200 >> @@ -40,6 +40,11 @@ >> #define JEDEC_REMS_OUTSIZE 0x04 >> #define JEDEC_REMS_INSIZE 0x02 >> >> +/* Read Electronic Manufacturer Signature 2 */ >> +#define JEDEC_REMS2 0xEF >> +#define JEDEC_REMS2_OUTSIZE 0x04 >> +#define JEDEC_REMS2_INSIZE 0x02 >> + >> /* Read Electronic Signature */ >> #define JEDEC_RES 0xab >> #define JEDEC_RES_OUTSIZE 0x04 >> diff -u flashrom/spi25.c flashrom-patched/spi25.c >> --- flashrom/spi25.c 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/spi25.c 2011-06-27 16:30:33.000000000 +0200 >> @@ -66,6 +66,27 @@ >> return 0; >> } >> >> +static int spi_rems2(unsigned char *readarr) { >> + unsigned char cmd[JEDEC_REMS2_OUTSIZE] = { JEDEC_REMS2, 0, 0, 0 }; >> + uint32_t readaddr; >> + int ret; >> + >> + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); >> + if (ret == SPI_INVALID_ADDRESS) { >> + /* Find the lowest even address allowed for reads. */ >> + readaddr = (spi_get_valid_read_addr() + 1) & ~1; >> + cmd[1] = (readaddr >> 16) & 0xff, >> + cmd[2] = (readaddr >> 8) & 0xff, >> + cmd[3] = (readaddr >> 0) & 0xff, >> + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); >> + } >> + if (ret) >> + return ret; >> + msg_cspew("REMS2 returned %02x %02x. ", readarr[0], readarr[1]); >> + return 0; >> +} >> + >> static int spi_res(unsigned char *readarr, int bytes) { >> unsigned char cmd[JEDEC_RES_OUTSIZE] = { JEDEC_RES, 0, 0, 0 }; @@ >> -173,6 +194,49 @@ >> return probe_spi_rdid_generic(flash, 3); } >> >> +int probe_spi_mx_2017(struct flashchip *flash) { >> + unsigned char readarr[4]; >> + uint32_t id1; >> + uint32_t id2; >> + >> + if (spi_rdid(readarr, 3)) { >> + msg_cdbg("\n"); >> + return 0; >> + } >> + id1 = readarr[0]; >> + id2 = (readarr[1] << 8) | readarr[2]; >> + >> + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6405) { >> + /* We have either MACRONIX_MX25L6405 or MACRONIX_MX25L6445E. >> + * MACRONIX_MX25L6405 has 64KB for erase function 20h and does not support REMS2 function, >> + * MACRONIX_MX25L6445E has 4KB for erase function 20h and does support REMS2 function. >> + * So to differentiate both, we execute REMS2 function (this is suggested by macronix). >> + */ >> + if (spi_rems2(readarr)) { >> + msg_cdbg("\n"); >> + return 0; >> + } >> + id1 = readarr[0]; >> + id2 = readarr[1]; >> + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6445E) { >> + /* MACRONIX_MX25L6445E */ >> + if (flash->model_id == MACRONIX_MX25L6445E) >> + return 1; >> + else >> + return 0; >> + } else { >> + /* MACRONIX_MX25L6405 */ >> + if (flash->model_id == MACRONIX_MX25L6405) >> + return 1; >> + else >> + return 0; >> + } >> + } >> + /* neither MACRONIX_MX25L6405 nor MACRONIX_MX25L6445E */ >> + return 0; >> +} >> + >> int probe_spi_rdid4(struct flashchip *flash) { >> /* Some SPI controllers do not support commands with writecnt=1 and >> >> >> > hello again and thanks for all you have done. > > without looking at your patch in too much detail i would like to > mention another possibility to implement this. as i have done in my > sfdp and intel hardware sequencing patch you can alter the struct > flashchip *flash the probing function gets as parameter. > you can then change the erase block size (and name) according to the id > instead of using two chips and returning 0/1 respectively. > Please avoid changing struct flashchip *flash in the probe function unless it is absolutely necessary. The hack needed for SFDP should not spread elsewhere, especially if we can handle this nicely with two separate flashchip entries. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list flashrom(a)flashrom.org http://www.flashrom.org/mailman/listinfo/flashrom _______________________________________________ flashrom mailing list flashrom(a)flashrom.org http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] [PATCH] Macronix MX25L6445E
by Wagner, Helge (GE Intelligent Platforms) 29 Jun '11

29 Jun '11

Hello all, i have now re-worked my patch. This is the full description of the complete patch: -Fixed spi_block_erase_d8() block size for MX25L3205 was wrong. -Now using spi_block_erase_20_4or64k() erase function instead of spi_block_erase_20() which can handle both 4KB and 64KB block sizes for those flash chips that might have same id but different erase block sizes. -New probe function added (probe_spi_mx_2017()) to differentiate MX25L6445E and MX25L6405. Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> I have also included log files for the MX25L6445E. Regards, Helge Wagner diff -u flashrom/chipdrivers.h flashrom-patched/chipdrivers.h --- flashrom/chipdrivers.h 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/chipdrivers.h 2011-06-28 14:38:54.000000000 +0200 @@ -31,9 +31,11 @@ int probe_spi_rems(struct flashchip *flash); int probe_spi_res1(struct flashchip *flash); int probe_spi_res2(struct flashchip *flash); +int probe_spi_mx_2017(struct flashchip *flash); int spi_write_enable(void); int spi_write_disable(void); int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen); +int spi_block_erase_20_4or64k(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_52(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_d7(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_d8(struct flashchip *flash, unsigned int addr, unsigned int blocklen); diff -u flashrom/flashchips.c flashrom-patched/flashchips.c --- flashrom/flashchips.c 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/flashchips.c 2011-06-29 13:22:51.000000000 +0200 @@ -3959,14 +3959,14 @@ .total_size = 2048, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PRW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { { - .eraseblocks = { {4 * 1024, 512} }, - .block_erase = spi_block_erase_20, /* This erase function has 64k blocksize for eLiteFlash */ + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_20_4or64k, /* This erase function has 64k blocksize for eLiteFlash */ }, { .eraseblocks = { {64 * 1024, 32} }, /* Not supported in MX25L1605 (eLiteFlash) and MX25L1605D */ .block_erase = spi_block_erase_52, @@ -4063,16 +4063,16 @@ .total_size = 4096, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PRW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { { - .eraseblocks = { {4 * 1024, 1024} }, - .block_erase = spi_block_erase_20, + .eraseblocks = { {64 * 1024, 64} }, + .block_erase = spi_block_erase_20_4or64k, }, { - .eraseblocks = { {4 * 1024, 1024} }, + .eraseblocks = { {64 * 1024, 64} }, .block_erase = spi_block_erase_d8, }, { .eraseblocks = { {4 * 1024 * 1024, 1} }, @@ -4132,12 +4132,46 @@ .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, .tested = TEST_OK_PROBE, - .probe = probe_spi_rdid, + .probe = probe_spi_mx_2017, .probe_timing = TIMING_ZERO, .block_erasers = { { .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_20_4or64k, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Macronix", + .name = "MX25L6445E", + .bustype = CHIP_BUSTYPE_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25L6445E, + .total_size = 8192, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_mx_2017, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, .block_erase = spi_block_erase_20, }, { .eraseblocks = { {64 * 1024, 128} }, diff -u flashrom/flashchips.h flashrom-patched/flashchips.h --- flashrom/flashchips.h 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/flashchips.h 2011-06-28 16:24:07.000000000 +0200 @@ -356,7 +356,8 @@ #define MACRONIX_MX25L8005 0x2014 /* Same as MX25V8005 */ #define MACRONIX_MX25L1605 0x2015 /* MX25L1605{,A,D} */ #define MACRONIX_MX25L3205 0x2016 /* MX25L3205{,A} */ -#define MACRONIX_MX25L6405 0x2017 /* MX25L3205{,D} */ +#define MACRONIX_MX25L6405 0x2017 /* MX25L6405, MX25L6406E */ +#define MACRONIX_MX25L6445E 0x16 /* MX25L6445E, MX25L6405D ID = REMS2 answer */ #define MACRONIX_MX25L12805 0x2018 /* MX25L12805 */ #define MACRONIX_MX25L1635D 0x2415 #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ diff -u flashrom/spi.h flashrom-patched/spi.h --- flashrom/spi.h 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/spi.h 2011-06-29 13:32:55.000000000 +0200 @@ -40,6 +40,21 @@ #define JEDEC_REMS_OUTSIZE 0x04 #define JEDEC_REMS_INSIZE 0x02 +/* Read Electronic Manufacturer Signature for 2x I/O mode */ +#define JEDEC_REMS2 0xef +#define JEDEC_REMS2_OUTSIZE 0x04 +#define JEDEC_REMS2_INSIZE 0x02 + +/* Read Electronic Manufacturer Signature for 4x I/O mode */ +#define JEDEC_REMS4 0xdf +#define JEDEC_REMS4_OUTSIZE 0x04 +#define JEDEC_REMS4_INSIZE 0x02 + +/* Read Electronic Manufacturer Signature for 4x I/O DT mode */ +#define JEDEC_REMS4D 0xcf +#define JEDEC_REMS4D_OUTSIZE 0x04 +#define JEDEC_REMS4D_INSIZE 0x02 + /* Read Electronic Signature */ #define JEDEC_RES 0xab #define JEDEC_RES_OUTSIZE 0x04 diff -u flashrom/spi25.c flashrom-patched/spi25.c --- flashrom/spi25.c 2011-06-27 15:21:57.000000000 +0200 +++ flashrom-patched/spi25.c 2011-06-29 13:09:59.000000000 +0200 @@ -22,6 +22,7 @@ * Contains the common SPI chip driver functions */ +#include <stdlib.h> #include <string.h> #include "flash.h" #include "flashchips.h" @@ -66,6 +67,27 @@ return 0; } +static int spi_rems2(unsigned char *readarr) +{ + unsigned char cmd[JEDEC_REMS2_OUTSIZE] = { JEDEC_REMS2, 0, 0, 0 }; + uint32_t readaddr; + int ret; + + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); + if (ret == SPI_INVALID_ADDRESS) { + /* Find the lowest even address allowed for reads. */ + readaddr = (spi_get_valid_read_addr() + 1) & ~1; + cmd[1] = (readaddr >> 16) & 0xff, + cmd[2] = (readaddr >> 8) & 0xff, + cmd[3] = (readaddr >> 0) & 0xff, + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); + } + if (ret) + return ret; + msg_cspew("REMS2 returned %02x %02x. ", readarr[0], readarr[1]); + return 0; +} + static int spi_res(unsigned char *readarr, int bytes) { unsigned char cmd[JEDEC_RES_OUTSIZE] = { JEDEC_RES, 0, 0, 0 }; @@ -173,6 +195,58 @@ return probe_spi_rdid_generic(flash, 3); } +int probe_spi_mx_2017(struct flashchip *flash) +{ + unsigned char readarr[4]; + uint32_t id1; + uint32_t id2; + uint32_t id3; + uint32_t id4; + + if (spi_rdid(readarr, 3)) { + msg_cdbg("\n"); + return 0; + } + id1 = readarr[0]; + id2 = (readarr[1] << 8) | readarr[2]; + + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6405) { + /* Now we have detected the 2017h class of Macronix flash devices. + * We can further differentiate two classes: + * -those who support the REMS2 function do always have 4KB sector size + * (at least i have not found one with 64KB yet), + * and + * -those who don't support the REMS2 function might have 4KB or 64KB + * (some have 4KB, e.g. MX25L6406E, some have 64KB, e.g. MX25L6405 (not D)) + * for erase function 20h. + */ + if (spi_rems2(readarr)) { + msg_cdbg("\n"); + return 0; + } + id3 = readarr[0]; + id4 = readarr[1]; + msg_cdbg("%s: id1 0x%02x, id2 0x%02x, id3 0x%02x, id4 0x%02x\n", __func__, id1, id2, id3, id4); + if (id3 == MACRONIX_ID && id4 == MACRONIX_MX25L6445E) { + /* MACRONIX_MX25L6445E class, always 4KB sector */ + if (flash->model_id == MACRONIX_MX25L6445E) + return 1; + else + return 0; + } else { + /* MACRONIX_MX25L6405 class, might have 4KB or 64KB sector */ + if (flash->model_id == MACRONIX_MX25L6405) + return 1; + else + return 0; + } + } else { + msg_cdbg("%s: id1 0x%02x, id2 0x%02x\n", __func__, id1, id2); + } + /* neither MACRONIX_MX25L6405 nor MACRONIX_MX25L6445E */ + return 0; +} + int probe_spi_rdid4(struct flashchip *flash) { /* Some SPI controllers do not support commands with writecnt=1 and @@ -694,6 +768,79 @@ return 0; } +/* Sector size might be 4KB or 64KB, but on call to this function this is unknown. + * So we do a first erase command and then check if mem in the complete 64KB sector is erased. + * If not we assume 4KB and so we repeat the erase for each 4KB sector in the 64KB block + * (which is not erased already). + * PLEASE NOTE: the .eraseblocks block size must be set to 64KB if you use this function. + */ +int spi_block_erase_20_4or64k(struct flashchip *flash, unsigned int addr, unsigned int blocklen) +{ + int result, i, j, fully_erased, sector_erased; + unsigned int curraddr, currblocklen; + uint8_t *readbuf; + + if (blocklen != (64 * 1024)) { + msg_gerr("%s: blocklen not 64KB! Please report a bug at " + "flashrom(a)flashrom.org\n", __func__); + return 1; + } + + readbuf = malloc(blocklen); + if (!readbuf) { + msg_gerr("Out of memory!\n"); + exit(1); + } + + for (i = 0; i < 16; i++) { /* there are 16 4KB sectors in 64KB */ + + curraddr = addr + (i * (4 * 1024)); + + if (i > 0) { + /* Skip the sector erase if the sector is already erased */ + sector_erased = 1; + result = flash->read(flash, readbuf, curraddr, (4 * 1024)); + if (result) { + msg_gerr("Erase impossible because read failed " + "at 0x%x (len 0x%x)\n", curraddr, (4 * 1024)); + break; + } + for (j = 0; j < currblocklen; j++) + if (readbuf[j] != 0xFF) + sector_erased = 0; + if (sector_erased) + continue; /* Sector is already erased */ + } + + result = spi_block_erase_20 (flash, curraddr, (4 * 1024)); /* last parameter (blocklen) is unused */ + if (result) break; + + if (0 == i) { + curraddr += 4 * 1024; + currblocklen = (64*1024)-(4*1024); + fully_erased = 1; + result = flash->read(flash, readbuf, curraddr, currblocklen); + if (result) { + msg_gerr("Erase impossible because read failed " + "at 0x%x (len 0x%x)\n", curraddr, currblocklen); + break; + } + for (j = 0; j < currblocklen; j++) + if (readbuf[j] != 0xFF) + fully_erased = 0; + if (fully_erased) { + /* This means either that the SE command has erased the full 64KB + * or that the remaining 64KB sector was already erased before. + * Anyhow, we can now exit without calling the SE command again. + */ + break; + } + } + } + free(readbuf); + return result; +} + int spi_block_erase_60(struct flashchip *flash, unsigned int addr, unsigned int blocklen) { if ((addr != 0) || (blocklen != flash->total_size * 1024)) { -----Original Message----- From: flashrom-bounces(a)flashrom.org [mailto:flashrom-bounces@flashrom.org] On Behalf Of Wagner, Helge (GE Intelligent Platforms) Sent: Mittwoch, 29. Juni 2011 13:57 To: flashrom(a)flashrom.org Subject: Re: [flashrom] [PATCH] Macronix MX25L6445E Hello all, as Stefan suggested ("what about 0x2015, 0x2016, 0x2018? do they also have such problems?"), I was looking at some more Macronix data sheets. While doing this, I found out that my solution is NOT sufficient for some of the Macronix 0x2017 flash chips. I am currently working on a solution for this problem. Please stand by. Regards, Helge -----Original Message----- From: flashrom-bounces+helge.wagner=ge.com(a)flashrom.org [mailto:flashrom-bounces+helge.wagner=ge.com@flashrom.org] On Behalf Of Carl-Daniel Hailfinger Sent: Montag, 27. Juni 2011 20:28 To: flashrom(a)flashrom.org Subject: Re: [flashrom] [PATCH] Macronix MX25L6445E Hello Helge, thanks for your patch. It looks good to me on a first glance, and I hope to review it in detail soon. A short comment (in reply to Stefan's review) is at the end of this mail. Am 27.06.2011 17:50 schrieb Stefan Tauner: > On Mon, 27 Jun 2011 17:06:42 +0200 > "Wagner, Helge (GE Intelligent Platforms)" <Helge.Wagner(a)ge.com> wrote: > > >> Hello Stefan, >> >> >>> i have not looked at the datasheet(s), but maybe there is a way to distinguish the two devices (with another id command for example)? >>> >> I have asked Macronix, and they suggest to use the REMS2 function, which is supported on the MX25L6445E (returns 0xC216) and is not supported on the MX25L6405 (according to Macronix, it returns 0x0000 or 0xFFFF for this command). >> >> So now there is no longer a need to re-order the erase functions for the MX25L6405. >> >> Here is my new patch. >> >> Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> >> >> Regards, >> Helge Wagner >> >> diff -u flashrom/chipdrivers.h flashrom-patched/chipdrivers.h >> --- flashrom/chipdrivers.h 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/chipdrivers.h 2011-06-27 16:29:25.000000000 +0200 >> @@ -31,6 +31,7 @@ >> int probe_spi_rems(struct flashchip *flash); int >> probe_spi_res1(struct flashchip *flash); int probe_spi_res2(struct >> flashchip *flash); >> +int probe_spi_mx_2017(struct flashchip *flash); >> int spi_write_enable(void); >> int spi_write_disable(void); >> int spi_block_erase_20(struct flashchip *flash, unsigned int addr, >> unsigned int blocklen); diff -u flashrom/flashchips.c flashrom-patched/flashchips.c >> --- flashrom/flashchips.c 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/flashchips.c 2011-06-27 16:26:34.000000000 +0200 >> @@ -4131,8 +4131,8 @@ >> .total_size = 8192, >> .page_size = 256, >> .feature_bits = FEATURE_WRSR_WREN, >> - .tested = TEST_OK_PROBE, >> - .probe = probe_spi_rdid, >> + .tested = TEST_UNTESTED, >> + .probe = probe_spi_mx_2017, >> .probe_timing = TIMING_ZERO, >> .block_erasers = >> { >> @@ -4141,6 +4141,40 @@ >> .block_erase = spi_block_erase_20, >> }, { >> .eraseblocks = { {64 * 1024, 128} }, >> + .block_erase = spi_block_erase_d8, >> + }, { >> + .eraseblocks = { {8 * 1024 * 1024, 1} }, >> + .block_erase = spi_block_erase_60, >> + }, { >> + .eraseblocks = { {8 * 1024 * 1024, 1} }, >> + .block_erase = spi_block_erase_c7, >> + } >> + }, >> + .unlock = spi_disable_blockprotect, >> + .write = spi_chip_write_256, >> + .read = spi_chip_read, >> + .voltage = {2700, 3600}, >> + }, >> + >> + { >> + .vendor = "Macronix", >> + .name = "MX25L6445E", >> + .bustype = CHIP_BUSTYPE_SPI, >> + .manufacture_id = MACRONIX_ID, >> + .model_id = MACRONIX_MX25L6445E, >> + .total_size = 8192, >> + .page_size = 256, >> + .feature_bits = FEATURE_WRSR_WREN, >> + .tested = TEST_OK_PREW, >> + .probe = probe_spi_mx_2017, >> + .probe_timing = TIMING_ZERO, >> + .block_erasers = >> + { >> + { >> + .eraseblocks = { {4 * 1024, 2048} }, >> + .block_erase = spi_block_erase_20, >> + }, { >> + .eraseblocks = { {64 * 1024, 128} }, >> .block_erase = spi_block_erase_d8, >> }, { >> .eraseblocks = { {8 * 1024 * 1024, 1} }, diff -u >> flashrom/flashchips.h flashrom-patched/flashchips.h >> --- flashrom/flashchips.h 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/flashchips.h 2011-06-27 15:46:22.000000000 +0200 >> @@ -356,7 +356,8 @@ >> #define MACRONIX_MX25L8005 0x2014 /* Same as MX25V8005 */ >> #define MACRONIX_MX25L1605 0x2015 /* MX25L1605{,A,D} */ >> #define MACRONIX_MX25L3205 0x2016 /* MX25L3205{,A} */ >> -#define MACRONIX_MX25L6405 0x2017 /* MX25L3205{,D} */ >> +#define MACRONIX_MX25L6405 0x2017 /* MX25L6405{,D} */ >> +#define MACRONIX_MX25L6445E 0x16 /* MX25L6445E, ID = REMS2 answer */ >> #define MACRONIX_MX25L12805 0x2018 /* MX25L12805 */ >> #define MACRONIX_MX25L1635D 0x2415 >> #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ >> diff -u flashrom/spi.h flashrom-patched/spi.h >> --- flashrom/spi.h 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/spi.h 2011-06-27 16:29:38.000000000 +0200 >> @@ -40,6 +40,11 @@ >> #define JEDEC_REMS_OUTSIZE 0x04 >> #define JEDEC_REMS_INSIZE 0x02 >> >> +/* Read Electronic Manufacturer Signature 2 */ >> +#define JEDEC_REMS2 0xEF >> +#define JEDEC_REMS2_OUTSIZE 0x04 >> +#define JEDEC_REMS2_INSIZE 0x02 >> + >> /* Read Electronic Signature */ >> #define JEDEC_RES 0xab >> #define JEDEC_RES_OUTSIZE 0x04 >> diff -u flashrom/spi25.c flashrom-patched/spi25.c >> --- flashrom/spi25.c 2011-06-27 15:21:57.000000000 +0200 >> +++ flashrom-patched/spi25.c 2011-06-27 16:30:33.000000000 +0200 >> @@ -66,6 +66,27 @@ >> return 0; >> } >> >> +static int spi_rems2(unsigned char *readarr) { >> + unsigned char cmd[JEDEC_REMS2_OUTSIZE] = { JEDEC_REMS2, 0, 0, 0 }; >> + uint32_t readaddr; >> + int ret; >> + >> + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); >> + if (ret == SPI_INVALID_ADDRESS) { >> + /* Find the lowest even address allowed for reads. */ >> + readaddr = (spi_get_valid_read_addr() + 1) & ~1; >> + cmd[1] = (readaddr >> 16) & 0xff, >> + cmd[2] = (readaddr >> 8) & 0xff, >> + cmd[3] = (readaddr >> 0) & 0xff, >> + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); >> + } >> + if (ret) >> + return ret; >> + msg_cspew("REMS2 returned %02x %02x. ", readarr[0], readarr[1]); >> + return 0; >> +} >> + >> static int spi_res(unsigned char *readarr, int bytes) { >> unsigned char cmd[JEDEC_RES_OUTSIZE] = { JEDEC_RES, 0, 0, 0 }; @@ >> -173,6 +194,49 @@ >> return probe_spi_rdid_generic(flash, 3); } >> >> +int probe_spi_mx_2017(struct flashchip *flash) { >> + unsigned char readarr[4]; >> + uint32_t id1; >> + uint32_t id2; >> + >> + if (spi_rdid(readarr, 3)) { >> + msg_cdbg("\n"); >> + return 0; >> + } >> + id1 = readarr[0]; >> + id2 = (readarr[1] << 8) | readarr[2]; >> + >> + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6405) { >> + /* We have either MACRONIX_MX25L6405 or MACRONIX_MX25L6445E. >> + * MACRONIX_MX25L6405 has 64KB for erase function 20h and does not support REMS2 function, >> + * MACRONIX_MX25L6445E has 4KB for erase function 20h and does support REMS2 function. >> + * So to differentiate both, we execute REMS2 function (this is suggested by macronix). >> + */ >> + if (spi_rems2(readarr)) { >> + msg_cdbg("\n"); >> + return 0; >> + } >> + id1 = readarr[0]; >> + id2 = readarr[1]; >> + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6445E) { >> + /* MACRONIX_MX25L6445E */ >> + if (flash->model_id == MACRONIX_MX25L6445E) >> + return 1; >> + else >> + return 0; >> + } else { >> + /* MACRONIX_MX25L6405 */ >> + if (flash->model_id == MACRONIX_MX25L6405) >> + return 1; >> + else >> + return 0; >> + } >> + } >> + /* neither MACRONIX_MX25L6405 nor MACRONIX_MX25L6445E */ >> + return 0; >> +} >> + >> int probe_spi_rdid4(struct flashchip *flash) { >> /* Some SPI controllers do not support commands with writecnt=1 and >> >> >> > hello again and thanks for all you have done. > > without looking at your patch in too much detail i would like to > mention another possibility to implement this. as i have done in my > sfdp and intel hardware sequencing patch you can alter the struct > flashchip *flash the probing function gets as parameter. > you can then change the erase block size (and name) according to the id > instead of using two chips and returning 0/1 respectively. > Please avoid changing struct flashchip *flash in the probe function unless it is absolutely necessary. The hack needed for SFDP should not spread elsewhere, especially if we can handle this nicely with two separate flashchip entries. Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list flashrom(a)flashrom.org http://www.flashrom.org/mailman/listinfo/flashrom _______________________________________________ flashrom mailing list flashrom(a)flashrom.org http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] [PATCH] Macronix MX25L6445E
by Stefan Tauner 29 Jun '11

29 Jun '11

On Mon, 27 Jun 2011 17:06:42 +0200 "Wagner, Helge (GE Intelligent Platforms)" <Helge.Wagner(a)ge.com> wrote: > Hello Stefan, > > >i have not looked at the datasheet(s), but maybe there is a way to distinguish the two devices (with another id command for example)? > I have asked Macronix, and they suggest to use the REMS2 function, which is supported on the MX25L6445E (returns 0xC216) and is not supported on the MX25L6405 (according to Macronix, it returns 0x0000 or 0xFFFF for this command). > > So now there is no longer a need to re-order the erase functions for the MX25L6405. > > Here is my new patch. > > Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> > > Regards, > Helge Wagner > > diff -u flashrom/chipdrivers.h flashrom-patched/chipdrivers.h > --- flashrom/chipdrivers.h 2011-06-27 15:21:57.000000000 +0200 > +++ flashrom-patched/chipdrivers.h 2011-06-27 16:29:25.000000000 +0200 > @@ -31,6 +31,7 @@ > int probe_spi_rems(struct flashchip *flash); > int probe_spi_res1(struct flashchip *flash); > int probe_spi_res2(struct flashchip *flash); > +int probe_spi_mx_2017(struct flashchip *flash); > int spi_write_enable(void); > int spi_write_disable(void); > int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen); > diff -u flashrom/flashchips.c flashrom-patched/flashchips.c > --- flashrom/flashchips.c 2011-06-27 15:21:57.000000000 +0200 > +++ flashrom-patched/flashchips.c 2011-06-27 16:26:34.000000000 +0200 > @@ -4131,8 +4131,8 @@ > .total_size = 8192, > .page_size = 256, > .feature_bits = FEATURE_WRSR_WREN, > - .tested = TEST_OK_PROBE, > - .probe = probe_spi_rdid, > + .tested = TEST_UNTESTED, > + .probe = probe_spi_mx_2017, > .probe_timing = TIMING_ZERO, > .block_erasers = > { > @@ -4141,6 +4141,40 @@ > .block_erase = spi_block_erase_20, > }, { > .eraseblocks = { {64 * 1024, 128} }, > + .block_erase = spi_block_erase_d8, > + }, { > + .eraseblocks = { {8 * 1024 * 1024, 1} }, > + .block_erase = spi_block_erase_60, > + }, { > + .eraseblocks = { {8 * 1024 * 1024, 1} }, > + .block_erase = spi_block_erase_c7, > + } > + }, > + .unlock = spi_disable_blockprotect, > + .write = spi_chip_write_256, > + .read = spi_chip_read, > + .voltage = {2700, 3600}, > + }, > + > + { > + .vendor = "Macronix", > + .name = "MX25L6445E", > + .bustype = CHIP_BUSTYPE_SPI, > + .manufacture_id = MACRONIX_ID, > + .model_id = MACRONIX_MX25L6445E, > + .total_size = 8192, > + .page_size = 256, > + .feature_bits = FEATURE_WRSR_WREN, > + .tested = TEST_OK_PREW, > + .probe = probe_spi_mx_2017, > + .probe_timing = TIMING_ZERO, > + .block_erasers = > + { > + { > + .eraseblocks = { {4 * 1024, 2048} }, > + .block_erase = spi_block_erase_20, > + }, { > + .eraseblocks = { {64 * 1024, 128} }, > .block_erase = spi_block_erase_d8, > }, { > .eraseblocks = { {8 * 1024 * 1024, 1} }, > diff -u flashrom/flashchips.h flashrom-patched/flashchips.h > --- flashrom/flashchips.h 2011-06-27 15:21:57.000000000 +0200 > +++ flashrom-patched/flashchips.h 2011-06-27 15:46:22.000000000 +0200 > @@ -356,7 +356,8 @@ > #define MACRONIX_MX25L8005 0x2014 /* Same as MX25V8005 */ > #define MACRONIX_MX25L1605 0x2015 /* MX25L1605{,A,D} */ > #define MACRONIX_MX25L3205 0x2016 /* MX25L3205{,A} */ > -#define MACRONIX_MX25L6405 0x2017 /* MX25L3205{,D} */ > +#define MACRONIX_MX25L6405 0x2017 /* MX25L6405{,D} */ > +#define MACRONIX_MX25L6445E 0x16 /* MX25L6445E, ID = REMS2 answer */ > #define MACRONIX_MX25L12805 0x2018 /* MX25L12805 */ > #define MACRONIX_MX25L1635D 0x2415 > #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ > diff -u flashrom/spi.h flashrom-patched/spi.h > --- flashrom/spi.h 2011-06-27 15:21:57.000000000 +0200 > +++ flashrom-patched/spi.h 2011-06-27 16:29:38.000000000 +0200 > @@ -40,6 +40,11 @@ > #define JEDEC_REMS_OUTSIZE 0x04 > #define JEDEC_REMS_INSIZE 0x02 > > +/* Read Electronic Manufacturer Signature 2 */ > +#define JEDEC_REMS2 0xEF > +#define JEDEC_REMS2_OUTSIZE 0x04 > +#define JEDEC_REMS2_INSIZE 0x02 > + > /* Read Electronic Signature */ > #define JEDEC_RES 0xab > #define JEDEC_RES_OUTSIZE 0x04 > diff -u flashrom/spi25.c flashrom-patched/spi25.c > --- flashrom/spi25.c 2011-06-27 15:21:57.000000000 +0200 > +++ flashrom-patched/spi25.c 2011-06-27 16:30:33.000000000 +0200 > @@ -66,6 +66,27 @@ > return 0; > } > > +static int spi_rems2(unsigned char *readarr) > +{ > + unsigned char cmd[JEDEC_REMS2_OUTSIZE] = { JEDEC_REMS2, 0, 0, 0 }; > + uint32_t readaddr; > + int ret; > + > + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); > + if (ret == SPI_INVALID_ADDRESS) { > + /* Find the lowest even address allowed for reads. */ > + readaddr = (spi_get_valid_read_addr() + 1) & ~1; > + cmd[1] = (readaddr >> 16) & 0xff, > + cmd[2] = (readaddr >> 8) & 0xff, > + cmd[3] = (readaddr >> 0) & 0xff, > + ret = spi_send_command(sizeof(cmd), JEDEC_REMS2_INSIZE, cmd, readarr); > + } > + if (ret) > + return ret; > + msg_cspew("REMS2 returned %02x %02x. ", readarr[0], readarr[1]); > + return 0; > +} > + > static int spi_res(unsigned char *readarr, int bytes) > { > unsigned char cmd[JEDEC_RES_OUTSIZE] = { JEDEC_RES, 0, 0, 0 }; > @@ -173,6 +194,49 @@ > return probe_spi_rdid_generic(flash, 3); > } > > +int probe_spi_mx_2017(struct flashchip *flash) > +{ > + unsigned char readarr[4]; > + uint32_t id1; > + uint32_t id2; > + > + if (spi_rdid(readarr, 3)) { > + msg_cdbg("\n"); > + return 0; > + } > + id1 = readarr[0]; > + id2 = (readarr[1] << 8) | readarr[2]; > + > + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6405) { > + /* We have either MACRONIX_MX25L6405 or MACRONIX_MX25L6445E. > + * MACRONIX_MX25L6405 has 64KB for erase function 20h and does not support REMS2 function, > + * MACRONIX_MX25L6445E has 4KB for erase function 20h and does support REMS2 function. > + * So to differentiate both, we execute REMS2 function (this is suggested by macronix). > + */ > + if (spi_rems2(readarr)) { > + msg_cdbg("\n"); > + return 0; > + } > + id1 = readarr[0]; > + id2 = readarr[1]; > + if (id1 == MACRONIX_ID && id2 == MACRONIX_MX25L6445E) { > + /* MACRONIX_MX25L6445E */ > + if (flash->model_id == MACRONIX_MX25L6445E) > + return 1; > + else > + return 0; > + } else { > + /* MACRONIX_MX25L6405 */ > + if (flash->model_id == MACRONIX_MX25L6405) > + return 1; > + else > + return 0; > + } > + } > + /* neither MACRONIX_MX25L6405 nor MACRONIX_MX25L6445E */ > + return 0; > +} > + > int probe_spi_rdid4(struct flashchip *flash) > { > /* Some SPI controllers do not support commands with writecnt=1 and > > hello again and thanks for all you have done. without looking at your patch in too much detail i would like to mention another possibility to implement this. as i have done in my sfdp and intel hardware sequencing patch you can alter the struct flashchip *flash the probing function gets as parameter. you can then change the erase block size (and name) according to the id instead of using two chips and returning 0/1 respectively. i dont know if that alternative is any better. one can argue that these really are two independent chips and deserve their own flashchip struct. OTOH are they almost identical. but that's probably true for many chip (variants). so i think the scheme you have used is the right one and this mail is mostly for documenting/educating (read: blahblahblah :) the other thing that sprang to my mind is the question if there are other mx chips that need this kind of differentiation and if the scheme should be more generalized. what about 0x2015, 0x2016, 0x2018? do they also have such problems? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

3 2

Re: [flashrom] [Patch] NVIDIA Tegra2 SPI controller support
by Carl-Daniel Hailfinger 29 Jun '11

29 Jun '11

Am 29.06.2011 03:32 schrieb Stefan Reinauer: > On Tue, Jun 28, 2011 at 5:54 PM, Carl-Daniel Hailfinger > <c-d.hailfinger.devel.2006(a)gmx.net> wrote: > > > >>> 2. Due to issues with libpci, you can't use the same binary on machines with >>> PCI and without PCI. So for example, you can't program a SPI ROM onboard a >>> PCI card that is connected to your ARM SoC. >>> >> Could you explain more? IIRC some people were using flashrom on ARM >> (independent patch) with PCI support. Not calling any PCI functions >> should be enough to avoid any and all interactions between libpci and >> the hardware. >> > One of the problems is that if you call libpci's init function on a > system with no PCI support, libpci will not return an error but just > end the program right away. This makes it hard to have one binary that > works on PCI and non-PCI ARM systems. > Just set pci_access->error to a function with printf signature (e.g. my_libpci_error_interceptor) before calling pci_init and make sure my_libpci_error_interceptor sets a global variable pci_failed=1 once it is called. That is ugly, but it should work. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

SST 49LF008A and Poulsbo - still having erase problem
by Joel Brinton 29 Jun '11

29 Jun '11

Hello, First thanks all for the hard work - flashrom is a great utility! I'm currently having trouble on the Intel SCH (Poulsbo) with a 49LF008A (Toradex Z530 COMExpress board). I found an old mail message [http://www.flashrom.org/pipermail/flashrom/2010-March/002481.html] of someone experiencing the same problem I have - blockwise erase failure. There was two proposed patches to SVN revision 988. I checked out revision 988 but neither patch fixes the issue. I then checked out the latest (both patched and unpatched) and it doesn't fix the problem and now segfaults. I've spent a good day digging through the source and datasheets to no avail. thank you, joel Here's my dump: flashrom v0.9.3-r1324 on Linux 2.6.24-26-generic (i686), built with libpci 2.2.4, GCC 4.2.4 (Ubuntu 4.2.4-1ubuntu4), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 2 usecs, 793M loops per second, 10 myus = 11 us, 100 myus = 101 us, 1000 myus = 1009 us, 10000 myus = 9986 us, 8 myus = 9 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "Toradex" DMI string system-product-name: "POULSBO" DMI string system-version: "1.0" DMI string baseboard-manufacturer: "Toradex" DMI string baseboard-product-name: "WoodPecker" DMI string baseboard-version: "1.0" DMI string chassis-type: "Desktop" Found chipset "Intel Poulsbo", enabling flash write... chipset PCI ID is 8086:8119, BIOS Lock Enable: disabled, BIOS Write Enable: enabled, BIOS_CNTL is 0x1 BIOS Prefetch Enable: disabled, OK. This chipset supports the following protocols: FWH. Probing for AMD Am29F010A/B, 128 kB: skipped. Probing for AMD Am29F002(N)BB, 256 kB: skipped. Probing for AMD Am29F002(N)BT, 256 kB: skipped. Probing for AMD Am29F016D, 2048 kB: skipped. Probing for AMD Am29F040B, 512 kB: skipped. Probing for AMD Am29F080B, 1024 kB: skipped. Probing for AMD Am29LV001BB, 128 kB: skipped. Probing for AMD Am29LV001BT, 128 kB: skipped. Probing for AMD Am29LV002BB, 256 kB: skipped. Probing for AMD Am29LV002BT, 256 kB: skipped. Probing for AMD Am29LV004BB, 512 kB: skipped. Probing for AMD Am29LV004BT, 512 kB: skipped. Probing for AMD Am29LV008BB, 1024 kB: skipped. Probing for AMD Am29LV008BT, 1024 kB: skipped. Probing for AMD Am29LV040B, 512 kB: skipped. Probing for AMD Am29LV081B, 1024 kB: skipped. Probing for AMIC A25L05PT, 64 kB: skipped. Probing for AMIC A25L05PU, 64 kB: skipped. Probing for AMIC A25L10PT, 128 kB: skipped. Probing for AMIC A25L10PU, 128 kB: skipped. Probing for AMIC A25L20PT, 256 kB: skipped. Probing for AMIC A25L20PU, 256 kB: skipped. Probing for AMIC A25L40PT, 512 kB: skipped. Probing for AMIC A25L40PU, 512 kB: skipped. Probing for AMIC A25L80P, 1024 kB: skipped. Probing for AMIC A25L16PT, 2048 kB: skipped. Probing for AMIC A25L16PU, 2048 kB: skipped. Probing for AMIC A25L512, 64 kB: skipped. Probing for AMIC A25L010, 128 kB: skipped. Probing for AMIC A25L020, 256 kB: skipped. Probing for AMIC A25L040, 512 kB: skipped. Probing for AMIC A25L080, 1024 kB: skipped. Probing for AMIC A25L016, 2048 kB: skipped. Probing for AMIC A25L032, 4096 kB: skipped. Probing for AMIC A25LQ032, 4096 kB: skipped. Probing for AMIC A29002B, 256 kB: skipped. Probing for AMIC A29002T, 256 kB: skipped. Probing for AMIC A29040B, 512 kB: skipped. Probing for AMIC A49LF040A, 512 kB: skipped. Probing for Atmel AT25DF021, 256 kB: skipped. Probing for Atmel AT25DF041A, 512 kB: skipped. Probing for Atmel AT25DF081, 1024 kB: skipped. Probing for Atmel AT25DF081A, 1024 kB: skipped. Probing for Atmel AT25DF161, 2048 kB: skipped. Probing for Atmel AT25DF321, 4096 kB: skipped. Probing for Atmel AT25DF321A, 4096 kB: skipped. Probing for Atmel AT25DF641, 8192 kB: skipped. Probing for Atmel AT25DQ161, 2048 kB: skipped. Probing for Atmel AT25F512B, 64 kB: skipped. Probing for Atmel AT25FS010, 128 kB: skipped. Probing for Atmel AT25FS040, 512 kB: skipped. Probing for Atmel AT26DF041, 512 kB: skipped. Probing for Atmel AT26DF081A, 1024 kB: skipped. Probing for Atmel AT26DF161, 2048 kB: skipped. Probing for Atmel AT26DF161A, 2048 kB: skipped. Probing for Atmel AT26F004, 512 kB: skipped. Probing for Atmel AT29C512, 64 kB: skipped. Probing for Atmel AT29C010A, 128 kB: skipped. Probing for Atmel AT29C020, 256 kB: skipped. Probing for Atmel AT29C040A, 512 kB: skipped. Probing for Atmel AT45CS1282, 16896 kB: skipped. Probing for Atmel AT45DB011D, 128 kB: skipped. Probing for Atmel AT45DB021D, 256 kB: skipped. Probing for Atmel AT45DB041D, 512 kB: skipped. Probing for Atmel AT45DB081D, 1024 kB: skipped. Probing for Atmel AT45DB161D, 2048 kB: skipped Probing for Atmel AT45DB321C, 4224 kB: skipped. Probing for Atmel AT45DB321D, 4096 kB: skipped. Probing for Atmel AT45DB642D, 8192 kB: skipped. Probing for Atmel AT49BV512, 64 kB: skipped. Probing for Atmel AT49F020, 256 kB: skipped. Probing for Atmel AT49F002(N), 256 kB: skipped. Probing for Atmel AT49F002(N)T, 256 kB: skipped. Probing for Bright BM29F040, 512 kB: skipped. Probing for EMST F49B002UA, 256 kB: skipped. Probing for EMST F25L008A, 1024 kB: skipped. Probing for Eon EN25B05, 64 kB: skipped. Probing for Eon EN25B05T, 64 kB: skipped Probing for Eon EN25B10, 128 kB: skipped. Probing for Eon EN25B10T, 128 kB: skipped. Probing for Eon EN25B20, 256 kB: skipped. Probing for Eon EN25B20T, 256 kB: skipped. Probing for Eon EN25B40, 512 kB: skipped. Probing for Eon EN25B40T, 512 kB: skipped. Probing for Eon EN25B80, 1024 kB: skipped. Probing for Eon EN25B80T, 1024 kB: skipped. Probing for Eon EN25B16, 2048 kB: skipped. Probing for Eon EN25B16T, 2048 kB: skipped. Probing for Eon EN25B32, 4096 kB: skipped. Probing for Eon EN25B32T, 4096 kB: skipped. Probing for Eon EN25B64, 8192 kB: skipped. Probing for Eon EN25B64T, 8192 kB: skipped. Probing for Eon EN25D16, 2048 kB: skipped. Probing for Eon EN25F05, 64 kB: skipped. Probing for Eon EN25F10, 128 kB: skipped. Probing for Eon EN25F20, 256 kB: skipped. Probing for Eon EN25F40, 512 kB: skipped. Probing for Eon EN25F80, 1024 kB: skipped. Probing for Eon EN25F16, 2048 kB: skipped. Probing for Eon EN25F32, 4096 kB: skipped. Probing for Eon EN29F010, 128 kB: skipped. Probing for Eon EN29F002(A)(N)B, 256 kB: skipped. Probing for Eon EN29F002(A)(N)T, 256 kB: skipped. Probing for Fujitsu MBM29F004BC, 512 kB: skipped. Probing for Fujitsu MBM29F004TC, 512 kB: skipped. Probing for Fujitsu MBM29F400BC, 512 kB: skipped. Probing for Fujitsu MBM29F400TC, 512 kB: skipped. Probing for Hyundai HY29F002T, 256 kB: skipped. Probing for Hyundai HY29F002B, 256 kB: skipped. Probing for Hyundai HY29F040A, 512 kB: skipped. Probing for Intel 28F001BN/BX-B, 128 kB: skipped. Probing for Intel 28F001BN/BX-T, 128 kB: skipped. Probing for Intel 28F002BC/BL/BV/BX-T, 256 kB: skipped. Probing for Intel 28F008S3/S5/SC, 512 kB: skipped. Probing for Intel 28F004B5/BE/BV/BX-B, 512 kB: skipped. Probing for Intel 28F004B5/BE/BV/BX-T, 512 kB: skipped. Probing for Intel 28F400BV/BX/CE/CV-B, 512 kB: skipped. Probing for Intel 28F400BV/BX/CE/CV-T, 512 kB: skipped. Probing for Intel 82802AB, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 82802AC, 1024 kB: probe_82802ab: id1 0x49, id2 0x4d, id1 is normal flash content, id2 is normal flash content Probing for Macronix MX25L512, 64 kB: skipped. Probing for Macronix MX25L1005, 128 kB: skipped. Probing for Macronix MX25L2005, 256 kB: skipped. Probing for Macronix MX25L4005, 512 kB: skipped. Probing for Macronix MX25L8005, 1024 kB: skipped. Probing for Macronix MX25L1605, 2048 kB: skipped. Probing for Macronix MX25L1635D, 2048 kB: skipped. Probing for Macronix MX25L1635E, 2048 kB: skipped. Probing for Macronix MX25L3205, 4096 kB: skipped. Probing for Macronix MX25L3235D, 4096 kB: skipped. Probing for Macronix MX25L6405, 8192 kB: skipped. Probing for Macronix MX25L12805, 16384 kB: skipped. Probing for Macronix MX29F001B, 128 kB: skipped. Probing for Macronix MX29F001T, 128 kB: skipped. Probing for Macronix MX29F002B, 256 kB: skipped. Probing for Macronix MX29F002T, 256 kB: skipped. Probing for Macronix MX29F040, 512 kB: skipped. Probing for Macronix MX29LV040, 512 kB: skipped. Probing for MoselVitelic V29C51000B, 64 kB: skipped. Probing for MoselVitelic V29C51000T, 64 kB: skipped. Probing for MoselVitelic V29C51400B, 512 kB: skipped. Probing for MoselVitelic V29C51400T, 512 kB: skipped. Probing for MoselVitelic V29LC51000, 64 kB: skipped. Probing for MoselVitelic V29LC51001, 128 kB: skipped. Probing for MoselVitelic V29LC51002, 256 kB: skipped. Probing for Numonyx M25PE10, 128 kB: skipped. Probing for Numonyx M25PE20, 256 kB: skipped. Probing for Numonyx M25PE40, 512 kB: skipped. Probing for Numonyx M25PE80, 1024 kB: skipped. Probing for Numonyx M25PE16, 2048 kB: skipped. Probing for PMC Pm25LV010, 128 kB: skipped. Probing for PMC Pm25LV016B, 2048 kB: skipped. Probing for PMC Pm25LV020, 256 kB: skipped. Probing for PMC Pm25LV040, 512 kB: skipped. Probing for PMC Pm25LV080B, 1024 kB: skipped. Probing for PMC Pm25LV512, 64 kB: skipped. Probing for PMC Pm29F002T, 256 kB: skipped. Probing for PMC Pm29F002B, 256 kB: skipped. Probing for PMC Pm39LV010, 128 kB: skipped. Probing for PMC Pm39LV020, 256 kB: skipped. Probing for PMC Pm39LV040, 512 kB: skipped. Probing for PMC Pm49FL002, 256 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for PMC Pm49FL004, 512 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for Sanyo LF25FW203A, 2048 kB: skipped. Probing for Sharp LHF00L04, 1024 kB: probe_82802ab: id1 0x49, id2 0x4d, id1 is normal flash content, id2 is normal flash content Probing for Spansion S25FL004A, 512 kB: skipped. Probing for Spansion S25FL008A, 1024 kB: skipped. Probing for Spansion S25FL016A, 2048 kB: skipped. Probing for Spansion S25FL032A, 4096 kB: skipped. Probing for Spansion S25FL064A, 8192 kB: skipped. Probing for SST SST25VF010.REMS, 128 kB: skipped. Probing for SST SST25VF016B, 2048 kB: skipped. Probing for SST SST25VF032B, 4096 kB: skipped. Probing for SST SST25VF064C, 8192 kB: skipped. Probing for SST SST25VF040.REMS, 512 kB: skipped. Probing for SST SST25VF040B, 512 kB: skipped. Probing for SST SST25LF040A.RES, 512 kB: skipped. Probing for SST SST25VF040B.REMS, 512 kB: skipped. Probing for SST SST25VF080B, 1024 kB: skipped. Probing for SST SST28SF040A, 512 kB: skipped. Probing for SST SST29EE010, 128 kB: skipped. Probing for SST SST29LE010, 128 kB: skipped. Probing for SST SST29EE020A, 256 kB: skipped. Probing for SST SST29LE020, 256 kB: skipped. Probing for SST SST39SF512, 64 kB: skipped. Probing for SST SST39SF010A, 128 kB: skipped. Probing for SST SST39SF020A, 256 kB: skipped. Probing for SST SST39SF040, 512 kB: skipped. Probing for SST SST39VF512, 64 kB: skipped. Probing for SST SST39VF010, 128 kB: skipped. Probing for SST SST39VF020, 256 kB: skipped. Probing for SST SST39VF040, 512 kB: skipped. Probing for SST SST39VF080, 1024 kB: skipped. Probing for SST SST49LF002A/B, 256 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for SST SST49LF003A/B, 384 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for SST SST49LF004A/B, 512 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for SST SST49LF004C, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF008A, 1024 kB: probe_jedec_common: id1 0xbf, id2 0x5a Found chip "SST SST49LF008A" (1024 kB, FWH) at physical address 0xfff00000. Lock status for 0x000000 (size 0x010000) is 00, full access Lock status for 0x010000 (size 0x010000) is 00, full access Lock status for 0x020000 (size 0x010000) is 00, full access Lock status for 0x030000 (size 0x010000) is 00, full access Lock status for 0x040000 (size 0x010000) is 00, full access Lock status for 0x050000 (size 0x010000) is 00, full access Lock status for 0x060000 (size 0x010000) is 00, full access Lock status for 0x070000 (size 0x010000) is 00, full access Lock status for 0x080000 (size 0x010000) is 00, full access Lock status for 0x090000 (size 0x010000) is 00, full access Lock status for 0x0a0000 (size 0x010000) is 00, full access Lock status for 0x0b0000 (size 0x010000) is 00, full access Lock status for 0x0c0000 (size 0x010000) is 00, full access Lock status for 0x0d0000 (size 0x010000) is 00, full access Lock status for 0x0e0000 (size 0x010000) is 00, full access Lock status for 0x0f0000 (size 0x010000) is 00, full access Probing for SST SST49LF008C, 1024 kB: probe_82802ab: id1 0x49, id2 0x4d, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF016C, 2048 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF020, 256 kB: skipped. Probing for SST SST49LF020A, 256 kB: skipped. Probing for SST SST49LF040, 512 kB: skipped. Probing for SST SST49LF040B, 512 kB: skipped Probing for SST SST49LF080A, 1024 kB: skipped. Probing for SST SST49LF160C, 2048 kB: skipped. Probing for ST M25P05-A, 64 kB: skipped. Probing for ST M25P05.RES, 64 kB: skipped. Probing for ST M25P10-A, 128 kB: skipped. Probing for ST M25P10.RES, 128 kB: skipped. Probing for ST M25P20, 256 kB: skipped. Probing for ST M25P40, 512 kB: skipped. Probing for ST M25P40-old, 512 kB: skipped. Probing for ST M25P80, 1024 kB: skipped. Probing for ST M25P16, 2048 kB: skipped. Probing for ST M25P32, 4096 kB: skipped. Probing for ST M25P64, 8192 kB: skipped. Probing for ST M25P128, 16384 kB: skipped. Probing for ST M25PX16, 2048 kB: skipped. Probing for ST M25PX32, 4096 kB: skipped. Probing for ST M25PX64, 8192 kB: skipped. Probing for ST M29F002B, 256 kB: skipped. Probing for ST M29F002T/NT, 256 kB: skipped. Probing for ST M29F040B, 512 kB: skipped. Probing for ST M29F400BB, 512 kB: skipped. Probing for ST M29F400BT, 512 kB: skipped. Probing for ST M29W010B, 128 kB: skipped. Probing for ST M29W040B, 512 kB: skipped. Probing for ST M29W512B, 64 kB: skipped. Probing for ST M50FLW040A, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW040B, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW080A, 1024 kB: probe_82802ab: id1 0x49, id2 0x4d, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW080B, 1024 kB: probe_82802ab: id1 0x49, id2 0x4d, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW002, 256 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW016, 2048 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW040, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW080, 1024 kB: probe_82802ab: id1 0x49, id2 0x4d, id1 is normal flash content, id2 is normal flash content Probing for ST M50LPW116, 2048 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001B, 128 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001T, 128 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51002B, 256 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51002T, 256 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51004B, 512 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51004T, 512 kB: skipped. Probing for SyncMOS/MoselVitelic {S,V}29C31004B, 512 kB: skipped. Probing for SyncMOS/MoselVitelic {S,V}29C31004T, 512 kB: skipped. Probing for TI TMS29F002RB, 256 kB: skipped. Probing for TI TMS29F002RT, 256 kB: skipped. Probing for Winbond W25Q80, 1024 kB: skipped Probing for Winbond W25Q16, 2048 kB: skipped. Probing for Winbond W25Q32, 4096 kB: skipped. Probing for Winbond W25Q64, 8192 kB: skipped. Probing for Winbond W25Q128, 16384 kB: skipped. Probing for Winbond W25x10, 128 kB: skipped. Probing for Winbond W25x20, 256 kB: skipped. Probing for Winbond W25x40, 512 kB: skipped. Probing for Winbond W25x80, 1024 kB: skipped. Probing for Winbond W25x16, 2048 kB: skipped. Probing for Winbond W25x32, 4096 kB: skipped. Probing for Winbond W25x64, 8192 kB: skipped. Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: skipped. Probing for Winbond W29C020(C)/W29C022, 256 kB: skipped. Probing for Winbond W29C040/P, 512 kB: skipped. Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: skipped. Probing for Winbond W39L040, 512 kB: skipped. Probing for Winbond W39V040A, 512 kB: skipped. Probing for Winbond W39V040B, 512 kB: skipped. Probing for Winbond W39V040C, 512 kB: skipped. Probing for Winbond W39V040FA, 512 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for Winbond W39V040FB, 512 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for Winbond W39V040FC, 512 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for Winbond W39V080A, 1024 kB: skipped. Probing for Winbond W49F002U/N, 256 kB: skipped. Probing for Winbond W49F020, 256 kB: skipped. Probing for Winbond W49V002A, 256 kB: skipped. Probing for Winbond W49V002FA, 256 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for Winbond W39V080FA, 1024 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for Winbond W39V080FA (dual mode), 512 kB: probe_jedec_common: id1 0xbf, id2 0x5a Probing for AMIC unknown AMIC SPI chip, 0 kB: skipped. Probing for Atmel unknown Atmel SPI chip, 0 kB: skipped. Probing for Eon unknown Eon SPI chip, 0 kB: skipped. Probing for Macronix unknown Macronix SPI chip, 0 kB: skipped. Probing for PMC unknown PMC SPI chip, 0 kB: skipped. Probing for SST unknown SST SPI chip, 0 kB: skipped. Probing for ST unknown ST SPI chip, 0 kB: skipped. Probing for Sanyo unknown Sanyo SPI chip, 0 kB: skipped. Probing for Generic unknown SPI chip (RDID), 0 kB: skipped. Probing for Generic unknown SPI chip (REMS), 0 kB: skipped. === This flash part has status UNTESTED for operations: WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! Lock status for 0x000000 (size 0x010000) is 00, full access Lock status for 0x010000 (size 0x010000) is 00, full access Lock status for 0x020000 (size 0x010000) is 00, full access Lock status for 0x030000 (size 0x010000) is 00, full access Lock status for 0x040000 (size 0x010000) is 00, full access Lock status for 0x050000 (size 0x010000) is 00, full access Lock status for 0x060000 (size 0x010000) is 00, full access Lock status for 0x070000 (size 0x010000) is 00, full access Lock status for 0x080000 (size 0x010000) is 00, full access Lock status for 0x090000 (size 0x010000) is 00, full access Lock status for 0x0a0000 (size 0x010000) is 00, full access Lock status for 0x0b0000 (size 0x010000) is 00, full access Lock status for 0x0c0000 (size 0x010000) is 00, full access Lock status for 0x0d0000 (size 0x010000) is 00, full access Lock status for 0x0e0000 (size 0x010000) is 00, full access Lock status for 0x0f0000 (size 0x010000) is 00, full access coreboot last image size (not ROM size) is 1048576 bytes. Manufacturer: iWave Mainboard ID: iWRainbowG6 Note: If the following flash access fails, try -m :. Reading old flash chip contents... Erasing and writing flash chip... Looking at blockwise erase function 0... trying... 0x000000-0x000fff:E Looking at blockwise erase function 1.. trying... 0x000000-0x00ffff:E Looking at blockwise erase function 2... eraseblock layout is known, but matching block erase function is not implemented. trying... 0x000000-0x0fffff:E Segmentation fault

1 2

This report flashrom-V
by Senior College Krikoon Hilton Enterprise 29 Jun '11

29 Jun '11

This report flashrom-V Please help [root@magnet alexander]# flashrom flashrom v0.9.3-r1299 on Linux 2.6.34.9-69.fc13.i686.PAE (i686), built with libpci 3.1.7, GCC 4.4.5 20101112 (Red Hat 4.4.5-2), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. Found chipset "NVIDIA MCP61", enabling flash write... This chipset is not really supported yet. Guesswork... SPI on this chipset is WIP. Write is unsupported! Mapping NVIDIA MCP6x SPI at 0xfec80000, unaligned size 0x544. Please send the output of "flashrom -V" to flashrom(a)flashrom.org with your board name: flashrom -V as the subject to help us finish support for your chipset. Thanks. OK. This chipset supports the following protocols: SPI. Found chip "Macronix MX25L8005" (1024 KB, SPI) at physical address 0xfff00000. === This flash part has status UNTESTED for operations: WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! No operations were specified. [root@magnet alexander]# flashrom -V flashrom v0.9.3-r1299 on Linux 2.6.34.9-69.fc13.i686.PAE (i686), built with libpci 3.1.7, GCC 4.4.5 20101112 (Red Hat 4.4.5-2), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 1 usecs, 421M loops per second, delay more than 10% too short (got 85% of expected delay), recalculating... 455M loops per second, 10 myus = 10 us, 100 myus = 92 us, 1000 myus = 1950 us, 10000 myus = 11243 us, 4 myus = 5 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "System manufacturer" DMI string system-product-name: "System Product Name" DMI string system-version: "System Version" DMI string baseboard-manufacturer: "ASUSTeK Computer INC." DMI string baseboard-product-name: "M2N-MX SE Plus" DMI string baseboard-version: "Rev x.xx" DMI string chassis-type: "Desktop" Found ITE Super I/O, ID 0x8712 on port 0x2e Found chipset "NVIDIA MCP61", enabling flash write... chipset PCI ID is 10de:03e0, This chipset is not really supported yet. Guesswork... ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0 Flash bus type is SPI SPI on this chipset is WIP. Write is unsupported! Found SMBus device 10de:03eb at 00:01:1 MCP SPI BAR is at 0xfec80000 Mapping NVIDIA MCP6x SPI at 0xfec80000, unaligned size 0x544. SPI control is 0x0002, req=0, gnt=0 Please send the output of "flashrom -V" to flashrom(a)flashrom.org with your board name: flashrom -V as the subject to help us finish support for your chipset. Thanks. OK. This chipset supports the following protocols: SPI. Super I/O ID 0x8712 is not on the list of flash capable controllers. Probing for AMD Am29F010A/B, 128 KB: skipped. Probing for AMD Am29F002(N)BB, 256 KB: skipped. Probing for AMD Am29F002(N)BT, 256 KB: skipped. Probing for AMD Am29F016D, 2048 KB: skipped. Probing for AMD Am29F040B, 512 KB: skipped. Probing for AMD Am29F080B, 1024 KB: skipped. Probing for AMD Am29LV001BB, 128 KB: skipped. Probing for AMD Am29LV001BT, 128 KB: skipped. Probing for AMD Am29LV002BB, 256 KB: skipped. Probing for AMD Am29LV002BT, 256 KB: skipped. Probing for AMD Am29LV004BB, 512 KB: skipped. Probing for AMD Am29LV004BT, 512 KB: skipped. Probing for AMD Am29LV008BB, 1024 KB: skipped. Probing for AMD Am29LV008BT, 1024 KB: skipped. Probing for AMD Am29LV040B, 512 KB: skipped. Probing for AMD Am29LV081B, 1024 KB: skipped. Probing for AMIC A25L05PT, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L05PU, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L10PT, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L10PU, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L20PT, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L20PU, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L40PT, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L40PU, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L80P, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L16PT, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L16PU, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L512, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L010, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L020, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L040, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L080, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L016, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25L032, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A25LQ032, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for AMIC A29002B, 256 KB: skipped. Probing for AMIC A29002T, 256 KB: skipped. Probing for AMIC A29040B, 512 KB: skipped. Probing for AMIC A49LF040A, 512 KB: skipped. Probing for Atmel AT25DF021, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF041A, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF081, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF081A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF161, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF321, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF321A, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DF641, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25DQ161, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25F512B, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25FS010, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT25FS040, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF041, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF081A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF161, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26DF161A, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT26F004, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT29C512, 64 KB: skipped. Probing for Atmel AT29C010A, 128 KB: skipped. Probing for Atmel AT29C020, 256 KB: skipped. Probing for Atmel AT29C040A, 512 KB: skipped. Probing for Atmel AT45CS1282, 16896 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB011D, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB021D, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB041D, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB081D, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB161D, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB321C, 4224 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB321D, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT45DB642D, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel AT49BV512, 64 KB: skipped. Probing for Atmel AT49F020, 256 KB: skipped. Probing for Atmel AT49F002(N), 256 KB: skipped. Probing for Atmel AT49F002(N)T, 256 KB: skipped. Probing for Bright BM29F040, 512 KB: skipped. Probing for EMST F49B002UA, 256 KB: skipped. Probing for EMST F25L008A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B05, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B05T, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B10T, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B20T, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B40T, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B80T, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B16T, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B32T, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25B64T, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25D16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F05, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN25F32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon EN29F010, 128 KB: skipped. Probing for Eon EN29F002(A)(N)B, 256 KB: skipped. Probing for Eon EN29F002(A)(N)T, 256 KB: skipped. Probing for Fujitsu MBM29F004BC, 512 KB: skipped. Probing for Fujitsu MBM29F004TC, 512 KB: skipped. Probing for Fujitsu MBM29F400BC, 512 KB: skipped. Probing for Fujitsu MBM29F400TC, 512 KB: skipped. Probing for Hyundai HY29F002T, 256 KB: skipped. Probing for Hyundai HY29F002B, 256 KB: skipped. Probing for Hyundai HY29F040A, 512 KB: skipped. Probing for Intel 28F001BN/BX-B, 128 KB: skipped. Probing for Intel 28F001BN/BX-T, 128 KB: skipped. Probing for Intel 28F002BC/BL/BV/BX-T, 256 KB: skipped. Probing for Intel 28F008S3/S5/SC, 512 KB: skipped. Probing for Intel 28F004B5/BE/BV/BX-B, 512 KB: skipped. Probing for Intel 28F004B5/BE/BV/BX-T, 512 KB: skipped. Probing for Intel 28F400BV/BX/CE/CV-B, 512 KB: skipped. Probing for Intel 28F400BV/BX/CE/CV-T, 512 KB: skipped. Probing for Intel 82802AB, 512 KB: skipped. Probing for Intel 82802AC, 1024 KB: skipped. Probing for Macronix MX25L512, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1005, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L2005, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L4005, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L8005, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Chip status register is 00 Chip status register: Status Register Write Disable (SRWD) is not set Chip status register: Bit 6 is not set Chip status register: Bit 5 / Block Protect 3 (BP3) is not set Chip status register: Bit 4 / Block Protect 2 (BP2) is not set Chip status register: Bit 3 / Block Protect 1 (BP1) is not set Chip status register: Bit 2 / Block Protect 0 (BP0) is not set Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Found chip "Macronix MX25L8005" (1024 KB, SPI) at physical address 0xfff00000. Probing for Macronix MX25L1605, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1635D, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L1635E, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L3205, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L3235D, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L6405, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX25L12805, 16384 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix MX29F001B, 128 KB: skipped. Probing for Macronix MX29F001T, 128 KB: skipped. Probing for Macronix MX29F002B, 256 KB: skipped. Probing for Macronix MX29F002T, 256 KB: skipped. Probing for Macronix MX29F040, 512 KB: skipped. Probing for Macronix MX29LV040, 512 KB: skipped. Probing for MoselVitelic V29C51000B, 64 KB: skipped. Probing for MoselVitelic V29C51000T, 64 KB: skipped. Probing for MoselVitelic V29C51400B, 512 KB: skipped. Probing for MoselVitelic V29C51400T, 512 KB: skipped. Probing for MoselVitelic V29LC51000, 64 KB: skipped. Probing for MoselVitelic V29LC51001, 128 KB: skipped. Probing for MoselVitelic V29LC51002, 256 KB: skipped. Probing for Numonyx M25PE10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Numonyx M25PE16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV010, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV016B, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV020, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV040, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV080B, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm25LV512, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC Pm29F002T, 256 KB: skipped. Probing for PMC Pm29F002B, 256 KB: skipped. Probing for PMC Pm39LV010, 128 KB: skipped. Probing for PMC Pm39LV020, 256 KB: skipped. Probing for PMC Pm39LV040, 512 KB: skipped. Probing for PMC Pm49FL002, 256 KB: skipped. Probing for PMC Pm49FL004, 512 KB: skipped. Probing for Sanyo LF25FW203A, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Sharp LHF00L04, 1024 KB: skipped. Probing for Spansion S25FL004A, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL008A, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL016A, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL032A, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Spansion S25FL064A, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF010.REMS, 128 KB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF016B, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF032B, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF064C, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25VF040.REMS, 512 KB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF040B, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST25LF040A.RES, 512 KB: probe_spi_res2: id1 0x13, id2 0x13 Probing for SST SST25VF040B.REMS, 512 KB: probe_spi_rems: id1 0xc2, id2 0x13 Probing for SST SST25VF080B, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST SST28SF040A, 512 KB: skipped. Probing for SST SST29EE010, 128 KB: skipped. Probing for SST SST29LE010, 128 KB: skipped. Probing for SST SST29EE020A, 256 KB: skipped. Probing for SST SST29LE020, 256 KB: skipped. Probing for SST SST39SF512, 64 KB: skipped. Probing for SST SST39SF010A, 128 KB: skipped. Probing for SST SST39SF020A, 256 KB: skipped. Probing for SST SST39SF040, 512 KB: skipped. Probing for SST SST39VF512, 64 KB: skipped. Probing for SST SST39VF010, 128 KB: skipped. Probing for SST SST39VF020, 256 KB: skipped. Probing for SST SST39VF040, 512 KB: skipped. Probing for SST SST39VF080, 1024 KB: skipped. Probing for SST SST49LF002A/B, 256 KB: skipped. Probing for SST SST49LF003A/B, 384 KB: skipped. Probing for SST SST49LF004A/B, 512 KB: skipped. Probing for SST SST49LF004C, 512 KB: skipped. Probing for SST SST49LF008A, 1024 KB: skipped. Probing for SST SST49LF008C, 1024 KB: skipped. Probing for SST SST49LF016C, 2048 KB: skipped. Probing for SST SST49LF020, 256 KB: skipped. Probing for SST SST49LF020A, 256 KB: skipped. Probing for SST SST49LF040, 512 KB: skipped. Probing for SST SST49LF040B, 512 KB: skipped. Probing for SST SST49LF080A, 1024 KB: skipped. Probing for SST SST49LF160C, 2048 KB: skipped. Probing for ST M25P05-A, 64 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P05.RES, 64 KB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P10.RES, 128 KB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P40-old, 512 KB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25P128, 16384 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M25PX64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST M29F002B, 256 KB: skipped. Probing for ST M29F002T/NT, 256 KB: skipped. Probing for ST M29F040B, 512 KB: skipped. Probing for ST M29F400BB, 512 KB: skipped. Probing for ST M29F400BT, 512 KB: skipped. Probing for ST M29W010B, 128 KB: skipped. Probing for ST M29W040B, 512 KB: skipped. Probing for ST M29W512B, 64 KB: skipped. Probing for ST M50FLW040A, 512 KB: skipped. Probing for ST M50FLW040B, 512 KB: skipped. Probing for ST M50FLW080A, 1024 KB: skipped. Probing for ST M50FLW080B, 1024 KB: skipped. Probing for ST M50FW002, 256 KB: skipped. Probing for ST M50FW016, 2048 KB: skipped. Probing for ST M50FW040, 512 KB: skipped. Probing for ST M50FW080, 1024 KB: skipped. Probing for ST M50LPW116, 2048 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001B, 128 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001T, 128 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51002B, 256 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51002T, 256 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51004B, 512 KB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51004T, 512 KB: skipped. Probing for SyncMOS/MoselVitelic {S,V}29C31004B, 512 KB: skipped. Probing for SyncMOS/MoselVitelic {S,V}29C31004T, 512 KB: skipped. Probing for TI TMS29F002RB, 256 KB: skipped. Probing for TI TMS29F002RT, 256 KB: skipped. Probing for Winbond W25Q80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25Q64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x10, 128 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x20, 256 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x40, 512 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x80, 1024 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x16, 2048 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x32, 4096 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W25x64, 8192 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 KB: skipped. Probing for Winbond W29C020(C)/W29C022, 256 KB: skipped. Probing for Winbond W29C040/P, 512 KB: skipped. Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 KB: skipped. Probing for Winbond W39L040, 512 KB: skipped. Probing for Winbond W39V040A, 512 KB: skipped. Probing for Winbond W39V040B, 512 KB: skipped. Probing for Winbond W39V040C, 512 KB: skipped. Probing for Winbond W39V040FA, 512 KB: skipped. Probing for Winbond W39V040FB, 512 KB: skipped. Probing for Winbond W39V040FC, 512 KB: skipped. Probing for Winbond W39V080A, 1024 KB: skipped. Probing for Winbond W49F002U/N, 256 KB: skipped. Probing for Winbond W49F020, 256 KB: skipped. Probing for Winbond W49V002A, 256 KB: skipped. Probing for Winbond W49V002FA, 256 KB: skipped. Probing for Winbond W39V080FA, 1024 KB: skipped. Probing for Winbond W39V080FA (dual mode), 512 KB: skipped. Probing for AMIC unknown AMIC SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Atmel unknown Atmel SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Eon unknown Eon SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Macronix unknown Macronix SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for PMC unknown PMC SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for SST unknown SST SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for ST unknown ST SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Sanyo unknown Sanyo SPI chip, 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Generic unknown SPI chip (RDID), 0 KB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 Probing for Generic unknown SPI chip (REMS), 0 KB: probe_spi_rems: id1 0xc2, id2 0x13 === This flash part has status UNTESTED for operations: WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! No operations were specified. [root@magnet alexander]#

1 0

[PATCH 8/8] squash! ichspi:c add support for Intel Hardware Sequencing
by Stefan Tauner 28 Jun '11

28 Jun '11

- add SPI_CONTROLLER_ICH_HWSEQ support to ich_set_bbar although unused atm - remove ich_hwseq_get_flash_boundary - use all fdata registers for transfers - allow 25b addresses and add ich_hwseq_set_addr Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- ichspi.c | 83 ++++++++++++++++++++++++++++--------------------------------- 1 files changed, 38 insertions(+), 45 deletions(-) diff --git a/ichspi.c b/ichspi.c index 361006d..fd3b808 100644 --- a/ichspi.c +++ b/ichspi.c @@ -577,6 +577,7 @@ static void ich_set_bbar(uint32_t min_addr) bbar_off = 0x50; break; case SPI_CONTROLLER_ICH9: + case SPI_CONTROLLER_ICH_HWSEQ: bbar_off = ICH9_REG_BBAR; break; default: @@ -1092,9 +1093,10 @@ static int ich_spi_send_command(unsigned int writecnt, unsigned int readcnt, return result; } -static uint32_t ich_hwseq_get_flash_boundary(void) +static void ich_hwseq_set_addr(uint32_t addr) { - return (REGREAD32(ICH9_REG_FPB) & FPB_FPBA) << 12; + uint32_t addr_old = REGREAD32(ICH9_REG_FADDR) & ~0x01FFFFFF; + REGWRITE32(ICH9_REG_FADDR, (addr & 0x01FFFFFF) | addr_old); } /* Sets FADDR.FLA to 'addr' and returns the erase block size in bytes @@ -1109,7 +1111,7 @@ static uint32_t ich_hwseq_get_erase_block_size(unsigned int addr) 64 * 1024 }; - REGWRITE32(ICH9_REG_FADDR, (addr & 0x00FFFFFF)); + ich_hwseq_set_addr(addr); enc_berase = (REGREAD16(ICH9_REG_HSFS) & HSFS_BERASE) >> HSFS_BERASE_OFF; return dec_berase[enc_berase]; @@ -1132,9 +1134,9 @@ static int ich_hwseq_wait_for_cycle_complete(unsigned int timeout, } REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); if (!timeout) { - addr = REGREAD32(ICH9_REG_FADDR); - msg_perr("Timeout error between offset 0x%06x and " - "0x%06x + %d (=0x%06x)!\n", + addr = REGREAD32(ICH9_REG_FADDR) & 0x01FFFFFF; + msg_perr("Timeout error between offset 0x%08x and " + "0x%08x + %d (=0x%08x)!\n", addr, addr, len - 1, addr + len - 1); prettyprint_ich9_reg_hsfs(hsfs); prettyprint_ich9_reg_hsfc(REGREAD16(ICH9_REG_HSFC)); @@ -1142,9 +1144,9 @@ static int ich_hwseq_wait_for_cycle_complete(unsigned int timeout, } if (hsfs & HSFS_FCERR) { - addr = REGREAD32(ICH9_REG_FADDR); - msg_perr("Transaction error between offset 0x%06x and " - "0x%06x + %d (=0x%06x)!\n", + addr = REGREAD32(ICH9_REG_FADDR) & 0x01FFFFFF; + msg_perr("Transaction error between offset 0x%08x and " + "0x%08x + %d (=0x%08x)!\n", addr, addr, len - 1, addr + len - 1); prettyprint_ich9_reg_hsfs(hsfs); prettyprint_ich9_reg_hsfc(REGREAD16(ICH9_REG_HSFC)); @@ -1175,8 +1177,8 @@ int ich_hwseq_probe(struct flashchip *flash) msg_cdbg("not met.\n"); return 0; } - msg_cdbg("met.\n"); + total_size = (getFCBA_component_density(0) + getFCBA_component_density(1)); msg_cdbg("Found %d attached SPI flash chip", fdbar.NC + 1); @@ -1188,7 +1190,7 @@ int ich_hwseq_probe(struct flashchip *flash) flash->total_size = total_size / 1024; eraser = &(flash->block_erasers[0]); - boundary = ich_hwseq_get_flash_boundary(); + boundary = (REGREAD32(ICH9_REG_FPB) & FPB_FPBA) << 12; size_high = total_size - boundary; erase_size_high = ich_hwseq_get_erase_block_size(boundary); @@ -1292,10 +1294,9 @@ int ich_hwseq_block_erase(struct flashchip *flash, int ich_hwseq_read(struct flashchip *flash, uint8_t *buf, int addr, int len) { - uint32_t *buf32 = (uint32_t *)buf; uint16_t hsfc; uint16_t timeout = 100 * 60; - int i; + uint8_t block_len; if (flash->manufacture_id != INTEL_ID || flash->model_id != INTEL_HWSEQ) { @@ -1304,14 +1305,8 @@ int ich_hwseq_read(struct flashchip *flash, uint8_t *buf, int addr, int len) return -1; } - if (len % 4 != 0) { - msg_perr("Read size has to be a multiple of 4 for this " - "implementation of hardware sequencing mode.\n"); - return -1; - } - - if (addr < 0 || addr + len > 0x00FFFFFF) { - msg_perr("Request to read from inaccessible memory address " + if (addr < 0 || addr + len > 0x01FFFFFF) { + msg_perr("Request to read from an inaccessible memory address " "(addr=0x%x, len=%d).\n", addr, len); return -1; } @@ -1320,30 +1315,32 @@ int ich_hwseq_read(struct flashchip *flash, uint8_t *buf, int addr, int len) /* clear FDONE, FCERR, AEL by writing 1 to them (if they are set) */ REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); - for (i = 0; i < len; i += 4) { - /* FIXME: reserved bits */ - REGWRITE32(ICH9_REG_FADDR, (addr & 0x00FFFFFF)); + while (len > 0) { + block_len = min(len, spi_programmer->max_data_read); + ich_hwseq_set_addr(addr); hsfc = REGREAD16(ICH9_REG_HSFC); hsfc &= ~HSFC_FCYCLE; /* set read operation */ hsfc &= ~HSFC_FDBC; /* clear byte count */ - hsfc |= (3 << HSFC_FDBC_OFF); /* set byte count to 3+1 */ + hsfc |= ((block_len - 1) << HSFC_FDBC_OFF); /* set byte count */ hsfc |= HSFC_FGO; /* start */ REGWRITE16(ICH9_REG_HSFC, hsfc); if (ich_hwseq_wait_for_cycle_complete(timeout, 4)) return 1; - *buf32++ = REGREAD32(ICH9_REG_FDATA0); - addr += 4; + ich_read_data(buf, block_len, ICH9_REG_FDATA0); + addr += block_len; + buf += block_len; + len -= block_len; } return 0; } int ich_hwseq_write_256(struct flashchip *flash, uint8_t *buf, int addr, int len) { - uint32_t *buf32 = (uint32_t *)buf; uint16_t hsfc; uint16_t timeout = 100 * 60; - int i; + uint8_t block_len; + if (flash->manufacture_id != INTEL_ID || flash->model_id != INTEL_HWSEQ) { msg_perr("This chip (%s) is not supported in hardware" @@ -1351,14 +1348,8 @@ int ich_hwseq_write_256(struct flashchip *flash, uint8_t *buf, int addr, int len return -1; } - if ((len % 4 != 0)) { - msg_perr("Write size has to be a multiple of 4 for this " - "implementation of hardware sequencing mode\n"); - return -1; - } - if (addr < 0 || addr + len > 0x00FFFFFF) { - msg_perr("Request to write to inaccessible memory address " + msg_perr("Request to write to an inaccessible memory address " "(addr=0x%x, len=%d).\n", addr, len); return -1; } @@ -1367,22 +1358,24 @@ int ich_hwseq_write_256(struct flashchip *flash, uint8_t *buf, int addr, int len /* clear FDONE, FCERR, AEL by writing 1 to them (if they are set) */ REGWRITE16(ICH9_REG_HSFS, REGREAD16(ICH9_REG_HSFS)); - for (i = 0; i < len; i += 4) { - /* FIXME: reserved bits */ - REGWRITE32(ICH9_REG_FADDR, (addr & 0x00FFFFFF)); - REGWRITE32(ICH9_REG_FDATA0, *buf32); + while (len > 0) { + ich_hwseq_set_addr(addr); + block_len = ich_fill_data(buf, len, ICH9_REG_FDATA0); + if (block_len < 0) + return block_len; hsfc = REGREAD16(ICH9_REG_HSFC); hsfc &= ~HSFC_FCYCLE; /* clear operation */ hsfc |= (0x2 << HSFC_FCYCLE_OFF); /* set write operation */ hsfc &= ~HSFC_FDBC; /* clear byte count */ - hsfc |= (3 << HSFC_FDBC_OFF); /* set byte count to 3+1 */ + hsfc |= ((block_len - 1) << HSFC_FDBC_OFF); /* set byte count */ hsfc |= HSFC_FGO; /* start */ REGWRITE16(ICH9_REG_HSFC, hsfc); - if (ich_hwseq_wait_for_cycle_complete(timeout, 4)) - return 1; - addr += 4; - buf32++; + if (ich_hwseq_wait_for_cycle_complete(timeout, block_len)) + return -1; + addr += block_len; + buf += block_len; + len -= block_len; } return 0; } -- 1.7.1

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom June 2011