January 2011 - flashrom - mail.coreboot.org

[RFC + PATCH] lock command for flashrom
by Mathias Krause Feb. 2, 2011

Feb. 2, 2011

Hi, flashrom currently tries to unlock the chip before each read/write/erase command. To prevent further modifications of the chip content, e.g. for security reasons, it would be helpful if flashrom would also be capable of the opposite operation. I talked with Carl-Daniel a little about it and he mentioned problems like having to implement features like partial locks, chips that cannot be unlocked after being locked, etc. To support those features and handle the problematic chips something more than this little patch can do must be implemented. But for now it would be nice to have *something*. See it as a starting point to solve the much bigger problem. This patch adds a function pointer to struct flashchip and a command line option to trigger this function to enable full flash chip write protection. It's currently only implemented for the Atmel AT26DF081A since this is the chip I'm currently working with and which I can test easily. ToDo: Add man page documentation. Signed-off-by: Mathias Krause <mathias.krause(a)secunet.com>

2 4

Present For You
by Glenn Mueller Jan. 31, 2011

Jan. 31, 2011

I wanna share this with u http://www.learn2juggle.com/info.html Enjoy!

2 1

Flashrom works on 848P-A7 with Winbond W49V002FA flash chip
by James Wall Jan. 31, 2011

Jan. 31, 2011

I just tested the write and erase process on the Winbond W49V002FA flash chip found on the ECS 848P-A7. Attached are the dumps of flashrom working on the chip. James Wall

1 0

EVGA nForce 780i
by Brandon Dowdy Jan. 31, 2011

Jan. 31, 2011

I found erase, read and write on the flashchip. :D Board: EVGA nForce 780i Flashchip: SST SST49LF080A Super IO: Winbond W83627DHG Southbridge: NVIDIA MCP55 the outputs are attachments. P.S. I made 3 lspci outputs.

1 0

Nvidia MCP73 Chipset readout from EVGA 112-CK-NF77-A1 motherboard
by Garth Dahlstrom Jan. 30, 2011

Jan. 30, 2011

flashrom v0.9.2-r1028 on Linux 2.6.35-25-generic (x86_64), built with libpci 3.0.0, GCC 4.4.4, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 1 usecs, 1865M loops per second, 10 myus = 10 us, 100 myus = 101 us, 1000 myus = 1007 us, 10000 myus = 10023 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "NVIDIA" DMI string system-product-name: "MCP73 " DMI string system-version: "2" DMI string baseboard-manufacturer: "EVGA" DMI string baseboard-product-name: "NF77-HDMI" DMI string baseboard-version: "2" DMI string chassis-type: "Desktop" Found chipset "NVIDIA MCP73", enabling flash write... chipset PCI ID is 10de:07d7, This chipset is not really supported yet. Guesswork... ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0 Guessed flash bus type is SPI Found SMBus device 10de:07d8 at 00:03:1 SPI BAR is at 0xeff00000, after clearing low bits BAR is at 0xeff00000 Mapping MCP67 SPI at 0xeff00000, unaligned size 0x544. SPI control is 0xc01a, enable=0, idle=0 Please send the output of "flashrom -V" to flashrom(a)flashrom.org to help us finish support for your chipset. Thanks. SPI on this chipset is not supported yet. OK. This chipset supports the following protocols: None. Probing for AMD Am29F010A/B, 128 KB: skipped. Probing for AMD Am29F002(N)BB, 256 KB: skipped. Probing for AMD Am29F002(N)BT, 256 KB: skipped. Probing for AMD Am29F016D, 2048 KB: skipped. Probing for AMD Am29F040B, 512 KB: skipped. Probing for AMD Am29F080B, 1024 KB: skipped. Probing for AMD Am29LV040B, 512 KB: skipped. Probing for AMD Am29LV081B, 1024 KB: skipped. Probing for ASD AE49F2008, 256 KB: skipped. Probing for Atmel AT25DF021, 256 KB: skipped. Probing for Atmel AT25DF041A, 512 KB: skipped. Probing for Atmel AT25DF081, 1024 KB: skipped. Probing for Atmel AT25DF161, 2048 KB: skipped. Probing for Atmel AT25DF321, 4096 KB: skipped. Probing for Atmel AT25DF321A, 4096 KB: skipped. Probing for Atmel AT25DF641, 8192 KB: skipped. Probing for Atmel AT25F512B, 64 KB: skipped. Probing for Atmel AT25FS010, 128 KB: skipped. Probing for Atmel AT25FS040, 512 KB: skipped. Probing for Atmel AT26DF041, 512 KB: skipped. Probing for Atmel AT26DF081A, 1024 KB: skipped. Probing for Atmel AT26DF161, 2048 KB: skipped. Probing for Atmel AT26DF161A, 2048 KB: skipped. Probing for Atmel AT26F004, 512 KB: skipped. Probing for Atmel AT29C512, 64 KB: skipped. Probing for Atmel AT29C010A, 128 KB: skipped. Probing for Atmel AT29C020, 256 KB: skipped. Probing for Atmel AT29C040A, 512 KB: skipped. Probing for Atmel AT45CS1282, 16896 KB: skipped. Probing for Atmel AT45DB011D, 128 KB: skipped. Probing for Atmel AT45DB021D, 256 KB: skipped. Probing for Atmel AT45DB041D, 512 KB: skipped. Probing for Atmel AT45DB081D, 1024 KB: skipped. Probing for Atmel AT45DB161D, 2048 KB: skipped. Probing for Atmel AT45DB321C, 4224 KB: skipped. Probing for Atmel AT45DB321D, 4096 KB: skipped. Probing for Atmel AT45DB642D, 8192 KB: skipped. Probing for Atmel AT49BV512, 64 KB: skipped. Probing for Atmel AT49F002(N), 256 KB: skipped. Probing for Atmel AT49F002(N)T, 256 KB: skipped. Probing for AMIC A25L40PT, 512 KB: skipped. Probing for AMIC A25L40PU, 512 KB: skipped. Probing for AMIC A29002B, 256 KB: skipped. Probing for AMIC A29002T, 256 KB: skipped. Probing for AMIC A29040B, 512 KB: skipped. Probing for AMIC A49LF040A, 512 KB: skipped. Probing for EMST F49B002UA, 256 KB: skipped. Probing for Eon EN25B05, 64 KB: skipped. Probing for Eon EN25B05T, 64 KB: skipped. Probing for Eon EN25B10, 128 KB: skipped. Probing for Eon EN25B10T, 128 KB: skipped. Probing for Eon EN25B20, 256 KB: skipped. Probing for Eon EN25B20T, 256 KB: skipped. Probing for Eon EN25B40, 512 KB: skipped. Probing for Eon EN25B40T, 512 KB: skipped. Probing for Eon EN25B80, 1024 KB: skipped. Probing for Eon EN25B80T, 1024 KB: skipped. Probing for Eon EN25B16, 2048 KB: skipped. Probing for Eon EN25B16T, 2048 KB: skipped. Probing for Eon EN25B32, 4096 KB: skipped. Probing for Eon EN25B32T, 4096 KB: skipped. Probing for Eon EN25B64, 8192 KB: skipped. Probing for Eon EN25B64T, 8192 KB: skipped. Probing for Eon EN25D16, 2048 KB: skipped. Probing for Eon EN25F05, 64 KB: skipped. Probing for Eon EN25F10, 128 KB: skipped. Probing for Eon EN25F20, 256 KB: skipped. Probing for Eon EN25F40, 512 KB: skipped. Probing for Eon EN25F80, 1024 KB: skipped. Probing for Eon EN25F16, 2048 KB: skipped. Probing for Eon EN25F32, 4096 KB: skipped. Probing for Eon EN29F010, 128 KB: skipped. Probing for EON EN29F002(A)(N)B, 256 KB: skipped. Probing for EON EN29F002(A)(N)T, 256 KB: skipped. Probing for Fujitsu MBM29F004BC, 512 KB: skipped. Probing for Fujitsu MBM29F004TC, 512 KB: skipped. Probing for Fujitsu MBM29F400BC, 512 KB: skipped. Probing for Fujitsu MBM29F400TC, 512 KB: skipped. Probing for Intel 28F001BX-B, 128 KB: skipped. Probing for Intel 28F001BX-T, 128 KB: skipped. Probing for Intel 28F004S5, 512 KB: skipped. Probing for Intel 28F004BV/BE-B, 512 KB: skipped. Probing for Intel 28F004BV/BE-T, 512 KB: skipped. Probing for Intel 28F400BV/CV/CE-B, 512 KB: skipped. Probing for Intel 28F400BV/CV/CE-T, 512 KB: skipped. Probing for Intel 82802AB, 512 KB: skipped. Probing for Intel 82802AC, 1024 KB: skipped. Probing for Macronix MX25L512, 64 KB: skipped. Probing for Macronix MX25L1005, 128 KB: skipped. Probing for Macronix MX25L2005, 256 KB: skipped. Probing for Macronix MX25L4005, 512 KB: skipped. Probing for Macronix MX25L8005, 1024 KB: skipped. Probing for Macronix MX25L1605, 2048 KB: skipped. Probing for Macronix MX25L1635D, 2048 KB: skipped. Probing for Macronix MX25L3205, 4096 KB: skipped. Probing for Macronix MX25L3235D, 4096 KB: skipped. Probing for Macronix MX25L6405, 8192 KB: skipped. Probing for Macronix MX25L12805, 16384 KB: skipped. Probing for Macronix MX29F001B, 128 KB: skipped. Probing for Macronix MX29F001T, 128 KB: skipped. Probing for Macronix MX29F002B, 256 KB: skipped. Probing for Macronix MX29F002T, 256 KB: skipped. Probing for Macronix MX29LV040, 512 KB: skipped. Probing for Numonyx M25PE10, 128 KB: skipped. Probing for Numonyx M25PE20, 256 KB: skipped. Probing for Numonyx M25PE40, 512 KB: skipped. Probing for Numonyx M25PE80, 1024 KB: skipped. Probing for Numonyx M25PE16, 2048 KB: skipped. Probing for PMC Pm25LV010, 128 KB: skipped. Probing for PMC Pm25LV016B, 2048 KB: skipped. Probing for PMC Pm25LV020, 256 KB: skipped. Probing for PMC Pm25LV040, 512 KB: skipped. Probing for PMC Pm25LV080B, 1024 KB: skipped. Probing for PMC Pm25LV512, 64 KB: skipped. Probing for PMC Pm29F002T, 256 KB: skipped. Probing for PMC Pm29F002B, 256 KB: skipped. Probing for PMC Pm39LV010, 128 KB: skipped. Probing for PMC Pm39LV020, 256 KB: skipped. Probing for PMC Pm39LV040, 512 KB: skipped. Probing for PMC Pm49FL002, 256 KB: skipped. Probing for PMC Pm49FL004, 512 KB: skipped. Probing for Sanyo LF25FW203A, 2048 KB: skipped. Probing for Sharp LHF00L04, 1024 KB: skipped. Probing for Spansion S25FL008A, 1024 KB: skipped. Probing for Spansion S25FL016A, 2048 KB: skipped. Probing for SST SST25VF016B, 2048 KB: skipped. Probing for SST SST25VF032B, 4096 KB: skipped. Probing for SST SST25VF040.REMS, 512 KB: skipped. Probing for SST SST25VF040B, 512 KB: skipped. Probing for SST SST25VF040B.REMS, 512 KB: skipped. Probing for SST SST25VF080B, 1024 KB: skipped. Probing for SST SST28SF040A, 512 KB: skipped. Probing for SST SST29EE010, 128 KB: skipped. Probing for SST SST29LE010, 128 KB: skipped. Probing for SST SST29EE020A, 256 KB: skipped. Probing for SST SST29LE020, 256 KB: skipped. Probing for SST SST39SF512, 64 KB: skipped. Probing for SST SST39SF010A, 128 KB: skipped. Probing for SST SST39SF020A, 256 KB: skipped. Probing for SST SST39SF040, 512 KB: skipped. Probing for SST SST39VF512, 64 KB: skipped. Probing for SST SST39VF010, 128 KB: skipped. Probing for SST SST39VF020, 256 KB: skipped. Probing for SST SST39VF040, 512 KB: skipped. Probing for SST SST39VF080, 1024 KB: skipped. Probing for SST SST49LF002A/B, 256 KB: skipped. Probing for SST SST49LF003A/B, 384 KB: skipped. Probing for SST SST49LF004A/B, 512 KB: skipped. Probing for SST SST49LF004C, 512 KB: skipped. Probing for SST SST49LF008A, 1024 KB: skipped. Probing for SST SST49LF008C, 1024 KB: skipped. Probing for SST SST49LF016C, 2048 KB: skipped. Probing for SST SST49LF020, 256 KB: skipped. Probing for SST SST49LF020A, 256 KB: skipped. Probing for SST SST49LF040, 512 KB: skipped. Probing for SST SST49LF040B, 512 KB: skipped. Probing for SST SST49LF080A, 1024 KB: skipped. Probing for SST SST49LF160C, 2048 KB: skipped. Probing for ST M25P05-A, 64 KB: skipped. Probing for ST M25P05.RES, 64 KB: skipped. Probing for ST M25P10-A, 128 KB: skipped. Probing for ST M25P10.RES, 128 KB: skipped. Probing for ST M25P20, 256 KB: skipped. Probing for ST M25P40, 512 KB: skipped. Probing for ST M25P40-old, 512 KB: skipped. Probing for ST M25P80, 1024 KB: skipped. Probing for ST M25P16, 2048 KB: skipped. Probing for ST M25P32, 4096 KB: skipped. Probing for ST M25P64, 8192 KB: skipped. Probing for ST M25P128, 16384 KB: skipped. Probing for ST M29F002B, 256 KB: skipped. Probing for ST M29F002T/NT, 256 KB: skipped. Probing for ST M29F040B, 512 KB: skipped. Probing for ST M29F400BT, 512 KB: skipped. Probing for ST M29W010B, 128 KB: skipped. Probing for ST M29W040B, 512 KB: skipped. Probing for ST M29W512B, 64 KB: skipped. Probing for ST M50FLW040A, 512 KB: skipped. Probing for ST M50FLW040B, 512 KB: skipped. Probing for ST M50FLW080A, 1024 KB: skipped. Probing for ST M50FLW080B, 1024 KB: skipped. Probing for ST M50FW002, 256 KB: skipped. Probing for ST M50FW016, 2048 KB: skipped. Probing for ST M50FW040, 512 KB: skipped. Probing for ST M50FW080, 1024 KB: skipped. Probing for ST M50LPW116, 2048 KB: skipped. Probing for SyncMOS S29C31004T, 512 KB: skipped. Probing for SyncMOS S29C51001T, 128 KB: skipped. Probing for SyncMOS S29C51002T, 256 KB: skipped. Probing for SyncMOS S29C51004T, 512 KB: skipped. Probing for TI TMS29F002RB, 256 KB: skipped. Probing for TI TMS29F002RT, 256 KB: skipped. Probing for Winbond W25Q80, 1024 KB: skipped. Probing for Winbond W25Q16, 2048 KB: skipped. Probing for Winbond W25Q32, 4096 KB: skipped. Probing for Winbond W25x10, 128 KB: skipped. Probing for Winbond W25x20, 256 KB: skipped. Probing for Winbond W25x40, 512 KB: skipped. Probing for Winbond W25x80, 1024 KB: skipped. Probing for Winbond W25x16, 2048 KB: skipped. Probing for Winbond W25x32, 4096 KB: skipped. Probing for Winbond W25x64, 8192 KB: skipped. Probing for Winbond W29C011, 128 KB: skipped. Probing for Winbond W29C020C, 256 KB: skipped. Probing for Winbond W29C040P, 512 KB: skipped. Probing for Winbond W29EE011, 128 KB: skipped. Probing for Winbond W39V040A, 512 KB: skipped. Probing for Winbond W39V040B, 512 KB: skipped. Probing for Winbond W39V040C, 512 KB: skipped. Probing for Winbond W39V040FA, 512 KB: skipped. Probing for Winbond W39V080A, 1024 KB: skipped. Probing for Winbond W49F002U, 256 KB: skipped. Probing for Winbond W49V002A, 256 KB: skipped. Probing for Winbond W49V002FA, 256 KB: skipped. Probing for Winbond W39V080FA, 1024 KB: skipped. Probing for Winbond W39V080FA (dual mode), 512 KB: skipped. Probing for Atmel unknown Atmel SPI chip, 0 KB: skipped. Probing for EON unknown EON SPI chip, 0 KB: skipped. Probing for Macronix unknown Macronix SPI chip, 0 KB: skipped. Probing for PMC unknown PMC SPI chip, 0 KB: skipped. Probing for SST unknown SST SPI chip, 0 KB: skipped. Probing for ST unknown ST SPI chip, 0 KB: skipped. Probing for Sanyo unknown Sanyo SPI chip, 0 KB: skipped. Probing for Generic unknown SPI chip (RDID), 0 KB: skipped. Probing for Generic unknown SPI chip (REMS), 0 KB: skipped. No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically.

1 0

Gigabyte GA-M720-US3 report
by John Alyx Jan. 30, 2011

Jan. 30, 2011

Flashrom 0.9.3 works flawless in 40/40 cases of flashing Gigabyte GA-M720-US3 from F2 to latest F7N BIOS. Details on: http://paste.flashrom.org/view.php?id=293 http://paste.flashrom.org/view.php?id=292 http://paste.flashrom.org/view.php?id=291 http://paste.flashrom.org/view.php?id=290 http://paste.flashrom.org/view.php?id=289 http://paste.flashrom.org/view.php?id=288 http://paste.flashrom.org/view.php?id=287

1 0

flashrom can't find flash device on 'Chaintech' motherboard.
by Craig Magee Jan. 28, 2011

Jan. 28, 2011

Someone gave me an old system before Christmas. It's a nice box for something from the turn of the millennium, and in good order. The case particularly is nice, so I decided replace my network/file server with it. Rather than replacing the board I tried to use it as is, but the BIOS balks at the idea of booting from a 500GB hard-drive. I know there are other ways I can boot and mount it, but have always wanted to try coreboot and though this would be a neat project. The board is a Chaintech, unfortunately I haven't been able to find a model number. It looks very similar to the Asus P2B: Intel® 440BX - Intel® 82371BX - Winbond™ W83977TF(visually verified). I currently have LFS installed. flashrom tells me "No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically." I'm a bit sad about that. Here are links to the flashrom, lspci, and superiotool outputs that I was told to post in IRC, and will be following up any leads in the chat room as well as here. Sorry if I should really be attaching them to the email instead. lspci -nnvvvxxx http://paste.flashrom.org/view.php?id=315 flashrom -v http://paste.flashrom.org/view.php?id=316 superiotool -deV http://paste.flashrom.org/view.php?id=317 Thanks for your time.

1 1

GA-790FXTA-UD5 + ST-Lab A142 PCI to PATA
by Кирилл Лещинский Jan. 28, 2011

Jan. 28, 2011

I've tested the subj. combination with a flash chip marked as ASD AE29F1008-15 said to be a clone of Winbond (and recognized as Winbond by flashing software, including SiI's updflash.exe), and it works OK. Cyril Leshinsky (I'm from Russia)

1 0

[PATCH] do something useful with the dediprog LEDs
by Stefan Reinauer Jan. 28, 2011

Jan. 28, 2011

This patch makes use of the dediprog LEDs. It would be nice to have some "more global" infrastructure for device dependent status reporting. Right now some scenarios can not be reported as an error, though the user would think of them as one. For example, if the chip is IDed successfully but not supported by flashrom, thus it can not be flashed. At best, the dediprog driver sees a successful RDID command, but has no knowledge about the failure to read/write the chip. Therefore it can not report it. However, the attached patch improves my work flow here quite a bit, so I thought it should be shared. -- Stefan Reinauer Google Inc.

2 5

[commit] r1257 - trunk
by repository service Jan. 28, 2011

Jan. 28, 2011

Author: stepan Date: Fri Jan 28 10:00:15 2011 New Revision: 1257 URL: http://flashrom.org/trac/flashrom/changeset/1257 Log: Support Dediprog LEDs on devices with 2 and 3 LEDs. Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Acked-by: Mathias Krause <mathias.krause(a)secunet.com> Modified: trunk/dediprog.c Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Tue Jan 25 01:23:32 2011 (r1256) +++ trunk/dediprog.c Fri Jan 28 10:00:15 2011 (r1257) @@ -25,6 +25,7 @@ #include "programmer.h" #include "spi.h" +#define FIRMWARE_VERSION(x,y,z) ((x << 16) | (y << 8) | z) #define DEFAULT_TIMEOUT 3000 static usb_dev_handle *dediprog_handle; static int dediprog_firmwareversion; @@ -58,6 +59,50 @@ //int usb_control_msg(usb_dev_handle *dev, int requesttype, int request, int value, int index, char *bytes, int size, int timeout); +/* Set/clear LEDs on dediprog */ +#define PASS_ON (0 << 0) +#define PASS_OFF (1 << 0) +#define BUSY_ON (0 << 1) +#define BUSY_OFF (1 << 1) +#define ERROR_ON (0 << 2) +#define ERROR_OFF (1 << 2) +static int current_led_status = -1; + +static int dediprog_set_leds(int leds) +{ + int ret, target_leds; + + if (leds < 0 || leds > 7) + leds = 0; // Bogus value, enable all LEDs + + if (leds == current_led_status) + return 0; + + /* Older Dediprogs with 2.x.x and 3.x.x firmware only had + * two LEDs, and they were reversed. So map them around if + * we have an old device. On those devices the LEDs map as + * follows: + * bit 2 == 0: green light is on. + * bit 0 == 0: red light is on. + */ + if (dediprog_firmwareversion < FIRMWARE_VERSION(5,0,0)) { + target_leds = ((leds & ERROR_OFF) >> 2) | + ((leds & PASS_OFF) << 2); + } else { + target_leds = leds; + } + + ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, target_leds, NULL, 0x0, DEFAULT_TIMEOUT); + if (ret != 0x0) { + msg_perr("Command Set LED 0x%x failed (%s)!\n", leds, usb_strerror()); + return 1; + } + + current_led_status = leds; + + return 0; +} + static int dediprog_set_spi_voltage(int millivolt) { int ret; @@ -211,20 +256,26 @@ int residue = start % chunksize ? chunksize - start % chunksize : 0; int bulklen; + dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); + if (residue) { msg_pdbg("Slow read for partial block from 0x%x, length 0x%x\n", start, residue); ret = spi_read_chunked(flash, buf, start, residue, 16); - if (ret) + if (ret) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return ret; + } } /* Round down. */ bulklen = (len - residue) / chunksize * chunksize; ret = dediprog_spi_bulk_read(flash, buf + residue, start + residue, bulklen); - if (ret) + if (ret) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return ret; + } len -= residue + bulklen; if (len) { @@ -232,17 +283,31 @@ start, len); ret = spi_read_chunked(flash, buf + residue + bulklen, start + residue + bulklen, len, 16); - if (ret) + if (ret) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return ret; + } } + dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); return 0; } int dediprog_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len) { + int ret; + + dediprog_set_leds(PASS_OFF|BUSY_ON|ERROR_OFF); + /* No idea about the real limit. Maybe 12, maybe more, maybe less. */ - return spi_write_chunked(flash, buf, start, len, 12); + ret = spi_write_chunked(flash, buf, start, len, 12); + + if (ret) + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); + else + dediprog_set_leds(PASS_ON|BUSY_OFF|ERROR_OFF); + + return ret; } int dediprog_spi_send_command(unsigned int writecnt, unsigned int readcnt, @@ -318,7 +383,7 @@ fw[1], fw[2]); return 1; } - dediprog_firmwareversion = fw[0]; + dediprog_firmwareversion = FIRMWARE_VERSION(fw[0], fw[1], fw[2]); return 0; } @@ -410,79 +475,6 @@ } return 0; } - -/* Start/stop blinking? - * Present in eng_detect_blink.log with firmware 3.1.8 - * Preceded by Command J - */ -static int dediprog_command_g(void) -{ - int ret; - - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x03, NULL, 0x0, DEFAULT_TIMEOUT); - if (ret != 0x0) { - msg_perr("Command G failed (%s)!\n", usb_strerror()); - return 1; - } - return 0; -} - -/* Something. - * Present in all logs with firmware 5.1.5 - * Always preceded by Command Receive Device String - * Always followed by Command Set SPI Voltage nonzero - */ -static int dediprog_command_h(void) -{ - int ret; - - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x05, NULL, 0x0, DEFAULT_TIMEOUT); - if (ret != 0x0) { - msg_perr("Command H failed (%s)!\n", usb_strerror()); - return 1; - } - return 0; -} -#endif - -/* Shutdown for firmware 5.x? - * This command swithces the "Pass" LED on. - * Present in all logs with firmware 5.1.5 - * Often preceded by a SPI operation (Command Read SPI Bulk or Receive SPI) - * Always followed by Command Set SPI Voltage 0x0000 - */ -static int dediprog_command_i(void) -{ - int ret; - - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x06, NULL, 0x0, DEFAULT_TIMEOUT); - if (ret != 0x0) { - msg_perr("Command I failed (%s)!\n", usb_strerror()); - return 1; - } - return 0; -} - -#if 0 -/* Start/stop blinking? - * Present in all logs with firmware 5.1.5 - * Always preceded by Command Receive Device String on 5.1.5 - * Always followed by Command Set SPI Voltage nonzero on 5.1.5 - * Present in eng_detect_blink.log with firmware 3.1.8 - * Preceded by Command B in eng_detect_blink.log - * Followed by Command G in eng_detect_blink.log - */ -static int dediprog_command_j(void) -{ - int ret; - - ret = usb_control_msg(dediprog_handle, 0x42, 0x07, 0x09, 0x07, NULL, 0x0, DEFAULT_TIMEOUT); - if (ret != 0x0) { - msg_perr("Command J failed (%s)!\n", usb_strerror()); - return 1; - } - return 0; -} #endif static int parse_voltage(char *voltage) @@ -584,22 +576,35 @@ return 1; } dediprog_endpoint = 2; + + dediprog_set_leds(PASS_ON|BUSY_ON|ERROR_ON); + /* URB 6. Command A. */ - if (dediprog_command_a()) + if (dediprog_command_a()) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; + } /* URB 7. Command A. */ - if (dediprog_command_a()) + if (dediprog_command_a()) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; + } /* URB 8. Command Prepare Receive Device String. */ /* URB 9. Command Receive Device String. */ - if (dediprog_check_devicestring()) + if (dediprog_check_devicestring()) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; + } /* URB 10. Command C. */ - if (dediprog_command_c()) + if (dediprog_command_c()) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; + } /* URB 11. Command Set SPI Voltage. */ - if (dediprog_set_spi_voltage(millivolt)) + if (dediprog_set_spi_voltage(millivolt)) { + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_ON); return 1; + } buses_supported = CHIP_BUSTYPE_SPI; spi_controller = SPI_CONTROLLER_DEDIPROG; @@ -610,6 +615,8 @@ dediprog_do_stuff(); #endif + dediprog_set_leds(PASS_OFF|BUSY_OFF|ERROR_OFF); + return 0; } @@ -670,10 +677,6 @@ { msg_pspew("%s\n", __func__); - /* Shutdown on firmware 5.x */ - if (dediprog_firmwareversion == 5) - if (dediprog_command_i()) - return 1; /* URB 28. Command Set SPI Voltage to 0. */ if (dediprog_set_spi_voltage(0x0)) return 1;

1 0