mythtv ~ # flashrom -V
flashrom v0.9.2-r1001 on Linux 2.6.36-gentoo-r3 (x86_64), built with
libpci 3.1.7, GCC 4.5.1 flashrom is free software, get the source code
at http://www.flashrom.org
Initializing internal programmer
No coreboot table found.
DMI string system-manufacturer: "To Be Filled By O.E.M."
DMI string system-product-name: "To Be Filled By O.E.M."
DMI string system-version: "To Be Filled By O.E.M."
DMI string baseboard-manufacturer: "To be filled by O.E.M."
DMI string baseboard-product-name: "To be filled by O.E.M."
DMI string baseboard-version: "To be filled by O.E.M."
DMI string chassis-type: "Desktop"
Found chipset "NVIDIA MCP79", enabling flash write... This chipset is
not really supported yet. Guesswork... ISA/LPC bridge reg 0x8a
contents: 0x40, bit 6 is 1, bit 5 is 0 Guessed flash bus type is SPI
Found SMBus device 10de:0aa2 at 00:03:2
SPI BAR is at 0xfae80000, after clearing low bits BAR is at 0xfae80000
Mapping MCP67 SPI at 0xfae80000, unaligned size 0x544.
SPI control is 0xc05a, enable=0, idle=0
Please send the output of "flashrom -V" to flashrom(a)flashrom.org to
help us finish support for your chipset. Thanks. SPI on this chipset is
not supported yet. OK.
This chipset supports the following protocols: None.
Calibrating delay loop... 399M loops per second, 10 myus = 10 us, 100
myus = 100 us, 1000 myus = 1082 us, 10000 myus = 10100 us, OK.
--
Thanks, Saul
Computer model:
acer aspire revo 3610
--
The information in this email is intended only for the named
recipient(s) and may be privileged or confidential. If you are not the
intended recipient, please notify the sender immediately. Do not copy,
distribute or take any action based on this email.
Please consider the environment before printing this e-mail.
Author: hailfinger
Date: Thu Dec 2 03:41:55 2010
New Revision: 1238
URL: http://flashrom.org/trac/flashrom/changeset/1238
Log:
Handle erase failure in partial write.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Acked-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de>
Modified:
trunk/flashrom.c
Modified: trunk/flashrom.c
==============================================================================
--- trunk/flashrom.c Mon Nov 29 01:37:49 2010 (r1237)
+++ trunk/flashrom.c Thu Dec 2 03:41:55 2010 (r1238)
@@ -1468,11 +1468,20 @@
/* If everything is OK, don't try another erase function. */
if (!ret)
break;
- /* FIXME: Reread the whole chip here so we know the current
- * chip contents? curcontents might be up to date, but this
- * code is only reached if something failed, and then we don't
- * know exactly what failed, and how.
+ /* Write/erase failed, so try to find out what the current chip
+ * contents are. If no usable erase functions remain, we could
+ * abort the loop instead of continuing, the effect is the same.
+ * The only difference is whether the reason for other unusable
+ * functions is printed or not. If in doubt, verbosity wins.
*/
+ if (flash->read(flash, curcontents, 0, size)) {
+ /* Now we are truly screwed. Read failed as well. */
+ msg_cerr("Can't read anymore!\n");
+ /* We have no idea about the flash chip contents, so
+ * retrying with another erase function is pointless.
+ */
+ break;
+ }
}
/* Free the scratchpad. */
free(curcontents);
