[PATCH] Don't abort if chipset init failed

[Carl-Daniel Hailfinger]

Don't abort if chipset init failed because the failing init may have
been a warning only. This was requested by Stefan.

Signed-off-by: Carl-Daniel Hailfinger <[e-mail]>

Index: flashrom-internal_init_noabort/internal.c
===================================================================
--- flashrom-internal_init_noabort/internal.c	(Revision 706)
+++ flashrom-internal_init_noabort/internal.c	(Arbeitskopie)
@@ -130,7 +130,11 @@
 
 	board_flash_enable(lb_vendor, lb_part);
 
-	return ret; 
+	/* Even if chipset init returns an error code, we don't want to abort.
+	 * The error code might have been a warning only.
+	 * Besides that, we don't check the board enable return code either.
+	 */
+	return 0; 
 }
 
 int internal_shutdown(void)


-- 
http://www.hailfinger.org/

[Carl-Daniel Hailfinger]

On 02.09.2009 00:53, Carl-Daniel Hailfinger wrote:
> Don't abort if chipset init failed because the failing init may have
> been a warning only. This was requested by Stefan.

At least I think it was requested by Stefan ~2 months ago with the
reason that even a failing chipset init (maybe due to unknown chipset)
could still get us reasonable probe results or at least forced reads.
Apologies if I misremembered something.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/

[Uwe Hermann]

On Wed, Sep 02, 2009 at 12:53:25AM +0200, Carl-Daniel Hailfinger wrote:
> Don't abort if chipset init failed because the failing init may have
> been a warning only. This was requested by Stefan.
>
> Signed-off-by: Carl-Daniel Hailfinger <[e-mail]>

Acked-by: Uwe Hermann <[e-mail]>

 
Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[Carl-Daniel Hailfinger]

On 02.09.2009 15:29, Uwe Hermann wrote:
> On Wed, Sep 02, 2009 at 12:53:25AM +0200, Carl-Daniel Hailfinger wrote:
> > Don't abort if chipset init failed because the failing init may have
> > been a warning only. This was requested by Stefan.
> >
> > Signed-off-by: Carl-Daniel Hailfinger <[e-mail]>
>
> Acked-by: Uwe Hermann <[e-mail]>

Thanks, r708.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/