[PATCH] print.c fix - remove empty pcidevs header

[Adam Jurkowski]

Don't print out supported PCI devices header if all following lines are 
excluded from build.

Signed-off-by: Adam Jurkowski 
---
best regards,
Adam Jurkowski

[Carl-Daniel Hailfinger]

Hi Adam,

thanks for your patch.

On 24.11.2009 16:46, Adam Jurkowski wrote:
> Don't print out supported PCI devices header if all following lines
> are excluded from build.

Your patch unfortunately conflicts with
http://patchwork.coreboot.org/patch/576/ but I'll merge it once that
other patch is committed.
> Signed-off-by: Adam Jurkowski

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

Hi Adam,

On 24.11.2009 16:52, Carl-Daniel Hailfinger wrote:
> On 24.11.2009 16:46, Adam Jurkowski wrote:
> > Don't print out supported PCI devices header if all following lines
> > are excluded from build.
>
> Your patch unfortunately conflicts with
> http://patchwork.coreboot.org/patch/576/ but I'll merge it once that
> other patch is committed.

The conflicting patch has now been committed.
Would you mind regenerating your patch and resending it with the
original changelog? I have roughly 50 patches I need to manage and this
would reduce my load. Feel free to include my Acked-by statement in your
changelog to get a speedier commit.

One minor comment, though. Could you use parentheses like this?
#if (NIC3COM_SUPPORT == 1) || (GFXNVIDIA_SUPPORT == 1) ||
(DRKAISER_SUPPORT == 1) || (SATASII_SUPPORT == 1)

IMHO that makes the code more readable.
> Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

I decided to update the patch myself since it is small enough.

Don't print out supported PCI devices header if all following lines are
excluded from build.

Signed-off-by: Adam Jurkowski 
Acked-by: Carl-Daniel Hailfinger

Index: flashrom-print_pcidevs_conditional/print.c
===================================================================
--- flashrom-print_pcidevs_conditional/print.c	(Revision 797)
+++ flashrom-print_pcidevs_conditional/print.c	(Arbeitskopie)
@@ -231,8 +231,10 @@
    	print_supported_chipsets();
    	print_supported_boards();
 #endif
+#if (NIC3COM_SUPPORT == 1) || (GFXNVIDIA_SUPPORT == 1) || (DRKAISER_SUPPORT == 1) || (SATASII_SUPPORT == 1)
    	printf("\nSupported PCI devices flashrom can use "
    	       "as programmer:\n\n");
+#endif
 #if NIC3COM_SUPPORT == 1
    	print_supported_pcidevs(nics_3com);
 #endif

[Carl-Daniel Hailfinger]

On 14.12.2009 03:57, Carl-Daniel Hailfinger wrote:
> Don't print out supported PCI devices header if all following lines are
> excluded from build.

r798.

Regards,
Carl-Daniel