Re: [flashrom] [PATCH] automatically round address ranges requested from physmap_common to page boundaries
On Mon, 30 May 2011 02:45:44 +0200 Stefan Tauner <stefan.tauner@student.tuwien.ac.at> wrote:
this patch also changes the display width of all addresses in physmap.c to 16 hex characters.
FIXME: what about unmappings? munmap is safe. djgpp's __dpmi_free_physical_address_mapping: unknown. DirectHW's unmap_physical: unknown.
FIXME: jakllsch suggested using PRIx64 instead of x, because it's more portable
FIXME: in the case we can not map and 'mayfail' is true we should return ERROR_PTR instead of ERROR_PTR + diff -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner
The current code is too much distributed and uncomfortable to use which leads to a lot of bugs. This series fixes both, existing bugs and future code. :) Two main points: 1) handle physmaps more intelligently by rounding to page sizes and automatic unmapping 2) automatic shutdown of pcilib Stefan Tauner (4): Let pcidev clean itself up. Add pci_init_common() to unify PCI init. Automatically unmap physmap()s. Allow physmap_common() to round address ranges to page boundaries. atahpt.c | 10 ------ chipset_enable.c | 12 ++++--- drkaiser.c | 15 ++------ gfxnvidia.c | 17 ++-------- ichspi.c | 4 ++- internal.c | 6 ++-- it85spi.c | 3 ++ mcp6x_spi.c | 15 +++----- nic3com.c | 2 +- nicintel.c | 27 +++------------ nicintel_spi.c | 12 +++---- nicrealtek.c | 7 ++-- ogp_spi.c | 13 ++----- pcidev.c | 28 +++++++++++++-- physmap.c | 100 ++++++++++++++++++++++++++++++++++++++++-------------- programmer.h | 2 ++ satamv.c | 16 +-------- satasii.c | 15 +++----- sb600spi.c | 6 ++-- 19 files changed, 153 insertions(+), 157 deletions(-) -- Kind regards, Stefan Tauner
participants (1)
-
Stefan Tauner