Re: [flashrom] [PATCH 4/8] ichspi.c: preserve reserved bits in address registers

[Carl-Daniel Hailfinger]

Am 28.06.2011 05:33 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner <[e-mail]>

Makes sense, but I worry that this might eventually break something. Do
we (want to) report the inital address setting during programmer init,
especially the reserved bits?

Anyway, this is
Acked-by: Carl-Daniel Hailfinger <[e-mail]>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/

[PATCH 4/8] ichspi.c: preserve reserved bits in address registers

[Stefan Tauner]

On Fri, 01 Jul 2011 01:21:33 +0200
Carl-Daniel Hailfinger <[e-mail]> wrote:
> Am 28.06.2011 05:33 schrieb Stefan Tauner:
> > Signed-off-by: Stefan Tauner <[e-mail]>
>
> Makes sense, but I worry that this might eventually break something. Do
> we (want to) report the inital address setting during programmer init,
> especially the reserved bits?

we do the usual register dumping for SPIA on ICH7 and VIA, but
we dont print the equivalent FADDR in the ICH9 branch. patch appended.
> Anyway, this is
> Acked-by: Carl-Daniel Hailfinger <[e-mail]>

thanks, r1362

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

[PATCH 4/8] ichspi.c: preserve reserved bits in address registers

[David Hendricks]

On Thu, Jun 30, 2011 at 5:52 PM, Stefan Tauner <
[e-mail]> wrote:
> On Fri, 01 Jul 2011 01:21:33 +0200
> Carl-Daniel Hailfinger <[e-mail]> wrote:
> > Am 28.06.2011 05:33 schrieb Stefan Tauner:
> > > Signed-off-by: Stefan Tauner <[e-mail]>
> >
> > Makes sense, but I worry that this might eventually break something. Do
> > we (want to) report the inital address setting during programmer init,
> > especially the reserved bits?
>
> we do the usual register dumping for SPIA on ICH7 and VIA, but
> we dont print the equivalent FADDR in the ICH9 branch. patch appended.

Acked-by: David Hendricks <[e-mail]>

-- 
David Hendricks (dhendrix)
Systems Software Engineer, Google Inc.