Re: [flashrom] [PATCH 1/1] Fix programmer-centric probe (patch v2)

[Michael Karcher]

Am Donnerstag, den 22.12.2011, 08:15 +0100 schrieb Michael Karcher:
> Signed-off-by: Michael Karcher

self-review :)
> while( chipcount < ARRAY_SIZE(flashes) ) {

wrong spacing convention, as Stefan Tauner already pointed out in v1 of
the patch. Fixed locally to
                while (chipcount < ARRAY_SIZE(flashes)) {
> 	startchip = probe_flash(&registered_programmers[j],
> 				startchip, &flashes[i], 0);
> 				startchip, 
> 				&flashes[chipcount], 0);
> if (startchip == -1)
> 		break;
>                    	break;

spaces before tabs. The whitespace change of this line is unintentional.
Fixed locally. The end result is a small and clean patch, replacing only
the bad for loop and using chipcount instead of the local counter i as
index for flashes.

Regards,
  Michael Karcher

[PATCH 1/1] Fix programmer-centric probe (patch v2)

[Carl-Daniel Hailfinger]

Am 22.12.2011 08:28 schrieb Michael Karcher:
> Am Donnerstag, den 22.12.2011, 08:15 +0100 schrieb Michael Karcher:
> > Signed-off-by: Michael Karcher
> >            while (chipcount < ARRAY_SIZE(flashes)) {
> > startchip = probe_flash(&registered_programmers[j],
> > 				startchip, &flashes[i], 0);
> > 				startchip, 
> > 				&flashes[chipcount], 0);
> > if (startchip == -1)

Looks good. Thanks for fixing up after my megapatch.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH 1/1] Fix programmer-centric probe (patch v2)

[Michael Karcher]

Am Freitag, den 23.12.2011, 00:24 +0100 schrieb Carl-Daniel Hailfinger:
> Am 22.12.2011 08:28 schrieb Michael Karcher:
> > Am Donnerstag, den 22.12.2011, 08:15 +0100 schrieb Michael Karcher:
> > > Signed-off-by: Michael Karcher
> > >            while (chipcount < ARRAY_SIZE(flashes)) {
> > > startchip = probe_flash(&registered_programmers[j],
> > > 				startchip, &flashes[i], 0);
> > > 				startchip, 
> > > 				&flashes[chipcount], 0);
> > > if (startchip == -1)
>
> Looks good. Thanks for fixing up after my megapatch.
>
> Acked-by: Carl-Daniel Hailfinger

committed in r1479.
Thanks for the ack.

Regards,
  Michael Karcher