Re: [flashrom] [2/2] Add support for GD25D05B and GD25D10B

[sean boree]

Hello Hatim,

I have checked your patch; I only have one small remark (and I might be
very wrong on this, but I felt it best to discuss).

1 You use spi_prettyprint_status_register_bp2_srwd for both devices,
however this function also prints the bits 5, 6 (with
spi_prettyprint_status_register_bit). The datasheets of GD25D05B and
GD25D10B note that these bits are reserved. So I think either they should
not be used (thus different print function) or it should be noted somewhere
that these are reserved bits.

Acked-by: Sean Boree <[e-mail]>
> Hatim Kanchwala <[e-mail]> - 2016-03-16 15:39:23
> Signed-off-by: Hatim Kanchwala <[e-mail]>