Re: [flashrom] [2/2] Add support for GD25D05B and GD25D10B

March 30, 2016
7:53 p.m.
Hello Hatim, I have checked your patch; I only have one small remark (and I might be very wrong on this, but I felt it best to discuss). 1 You use spi_prettyprint_status_register_bp2_srwd for both devices, however this function also prints the bits 5, 6 (with spi_prettyprint_status_register_bit). The datasheets of GD25D05B and GD25D10B note that these bits are reserved. So I think either they should not be used (thus different print function) or it should be noted somewhere that these are reserved bits. Acked-by: Sean Boree <seanboree@gmail.com>
Hatim Kanchwala <hatim@hatimak.me> - 2016-03-16 15:39:23 Signed-off-by: Hatim Kanchwala <hatim@hatimak.me>
3396
Age (days ago)
3396
Last active (days ago)
0 comments
1 participants
participants (1)
-
sean boree