Re: [flashrom] [PATCH] Add selfcheck_board_enables().

[Carl-Daniel Hailfinger]

Am 31.05.2014 05:04 schrieb Stefan Tauner:
> Check for NULL termination of the array, that each board has the two
> main PCI ID sets defined, that coreboot vendor and model fields are either
> both set or unset, and that either an enable function or a max decode size is
> available.
>
> Signed-off-by: Stefan Tauner <[e-mail]>

Excellent, thank you! Please make sure to commit the additional #ifdef
fix you posted in a followup as well.

Acked-by: Carl-Daniel Hailfinger <[e-mail]>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/

[PATCH] Add selfcheck_board_enables().

[Stefan Tauner]

On Sun, 01 Jun 2014 00:10:34 +0200
Carl-Daniel Hailfinger <[e-mail]> wrote:
> Am 31.05.2014 05:04 schrieb Stefan Tauner:
> > Check for NULL termination of the array, that each board has the two
> > main PCI ID sets defined, that coreboot vendor and model fields are either
> > both set or unset, and that either an enable function or a max decode size is
> > available.
> >
> > Signed-off-by: Stefan Tauner <[e-mail]>
>
> Excellent, thank you! Please make sure to commit the additional #ifdef
> fix you posted in a followup as well.
>
> Acked-by: Carl-Daniel Hailfinger <[e-mail]>

Oops, missed that one. Committed in r1821, thanks.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner