Support for Dediprog SF100 / Multiple dediprogs

[Mike Hibbett]

Hi all,

I'm interested in the support for the Dediprog SF100. I've built flashrom with the DEDIPROG config enabled; there was a slight issue with the build, however on running it, flashrom recognises my device but fails to read it ( or, is very, very slow. )

Also, I would be interested in multiple simultaneous dediprog device support. I have access to several programmers and a variety of motherboards

Long term I will provide patches myself. Short term, I would be happy to provide test & debug support for anyone who is making changes in this area and does not have access to multiple programmers & device combinations.

Regards,

Mike.

[Stefan Tauner]

On Thu, 22 May 2014 07:52:55 +0000
Mike Hibbett  wrote:
> Hi all,
>
> I'm interested in the support for the Dediprog SF100. I've built flashrom with the DEDIPROG config enabled; there was a slight issue with the build, however on running it, flashrom recognises my device but fails to read it ( or, is very, very slow. )
>
> Also, I would be interested in multiple simultaneous dediprog device support. I have access to several programmers and a variety of motherboards
>
> Long term I will provide patches myself. Short term, I would be happy to provide test & debug support for anyone who is making changes in this area and does not have access to multiple programmers & device combinations.

Hello Mike,

reading the manpage would help with the multi-device problem: The
dediprog module supports that with a device parameter (in a rather
awkward but yet sufficient way).

What was your build issue?

[Mike Hibbett]

Hi Stefan,

I'm using gcc 4.8.2, the distribution compiler on my Ubuntu 14.04 64 bit box.

Make CONFIG_DEDIPROG=yes gives:

cc -MMD -Os -Wall -Wshadow -Werror   -D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID' -D'CONFIG_INTERNAL=1' -D'CONFIG_INTERNAL_DMI=1' -D'CONFIG_SERPROG=1' -D'CONFIG_RAYER_SPI=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1' -D'CONFIG_NIC3COM=1' -D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1' -D'CONFIG_DRKAISER=1' -D'CONFIG_NICREALTEK=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1' -D'CONFIG_OGP_SPI=1' -D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_SATAMV=1' -D'CONFIG_LINUX_SPI=1' -D'NEED_PCI=1' -D'NEED_USB=1' -D'HAVE_UTSNAME=1' -D'FLASHROM_VERSION="0.9.7-r1791"' -o dediprog.o -c dediprog.c
dediprog.c:761:2: error: initialization from incompatible pointer type [-Werror]
  .write_aai = dediprog_spi_write_aai,
  ^
dediprog.c:761:2: error: (near initialization for ‘spi_programmer_dediprog.write_aai’) [-Werror]
cc1: all warnings being treated as errors

fixed with this quick hack:

diff dediprog.c dedipro.c~

< static int dediprog_spi_write_aai(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len)
---
> static int dediprog_spi_write_aai(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len)

< 	return dediprog_spi_write(flash, (uint8_t *)buf, start, len, DEDI_SPI_CMD_AAIWRITE);
---
> return dediprog_spi_write(flash, buf, start, len, DEDI_SPI_CMD_AAIWRITE);

Regards,

Mike.

-----Original Message-----
From: Stefan Tauner [mailto:[e-mail]] 
Sent: 22 May 2014 22:45
To: Mike Hibbett
Cc: [e-mail]
Subject: Re: [flashrom] Support for Dediprog SF100 / Multiple dediprogs

On Thu, 22 May 2014 07:52:55 +0000
Mike Hibbett  wrote:
> Hi all,
>
> I'm interested in the support for the Dediprog SF100. I've built 
> flashrom with the DEDIPROG config enabled; there was a slight issue 
> with the build, however on running it, flashrom recognises my device 
> but fails to read it ( or, is very, very slow. )
>
> Also, I would be interested in multiple simultaneous dediprog device 
> support. I have access to several programmers and a variety of 
> motherboards
>
> Long term I will provide patches myself. Short term, I would be happy to provide test & debug support for anyone who is making changes in this area and does not have access to multiple programmers & device combinations.

Hello Mike,

reading the manpage would help with the multi-device problem: The dediprog module supports that with a device parameter (in a rather awkward but yet sufficient way).

What was your build issue?

[Stefan Tauner]

On Fri, 23 May 2014 10:03:53 +0000
Mike Hibbett  wrote:
> Hi Stefan,
>
> I'm using gcc 4.8.2, the distribution compiler on my Ubuntu 14.04 64 bit box.
>
> Make CONFIG_DEDIPROG=yes gives:
>
> cc -MMD -Os -Wall -Wshadow -Werror   -D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID' -D'CONFIG_INTERNAL=1' -D'CONFIG_INTERNAL_DMI=1' -D'CONFIG_SERPROG=1' -D'CONFIG_RAYER_SPI=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1' -D'CONFIG_NIC3COM=1' -D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1' -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1' -D'CONFIG_DRKAISER=1' -D'CONFIG_NICREALTEK=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1' -D'CONFIG_OGP_SPI=1' -D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_SATAMV=1' -D'CONFIG_LINUX_SPI=1' -D'NEED_PCI=1' -D'NEED_USB=1' -D'HAVE_UTSNAME=1' -D'FLASHROM_VERSION="0.9.7-r1791"' -o dediprog.o -c dediprog.c
> dediprog.c:761:2: error: initialization from incompatible pointer type [-Werror]
>   .write_aai = dediprog_spi_write_aai,
>   ^
> dediprog.c:761:2: error: (near initialization for ‘spi_programmer_dediprog.write_aai’) [-Werror]
> cc1: all warnings being treated as errors

Thanks. That was a mistake I made in r1789 and should be fixed in r1797.