Re: [flashrom] [PATCH 5/8] add support for 8086:1076 (82541GI) to nicintel_spi.c

[Carl-Daniel Hailfinger]

Am 15.03.2011 16:29 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner
>
> nicintel_spi.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/nicintel_spi.c b/nicintel_spi.c
> index 3882e81..5a6e04d 100644
> --- a/nicintel_spi.c
> +++ b/nicintel_spi.c
> @@ -64,6 +64,7 @@ const struct pcidev_status nics_intel_spi[] = {
>    {PCI_VENDOR_ID_INTEL, 0x105e, OK, "Intel", "82571EB Gigabit Ethernet Controller"},
>    {PCI_VENDOR_ID_INTEL, 0x107c, OK, "Intel", "82541PI Gigabit Ethernet Controller"},
>    {PCI_VENDOR_ID_INTEL, 0x10b9, OK, "Intel", "82572EI Gigabit Ethernet Controller"},
> {PCI_VENDOR_ID_INTEL, 0x1076, OK, "Intel", "82541GI Gigabit Ethernet Controller"},

Should we sort by name or by PCI ID? I think we sort by PCI ID 
everywhere else.
> {},
>   };

Looks good otherwise.

Regards,
Carl-Daniel

[PATCH 5/8] add support for 8086:1076 (82541GI) to nicintel_spi.c

[Stefan Tauner]

On Thu, 31 Mar 2011 08:43:13 +0200
Carl-Daniel Hailfinger  wrote:
> Should we sort by name or by PCI ID? I think we sort by PCI ID 
> everywhere else.

does not really matter in this case anyway ;)

[PATCH] add support for 8086:1076 (82541GI) to nicintel_spi.c

[Stefan Tauner]

Signed-off-by: Stefan Tauner 
---
 nicintel_spi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/nicintel_spi.c b/nicintel_spi.c
index 3882e81..7748e8c 100644
--- a/nicintel_spi.c
+++ b/nicintel_spi.c
@@ -62,6 +62,7 @@ uint8_t *nicintel_spibar;

const struct pcidev_status nics_intel_spi[] = {
    {PCI_VENDOR_ID_INTEL, 0x105e, OK, "Intel", "82571EB Gigabit Ethernet Controller"},
+	{PCI_VENDOR_ID_INTEL, 0x1076, OK, "Intel", "82541GI Gigabit Ethernet Controller"},
    {PCI_VENDOR_ID_INTEL, 0x107c, OK, "Intel", "82541PI Gigabit Ethernet Controller"},
    {PCI_VENDOR_ID_INTEL, 0x10b9, OK, "Intel", "82572EI Gigabit Ethernet Controller"},