Re: [flashrom] Add timeout check to SPI bitbang bus request

[GatoLoko]

-------- Mensaje original --------
Asunto: Re: [flashrom] Add timeout check to SPI bitbang bus request
Fecha: Tue, 11 Oct 2011 16:22:17 +0200
De: GatoLoko 
Para: Carl-Daniel Hailfinger

El 11/10/11 14:42, Carl-Daniel Hailfinger escribió:
> Here is an updated timeout patch (no functional changes for
> nicintel_spi). A year has passed, and I'm still trying to find someone
> who can test and ack it.
>
> GatoLoko: This new patch also addresses the SB600 timeout issue you were
> seeing.
>
> Signed-off-by: Carl-Daniel Hailfinger

Tested it, and seems to work, but the timeout feels a little too long.
It took half an hour to complete a pass where no chip was found.

The chip is a MX25L4005APC-12G.

There was a few "strange" messages, don't know if they are related. The
messages are:

"Not unmapping zero size at 0xffffffffffffffff"

and:

"""
Probing for ST M25P40-old, 512 kB: sb600_spi_send_command, cmd=9f,
writecnt=0, readcnt=3
Writing:
SB600 FIFO pointer is 0, wanted 0
Executing:
SB600: execute_command timeout!
sb600_spi_send_command, cmd=90, writecnt=3, readcnt=2
Writing: [00][00][00]
SB600 FIFO pointer corruption! Pointer is 0, wanted 3
Something else is accessing the flash chip and causes random corruption.
Please stop all applications and drivers and IPMI which access the flash
chip.
sb600_spi_send_command, cmd=ab, writecnt=3, readcnt=1
Writing: [00][00][00]
SB600 FIFO pointer corruption! Pointer is 0, wanted 3
Something else is accessing the flash chip and causes random corruption.
Please stop all applications and drivers and IPMI which access the flash
chip.
"""

Attached is a full pass log.