Re: [flashrom] Flashrom patch submission

[Stefan Tauner]

On Mon, 17 Jun 2013 16:02:09 +0000
Greg Schardt  wrote:
> I have modified flashrom_0.9.6.1 so that the layout file is used for reads, writes, and verifies, as well as ensuring that no other regions are touched during any operation, so that locked regions do not cause transaction errors. I would like to submit a patch, but do not know the procedure, or the preferred diff options for producing the patch. I do not plan to do any other development, so would prefer not having to learn a large procedure.

Hello Greg,

thanks for trying to contribute back! Are you aware of my layout
patches that do approximately the same thing? What did you do
differently?

In general the best way to do such things is to use a version control
system from beginning and do smaller commits on the go.
If you started with the sources extracted from the 0.9.6.1 release,
then the easiest way is probably to extract that a second time to
another directory and create a patch file that contains all differences
between the two trees.
There are many howtos on how to do this, e.g.
http://jungels.net/articles/diff-patch-ten-minutes.html

Then you need to legally sign-off the resulting patch (i.e. add a single
line to the mail when sending the patch), see
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
(and http://flashrom.org/Development_Guidelines)

Flashrom patch submission

[Greg Schardt]

Stefan,

My patch does include your patch for reads, but some modifications were required to apply it to version 0.9.6.1, and the patches for writes and verifies would have been difficult to merge with that version. I also had to modify any attempts to read the entire flash, since these cause transaction errors if there is a locked region. Do I need to submit this as a series of patches, applying yours, then applying my patch (to fix the problems associated with the versioning), or can I leave it as a single patch to 0.9.6.1?

So should I just send the patch to this email address once it is signed or does it get submitted elsewhere?

Thanks,
Greg

-----Original Message-----
From: Stefan Tauner [mailto:[e-mail]] 
Sent: Monday, June 17, 2013 1:12 PM
To: Greg Schardt
Cc: [e-mail]
Subject: Re: [flashrom] Flashrom patch submission

On Mon, 17 Jun 2013 16:02:09 +0000
Greg Schardt  wrote:
> I have modified flashrom_0.9.6.1 so that the layout file is used for reads, writes, and verifies, as well as ensuring that no other regions are touched during any operation, so that locked regions do not cause transaction errors. I would like to submit a patch, but do not know the procedure, or the preferred diff options for producing the patch. I do not plan to do any other development, so would prefer not having to learn a large procedure.

Hello Greg,

thanks for trying to contribute back! Are you aware of my layout patches that do approximately the same thing? What did you do differently?

In general the best way to do such things is to use a version control system from beginning and do smaller commits on the go.
If you started with the sources extracted from the 0.9.6.1 release, then the easiest way is probably to extract that a second time to another directory and create a patch file that contains all differences between the two trees.
There are many howtos on how to do this, e.g.
http://jungels.net/articles/diff-patch-ten-minutes.html

Then you need to legally sign-off the resulting patch (i.e. add a single line to the mail when sending the patch), see http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
(and http://flashrom.org/Development_Guidelines)