Thanks to The Raven and Stefan Tauner for bug report. I fix patch for correct write buffer calculation. Correct version of patch is attached.
On Tue, 13 May 2014 12:51:18 +0400 Shire degener_trash@mail.ru wrote:
Thanks to The Raven and Stefan Tauner for bug report. I fix patch for correct write buffer calculation. Correct version of patch is attached.
Yes, that one looks correct. I came to the same conclusion like you: 1) the loop condition is wrong and 2) the offset used within the read buffer should start at 0 and not at the chip offset. I really wonder how this could have ever worked in my tests :)
My patch to solve the issue is a bit different though and I think it is slightly better readable. I'd be glad if you could test/review it.
Yes, Stefan, I agree with you.
Fri, 16 May 2014 14:23:43 +0200 от Stefan Tauner stefan.tauner@alumni.tuwien.ac.at:
My patch to solve the issue is a bit different though and I think it is slightly better readable. I'd be glad if you could test/review it.
On Fri, 16 May 2014 18:08:49 +0400 Shire degener_trash@mail.ru wrote:
Yes, Stefan, I agree with you.
Great, and with Raven's testing on his AT45DB021D and mine with AT45DB041D, I think we can safely assume we have fixed it now, thanks guys. I have committed the proposed change in r1792.
Hm, very strange. I have tested again with the AT45DB021D and unbelievable -> it works now!?! Absolutely no clue why, but it works. Tested it many times (read, write and erase) and compare the files. All ok.
The bad thing is i have deleted the original random-data file. Can you please send it to me by mail so i can retest with this?
THX
-
Shire -
Stefan Tauner -
The Raven