Re: [flashrom] [PATCH 6/8] ichspi: add prettyprinting for PR registers

[Stefan Tauner]

On Sat, 20 Aug 2011 12:39:46 +0200
Stefan Tauner <[e-mail]> wrote:
> +	if (rwperms != 0x3)
> +		msg_pdbg(")\n0x%08x-0x%08x is %s\n", (ICH_FREG_BASE(pr) << 12),
> +			 (ICH_FREG_LIMIT(pr) << 12) | 0x0fff,
> +			 access_names[rwperms]);

this is wrong. i have rebased these patches onto hwseq and forgot that
the FREG macros have changed (no more shifting needed). depending on
what gets acked when, i will fix this one way or another...

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

[PATCH 6/8] ichspi: add prettyprinting for PR registers

[Carl-Daniel Hailfinger]

Am 22.08.2011 11:12 schrieb Stefan Tauner:
> On Sat, 20 Aug 2011 12:39:46 +0200
> Stefan Tauner <[e-mail]> wrote:
> > +	if (rwperms != 0x3)
> > +		msg_pdbg(")\n0x%08x-0x%08x is %s\n", (ICH_FREG_BASE(pr) << 12),
> > +			 (ICH_FREG_LIMIT(pr) << 12) | 0x0fff,
> > +			 access_names[rwperms]);
> > this is wrong. i have rebased these patches onto hwseq and forgot that
> > the FREG macros have changed (no more shifting needed). depending on
> > what gets acked when, i will fix this one way or another...

I think the changed FREG macros are already merged, so please adjust the
code here.

Thanks.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/