Re: [flashrom] [PATCH 01/12] improve macros for SSFS and SSFC bits

[Carl-Daniel Hailfinger]

One additional comment...

Am 08.06.2011 04:55 schrieb Stefan Tauner:
> introduce offset macros and use them to (re)define the existing mask macros
> add comments
> rename SSFS_CDS to SSFS_FDONE (abbr. used in datasheet not in SSFS but HSFS)
> use those for refactoring and magic number elemination.
> following patch uses them for pretty printing
>
> --- a/ichspi.c
> +++ b/ichspi.c
> @@ -709,8 +721,8 @@ static int ich9_run_opcode(OPCODE op, uint32_t offset,
>    temp32 = REGREAD32(ICH9_REG_SSFS);
>    /* Keep reserved bits only */
>    temp32 &= SSFS_RESERVED_MASK | SSFC_RESERVED_MASK;
> /* clear error status registers */
> temp32 |= (SSFS_CDS + SSFS_FCERR);
> /* Clear cycle done and cycle error status registers */
> temp32 |= (SSFS_FDONE + SSFS_FCERR);

Please use | instead of + here.
> REGWRITE32(ICH9_REG_SSFS, temp32);
>
> /* Use 20 MHz */

Regards,
Carl-Daniel

[PATCH 01/12] improve macros for SSFS and SSFC bits

[Stefan Tauner]

On Thu, 09 Jun 2011 00:42:12 +0200
Carl-Daniel Hailfinger  wrote:
> One additional comment...
>
> Am 08.06.2011 04:55 schrieb Stefan Tauner:
> > /* clear error status registers */
> > temp32 |= (SSFS_CDS + SSFS_FCERR);
> > /* Clear cycle done and cycle error status registers */
> > temp32 |= (SSFS_FDONE + SSFS_FCERR);
>
> Please use | instead of + here.

hi

i have posted this patch set only because dhendrix tried to build the
previous one including the squash (11b) patch as mentioned in my 0/12
mail. i have not taken care of the comments you made to the 4.0 version
of the series (which included the above request already).
i am aware of that and will incorporate everything you said previously
of course before committing! some of those were already acked by
you... :)
jfyi

[PATCH 01/12] improve macros for SSFS and SSFC bits

[Stefan Tauner]

committed with addressed concerns and additional minor changes in r1328