Re: [flashrom] [PATCH] Speed up dediprog writes

[Steven A. Falco]

I have just tested the following patch:

http://patchwork.coreboot.org/patch/3469/

which I applied to flashrom r1472.

It is fantastic!

I can now program and verify a M25P16 in just 15 seconds.  Every
bit as fast as the Windows app.

One comment about the patch.  The first change (to lines 30,6)
should be removed, because it adds a duplicate copy of the
statement "static int dediprog_firmwareversion;"  Other than
that, the patch looks fine to me.

Here is the bit that should be removed from the patch:

@@ -30,6 +30,7 @@
 static usb_dev_handle *dediprog_handle;
 static int dediprog_firmwareversion;
 static int dediprog_endpoint;
+static int dediprog_firmwareversion;

#if 0
 /* Might be useful for other pieces of code as well. */

Therefore:

Acked-by: Steven A. Falco

[PATCH] Speed up dediprog writes

[Carl-Daniel Hailfinger]

Hi Steven,

thanks for your tests and the enthusiastic response!

Am 13.12.2011 02:51 schrieb Steven A. Falco:
> I have just tested the following patch:
>
> http://patchwork.coreboot.org/patch/3469/
>
> which I applied to flashrom r1472.
>
> It is fantastic!
>
> I can now program and verify a M25P16 in just 15 seconds.  Every
> bit as fast as the Windows app.
>
> Therefore:
>
> Acked-by: Steven A. Falco

Thanks, committed in r1477.

Note: This also includes
[PATCH] Implement unknown Dediprog commands
which was
Acked-by: Uwe Hermann

Regards,
Carl-Daniel