[commit] r1332 - trunk

[repository service]

Author: stefanct
Date: Sat Jun 11 20:16:50 2011
New Revision: 1332
URL: http://flashrom.org/trac/flashrom/changeset/1332

Log:
enable_flash_ich: warn if SMM BIOS Write Protection is detected in BIOS_CNTL

Signed-off-by: Stefan Tauner <[e-mail]>
Acked-by: Carl-Daniel Hailfinger <[e-mail]>

Modified:
   trunk/chipset_enable.c

Modified: trunk/chipset_enable.c
==============================================================================
--- trunk/chipset_enable.c	Sat Jun 11 14:21:37 2011	(r1331)
+++ trunk/chipset_enable.c	Sat Jun 11 20:16:50 2011	(r1332)
@@ -264,8 +264,17 @@
 		     (old & (1 << 0)) ? "en" : "dis");
 	msg_pdbg("BIOS_CNTL is 0x%x\n", old);
 
-	new = old | 1;
+	/*
+	 * Quote from the 6 Series datasheet (Document Number: 324645-004):
+	 * "Bit 5: SMM BIOS Write Protect Disable (SMM_BWP)
+	 * 1 = BIOS region SMM protection is enabled.
+	 * The BIOS Region is not writable unless all processors are in SMM."
+	 * In earlier chipsets this bit is reserved. */
+	if (old & (1 << 5)) {
+		msg_pinfo("WARNING: BIOS region SMM protection is enabled!\n");
+	}
 
+	new = old | 1;
 	if (new == old)
 		return 0;