We just got a flashrom’s own MAINTAINERS file! I wanted to share the news with everyone. https://github.com/flashrom/flashrom/blob/master/MAINTAINERS
There is a script which will automatically add people as reviewers to the patch, if the patch is touching the files/area they are “registered” for. This makes sure patches are not lost and also answers the question “who are the best reviewers for this patch?” Anyone else can join any code review (as usual, as it was before), but the people from the file will be added automatically.
Is anyone interested in being a maintainer/reviewer? Maybe you know some specific area well, and/or maybe you don’t want to miss when a patch comes along and touches that area. “Area” can be just one programmer that you know well, and you can take it with “Odd Fixes” status - this is the smallest possible commitment, but still will be very useful for flashrom.
Any area can have multiple maintainers.
Also, MAINTAINERS file have some content already, but you can of course join the existing category if you are interested.
What to do if you are interested? You can reply to this thread or just send a patch.
I have some thoughts on what categories/areas we can have, but that’s my initial suggestion, it is not a complete list and everyone’s ideas are welcome.
In general, one programmer can be a category by itself. Some others can be grouped (for example we have an i2c group with 3 items).
# Libflashrom (can be sub-category of Core)
Doxyfile README flashrom.8.tmpl
Flashrom.c Layout.c Jedec.c Opaque.c Spi.c Programmer.c Programmer_table.c Spi25.c Spi25_statusreg.c Spi95.c … and more files here, and headers
List of files here, also headers
# Git (can be sub-category of Configs)
*.sh util/*.nix util/*.sh
Manibuilder Flashrom_tester ubertest
flashchips.c One file, but it has a constant stream of patches. Would be great to have someone keeping an eye on it.