Re: [flashrom] [PATCH 0/3] Some serprog improvements

[Urja Rannikko]

On Sun, Jun 28, 2015 at 4:56 AM, Stefan Tauner
 wrote:
> I plan to include them (and probably some of Urja's patches too) in
> flashrom 0.9.8.1.
>
> Stefan Tauner (3):
>   serprog: clear NDELAY flag only once after opening the port.
>   serprog: ignore failures when setting serial port options.
>   serprog: allow to omit specifying a baud rate.
>
> flashrom.8.tmpl | 26 ++++++++++++-----------
>  programmer.h    |  4 +---
>  serial.c        | 66 ++++++++++++++++++++++++++++++++++++++++-----------------
>  serprog.c       | 44 ++++++++++++++++++++------------------
>  4 files changed, 84 insertions(+), 56 deletions(-)

These all 3 tested as a series on two of my serprog flashers, one with
an FT232RL (arduino LPC+SPI shield) and one with a virtual serial
port, a Teensy 3.1 LPC+SPI (and on two PCs just to check that my i586
works too.). Did try out the ability to leave out the baudrate of both
of those (one run to set the rate is needed on the "real serial port"
== FT232RL).

Also reviewed the code, no comments from me.

Acked-by: Urja Rannikko