[PATCH] Use of CFLAGS and CPPFLAGS

[Stefan Reinauer]

See patch

[Sean Nelson]

Acked-by: Sean Nelson

I had to do a google search on why we should be using CPPFLAGS instead 
of CFLAGS and found this:
http://www.gnu.org/software/hello/manual/autoconf/Preset-Output-Variables.ht...

[Stefan Reinauer]

On 1/21/10 7:12 PM, Sean Nelson wrote:
> Acked-by: Sean Nelson
>
> I had to do a google search on why we should be using CPPFLAGS instead
> of CFLAGS and found this:
> http://www.gnu.org/software/hello/manual/autoconf/Preset-Output-Variables.ht...

Oh, sorry for the missing explanation... in my case the reason was the
following:
For the OSX packages I build of pciutils and flashrom, I add "-arch i386
-arch x86_64" to the CFLAGS on the make command line in order to create
bi-arch binaries.
However, this does not work when creating dependency files, so the build
process failed very early. The patch separates compiler flags that
influence the preprocessor and those that influence code generation and
changes the compiler calls to combine the two accordingly where needed.
With the patch, flashrom will also recognize and enable libftdi and
libusb on OSX.

Stefan

[Stefan Reinauer]

On 1/21/10 7:12 PM, Sean Nelson wrote:
> Acked-by: Sean Nelson

Thanks, r878

[Carl-Daniel Hailfinger]

On 21.01.2010 18:21, Stefan Reinauer wrote:
> This patch fixes the use of CFLAGS and CPPFLAGS in the flashrom makefile
>
> Signed-off-by: Stefan Reinauer
> Index: Makefile
>
> --- Makefile	(revision 877)
> +++ Makefile	(working copy)
> @@ -221,7 +221,7 @@
>    rm -f .dependencies .features .libdeps
>
> dep:
> @$(CC) $(CPPFLAGS) $(SVNDEF) -MM *.c > .dependencies
> $(CC) $(CPPFLAGS) $(SVNDEF) -MM *.c > .dependencies
>
> strip: $(PROGRAM)
>    $(STRIP) $(STRIP_ARGS) $(PROGRAM)

Was that chunk intentional?

Regards,
Carl-Daniel

[Stefan Reinauer]

On 1/22/10 3:49 AM, Carl-Daniel Hailfinger wrote:
> On 21.01.2010 18:21, Stefan Reinauer wrote:
> > This patch fixes the use of CFLAGS and CPPFLAGS in the flashrom makefile
> >
> > Signed-off-by: Stefan Reinauer
> > Index: Makefile
> >
> > --- Makefile	(revision 877)
> > +++ Makefile	(working copy)
> > @@ -221,7 +221,7 @@
> >    rm -f .dependencies .features .libdeps
> >
> > dep:
> > @$(CC) $(CPPFLAGS) $(SVNDEF) -MM *.c > .dependencies
> > $(CC) $(CPPFLAGS) $(SVNDEF) -MM *.c > .dependencies
> >
> > strip: $(PROGRAM)
> >    $(STRIP) $(STRIP_ARGS) $(PROGRAM)
>
> Was that chunk intentional?

No. Sorry for that. r880