Re: [flashrom] [PATCH 2/5] Add deferred -i processing

[Carl-Daniel Hailfinger]

Hi Stefan,

minor commit log nitpicks only.

As first line of the changelog, use this instead for better
searchability of the changelog:
Add deferred --image processing

Am 24.12.2011 01:35 schrieb Stefan Tauner:
> The general idea and most of the code is stolen from chromiumos:

The general idea and most of the code are based on the following
commits in the chromiumos flashrom tree:
> 8fc0740356ca15d02fb1c65ab43b10844f148c3b
> bb9049c66ca55e0dc621dd2c70b5d2cb6e5179bf
> Signed-off-by: Louis Yung-Chieh Lo
>
> and the main part:
> d0ea9ed71e7f86bb8e8db2ca7c32a96de25343d8
> Signed-off-by: David Hendricks
>
> My implementation does not defer the processing until doit(), but after the

s/My/This/
> argument parsing loop only (doit() should not contain argument checks).
>
> This allows to specify -i and -l parameters in any order.
>
> Signed-off-by: Stefan Tauner 
> Acked-by: David Hendricks

You already have an ack, go ahead.

Regards,
Carl-Daniel

[PATCH 2/5] Add deferred -i processing

[Stefan Tauner]

On Sun, 25 Dec 2011 01:17:24 +0100
Carl-Daniel Hailfinger  wrote:
> Hi Stefan,
>
> minor commit log nitpicks only.
>
> As first line of the changelog, use this instead for better
> searchability of the changelog:
> Add deferred --image processing
>
> Am 24.12.2011 01:35 schrieb Stefan Tauner:
> > The general idea and most of the code is stolen from chromiumos:
>
> The general idea and most of the code are based on the following
> commits in the chromiumos flashrom tree:
> > 8fc0740356ca15d02fb1c65ab43b10844f148c3b
> > bb9049c66ca55e0dc621dd2c70b5d2cb6e5179bf
> > Signed-off-by: Louis Yung-Chieh Lo
> >
> > and the main part:
> > d0ea9ed71e7f86bb8e8db2ca7c32a96de25343d8
> > Signed-off-by: David Hendricks
> >
> > My implementation does not defer the processing until doit(), but after the
>
> s/My/This/

just out of interest: why? this was added to emphasize the difference
to chromiumos.
> > argument parsing loop only (doit() should not contain argument checks).
> >
> > This allows to specify -i and -l parameters in any order.
> >
> > Signed-off-by: Stefan Tauner 
> > Acked-by: David Hendricks
>
> You already have an ack, go ahead.

thanks, committed in r1482

[PATCH 2/5] Add deferred -i processing

[Carl-Daniel Hailfinger]

Am 25.12.2011 10:14 schrieb Stefan Tauner:
> On Sun, 25 Dec 2011 01:17:24 +0100 Carl-Daniel Hailfinger wrote:
> > minor commit log nitpicks only.
> > > My implementation does not defer the processing until doit(),
> >
> > s/My/This/
>
> just out of interest: why? this was added to emphasize the difference
> to chromiumos.

Ah, I didn't notice that. Makes sense. I just thought "this" was enough
of a differentiator, but you're right that "my" has a stronger emphasis.

Regards,
Carl-Daniel