On Thu, Feb 04, 2010 at 03:30:13AM +0100, Stefan Reinauer wrote:
On 2/4/10 3:07 AM, Carl-Daniel Hailfinger wrote:
On 04.02.2010 01:51, Stefan Reinauer wrote:
- get Kontron 986LCD-M recognized by ID detection again. This was apparently broken in r796
Just a short question: The Kontron 986LCD-M appeared to be running coreboot. Is that correct? Quoting from the failure log you sent earlier:
No. The run that requires the IDs are with vendor BIOS. coreboot can detect the board through coreboot table.
The subsystem IDs are only required when running flashrom on a not yet migrated board.
I tried not changing the subsystem IDs and simply adding a DMI match string, but that won't work because the DMI matching code is never executed because the subsystem vendor ID matching code already decided it's not a kontron board
If DMI can be used successfully (could be that kontron also buggered that up), then the combination of subsystem ids and dmi will make a unique match.
As things are, it will not be unique. Add DMI, and it will be unique.
How did you handle this board in the past? It always used to be a -m board as far as i can tell:
/* Note: There are >= 2 version of the Kontron 986LCD-M/mITX! */ - {0x8086, 0x27b8, 0, 0, 0, 0, 0, 0, "kontron", "986lcd-m", "Kontron", "986LCD-M", board_kontron_986lcd_m}, - {0x10ec, 0x8168, 0x10ec, 0x8168, 0x104c, 0x8023, 0x104c, 0x8019, "kontron", "986lcd-m", "Kontron", "986LCD-M", board_kontron_986lcd_m}, + {0x8086, 0x27A0, 0, 0, 0x8086, 0x27b8, 0, 0, "kontron", "986lcd-m", "Kontron", "986LCD-M", board_kontron_986lcd_m},
Luc Verhaegen.