Re: [flashrom] [PATCH] Add Spi interface support for Tunnel Creek chipset (3)

[Feldschmid, Ingo]

Hi,

Actually, I have taken the Poulsbo function as source for the tunnel creek support function. AFAIK, disabling the prefetch mechanism should make sure we always get the correct values when reading status registers or flash data for verify.

If that's any help, I have taken our board and tested flashrom with and without clearing prefetch, and both versions seem to work.

Best regards,
Ingo

Es gelten unsere Allgemeinen Leistungsbedingungen die 
unter http://www.msc-ge.com/alb abrufbar sind.

Our standard terms and conditions apply which are 
available under http://www.msc-ge.com/alb .

MSC Vertriebs GmbH

Sitz der Gesellschaft:	Industriestrasse 16, 76297 Stutensee 
Handelsregister: 	Mannheim, HRB Nr. 10 3631
Geschäftsführung: 	Lothar Kümmerlin, Rüdiger Kuhn, Silvano Geissler, Johannes Alberti
Umsatzsteuer ID Nr.: 	DE 143 585 507
WEEE Reg. Nr. :		DE 31011852

Gleichmann & Co. Electronics GmbH

Sitz der Gesellschaft:	Schraderstrasse 44, 67227 Frankenthal 
Handelsregister:	Ludwigshafen, HRB Nr. 21305
Geschäftsführung:	Lothar Kümmerlin, Johannes Alberti, Klaus Hagenacker
Umsatzsteuer ID Nr. :	DE 148 421 329            
WEEE Reg. Nr.:		DE 72277043

Diese E-Mail enthält vertrauliche und/ oder rechtlich geschützte Informationen. 
Wenn Sie nicht der beabsichtigte Empfänger sind, informieren Sie bitte sofort den
Absender und löschen Sie diese E-Mail.

The information contained in this message is confidential and/ or protected by law. 
If you are not the intended recipient, please contact the sender and delete this message.

-----Ursprüngliche Nachricht-----
Von: Stefan Tauner [mailto:[e-mail]] 
Gesendet: Freitag, 24. August 2012 03:54
An: Feldschmid, Ingo
Cc: [e-mail]
Betreff: Re: [flashrom] [PATCH] Add Spi interface support for Tunnel Creek chipset (3)

hello ingo,

i am trying to refactor your patch and merge it with the poulsbo enable (something i wanted to do before merging your patch, but uwe was faster with committing back then...).

i noticed that you try to disable the prefetching and i wonder why. did you have any problems with it? we dont do this for any other intel chipset afaics and i would rather leave it alone/use it.

On Mon, 5 Sep 2011 09:58:14 +0200
"Feldschmid, Ingo"  wrote:
> /* Make sure BIOS prefetch mechanism is disabled */
> old = pci_read_byte(dev, 0xd9);
> msg_pdbg("BIOS Prefetch Enable: %sabled, ", (old & 1) ? "en" : "dis");
> new = old & ~1;
> if (new != old)
> rpci_write_byte(dev, 0xd9, new);