Re: [flashrom] [PATCH] Enable spi clock setting in dediprog driver

[Carl-Daniel Hailfinger]

Am 20.02.2013 10:23 schrieb Nico Huber:
> > Am 16.11.2012 11:23 schrieb Nico Huber:
> > > This adds a programmer parameter 'spispeed' to the dediprog driver to
> > > control the transfer rate on the spi bus. The following rates are
> > > available (in Hz):
> > >   375k, 750k, 1.5M, 2.18M, 3M, 8M, 12M and 24M
> > >
> > > The original driver reinitializes the programmer after setting the
> > > speed, so the initialization calls have moved into a new function
> > > dediprog_setup() which is called twice.
> > >
> > > Signed-off-by: Nico Huber
> >
> > No error handling for invalid strings, memory leak of spispeed.
> > I have fixed the issues. See below for the updated patch.
>
> Looks like I fixed the leak earlier, but didn't submit. Sorry.
> > If the updated patch is OK with you, I'll ack and commit.
>
> Looks good to me.

Acked-by: Carl-Daniel Hailfinger 
and committed in r1649.

Regards,
Carl-Daniel