Am Freitag, den 16.12.2011, 14:41 +0100 schrieb Carl-Daniel Hailfinger:
No functional changes. Please test anyway on real hardware.
flashrom -r works on my laptop (ICH7, SPI)
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
One remark: You might consider to split chip_{read,write}{b,l,w} into chip_data_{read,write}{b,l,w} and chip_reg_{read,write}{b,l,w} and implicitly add "virtual_memory" or "virtual_registers" to the address space offset passed to the new functions (for the case of registers and data mapped into the same address space, so one chip_read/write family is usefull at all).
The upside of the proposal is that we get rid of all the "flash->virtual_memory + " additions scattered over all chip driver, the downside is yet another layer of indirection.
Please do not merge such a change into this patch, but do that as follow-up patch.
Thank you for all this tedious mechanical work on the patch, Michael Karcher