Re: [flashrom] [PATCH] Add a board-enable for the ASRock K7S41, chipset-enable for SiS 741

[Joshua Roys]

On 09/11/2010 12:09 PM, Uwe Hermann wrote:
> See patch.
>
> I literally guessed this board-enable and was lucky at the very first try :)
>
> Not sure if DMI matching is required (I guess it is), please let me know
> if I should change that.
>
> lspci/superiotool/flashrom -w are attached.
>
> Uwe.

Two things,

This one will conflict with:
http://patchwork.coreboot.org/patch/1927/

Other than that, if you're going to do DMI (which isn't strictly needed
right now- I don't see anything in board_enable.c we could conflict
with, but who knows in the future) I would just match on the SMBus even
though it doesn't have subsystem IDs.  That may be a personal preference
though, so feel free to disagree.

Josh