Acked-by: Anders Juel Jensen andersjjensen@gmail.com
-- I only have one thing on it, and that is just me being totally anal about it. I think it should be:
#define FEATURE_LONG_RESET (0 << 4) #define FEATURE_SHORT_RESET (1 << 4) #define FEATURE_EITHER_RESET FEATURE_LONG_RESET
As that is what the code really does... but yes, totally cosmetic/pedantic. Maybe i am tired..
/Anders
On Friday 29 January 2010 00:24:45 Sean Nelson wrote:
Complete the addition of Feature Bits for all Jedec based chips. Add FEATURE_SHORT_RESET, FEATURE_LONG_RESET, and FEATURE_EITHER_RESET rewrite jedec functions to use getaddrmask
convert write_49f002 to write_jedec_1 convert write_w39v040c to write_jedec_1 convert probe_w39v040c to probe_jedec convert write_49lf040 to write_jedec_1 convert write_pm29f002 to write_jedec convert write_29f040b to write_jedec_1 convert probe_29f040b to probe_jedec convert erase_chip_29f040b to erase_chip_block_jedec convert erase_sector_29f040b to erase_sector_jedec convert write_m29f002b to write_jedec convert write_m29f002t to write_jedec convert *_29f002 to *_jedec
decouple unused files from Makefile: am29f040b.c en29f002a.c m29f002.c mx29f002.c pm29f002.c sst49lf040.c w39v040c.c w49f002u.c
Signed-off-by: Sean Nelson audiohacked@gmail.com
Final version of patch
Thanks to Carl-Daniel for: For all stuff outside flashchips.c (I assume you tested compilation): Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks to Anders Juel Jensen for double-checking the flashchips.c (waiting for his Ack, before commit).