Re: [flashrom] [PATCH] Full VIA SPI support

[Rudolf Marek]

> > case SPI_CONTROLLER_VIA:
> > ichspi_bbar = mmio_readl(ich_spibar + 0x50)& ~BBAR_MASK;

Because of the mask ;) Maybe there is missing a space.
> > if (ichspi_bbar)
> > msg_pdbg("Reserved bits in BBAR not zero: 0x%04x",
> > ichspi_bbar);
> > ichspi_bbar |= minaddr;
>
> Why or?
> > mmio_writel(ichspi_bbar, ich_spibar + 0x50);
> >
> > ichspi_bbar = mmio_readl(ich_spibar + 0x50);
> > /* We don't have any option except complaining. */
> > if (ichspi_bbar != minaddr)
> > msg_perr("Setting BBAR failed!\n");
> > break;
> > case SPI_CONTROLLER_ICH9:
> > mmio_writel(minaddr, ich_spibar + 0xA0);
> > ichspi_bbar = mmio_readl(ich_spibar + 0xA0)& ~BBAR_MASK;

and here too.

Acked-by: Rudolf Marek

Thanks,
Rudolf