Re: [flashrom] [PATCH] Override incompatible CONFIG_FOO for DOS

[Carl-Daniel Hailfinger]

On 14.06.2010 17:38, Idwer Vollering wrote:
> 2010/6/14 Carl-Daniel Hailfinger
> > On 12.06.2010 22:35, Carl-Daniel Hailfinger wrote:
> > > On 05.06.2010 00:06, Carl-Daniel Hailfinger wrote:
> > > > Override incompatible CONFIG_FOO settings for DOS. This allows you to
> > > > specify CONFIG_FOO=yes for all drivers and still get only those which
> > > > compile under DOS.
> > >
> > > Silently disabling explicitly requested features is a really bad idea.
> > > This new patch instead warns the user if any impossible (i.e. not
> > > compilable on this platform) features were specified. Such a warning
> > > will look like this:
> > >
> > > The following features are unavailable on your machine:
> >
> > CONFIG_NIC3COM=yes
> > > If a user does not explicitly request an impossible feature, such a
> > > feature will be automatically disabled, so just typing "make" will get
> > > you the common subset of default and possible features.
> >
> > Fixed a few minor bugs. Should be ready for merge.
>
> I'm not sure about that, it breaks djgpp-dos' compilation:
>
> $ make distclean CONFIG_SERPROG=yes djgpp-dos
> rm -f flashrom flashrom.exe *.o *.d
> rm -f .features .libdeps
> make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip WARNERROR=no
> OS_ARCH=DOS
> make[1]: Entering directory
> `/home/idwer/coreboot/svn/flashrom/trunk-r1047-patchwork-1509'
> The following features are unavailable on your machine: CONFIG_SERPROG=yes

This is a desired effect of my patch, and we want that because serprog
does not work on DOS (yet).
> make[1]: *** [featuresavailable] Error 1
> make[1]: Leaving directory
> `/home/idwer/coreboot/svn/flashrom/trunk-r1047-patchwork-1509'
> make: *** [djgpp-dos] Error 2
>
> $ make distclean djgpp-dos
> rm -f flashrom flashrom.exe *.o *.d
> rm -f .features .libdeps
> make CC=i586-pc-msdosdjgpp-gcc STRIP=i586-pc-msdosdjgpp-strip WARNERROR=no
> OS_ARCH=DOS
> make[1]: Entering directory
> `/home/idwer/coreboot/svn/flashrom/trunk-r1047-patchwork-1509'
> Checking for a C compiler... found.
> Checking for libpci headers... found.
> Checking if libpci is present and sufficient... no.
> Checking if libz+libpci are present and sufficient...no.

And this is a bug. Can you reproduce this bug with a clean (no local
patches) tree with latest svn HEAD?
> Please install libpci (package pciutils) and/or libz.
> See README for more information.
>
> make[1]: *** [pciutils] Error 1
> make[1]: Leaving directory
> `/home/idwer/coreboot/svn/flashrom/trunk-r1047-patchwork-1509'
> make: *** [djgpp-dos] Error 2

Thanks for testing this.

Regards,
Carl-Daniel