Hi Felix,
Op donderdag 10 november 2022 om 18:35:39 +00:00:00 schreef Felix Singer felixsinger@posteo.net:
Hi Stijn,
On Thu, 2022-11-10 at 19:03 +0100, Stijn Segers wrote:
Patch is sitting in Gerrit since November 5th 😊.
I just did a quick review. Meanwhile we changed some function pointers to enums and this needs to be fixed in your patch.
I was able to cobble this patch together because another chip from the same family was already supported (my C is extremely basic). I ran a compile again on recent master and it looks like most of the 'commands' in the code block were uppercased (which I suppose is the enum part). Looks good now, no compilation errors anymore.
The commit message also needs some polishing. Otherwise looks pretty good.
Could you tell me what I'd need to change?
Thanks for your contribution!
Thank you for your review.
// Felix