Re: [flashrom] [PATCH] Add support for libpci older than 2.2

[Michael Karcher]

Am Samstag, den 17.07.2010, 16:47 +0200 schrieb Carl-Daniel Hailfinger:
> +#if PCI_LIB_VERSION >= 0x020200
>    	dev = pci_get_dev(pacc, dev->domain, dev->bus, dev->dev, 1);
> +#else
> /* libpci before 2.2 */
> msg_pinfo("Your pciutils/libpci version is too old to support "
> 	  "PCI domains. Continuing anyway.\n");

If a system needs PCI domain support, you can be pretty sure that a
newer libpci is installed, because even lspci would not work correctly
as far as I can tell. So I think anyone still having libpci < 2.2 never
heard of PCI domains and so we don't need to confuse the user with a
message containing a technical term he is not going to understand. Kill
this message. You can make it a comment - the source code reader might
wonder why it works without the parameter.

Regards,
  Michael Karcher