Re: [flashrom] [PATCH] Change image building in layout code

[Carl-Daniel Hailfinger]

On 02.11.2010 02:03, David Hendricks wrote:
> On Thu, Oct 28, 2010 at 10:29 PM, Carl-Daniel Hailfinger wrote
> > Index: flashrom-layout_exclude_unspecified_regions/layout.c
> >
> > --- flashrom-layout_exclude_unspecified_regions/layout.c        (revision
> > 1217)
> > +++ flashrom-layout_exclude_unspecified_regions/layout.c        (working
> > copy)
> > @@ -205,33 +206,62 @@
> >        return -1;
> >  }
> >
> > -int handle_romentries(struct flashchip *flash, uint8_t *oldcontents,
> > uint8_t *newcontents)
> > +int find_next_included_romentry(unsigned int start)
> >  {
> >        int i;
> >   unsigned int best_start = INT_MAX;
>
> Minor nit: Should that be UINT_MAX? Alternatively, maybe ~0 would work
> without including limits.h.

Thanks, changed. The code originally started out with int instead of
unsigned int, and INT_MAX was a relic from back then.
> Looks good to me. I've also tested this successfully, so:
>
> Acked-by: David Hendricks

Thanks for the review, committed with the requested change in r1223.

Regards,
Carl-Daniel