Re: [flashrom] [PATCH] Use the register mapping feature bit

[Michael Karcher]

Am Donnerstag, den 07.01.2010, 19:31 +0100 schrieb Carl-Daniel
Hailfinger:
> Use the register mapping feature bit.
> All functions which just call probe_jedec and then map flash registers
> are replaced by probe_jedec. All functions which call probe_jedec, map
> flash registers and do something else can at least eliminate mapping
> flash registers.
> Fix logic inversion in probe_jedec to map flash registers on success
> instead of on failure.
> Change a few TIMING_IGNORED to TIMING_FIXME where probe_jedec is used.
>
> Total savings: One probe function simplified, three probe functions
> eliminated.
>
> Signed-off-by: Carl-Daniel Hailfinger

[...]
Acked-by: Michael Karcher
> Index: flashrom-registermap_featurebit/flashchips.c
>
> --- flashrom-registermap_featurebit/flashchips.c	(Revision 834)
> +++ flashrom-registermap_featurebit/flashchips.c	(Arbeitskopie)
> @@ -827,7 +827,7 @@
>    	.total_size	= 64,
>    	.page_size	= 128,
>    	.tested		= TEST_OK_PRW,
> .probe		= probe_jedec, 
> .probe		= probe_jedec,
> .probe_timing	= 10000, /* 10mS, Enter=Exec */
> .erase		= NULL,
> .block_erasers	=

Is this whitespace-only change (removes a trailing space that shouldn't
have been there from the beginning) intentional?

Regards,
  Michael Karcher