Re: [flashrom] [PATCH] Fix EN29F002(A)(N) eraseblock tables (B and T transposed)

[Sean Nelson]

On 2/5/10 3:47 PM, TJ wrote:
> Based on reading the datasheet the eraseblocks for B and T variations
> look to have been accidentally transposed.
> http://www.datasheetcatalog.org/datasheet/EonSiliconSolution/mXssvqt.pdf
>
> flashchips.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/flashchips.c b/flashchips.c
> index 2953dd6..b5be180 100644
> --- a/flashchips.c
> +++ b/flashchips.c
> @@ -2244,10 +2244,10 @@ struct flashchip flashchips[] = {
>    	{
>    		{
>    			.eraseblocks = {
> 			{64 * 1024, 3},
> 			{32 * 1024, 1},
> 			{8 * 1024, 2},
> 		{16 * 1024, 1},
> 			{8 * 1024, 2},
> 			{32 * 1024, 1},
> 			{64 * 1024, 3},
> 	},
> 	.block_erase = erase_sector_jedec,
> }, {
>
> @@ -2276,10 +2276,10 @@ struct flashchip flashchips[] = {
>    	{
>    		{
>    			.eraseblocks = {
> 			{16 * 1024, 1},
> 			{8 * 1024, 2},
> 			{32 * 1024, 1},
> 		{64 * 1024, 3},
> 			{32 * 1024, 1},
> 			{8 * 1024, 2},
> 			{16 * 1024, 1},
> 	},
> 	.block_erase = erase_sector_jedec,
> }, {

You forgot to add a signoff!