Re: [flashrom] [PATCH] Add IT8705 autodetection, Shuttle AK38N info

[Uwe Hermann]

On Fri, Jul 09, 2010 at 06:39:40PM +0200, Carl-Daniel Hailfinger wrote:
> Autodetect the ITE IT8705 Super I/O and enable flash writes if it

^
        Missing 'F' in the commit message.
> performs LPC->Parallel translation.
> Remove board enables which triggered the IT8705 write enable manually.

^
                                               Ditto
> Change the IT87 SPI special case to cover IT87 LPC->SPI and
> LPC->Parallel translation.
>
> Signed-off-by: Carl-Daniel Hailfinger
>
> Tested on Syntax SV266A.
> Acked-by: Paul Menzel
>
> Tested on Shuttle AK38N, all operations work fine.
> Acked-by: Uwe Hermann

Retested this version on AK38N, still works fine.

Acked-by: Uwe Hermann
> case 0x8705:
> return it8705f_write_enable(superio.port);
> break;
> case 0x8716:
> case 0x8718:
> case 0x8720:
> return it87spi_probe(superio.port);
> break;
> default:
> msg_pdbg("Super I/O ID %04hx is not on the list of flash "

^
                  I'd add "0x" here to make it clear to
                  the user that it's a hex number.
> if ((sio_read(port, 0x29) & 0x03) != 0) {
> 	msg_perr("IT8705F flash address pins 16-17 disabled!\n");
> 	/* Not really an error if you use flash chips smaller
> 	 * than 256 kByte, but
> 	 */

The comment/sentence is truncated here, it seems.

Please feel free to commit. I will do a review against the datasheet
when time permits, but no need to wait for that, the code has been
tested and reviewed by multiple people now, I don't expect issues.

I'll attach flashrom and superiotool output on Shuttle AK38N for reference.

Uwe.