28 Jul
2010
28 Jul
'10
12:36 p.m.
On Wed, Jul 28, 2010 at 03:13:42AM +0200, Carl-Daniel Hailfinger wrote:
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Looks good, compile-tested and reviewed, also tested on hardware by various people.
+static void mcp6x_request_spibus(void) +{
- uint8_t byte;
You use "byte" in most functions as variable name, but IIRC there were issues on some systems/compilers with this name. I recommend renaming to reg8 or tmp8 or the like.
Uwe.