Re: [flashrom] [PATCH] Check for duplicate -i arguments.

[Uwe Hermann]

On Sat, Feb 25, 2012 at 10:18:13PM +0100, Stefan Tauner wrote:
> And a tiny cleanup.
>
> ./flashrom -p dummy:emulate=M25P10.RES  -c M25P10 -i blub -i blub
> flashrom v0.9.5-r1505 on Linux 2.6.35-32-generic (x86_64), built with libpci 3.1.7, GCC 4.4.5, little endian
> flashrom is free software, get the source code at http://www.flashrom.org
>
> Duplicate region name: "blub".
> Please run "flashrom --help" for usage info.
>
> Signed-off-by: Stefan Tauner

Looks good and seems to work fine here.

Acked-by: Uwe Hermann
> +/* returns the index of the entry (or a negative value if it is not found) */

Should start with capital letter and end with full-stop.

Uwe.