Hi,
Anastasia Klimchuk aklm@chromium.org schreef op 20 november 2022 23:20:43 CET:
Hi Stijn,
The process for code review is as follows: you send the patch for review (you did it!) and then reviewers add comments (Felix did it). You are expected to fix the comments (or reply back explaining why this is not possible, or why you disagree) and then upload a new patchset to the same patch.
Did you get an email from Gerrit with the comments on your patch?
No, I did not 🙈. Used to review by mail as well. Just checked Gerrit, thanks for the pointer.
Stijn
(that should be around Nov 10 or 11 depending on timezone). Check the patch: https://review.coreboot.org/c/flashrom/+/69309 As you see, there are currently 7 unresolved comments.
From your previous email, it seems like you fixed compilation errors locally, this is great! Now you need to upload a new patchset to Gerrit, so that we all can see it, and build bot can verify it. If the patch builds, build bot will give you +1 (currently it's -1). You push the new patchset in the same way as previous, but pay attention to "Change-Id: " in the commit message, it should stay exactly the same. Yes, new commit ID, but the same Change-Id.
The commit message also needs some polishing. Otherwise looks pretty good.
Could you tell me what I'd need to change?
This is in the comments to the patch.
In general, any conversations in the patch are happening in Gerrit, not on the mailing list. You can reply in Gerrit and all reviewers get an email.
If you are new to Gerrit, don't worry, you will learn quickly! Your second patch will be much easier than the first ;)